Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Disable locale checks to avoid warnings in Active Model tests [ci skip] | Carlos Antonio da Silva | 2013-12-23 | 1 | -0/+3 | |
|/ | | | | | Missed AMo when adding to the other components in ae196e85ee7169700afac2eecdc276bc06b10b8d. | |||||
* | Merge pull request #13273 from robertomiranda/test-remove-require | Guillermo Iguaran | 2013-12-11 | 1 | -1/+0 | |
|\ | | | | | Remove require 'models/administrator', Administrator is not used in secure password test | |||||
| * | Remove require 'models/administrator', Administrator is not used in secure ↵ | robertomiranda | 2013-12-11 | 1 | -1/+0 | |
| | | | | | | | | password test | |||||
* | | Let validates_inclusion_of accept Time and DateTime ranges | Akira Matsuda | 2013-10-23 | 1 | -0/+22 | |
| | | | | | | | | fixes 4.0.0 regression introduced in 0317b93c17a46d7663a8c36edc26ad0ba3d75f85 | |||||
* | | Use bcrypt's public cost attr, not internal constant | T.J. Schuck | 2013-10-10 | 1 | -0/+8 | |
| | | | | | | | | | | | | | | | | See: - https://github.com/codahale/bcrypt-ruby/pull/63 - https://github.com/codahale/bcrypt-ruby/pull/64 - https://github.com/codahale/bcrypt-ruby/pull/65 | |||||
* | | Merge pull request #8791 from griffinmyers/master | Rafael Mendonça França | 2013-10-03 | 1 | -1/+16 | |
|\ \ | | | | | | | | | | | | | | | | | | | Updated DirtyModel's @changed_attributes hash to be symbol/string agnostic Conflicts: activemodel/CHANGELOG.md | |||||
| * | | DirtyModel uses a hash to keep track of any changes made to attributes | William Myers | 2013-05-27 | 1 | -1/+16 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | of an instance. When using the attribute_will_change! method, you must supply a string and not a symbol or the *_changed? method will break (because it is looking for the attribute name as a string in the keys of the underlying hash). To remedy this, I simply made the underlying hash a HashWithIndifferentAccess so it won't matter if you supply the attribute name as a symbol or string to attribute_will_change!. | |||||
* | | | Merge pull request #10816 from bogdan/less-dirty-dirty | Rafael Mendonça França | 2013-09-23 | 1 | -2/+1 | |
| | | | | | | | | | | | | Make AM::Dirty less dirty to plugin into AR or other library | |||||
* | | | use assert_empty in activemodel conditional validation test cases | Rajarshi Das | 2013-09-10 | 1 | -7/+7 | |
| | | | ||||||
* | | | fix actionview and activemodel test cases typos | Rajarshi Das | 2013-09-05 | 1 | -1/+1 | |
| | | | ||||||
* | | | remove unused instance variable | Rajarshi Das | 2013-08-23 | 1 | -2/+1 | |
| | | | ||||||
* | | | Dont' check for any order in hash since we aren't sorting it and this is ↵ | Guillermo Iguaran | 2013-08-18 | 1 | -11/+0 | |
| | | | | | | | | | | | | determinated only by the used interpreter | |||||
* | | | Refactor serialization test for hash order | Guillermo Iguaran | 2013-08-18 | 1 | -7/+6 | |
| | | | ||||||
* | | | Avoid Skip in test, have a unified test for order | Gaurish Sharma | 2013-08-09 | 1 | -10/+7 | |
| | | | ||||||
* | | | Add tests for ActiveModel::Serializers::JSON#as_json ordering | Gaurish Sharma | 2013-08-09 | 1 | -1/+10 | |
| |/ |/| | ||||||
* | | fix tests | Max Shytikov | 2013-07-30 | 1 | -1/+1 | |
| | | ||||||
* | | Fix secure_password password_confirmation validations | Vladimir Kiselev | 2013-07-24 | 1 | -0/+5 | |
| | | ||||||
* | | Remove redundant escapes from xml serialization test | Vipul A M | 2013-07-01 | 1 | -6/+6 | |
| | | ||||||
* | | Remove deprecation warning from AttributeMethodsMatcher | Paul Nikitochkin | 2013-06-28 | 1 | -11/+0 | |
| | | ||||||
* | | Remove deprecated attr_protected/accessible | Łukasz Strzałkowski | 2013-06-27 | 1 | -16/+0 | |
| | | | | | | | | Rails 4.0 has removed attr_protected and attr_accessible feature in favor of Strong Parameters. | |||||
* | | Merge pull request #10774 from ↵ | Carlos Antonio da Silva | 2013-06-25 | 1 | -0/+1 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | chuckbergeron/validates-inclusion-of-accuracy-for-non-numeric-ranges Greater accuracy for validates_inclusion_of on non-numeric ranges Closes #10774, fixes #10593 | |||||
| * | | Use Range#cover? for Numeric ranges (tests via endpoints) and use ↵ | Charles Bergeron | 2013-05-27 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | Range#include? for non-numeric ranges added changelog message | |||||
* | | | ActiveModel::Model inclusion chain backward compatibility | Fred Wu | 2013-06-20 | 1 | -5/+15 | |
| | | | ||||||
* | | | Fixes AciveModel::Model with no ancestors, fixes #11004 | Fred Wu | 2013-06-19 | 1 | -2/+23 | |
| | | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@plataformatec.com.br> | |||||
* | | | Fixed ActiveModel::Model's inclusion chain | Fred Wu | 2013-06-19 | 1 | -0/+12 | |
| | | | ||||||
* | | | Stub logger for tests | Andrey Koleshko | 2013-06-06 | 1 | -0/+4 | |
| | | | ||||||
* | | | Fix regression in has_secure_password. | Phil Calvin | 2013-05-30 | 1 | -0/+9 | |
|/ / | | | | | | | If the confirmation was blank, but the password wasn't, it would still save. | |||||
* | | deprecate Validator#setup (to get rid of a respond_to call). validators do ↵ | Nick Sutterer | 2013-05-23 | 2 | -23/+22 | |
| | | | | | | | | their setup in their constructor now. | |||||
* | | Merge pull request #10527 from zenspider/squishy_minitest5 | Aaron Patterson | 2013-05-16 | 1 | -1/+0 | |
|\ \ | | | | | | | Squishy minitest5 | |||||
| * | | Updates to make rails 4 happy with minitest 5: | Ryan Davis | 2013-05-06 | 1 | -1/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + Namespace changes, overhaul of runners. + Internal ivar name changes - Removed a logger globally applied to tests that spew everywhere?!? + Override Minitest#__run to sort tests by name. + Reworked testing isolation to work with the new cleaner architecture. - Removed a bunch of tests that just test minitest straight up. I think these changes were all merged to minitest 4 a long time ago. - Minor report output differences. | |||||
* | | | callbacks are wrapped with lambdas | Aaron Patterson | 2013-05-10 | 1 | -1/+1 | |
|/ / | ||||||
* | | Convert ActiveModel to 1.9 hash syntax. | Patrick Robertson | 2013-05-01 | 22 | -303/+305 | |
| | | | | | | | | | | I also attempted to fix other styleguide violations such as { a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ). | |||||
* | | Merge pull request #10286 from ↵ | Carlos Antonio da Silva | 2013-04-21 | 1 | -2/+2 | |
|\ \ | | | | | | | | | | | | | neerajdotname/fix-wrong-test-name-and-failure-message fix wrong test description and failure message | |||||
| * | | fix wrong test description and failure message | Neeraj Singh | 2013-04-21 | 1 | -2/+2 | |
| | | | ||||||
* | | | Added tests for if condition in Active Model callbacks | Neeraj Singh | 2013-04-21 | 1 | -0/+21 | |
|/ / | ||||||
* | | Removed unused setup | Anupam Choudhury | 2013-04-09 | 1 | -4/+0 | |
| | | ||||||
* | | Review some tests from AMo::Errors to remove "should" usage | Carlos Antonio da Silva | 2013-03-30 | 1 | -55/+35 | |
| | | | | | | | | | | Also remove duplicated tests for Errors#as_json and minor improvements in some tests. | |||||
* | | Merge pull request #8527 from shockone/patch-1 | Rafael Mendonça França | 2013-03-25 | 1 | -0/+20 | |
|\ \ | | | | | | | Add a method full_messages_for to the Errors class | |||||
| * | | Add a method full_messages_for to the Errors class | shock_one | 2013-03-24 | 1 | -0/+20 | |
| | | | ||||||
* | | | Add Error#full_message test; Fix typos | Vipul A M | 2013-03-22 | 1 | -0/+1 | |
|/ / | | | | | | | | | Introduce test on Error#full_message for attribute with underscores; Fix some typos | |||||
* | | fix some typos found in activemodel | Vipul A M | 2013-03-18 | 3 | -4/+4 | |
| | | ||||||
* | | Small typos here and there. | Vipul A M | 2013-03-15 | 3 | -4/+4 | |
| | | ||||||
* | | `has_secure_password` is not invalid when assigning empty Strings. | Yves Senn | 2013-03-04 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | | | | | Closes #9535. With 692b3b6 the `password=` setter does no longer set blank passwords. This triggered validation errors when assigning empty Strings to `password` and `password_confirmation`. This patch only sets the confirmation if it is not `blank?`. | |||||
* | | `validates_confirmation_of` does not override writer methods. | Yves Senn | 2013-03-04 | 1 | -0/+31 | |
| | | ||||||
* | | added more accurate test for add_on_empty | Angelo capilleri | 2013-02-19 | 1 | -0/+7 | |
| | | | | | | | | | | with the current tests, if delete the assignment of is_empty in add_on_empty method the tests not fail. With this test, if we delete is_empty, the test fails | |||||
* | | Take care of whitespaces and changing the hash syntax | Rafael Mendonça França | 2013-02-04 | 1 | -57/+56 | |
| | | ||||||
* | | test for issue 8931 | David | 2013-02-02 | 1 | -0/+8 | |
| | | ||||||
* | | Adding the route_key and param_key tests | Attila Domokos | 2013-01-22 | 1 | -0/+8 | |
| | | | | | | This way all the tests are testing the same fields | |||||
* | | Merge pull request #8940 from adomokos/adding_tests_for_changed_attributes | Carlos Antonio da Silva | 2013-01-15 | 1 | -1/+12 | |
|\ \ | | | | | | | Cleaning up ActiveModel::Dirty tests | |||||
| * | | Cleaning up ActiveModel::Dirty tests | Attila Domokos | 2013-01-15 | 1 | -1/+12 | |
| | | | | | | | | | | | | | | | | | | | | | * Clarifying what the #changed method returns * Adding tests to describe what the #changed_attributes returns * Updating test name based on pull request comment * Moving the test lower in the file per pull request comment |