aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* Default to sorting user's test cases for nowGodfrey Chan2014-09-081-1/+1
| | | | | | | | | | | Goals: 1. Default to :random for newly generated applications 2. Default to :sorted for existing applications with a warning 3. Only show the warning once 4. Only show the warning if the app actually uses AS::TestCase Fixes #16769
* Leave all our tests as order_dependent! for nowMatthew Draper2014-09-021-0/+5
| | | | | | | | | We're seeing too many failures to believe otherwise. This reverts commits bc116a55ca3dd9f63a1f1ca7ade3623885adcc57, cbde413df3839e06dd14e3c220e9800af91e83ab, bf0a67931dd8e58f6f878b9510ae818ae1f29a3a, and 2440933fe2c27b27bcafcd9019717800db2641aa.
* Move model definition to test/models for test order indenendencyAkira Matsuda2014-08-282-29/+0
|
* [ci skip] make assert messages consistentankit19102014-08-251-2/+2
|
* AM, AP, AV, and AMo tests are already order_independent!Akira Matsuda2014-08-131-5/+0
|
* Nobody sucks so nobody should call this awful method nameRafael Mendonça França2014-08-121-1/+1
|
* users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent!Akira Matsuda2014-08-121-0/+5
| | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework.
* Allow password to contain spaces only.Yevhene Shemet2014-08-061-0/+10
|
* Merge pull request #15959 from aditya-kapoor/remove-unneeded-casesRafael Mendonça França2014-07-291-13/+17
|\ | | | | remove unneeded test model for ActiveModel test cases.
| * remove unneeded test model for ActiveModel test cases.Aditya Kapoor2014-06-281-13/+17
| |
* | Merge branch 'rm-remove-mocha'Rafael Mendonça França2014-07-191-0/+2
|\ \ | | | | | | | | | | | | Conflicts: actionpack/test/abstract_unit.rb
| * | Stop requiring mocha automaticallyRafael Mendonça França2014-07-191-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal
* | | Merge pull request #16210 from sonnym/assert_valid_keys_in_validateMatthew Draper2014-07-181-0/+7
|\ \ \ | | | | | | | | | | | | Check for valid options in validate method
| * | | check for valid options in validate methodsonnym2014-07-171-0/+6
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change prevents a certain class of user error which results when mistakenly using the `validate` class method instead of the `validates` class method. Only apply when all arguments are symbols, because some validations use the `validate` method and pass in additional options, namely the `LenghValidator` via the `ActiveMode::Validations::validates_with` method.
* | | Make restore_attributes publicRafael Mendonça França2014-07-171-5/+15
| | | | | | | | | | | | | | | | | | | | | Also make it accept a list of attributes to be changed. This will make possible to restore only a subset of the changed attributes. Closes #16203
* | | Deprecate `reset_#{attribute}` in favor of `restore_#{attribute}`.Rafael Mendonça França2014-07-151-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | These methods may cause confusion with the `reset_changes` that behaves differently of them. Also rename undo_changes to restore_changes to match this new set of methods.
* | | Deprecate ActiveModel::Dirty#reset_changes in favor of ↵Rafael Mendonça França2014-07-151-0/+21
|/ / | | | | | | | | | | | | | | | | #clear_changes_information This method name is causing confusion with the `reset_#{attribute}` methods. While `reset_name` set the value of the name attribute for the previous value the `reset_changes` only discard the changes and previous changes.
* | Only automatically include validations when enabledGodfrey Chan2014-07-021-11/+3
| | | | | | | | This is a follow up to #16024.
* | automatically include ActiveModel::Validations when include ↵Aditya Kapoor2014-07-031-0/+5
| | | | | | | | ActiveModel::SecurePassword
* | Rename rollback_changes to undo_changesRafael Mendonça França2014-06-301-2/+2
| | | | | | | | To avoid overload with database rollback
* | Merge pull request #14861 from igor04/dirty-rollbackRafael Mendonça França2014-06-301-0/+18
|\ \ | |/ |/| | | Added rollback method to ActiveModel::Dirty
| * Added rollback method to ActiveModel::Dirtyigor042014-06-231-0/+18
| |
* | Merge pull request #15834 from rmehner/allow_proc_and_symbol_for_only_integerRafael Mendonça França2014-06-261-0/+15
|\ \ | | | | | | Allow proc and symbol as values for `only_integer` of `NumericalityValidator`
| * | `only_integer` of `NumericalityValidator` now allows procs and symbolsRobin Mehner2014-06-221-0/+15
| | |
* | | Merge pull request #15871 from yuki24/add-model-name-instance-methodDavid Heinemeier Hansson2014-06-241-0/+6
|\ \ \ | | | | | | | | Add #model_name instance method to ActiveModel::Naming
| * | | Delegate #model_name method to self.classYuki Nishijima2014-06-221-0/+6
| |/ /
* / / remove unnecessary require for json serialization test casesAditya Kapoor2014-06-241-1/+0
|/ /
* | Correct typo, add test for validates_absence_of, correct method namesAkshay Vishnoi2014-06-161-3/+4
| |
* | Use `@existing_user` while updating existing user, fixing - #ee4e86Akshay Vishnoi2014-06-141-6/+6
| |
* | Cleaned up the `has_secure_password` test casesGodfrey Chan2014-06-141-33/+29
| | | | | | | | | | | | * Grouped the valid test cases in one place * Make the length of the generated password obvious * Removed two wrong (copy-and-pasted) test cases
* | SecurePassword - Validate password must be less than or equal to 72Akshay Vishnoi2014-06-141-0/+28
| | | | | | | | See #14591, Reason - BCrypt hash function can handle maximum 72 characters.
* | [ci skip] add tests for ActionModel::ConversionAditya Kapoor2014-06-111-0/+4
| |
* | remove depricated Validatior#setupKuldeep Aggarwal2014-06-101-21/+0
| |
* | Add singular and plural form for some validation messagesAbd ar-Rahman Hamidi2014-05-021-3/+15
|/
* Fix warning for overshadowing XML variableMusannif Zahir2014-03-281-2/+2
|
* ActiveRecord/ActiveModel '#validate' alias for 'valid?'Henrik Nyh2014-03-271-0/+9
| | | | | | | | It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies.
* comment why we are modifying global state. [ci skip]Yves Senn2014-03-111-0/+1
|
* Completely remove potential global state leaks in ActiveModel tests.Zuhao Wan2014-03-117-110/+136
| | | | ActiveModel tests can now be run in random order.
* Merge pull request #14315 from zuhao/activemodel_tests_in_random_orderYves Senn2014-03-094-13/+39
|\ | | | | Run ActiveModel test suites in random order.
| * Run ActiveModel test suites in random order.Zuhao Wan2014-03-104-13/+39
| | | | | | | | | | | | | | | | | | | | This gets the whole ActiveModel test suites working even if `self.i_suck_and_my_tests_are_order_dependent!` is disabled in `ActiveSupport::TestCase`. Two places are found that potentially leak global state. This patch makes sure states are restored so that none of the changes happen in a single test will be carried over to subsequence tests.
* | Tests for indifferent access using full_messages_for. Closes #11916Pavel Penkov2014-03-081-0/+7
|/
* Fix some validators when used on model instanceEric Hutzelman2014-02-261-1/+2
| | | | | | | | Now that Validator #setup is called from the initializer, we need a reference to the model's class to be passed in to allow the validators to continue functioning when used at the instance level. Closes #14134.
* add test coverage for activemodel Dirty#reset_changesDmitry Polushkin2014-02-091-0/+19
|
* `#to_param` returns `nil` if `to_key` returns `nil`. Closes #11399.Yves Senn2014-02-041-0/+10
| | | | | | | | | | | | | | | | The documentation of `#to_key` (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key) states that it returns `nil` if there are no key attributes. `to_param` needs to be aware of that fact and return `nil` as well. Previously it raised the following exception: ``` 1) Error: ConversionTest#test_to_param_returns_nil_if_to_key_is_nil: NoMethodError: undefined method `join' for nil:NilClass /Users/senny/Projects/rails/activemodel/lib/active_model/conversion.rb:65:in `to_param' /Users/senny/Projects/rails/activemodel/test/cases/conversion_test.rb:34:in `block in <class:ConversionTest>' ```
* use the new clear_validators! api everywhere to reset validators in testsKuldeep Aggarwal2014-01-281-1/+1
|
* Use the new clear_validators! api to reset validators in testsCarlos Antonio da Silva2014-01-2716-42/+33
|
* Merge tests about multiple validation contextsCarlos Antonio da Silva2014-01-271-10/+6
|
* Ability to specify multiple contexts when defining a validation.Vince Puzzella2014-01-271-0/+16
| | | | | | Example: validates_presence_of :name, on: [:update, :custom_validation_context]
* Some minor fixesGodfrey Chan2014-01-241-1/+0
|
* Removed old testsGodfrey Chan2014-01-242-239/+121
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 16:25:34 +0000