Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Completely remove potential global state leaks in ActiveModel tests. | Zuhao Wan | 2014-03-11 | 2 | -9/+11 |
| | | | | ActiveModel tests can now be run in random order. | ||||
* | Run ActiveModel test suites in random order. | Zuhao Wan | 2014-03-10 | 2 | -6/+10 |
| | | | | | | | | | | This gets the whole ActiveModel test suites working even if `self.i_suck_and_my_tests_are_order_dependent!` is disabled in `ActiveSupport::TestCase`. Two places are found that potentially leak global state. This patch makes sure states are restored so that none of the changes happen in a single test will be carried over to subsequence tests. | ||||
* | use the new clear_validators! api everywhere to reset validators in tests | Kuldeep Aggarwal | 2014-01-28 | 1 | -1/+1 |
| | |||||
* | Use the new clear_validators! api to reset validators in tests | Carlos Antonio da Silva | 2014-01-27 | 15 | -34/+32 |
| | |||||
* | Merge tests about multiple validation contexts | Carlos Antonio da Silva | 2014-01-27 | 1 | -10/+6 |
| | |||||
* | Ability to specify multiple contexts when defining a validation. | Vince Puzzella | 2014-01-27 | 1 | -0/+16 |
| | | | | | | Example: validates_presence_of :name, on: [:update, :custom_validation_context] | ||||
* | Let validates_inclusion_of accept Time and DateTime ranges | Akira Matsuda | 2013-10-23 | 1 | -0/+22 |
| | | | | fixes 4.0.0 regression introduced in 0317b93c17a46d7663a8c36edc26ad0ba3d75f85 | ||||
* | use assert_empty in activemodel conditional validation test cases | Rajarshi Das | 2013-09-10 | 1 | -7/+7 |
| | |||||
* | Use Range#cover? for Numeric ranges (tests via endpoints) and use ↵ | Charles Bergeron | 2013-05-27 | 1 | -0/+1 |
| | | | | | | Range#include? for non-numeric ranges added changelog message | ||||
* | deprecate Validator#setup (to get rid of a respond_to call). validators do ↵ | Nick Sutterer | 2013-05-23 | 1 | -23/+1 |
| | | | | their setup in their constructor now. | ||||
* | Convert ActiveModel to 1.9 hash syntax. | Patrick Robertson | 2013-05-01 | 12 | -202/+201 |
| | | | | | I also attempted to fix other styleguide violations such as { a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ). | ||||
* | Merge pull request #10286 from ↵ | Carlos Antonio da Silva | 2013-04-21 | 1 | -2/+2 |
|\ | | | | | | | | | neerajdotname/fix-wrong-test-name-and-failure-message fix wrong test description and failure message | ||||
| * | fix wrong test description and failure message | Neeraj Singh | 2013-04-21 | 1 | -2/+2 |
| | | |||||
* | | Added tests for if condition in Active Model callbacks | Neeraj Singh | 2013-04-21 | 1 | -0/+21 |
|/ | |||||
* | fix some typos found in activemodel | Vipul A M | 2013-03-18 | 1 | -1/+1 |
| | |||||
* | `validates_confirmation_of` does not override writer methods. | Yves Senn | 2013-03-04 | 1 | -0/+31 |
| | |||||
* | Take care of whitespaces and changing the hash syntax | Rafael Mendonça França | 2013-02-04 | 1 | -57/+56 |
| | |||||
* | test for issue 8931 | David | 2013-02-02 | 1 | -0/+8 |
| | |||||
* | Add CHANGELOG entry for #8622 | Rafael Mendonça França | 2012-12-26 | 1 | -2/+2 |
| | |||||
* | Revert the change at ActiveModel::Errors#add_on_blank and fix in the | Rafael Mendonça França | 2012-12-26 | 1 | -5/+5 |
| | | | | | | | | | | | right place. The EachValidator#validate already handle :allow_blank and :allow_nil, correctly. Closes #8622. Fix #8621. | ||||
* | Tests and fix for validates_presence of :allow_nil, :allow_blank | Colin Kelley | 2012-12-26 | 1 | -0/+34 |
| | | | | | Conflicts: activemodel/lib/active_model/errors.rb | ||||
* | Add `ActiveModel::Validations::AbsenceValidator`, a validator to check the ↵ | Roberto Vasquez Angel | 2012-12-15 | 1 | -0/+67 |
| | | | | | | absence of attributes. Add `ActiveModel::Errors#add_on_present` method. Adds error messages to present attributes. | ||||
* | Length validation handles correctly nil. Fix #7180 | Michal Zima | 2012-11-26 | 1 | -0/+39 |
| | | | | When nil or empty string are not allowed, they are not valid. | ||||
* | use Array() instead flatten | Vasiliy Ermolovich | 2012-11-05 | 1 | -20/+0 |
| | | | | | * move ActiveModel::Errors tests to errors_test.rb * add spec coverage for add_on_empty and add_on_blank | ||||
* | Raise ArgumentError when no attribute is given to AMo::EachValidator | Carlos Antonio da Silva | 2012-11-04 | 1 | -1/+1 |
| | | | | ArgumentError is better suited than RuntimeError for this. | ||||
* | convert comments to 1.9 hash syntax | AvnerCohen | 2012-10-22 | 2 | -13/+13 |
| | |||||
* | Fix method redefined warnings. | kennyj | 2012-08-29 | 2 | -0/+6 |
| | |||||
* | Accept a symbol for `:in` option on inclusion and exclusion validators | Gabriel Sobrinho | 2012-08-24 | 2 | -0/+44 |
| | |||||
* | fix typo in callbacks test | Accessd | 2012-07-24 | 1 | -2/+2 |
| | |||||
* | Don't pass `:within` option to the i18n | Rafael Mendonça França | 2012-07-20 | 1 | -0/+22 |
| | |||||
* | `validates_inclusion_of` and `validates_exclusion_of` now accept | Rafael Mendonça França | 2012-07-20 | 2 | -0/+20 |
| | | | | | | `:within` option as alias of `:in` as documented. Fix #7118 | ||||
* | prevent users from unknowingly using bad regexps that can compromise ↵ | MrBrdo | 2012-06-14 | 2 | -6/+16 |
| | | | | security (http://homakov.blogspot.co.uk/2012/05/saferweb-injects-in-various-ruby.html) | ||||
* | Support i18n attributes for confirmation | Brian Cardarella | 2012-04-24 | 2 | -2/+21 |
| | |||||
* | confirmation validation error attribute | Brian Cardarella | 2012-04-23 | 4 | -9/+14 |
| | | | | | | | | | | | | This will render the error message on :#{attribute}_confirmation instead of on attribute itself. When rendering confirmation errors inline on the form with form builders such as SimpleForm and Formtastic it is confusing to the ender user to see the confirmation error message on the attribute element. Instead it makes more sense to have this validation error render on the confirmation field instead. The i18n message has been updated for the confirmation validator error message to include the original attribute name. | ||||
* | To infinity… and beyond! | Niels Ganser | 2012-02-06 | 1 | -0/+18 |
| | | | | | | | Allow infinite values for validates_length_of. Particularly useful for prettily defining an open ended range such as validates_length_of :human_stupidity, :within => 0..Float::INFINITY | ||||
* | Removing unwanted method and adding to accessor for getter history | prasath | 2012-01-25 | 1 | -4/+3 |
| | |||||
* | added :other_than => :!= option to numericality validator | Jakub Kuźma | 2011-12-21 | 1 | -0/+7 |
| | |||||
* | Remove dead code from AMo. | José Valim | 2011-12-20 | 1 | -47/+37 |
| | |||||
* | Fixed test "ArgumentError: wrong number of arguments(1 for 0)" | Arun Agrawal | 2011-12-17 | 1 | -1/+1 |
| | |||||
* | Fixed bug when error message is an empty string. | Antonio Roberto | 2011-12-16 | 1 | -0/+6 |
| | |||||
* | Update variable's name in the test case to reflect the class we're testing | Prem Sichanugrist | 2011-11-18 | 3 | -24/+24 |
| | |||||
* | Follow code conventions on some tests | Sebastian Martinez | 2011-05-10 | 4 | -29/+29 |
| | |||||
* | No need to rescue here. Invoking the wrong method in an object can happen ↵ | José Valim | 2011-04-11 | 3 | -34/+0 |
| | | | | anywhere if you are not careful. In other words, test your shit. | ||||
* | Revert "Add :use_include option to allow user to explicitly use ↵ | José Valim | 2011-04-11 | 2 | -19/+0 |
| | | | | | | | | `Range#include?` method in Ruby 1.9" Use :with => range.to_a instead. This reverts commit f6540211b5b9133c9f93c11655a04d613c237e67. | ||||
* | Add :use_include option to allow user to explicitly use `Range#include?` ↵ | Prem Sichanugrist | 2011-04-10 | 2 | -0/+19 |
| | | | | | | method in Ruby 1.9 In Ruby 1.9 we're currently use `Range#cover?` to fix the performance problem. However, there might be the case that you want to use `Range#include?` instead. This patch will give you that option. | ||||
* | Add support for proc or lambda as an option for InclusionValidator, ↵ | Prem Sichanugrist | 2011-04-10 | 3 | -0/+82 |
| | | | | | | ExclusionValidator, and FormatValidator You can now use a proc or lambda in :in option for InclusionValidator and ExclusionValidator, and :with, :without option for FormatValidator | ||||
* | Refactor length validation | Santiago Pastorino | 2011-03-12 | 1 | -3/+3 |
| | |||||
* | length validation for fixnums | Andriy Tyurnikov | 2011-03-12 | 1 | -0/+11 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Active Model typos. | R.T. Lechow | 2011-03-05 | 1 | -1/+1 |
| | |||||
* | Revert "Properly interpolate i18n keys in modules [#5572 state:resolved]" | Santiago Pastorino | 2011-02-27 | 1 | -19/+0 |
| | | | | | | | This breaks #6448, you should use :"module/class" as key for namespacing [#6448 state:committed] This reverts commit 8d30193b08bd2321a7a78a1f481bd5e4d4d45557. |