| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Revert "No such class since 8d2866bb80fbe81acb04f5b0c44f152f571fb29f" | Rafael Mendonça França | 2019-08-02 | 1 | -1/+1 |
| | | | | | This reverts commit dd779c9686f49f5ed6dda8ad5a1cb3b0788e1dd4. | ||||
| * | No such class since 8d2866bb80fbe81acb04f5b0c44f152f571fb29f | Akira Matsuda | 2019-08-02 | 1 | -1/+1 |
| | | |||||
| * | Enable `Layout/EmptyLinesAroundAccessModifier` cop | Ryuta Kamizono | 2019-06-13 | 1 | -1/+0 |
| | | | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost. | ||||
| * | Ensure multiple anonymous modules are not included into Topic in tests | Chris Salzberg | 2019-04-14 | 1 | -18/+32 |
| | | | | | | | | | | | | Each acceptance validator applied to a model class includes an instance of a module builder (LazilyDefineAttributes) into that class. In tests, if the original model class is not subclassed, these modules pile up and cannot be removed, potentially leading to flakey specs and false positive/negatives. To avoid this, always use subclasses in tests whose names (constants) can be removed when the test is done. | ||||
| * | Use assert_predicate and assert_not_predicate | Daniel Colson | 2018-01-25 | 1 | -13/+13 |
| | | |||||
| * | Use frozen string literal in activemodel/ | Kir Shatrov | 2017-07-16 | 1 | -0/+2 |
| | | |||||
| * | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
| * | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | | |||||
| * | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -2/+2 |
| | | |||||
| * | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -1/+0 |
| | | |||||
| * | applies new string literal convention in activemodel/test | Xavier Noria | 2016-08-06 | 1 | -4/+4 |
| | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
| * | Improve Validation Helpers' documentation comments and tests | Radan Skoric | 2015-06-27 | 1 | -0/+14 |
| | | |||||
| * | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵ | Vipul A M | 2015-02-03 | 1 | -1/+0 |
| | | | | | onwards. | ||||
| * | allow '1' or true for acceptance validation. | mo khan | 2015-01-10 | 1 | -0/+6 |
| | | |||||
| * | use the new clear_validators! api everywhere to reset validators in tests | Kuldeep Aggarwal | 2014-01-28 | 1 | -1/+1 |
| | | |||||
| * | Use the new clear_validators! api to reset validators in tests | Carlos Antonio da Silva | 2014-01-27 | 1 | -1/+1 |
| | | |||||
| * | Convert ActiveModel to 1.9 hash syntax. | Patrick Robertson | 2013-05-01 | 1 | -2/+2 |
| | | | | | | I also attempted to fix other styleguide violations such as { a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ). | ||||
| * | removed AR from all AMo tests, including any unneeded files (schema, ↵ | Josh Kalderimis | 2010-05-09 | 1 | -2/+0 |
| | | | | | fixtures and test helper) | ||||
| * | removed an old unused model in the AMo tests which also removes another AR ↵ | Josh Kalderimis | 2010-05-09 | 1 | -1/+0 |
| | | | | | dependency | ||||
| * | removed use of AR in AMo tests and removed testing of scopes (:on) in ↵ | Josh Kalderimis | 2010-05-08 | 1 | -15/+15 |
| | | | | | individual validation tests and moved them to their own test file | ||||
| * | No need to use ValidationsRepairHelper hack on ActiveModel anymore, ↵ | José Valim | 2009-12-23 | 1 | -21/+12 |
| | | | | | Model.reset_callbacks(:validate) is enough. However, tests in ActiveRecord are still coupled, so moved ValidationsRepairHelper back there. | ||||
| * | Add ActiveModel::Validations tests for regular ruby classes | Pratik Naik | 2009-03-20 | 1 | -9/+16 |
| | | |||||
| * | TestDatabase -> TestsDatabase | Pratik Naik | 2009-03-20 | 1 | -2/+2 |
| | | |||||
| * | Move relevant validation tests from Active Record to Active Model | Pratik Naik | 2009-03-20 | 1 | -0/+73 |
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |