Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix `CustomCops/AssertNot` to allow it to have failure message | Ryuta Kamizono | 2018-05-13 | 1 | -11/+11 |
| | | | | Follow up of #32605. | ||||
* | Replace `assert !` with `assert_not` | Daniel Colson | 2018-04-19 | 1 | -1/+1 |
| | | | | | This autocorrects the violations after adding a custom cop in 3305c78dcd. | ||||
* | Use frozen string literal in activemodel/ | Kir Shatrov | 2017-07-16 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | "Use assert_nil if expecting nil. This will fail in minitest 6." | Akira Matsuda | 2016-12-25 | 1 | -1/+1 |
| | |||||
* | applies new string literal convention in activemodel/test | Xavier Noria | 2016-08-06 | 1 | -59/+59 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Allow password to contain spaces only. | Yevhene Shemet | 2014-08-06 | 1 | -0/+10 |
| | |||||
* | Only automatically include validations when enabled | Godfrey Chan | 2014-07-02 | 1 | -11/+3 |
| | | | | This is a follow up to #16024. | ||||
* | automatically include ActiveModel::Validations when include ↵ | Aditya Kapoor | 2014-07-03 | 1 | -0/+5 |
| | | | | ActiveModel::SecurePassword | ||||
* | Use `@existing_user` while updating existing user, fixing - #ee4e86 | Akshay Vishnoi | 2014-06-14 | 1 | -6/+6 |
| | |||||
* | Cleaned up the `has_secure_password` test cases | Godfrey Chan | 2014-06-14 | 1 | -33/+29 |
| | | | | | | * Grouped the valid test cases in one place * Make the length of the generated password obvious * Removed two wrong (copy-and-pasted) test cases | ||||
* | SecurePassword - Validate password must be less than or equal to 72 | Akshay Vishnoi | 2014-06-14 | 1 | -0/+28 |
| | | | | See #14591, Reason - BCrypt hash function can handle maximum 72 characters. | ||||
* | comment why we are modifying global state. [ci skip] | Yves Senn | 2014-03-11 | 1 | -0/+1 |
| | |||||
* | Completely remove potential global state leaks in ActiveModel tests. | Zuhao Wan | 2014-03-11 | 1 | -23/+11 |
| | | | | ActiveModel tests can now be run in random order. | ||||
* | Run ActiveModel test suites in random order. | Zuhao Wan | 2014-03-10 | 1 | -7/+25 |
| | | | | | | | | | | This gets the whole ActiveModel test suites working even if `self.i_suck_and_my_tests_are_order_dependent!` is disabled in `ActiveSupport::TestCase`. Two places are found that potentially leak global state. This patch makes sure states are restored so that none of the changes happen in a single test will be carried over to subsequence tests. | ||||
* | Some minor fixes | Godfrey Chan | 2014-01-24 | 1 | -1/+0 |
| | |||||
* | Removed old tests | Godfrey Chan | 2014-01-24 | 1 | -58/+121 |
| | |||||
* | Merge pull request #13273 from robertomiranda/test-remove-require | Guillermo Iguaran | 2013-12-11 | 1 | -1/+0 |
|\ | | | | | Remove require 'models/administrator', Administrator is not used in secure password test | ||||
| * | Remove require 'models/administrator', Administrator is not used in secure ↵ | robertomiranda | 2013-12-11 | 1 | -1/+0 |
| | | | | | | | | password test | ||||
* | | Use bcrypt's public cost attr, not internal constant | T.J. Schuck | 2013-10-10 | 1 | -0/+8 |
|/ | | | | | | | | See: - https://github.com/codahale/bcrypt-ruby/pull/63 - https://github.com/codahale/bcrypt-ruby/pull/64 - https://github.com/codahale/bcrypt-ruby/pull/65 | ||||
* | Fix secure_password password_confirmation validations | Vladimir Kiselev | 2013-07-24 | 1 | -0/+5 |
| | |||||
* | Fix regression in has_secure_password. | Phil Calvin | 2013-05-30 | 1 | -0/+9 |
| | | | | If the confirmation was blank, but the password wasn't, it would still save. | ||||
* | `has_secure_password` is not invalid when assigning empty Strings. | Yves Senn | 2013-03-04 | 1 | -0/+6 |
| | | | | | | | | | | Closes #9535. With 692b3b6 the `password=` setter does no longer set blank passwords. This triggered validation errors when assigning empty Strings to `password` and `password_confirmation`. This patch only sets the confirmation if it is not `blank?`. | ||||
* | Use secure password min cost option in its own tests for a speed up | Carlos Antonio da Silva | 2012-11-21 | 1 | -2/+10 |
| | | | | Around 0.564359s => 0.092244s speed up in my machine. | ||||
* | Use BCrypt's MIN_COST in the test environment for speedier tests | Trevor Turk | 2012-11-14 | 1 | -1/+12 |
| | |||||
* | Cleanup trailing whitespaces | dfens | 2012-10-12 | 1 | -1/+1 |
| | |||||
* | Remove MassAssignmentSecurity from ActiveModel | Guillermo Iguaran | 2012-09-16 | 1 | -12/+0 |
| | | | | This will be moved out to protected_attributes gem | ||||
* | has_secure_password should not raise a 'digest missing' error if the calling ↵ | Robby Grossman | 2012-07-31 | 1 | -0/+8 |
| | | | | class has specified for validations to be skipped. | ||||
* | Updated tests for has_secure_password. | Erich Menge | 2012-05-08 | 1 | -8/+22 |
| | |||||
* | Fix secure_password setter | Oscar Del Ben | 2012-04-24 | 1 | -0/+6 |
| | |||||
* | use variables from test setup | Vijay Dev | 2011-10-17 | 1 | -6/+4 |
| | |||||
* | AM mass assignment security attr_accessible and attr_protected now allow for ↵ | Josh Kalderimis | 2011-04-24 | 1 | -5/+6 |
| | | | | | | | | scopes using :as => scope eg. attr_accessible :name attr_accessible :name, :admin, :as => :admin | ||||
* | bcrypt will encrypt anything, so validate_presence_of would not catch nil / ↵ | Aaron Patterson | 2011-04-14 | 1 | -0/+12 |
| | | | | blank passwords. Thank you to Aleksander Kamil Modzelewski for reporting this | ||||
* | Override attributes_protected_by_default when has_secure_password is called. | Tsutomu Kuroda | 2011-02-09 | 1 | -0/+13 |
| | | | | | | | attr_protected should not be called, because it nullifies the mass assignment protection that has been set by attr_accessible. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Remove weak_passwords list and the length/strong password validator, leave ↵ | Santiago Pastorino | 2010-12-19 | 1 | -49/+1 |
| | | | | that up to the programmer | ||||
* | Add set_weak_passwords call in alignment with set_table_name. | Mikel Lindsaar | 2010-12-19 | 1 | -0/+5 |
| | |||||
* | Added ability to specify which passwords you want as weak passwords | Mikel Lindsaar | 2010-12-19 | 1 | -11/+31 |
| | |||||
* | Make password messages translatable. | José Valim | 2010-12-19 | 1 | -1/+1 |
| | |||||
* | Avoid warnings and fix small typo on SecurePassword. | José Valim | 2010-12-19 | 1 | -1/+3 |
| | |||||
* | BCrypt does its own salting, lovely! | David Heinemeier Hansson | 2010-12-18 | 1 | -0/+11 |
| | |||||
* | Added ActiveRecord::Base#has_secure_password (via ↵ | David Heinemeier Hansson | 2010-12-18 | 1 | -0/+42 |
ActiveModel::SecurePassword) to encapsulate dead-simple password usage with SHA2 encryption and salting |