Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert "No such class since 8d2866bb80fbe81acb04f5b0c44f152f571fb29f" | Rafael Mendonça França | 2019-08-02 | 1 | -1/+1 |
| | | | | This reverts commit dd779c9686f49f5ed6dda8ad5a1cb3b0788e1dd4. | ||||
* | No such class since 8d2866bb80fbe81acb04f5b0c44f152f571fb29f | Akira Matsuda | 2019-08-02 | 1 | -1/+1 |
| | |||||
* | Change the empty block style to have space inside of the block | Rafael Mendonça França | 2018-09-25 | 1 | -1/+1 |
| | |||||
* | Use respond_to test helpers | Daniel Colson | 2018-01-25 | 1 | -6/+6 |
| | |||||
* | Use frozen string literal in activemodel/ | Kir Shatrov | 2017-07-16 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Remove deprecated behavior that halts callbacks when the return is false | Rafael Mendonça França | 2017-02-07 | 1 | -5/+4 |
| | |||||
* | Remove deprecated passing string to define callback | Ryuta Kamizono | 2017-02-04 | 1 | -1/+1 |
| | | | | And raise `ArgumentError` when passing string to define callback. | ||||
* | code gardening: removes redundant selfs | Xavier Noria | 2016-08-08 | 1 | -2/+2 |
| | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required. | ||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -2/+0 |
| | |||||
* | applies new string literal convention in activemodel/test | Xavier Noria | 2016-08-06 | 1 | -2/+2 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Deprecate passing string to define callback. | yui-knk | 2015-12-16 | 1 | -1/+1 |
| | |||||
* | Deprecate `false` as the way to halt AM callbacks | claudiob | 2015-01-02 | 1 | -3/+13 |
| | | | | | | | | | | Before this commit, returning `false` in an ActiveModel `before_` callback such as `before_create` would halt the callback chain. After this commit, the behavior is deprecated: will still work until the next release of Rails but will also display a deprecation warning. The preferred way to halt a callback chain is to explicitly `throw(:abort)`. | ||||
* | Add AM test: after/around callback returning false | claudiob | 2014-12-14 | 1 | -4/+15 |
| | | | | | | | | | | | This stems from https://github.com/rails/rails/pull/17227#discussion_r21641358 It's simply a clarification of the current behavior by which if an `after_` or `around_` ActiveModel callback returns +false+, then the callback chain **is not halted**. The callback chain in ActiveModel is only halted when a `before_` callback returns `false`. | ||||
* | Convert ActiveModel to 1.9 hash syntax. | Patrick Robertson | 2013-05-01 | 1 | -3/+3 |
| | | | | | I also attempted to fix other styleguide violations such as { a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ). | ||||
* | fix some typos found in activemodel | Vipul A M | 2013-03-18 | 1 | -1/+1 |
| | |||||
* | Use run_callbacks; the generated _run_<name>_callbacks method is not a ↵ | John Firebaugh | 2011-01-31 | 1 | -2/+2 |
| | | | | | | public interface. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | after_create in ActiveModel should in the order specified | Neeraj Singh | 2010-09-27 | 1 | -0/+30 |
| | | | | | | [#5650 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | no callbacks should be created for empty array [#5289 state:resolved] | Subba Rao Pasupuleti | 2010-08-12 | 1 | -0/+14 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Use better assertion methods for testing | Neeraj Singh | 2010-05-19 | 1 | -1/+1 |
| | | | | | | [#4645 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Move ActiveRecord callbacks implementation to ActiveModel and make use of it. | José Valim | 2009-12-28 | 1 | -0/+70 |
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local> |