| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| | |
We have to specify the `:title` option to really use the
`TitleValidator` defined above.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This change prevents a certain class of user error which results when
mistakenly using the `validate` class method instead of the `validates`
class method.
Only apply when all arguments are symbols, because some validations use
the `validate` method and pass in additional options, namely the
`LenghValidator` via the `ActiveMode::Validations::validates_with`
method.
|
| |
| |
| |
| |
| |
| |
| | |
Also make it accept a list of attributes to be changed. This will make
possible to restore only a subset of the changed attributes.
Closes #16203
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
These methods may cause confusion with the `reset_changes` that
behaves differently
of them.
Also rename undo_changes to restore_changes to match this new set of
methods.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
#clear_changes_information
This method name is causing confusion with the `reset_#{attribute}`
methods. While `reset_name` set the value of the name attribute for the
previous value the `reset_changes` only discard the changes and previous
changes.
|
| | |
|
| |
| |
| |
| | |
This is a follow up to #16024.
|
| |
| |
| |
| | |
ActiveModel::SecurePassword
|
| |
| |
| |
| |
| | |
The instance method `model_name` was being defined multiple times,
causing a redefinition warning.
|
| |
| |
| |
| | |
To avoid overload with database rollback
|
| | |
|
|\ \
| | |
| | |
| | | |
Added rollback method to ActiveModel::Dirty
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Leave the note for `ActiveModel`, since it can't yet detect mutations
(hopefully we can change this in time for 4.2). However, we now detect
mutations on all supported types in `ActiveRecord`, so we can note that
`_will_change!` is no longer needed there.
|
|\ \ \
| |_|/
|/| | |
Allow proc and symbol as values for `only_integer` of `NumericalityValidator`
|
| | | |
|
|/ / |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
See #14591, Reason - BCrypt hash function can handle maximum 72 characters.
|
|\ \
| | |
| | | |
[ci skip] Clarify ActiveModel::Model docs
|
| | |
| | |
| | |
| | | |
ActiveModel attributes initialized with String return String values
|
|/ / |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Put attr_reader in with all of the other instance methods
|
| | |
| | |
| | |
| | | |
This makes the grouping make a little more sense
|
|/ /
| |
| |
| | |
[ci skip]
|
|/ |
|
|
|
|
|
|
| |
Currently, if environment doesn’t eager load code, invoking this
constant before calling #valid? on a model instance results in a
NameError.
|
| |
|
|
|
| |
[ci skip]
|
|
|
|
|
|
|
|
| |
It's unintuitive to call '#valid?' when you want to run validations but
don't care about the return value.
The alias in ActiveRecord isn't strictly necessary (the ActiveModel
alias is still in effect), but it clarifies.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This method return `Gem::Version.new(Rails.version)`, suggesting a more
reliable way to perform version comparison.
Example:
Rails.version #=> "4.1.2"
Rails.gem_version #=> #<Gem::Version "4.1.2">
Rails.version > "4.1.10" #=> false
Rails.gem_version > Gem::Version.new("4.1.10") #=> true
Gem::Requirement.new("~> 4.1.2") =~ Rails.gem_version #=> true
This was originally introduced as `.version` by @charliesome in #8501
but got reverted in #10002 since it was not backward compatible.
Also, updating template for `rake update_versions`.
|
|
|
|
|
|
|
|
| |
Now that Validator #setup is called from the initializer, we need a
reference to the model's class to be passed in to allow the validators
to continue functioning when used at the instance level.
Closes #14134.
|
|
|
|
|
| |
Goes along with fea1cdcff4d50d302d8e8532432c3ab107ff816d and
59ec4562a2e70df455b2e44a67c340fa5254e26e.
|
|
|
|
| |
We should not rely on to_s to return the name of the class
|
| |
|
| |
|
|\
| |
| |
| |
| |
| | |
Conflicts:
actionview/CHANGELOG.md
activerecord/CHANGELOG.md
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The documentation of `#to_key` (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key)
states that it returns `nil` if there are no key attributes. `to_param` needs
to be aware of that fact and return `nil` as well.
Previously it raised the following exception:
```
1) Error:
ConversionTest#test_to_param_returns_nil_if_to_key_is_nil:
NoMethodError: undefined method `join' for nil:NilClass
/Users/senny/Projects/rails/activemodel/lib/active_model/conversion.rb:65:in `to_param'
/Users/senny/Projects/rails/activemodel/test/cases/conversion_test.rb:34:in `block in <class:ConversionTest>'
```
|
| | |
|
| |
| |
| |
| |
| |
| | |
Example:
validates_presence_of :name, on: [:update, :custom_validation_context]
|
| |
| |
| |
| |
| |
| | |
& Xavier Noria]
Closes #11247.
|