aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel/lib
Commit message (Collapse)AuthorAgeFilesLines
* revises rdoc of AMo::Error#add [#4738 state:resolved]Xavier Noria2010-06-011-6/+6
|
* Fixed numericality validator in ActiveModel to reject hex numbers for floats ↵rohit2010-05-181-1/+1
| | | | | | completely [#4622 state:commited] Signed-off-by: José Valim <jose.valim@gmail.com>
* Valid hex strings aren't valid float column values, to match the integer ↵Jeremy Kemper2010-05-171-3/+8
| | | | restriction. [#4622 state:resolved]
* a cloned object no longer mimics changed flags from creator , plus a test ↵Federico Brubacher2010-05-161-4/+5
| | | | | | case [#4614 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an ↵José Valim2010-05-159-54/+26
| | | | | | | | options hash and make various Validators pass their (filtered) options." Having a huge array to whitelist options is not the proper way to handle this case. This means that the ActiveModel::Errors object should know about the options given in *all* validators and break the extensibility added by the validators itself. If the intent is to whitelist options before sending them to I18n, each validator should clean its respective options instead of throwing the responsibility to the Errors object. This reverts commit bc1c8d58ec45593acba614d1d0fecb49adef08ff.
* Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵Jeroen van Dijk2010-05-159-26/+54
| | | | | | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Original patch by Sven Fuchs, some minor changes and has been changed to be applicable to master again [#4057 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* minor changes to instance level validations implementation based on feedback ↵Josh Kalderimis2010-05-134-38/+17
| | | | from José Valim
* validation macros can now be used within an instanceJosh Kalderimis2010-05-1311-14/+89
|
* Revert "Refactor of active_model/naming.rb and allow collection and element ↵Santiago Pastorino2010-05-121-29/+5
| | | | | | | | to be writable" This reverts commit f7862b2c34b5b298bf7b937c55f0637ebfe43a25. Signed-off-by: José Valim <jose.valim@gmail.com>
* Make ActiveResource serialize XML correctly when element_name is set.Santiago Pastorino2010-05-121-1/+1
| | | | | | [#4529] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Refactor of active_model/naming.rb and allow collection and element to be ↵Santiago Pastorino2010-05-121-5/+29
| | | | | | writable Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Merge remote branch 'rails/master'Xavier Noria2010-05-092-6/+17
|\
| * updated AMo validations to use a context for valid? and invalid?, removing ↵Josh Kalderimis2010-05-081-5/+12
| | | | | | | | the dependency on AR
| * Active Model JSON serializer now supports custom root optionJatinder Singh2010-05-041-1/+5
| | | | | | | | | | | | [#4515 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* | typo 'Provivdes' -> 'Provides'Santiago Pastorino2010-05-051-1/+1
|/
* Favor %{} in all code instead of (deprecated) {{}} as interpolation syntax ↵Lawrence Pit2010-05-033-5/+5
| | | | | | for I18n Signed-off-by: José Valim <jose.valim@gmail.com>
* Use %{} syntax in I18n (faster) instead of {{}}.José Valim2010-05-012-10/+10
|
* Move several configuration values from Hash to ActiveSupport::XmlMini, which ↵José Valim2010-04-291-111/+51
| | | | | | both Hash and Array depends on. Also, refactored ActiveModel serializers to just use ActiveSupport::XmlMini.to_tag. As consequence, if a serialized attribute is an array or a hash, it's not encoded as yaml, but as a hash or array.
* Makes validates_acceptance_of to not override database fields [#4460 ↵Santiago Pastorino2010-04-282-2/+7
| | | | | | state:committed] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix validates_numericaly_of only integer error message [#4406 state:resolved]reu2010-04-252-11/+19
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Speed up xml serializer by computing values just once and remove unecessary ↵José Valim2010-04-221-18/+17
| | | | code duplication.
* Fix Active Model observer testsJeremy Kemper2010-04-161-0/+4
|
* ActiveModel::Observing: stop using Observable Ruby module, re-implement ↵Mislav Marohnić2010-04-161-7/+16
| | | | | | | | | `notify_observers` `Observable#notify_observers` from Ruby always returns false (which halts ActiveRecord callback chains) and has extra features (like `changed`) that were never used. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Re-define empty? for errors to check if the values inside the OrderedHash ↵Ryan Bigg2010-04-101-0/+5
| | | | | | are empty rather than the OrderedHash itself. [#4356 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Update versions (otherwise you install a gem from source as beta3 but ↵José Valim2010-04-101-1/+1
| | | | internally it's beta2) and update CHANGELOG.
* fix stack trace lines on class_evalSantiago Pastorino2010-04-092-5/+5
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* errors.rb needs to be declared as UTF-8 [#3941 state:resolved]Aaron Patterson2010-04-021-0/+2
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Restore changed_attributes method in ActiveModel::Dirty and loosen ↵Sam Pohlenz2010-04-011-12/+12
| | | | | | | | expectation on including class' initialize method. [#4308 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Prep for beta2, depend on latest BundlerDavid Heinemeier Hansson2010-04-011-1/+1
|
* Merge branch 'master' of github.com:rails/railsJeremy Kemper2010-03-283-0/+5
|\
| * adds missing requires for Object#blank? and Object#present?Xavier Noria2010-03-282-0/+2
| |
| * adds a few requires in active_model/dirty.rbXavier Noria2010-03-281-0/+3
| | | | | | | | [#4284 state:committed]
* | Cosmetics: mismatch indentationJeremy Kemper2010-03-281-1/+1
|/
* Use Array.wrap uniformlyJeremy Kemper2010-03-275-7/+12
|
* Fix unstated dep on HWIAJeremy Kemper2010-03-271-0/+2
|
* Fix tests added in previous commit.José Valim2010-03-271-0/+5
|
* ActiveModel::Dirty#changes should return a HashWithIndifferentAccess [#4157 ↵Jacob Atzen2010-03-271-1/+1
| | | | | | | | state:resolved] Keep the Rails style of inject Signed-off-by: José Valim <jose.valim@gmail.com>
* Merge branch 'master' into docrailswycats2010-03-263-22/+23
|\
| * Remove reference to unexistent methods and fix typo.José Valim2010-03-261-1/+0
| |
| * cleaning up a bunch of method already defined warnings [#4209 state:resolved]Aaron Patterson2010-03-171-3/+15
| | | | | | | | Signed-off-by: wycats <wycats@gmail.com>
| * fisting uninitialized ivar warnings. [#4198 state:resolved]Aaron Patterson2010-03-161-10/+7
| | | | | | | | Signed-off-by: wycats <wycats@gmail.com>
| * clean up more warnings, remove unnecessary methods, fix eval line numbers. ↵Aaron Patterson2010-03-161-9/+2
| | | | | | | | | | | | [#4193 state:resolved] Signed-off-by: wycats <wycats@gmail.com>
* | Merge remote branch 'mainstream/master'Pratik Naik2010-03-128-30/+123
|\| | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/base.rb railties/lib/rails/configuration.rb railties/lib/rails/log_subscriber.rb
| * Update versions of all components to normalize them to new formatBryan Helmkamp2010-03-021-2/+3
| |
| * Add missing information about attributes method.José Valim2010-02-281-3/+6
| |
| * ActiveModel::Lint should not require our models to respond to id.José Valim2010-02-281-2/+0
| |
| * Accept array of attributes as arg also, like 2.3Jeremy Kemper2010-02-251-1/+1
| |
| * Use Object#singleton_class instead of #metaclass. Prefer Ruby's choice.Jeremy Kemper2010-02-251-1/+1
| |
| * Add validators reflection so you can do 'Person.validators' and ↵Prem Sichanugrist2010-02-213-3/+45
| | | | | | | | | | | | 'Person.validators_on(:name)'. Signed-off-by: José Valim <jose.valim@gmail.com>
| * Require persisted? in ActiveModel::Lint and remove new_record? and ↵José Valim2010-02-212-21/+16
| | | | | | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not.