aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel/lib
Commit message (Collapse)AuthorAgeFilesLines
* Refactor previous commit a bit [#4057 state:resolved]José Valim2010-06-217-16/+16
|
* Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵Jeroen van Dijk2010-06-219-32/+69
| | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now. The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet. Signed-off-by: José Valim <jose.valim@gmail.com>
* Merge remote branch 'rails/master'Xavier Noria2010-06-202-2/+66
|\ | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb
| * ActiveModel::Validations::Callbacks should not be required by default.José Valim2010-06-192-13/+23
| |
| * moving before_validation and after_validation functionality from ↵Neeraj Singh2010-06-192-12/+66
| | | | | | | | | | | | | | | | ActiveRecord to ActiveModel [#4653 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* | Changes call backs to callbacks.Rizwan Reza2010-06-152-9/+9
| |
* | Merge branch 'master' of github.com:lifo/docrailsRizwan Reza2010-06-151-2/+2
|\ \
| * | Active Model lint - fix minor typosBryan Woods2010-06-151-2/+2
| | |
* | | Add titles to the rest of the files in active_model/validations/*Rizwan Reza2010-06-158-0/+16
| | |
* | | Minor doc changes to active_model/validations/confirmation.rbRizwan Reza2010-06-151-13/+27
| | |
* | | Minor doc changes to active_model/validations/acceptance.rbRizwan Reza2010-06-151-15/+30
|/ /
* | Fix a bunch of minor spelling mistakesEvgeniy Dolzhenko2010-06-156-8/+8
|\ \ | |/ |/|
| * Fix a bunch of minor spelling mistakesEvgeniy Dolzhenko2010-06-116-8/+8
| |
* | edit pass: the names of Rails components have a space, ie, "Active Record", ↵Xavier Noria2010-06-143-3/+3
| | | | | | | | not "ActiveRecord"
* | Added headings to serializers.Rizwan Reza2010-06-143-3/+7
| |
* | Revised the rest of the files from ActiveModel.Rizwan Reza2010-06-143-23/+36
| |
* | Revised and added headings.Rizwan Reza2010-06-143-1/+7
| |
* | Revised naming.rb and lint.rbRizwan Reza2010-06-142-5/+5
| |
* | Added headings and revised active_model.rb/lint.rb grammaticallyRizwan Reza2010-06-141-1/+3
| |
* | Minor changes to active_model/errors.rbRizwan Reza2010-06-141-8/+16
| |
* | Minor changes to active_model/callbacks.rb and dirty.rbRizwan Reza2010-06-142-7/+12
| |
* | Minor changes to active_model/attribute_methodsRizwan Reza2010-06-141-24/+30
| |
* | Minor changes to callbacks and conversion API docs.Rizwan Reza2010-06-142-13/+17
|/
* Fix spelling error in ActiveModel::Conversion docs. [#4826 state:resolved]Pavel Gorbokon2010-06-111-1/+1
|
* class_attribute is not a direct replacement of class_inheritable_*.José Valim2010-06-101-5/+11
| | | | | | If you are setting a hash or an array in class_attribute or you need to freeze it, to ensure people won't modify it in place or you need to dup it on inheritance.
* Validators should at model level and not at AR:Base level [Closes #4804]Neeraj Singh2010-06-101-1/+1
| | | | | | [#4804 state:resolved] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
* Get ready for beta 4David Heinemeier Hansson2010-06-081-1/+1
|
* Really make include_root_in_json default to true [#3770 state:resolved]José Valim2010-06-081-3/+6
|
* Observing module is using constantizeSantiago Pastorino2010-06-061-0/+1
|
* revises rdoc of AMo::Error#add [#4738 state:resolved]Xavier Noria2010-06-011-6/+6
|
* Fixed numericality validator in ActiveModel to reject hex numbers for floats ↵rohit2010-05-181-1/+1
| | | | | | completely [#4622 state:commited] Signed-off-by: José Valim <jose.valim@gmail.com>
* Valid hex strings aren't valid float column values, to match the integer ↵Jeremy Kemper2010-05-171-3/+8
| | | | restriction. [#4622 state:resolved]
* a cloned object no longer mimics changed flags from creator , plus a test ↵Federico Brubacher2010-05-161-4/+5
| | | | | | case [#4614 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an ↵José Valim2010-05-159-54/+26
| | | | | | | | options hash and make various Validators pass their (filtered) options." Having a huge array to whitelist options is not the proper way to handle this case. This means that the ActiveModel::Errors object should know about the options given in *all* validators and break the extensibility added by the validators itself. If the intent is to whitelist options before sending them to I18n, each validator should clean its respective options instead of throwing the responsibility to the Errors object. This reverts commit bc1c8d58ec45593acba614d1d0fecb49adef08ff.
* Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵Jeroen van Dijk2010-05-159-26/+54
| | | | | | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Original patch by Sven Fuchs, some minor changes and has been changed to be applicable to master again [#4057 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* minor changes to instance level validations implementation based on feedback ↵Josh Kalderimis2010-05-134-38/+17
| | | | from José Valim
* validation macros can now be used within an instanceJosh Kalderimis2010-05-1311-14/+89
|
* Revert "Refactor of active_model/naming.rb and allow collection and element ↵Santiago Pastorino2010-05-121-29/+5
| | | | | | | | to be writable" This reverts commit f7862b2c34b5b298bf7b937c55f0637ebfe43a25. Signed-off-by: José Valim <jose.valim@gmail.com>
* Make ActiveResource serialize XML correctly when element_name is set.Santiago Pastorino2010-05-121-1/+1
| | | | | | [#4529] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Refactor of active_model/naming.rb and allow collection and element to be ↵Santiago Pastorino2010-05-121-5/+29
| | | | | | writable Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Merge remote branch 'rails/master'Xavier Noria2010-05-092-6/+17
|\
| * updated AMo validations to use a context for valid? and invalid?, removing ↵Josh Kalderimis2010-05-081-5/+12
| | | | | | | | the dependency on AR
| * Active Model JSON serializer now supports custom root optionJatinder Singh2010-05-041-1/+5
| | | | | | | | | | | | [#4515 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* | typo 'Provivdes' -> 'Provides'Santiago Pastorino2010-05-051-1/+1
|/
* Favor %{} in all code instead of (deprecated) {{}} as interpolation syntax ↵Lawrence Pit2010-05-033-5/+5
| | | | | | for I18n Signed-off-by: José Valim <jose.valim@gmail.com>
* Use %{} syntax in I18n (faster) instead of {{}}.José Valim2010-05-012-10/+10
|
* Move several configuration values from Hash to ActiveSupport::XmlMini, which ↵José Valim2010-04-291-111/+51
| | | | | | both Hash and Array depends on. Also, refactored ActiveModel serializers to just use ActiveSupport::XmlMini.to_tag. As consequence, if a serialized attribute is an array or a hash, it's not encoded as yaml, but as a hash or array.
* Makes validates_acceptance_of to not override database fields [#4460 ↵Santiago Pastorino2010-04-282-2/+7
| | | | | | state:committed] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix validates_numericaly_of only integer error message [#4406 state:resolved]reu2010-04-252-11/+19
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Speed up xml serializer by computing values just once and remove unecessary ↵José Valim2010-04-221-18/+17
| | | | code duplication.