Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 9 | -10/+10 |
| | |||||
* | removes requires already present in active_support/rails | Xavier Noria | 2016-10-27 | 1 | -1/+0 |
| | |||||
* | let Regexp#match? be globally available | Xavier Noria | 2016-10-27 | 2 | -2/+0 |
| | | | | | | Regexp#match? should be considered to be part of the Ruby core library. We are emulating it for < 2.4, but not having to require the extension is part of the illusion of the emulation. | ||||
* | Missing require extract_options | Akira Matsuda | 2016-10-25 | 1 | -0/+2 |
| | |||||
* | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2016-10-20 | 1 | -1/+1 |
|\ | |||||
| * | Corrected comments referring to ActiveModel::Attributes | Iain Beeston | 2016-10-03 | 1 | -1/+1 |
| | | | | | | | | Should be ActiveRecord::Attributes (ActiveModel::Attributes does not exist) | ||||
* | | Removed deprecated :tokenizer in the length validator | Rafael Mendonça França | 2016-10-10 | 1 | -34/+1 |
| | | |||||
* | | Removed deprecated methods in ActiveModel::Errors | Rafael Mendonça França | 2016-10-10 | 1 | -87/+0 |
| | | | | | | | | `#get`, `#set`, `[]=`, `add_on_empty` and `add_on_blank`. | ||||
* | | Merge pull request #24571 from raimo/patch-1 | Sean Griffin | 2016-10-04 | 1 | -0/+9 |
|\ \ | |/ |/| | Print the proper ::Float::INFINITY value when used as a default value | ||||
| * | Print the proper ::Float::INFINITY value when used as a default value | Raimo Tuisku | 2016-05-23 | 1 | -0/+9 |
| | | | | | | | | Addresses https://github.com/rails/rails/issues/22396 | ||||
* | | Do not leak the Errors default proc when calling to_hash or as_json | Jean Boussier | 2016-09-27 | 1 | -1/+1 |
| | | |||||
* | | [ci skip] Fix bad examples in rdoc | Andrey Molchanov | 2016-09-17 | 1 | -2/+11 |
| | | |||||
* | | Update ActiveModel::Dirty Doc [ci skip] | Louis-Michel Couture | 2016-09-16 | 1 | -8/+8 |
| | | |||||
* | | Update ActiveModel::Dirty Doc [ci skip] | Louis-Michel Couture | 2016-09-15 | 1 | -1/+1 |
| | | | | | | Fix potentially misleading example. | ||||
* | | Fix broken comments indentation caused by rubocop auto-correct [ci skip] | Ryuta Kamizono | 2016-09-14 | 3 | -6/+6 |
| | | | | | | | | | | | | All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency. | ||||
* | | Fix Remaining Case-In-Assignment Statement Formatting | Alex Kitchens | 2016-09-06 | 1 | -12/+13 |
| | | | | | | | | | | | | | | | | | | Recently, the Rails team made an effort to keep the source code consistent, using Ruboco (bb1ecdcc677bf6e68e0252505509c089619b5b90 and below). Some of the case statements were missed. This changes the case statements' formatting and is consistent with changes in 810dff7c9fa9b2a38eb1560ce0378d760529ee6b and db63406cb007ab3756d2a96d2e0b5d4e777f8231. | ||||
* | | apply case-in-assignment pattern | Xavier Noria | 2016-09-02 | 2 | -11/+13 |
| | | |||||
* | | RuboCop is 100% green :tada: | Xavier Noria | 2016-09-02 | 2 | -2/+2 |
| | | |||||
* | | validate_each in NumericalityValidator is never called in this case. | Guillermo Iguaran | 2016-08-28 | 1 | -2/+0 |
| | | | | | | | | | | NumericalityValidator#validate_each is never called when allow_nil is true and the value is nil because it is already skipped in EachValidator#validate. | ||||
* | | Fix typo in deprecation message | Georg Ledermann | 2016-08-27 | 1 | -1/+1 |
| | | | | | | This fixes a copy-and-paste-issue slipped in by #18996 | ||||
* | | Fix broken alignments caused by auto-correct commit 411ccbd | Ryuta Kamizono | 2016-08-10 | 1 | -1/+2 |
| | | | | | | | | Hash syntax auto-correcting breaks alignments. 411ccbdab2608c62aabdb320d52cb02d446bb39c | ||||
* | | code gardening: removes redundant selfs | Xavier Noria | 2016-08-08 | 3 | -4/+4 |
| | | | | | | | | | | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required. | ||||
* | | revises most Lint/EndAlignment offenses | Xavier Noria | 2016-08-07 | 1 | -5/+5 |
| | | | | | | | | Some case expressions remain, need to think about those ones. | ||||
* | | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 13 | -21/+9 |
| | | |||||
* | | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 25 | -307/+307 |
| | | |||||
* | | remove redundant curlies from hash arguments | Xavier Noria | 2016-08-06 | 1 | -4/+2 |
| | | |||||
* | | applies new string literal convention in activemodel/lib | Xavier Noria | 2016-08-06 | 28 | -77/+77 |
| | | | | | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | | systematic revision of =~ usage in AMo | Xavier Noria | 2016-07-24 | 3 | -5/+7 |
| | | |||||
* | | [ci skip] add class level documentation to ActiveModel::Type::Boolean | David Elliott | 2016-07-11 | 1 | -2/+13 |
| | | | | | | | | add documentation of the behaviors of type coercion at the class level | ||||
* | | Merge pull request #25364 from kamipo/fix_serialize_for_date_type | Rafael França | 2016-06-28 | 1 | -0/+4 |
|\ \ | | | | | | | Fix `Type::Date#serialize` to return a date object correctly | ||||
| * | | Fix `Type::Date#serialize` to return a date object correctly | Ryuta Kamizono | 2016-06-16 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | Currently `Type::Date#serialize` does not cast a value to a date object. It should be cast to a date object for finding by date column correctly working. Fixes #25354. | ||||
* | | | Tiny documentation fixes [ci skip] | Robin Dupret | 2016-06-25 | 1 | -7/+7 |
| | | | | | | | | | | | | | | | Fix a tiny typo and vertical-align some return results in the ActiveModel::Errors documentation. | ||||
* | | | [ci skip] Add additional documentation to ActiveModel::Errors | Alex Kitchens | 2016-06-22 | 1 | -1/+12 |
| | | | |||||
* | | | [ci skip] Remove duplicate alias documentation in ActiveModel::Validations | Alex Kitchens | 2016-06-16 | 1 | -2/+0 |
|/ / | |||||
* | | Ensure that instances of `ActiveModel::Errors` can be marshalled | Sean Griffin | 2016-05-30 | 1 | -2/+23 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We now use default procs inside of the errors object, which gets included by default when marshaling anything that includes `ActiveModel::Validations`. This means that Active Record objects cannot be marshalled. We strip and apply the default proc ourselves. This will ensure the objects are YAML serializable as well, since YAML falls back to marshal implementations now. This is less important, however, as the errors aren't included when dumping Active Record objects. This commit does not include a changelog entry, as 5.0 is still in RC status at the time of writing, and 5.0.0 will not release with the bug this fixes. Fixes #25165 | ||||
* | | Support for unified Integer class in Ruby 2.4+ | Jeremy Daer | 2016-05-18 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005 * Forward compat with new unified Integer class in Ruby 2.4+. * Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3. * Drops needless Fixnum distinction in docs, preferring Integer. | ||||
* | | - removing redundant 'happens' in documentation [ci skip] | Mohit Natoo | 2016-05-19 | 1 | -4/+2 |
| | | |||||
* | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2016-05-14 | 1 | -2/+11 |
|\ \ | | | | | | | | | | | | | Conflicts: guides/source/configuring.md | ||||
| * | | Add example for UnknownAttributeError | Vipul A M | 2016-05-02 | 1 | -0/+9 |
| | | | | | | | | | | | | [ci skip] | ||||
| * | | Active Model: Messages for strict validation always convert attributes to ↵ | Prathamesh Sonpatki | 2016-05-01 | 1 | -2/+2 |
| | | | | | | | | | | | | human readable form [ci skip] | ||||
* | | | Start Rails 5.1 development :tada: | Rafael Mendonça França | 2016-05-10 | 1 | -2/+2 |
| | | | |||||
* | | | Preparing for 5.0.0.rc1 release | Rafael Mendonça França | 2016-05-06 | 1 | -1/+1 |
| | | | |||||
* | | | Change RangeError to a more specific ActiveModel::RangeError | Christian Blais | 2016-05-03 | 3 | -1/+6 |
| |/ |/| | | | | | | | | | The should make it easier for apps to rescue ActiveModel specific errors without the need to wrap all method calls with a generic rescue RangeError. | ||||
* | | Chomp: prefer String#chomp where we can for a clarity boost | lvl0nax | 2016-04-29 | 2 | -6/+2 |
|/ | | | | | | Closes #24766, #24767 Signed-off-by: Jeremy Daer <jeremydaer@gmail.com> | ||||
* | Prep Rails 5 beta 4 | eileencodes | 2016-04-27 | 1 | -1/+1 |
| | |||||
* | - [ci skip] `regardless` is usually followed by `of` and not by `if .. or not`. | Mohit Natoo | 2016-04-21 | 1 | -2/+2 |
| | |||||
* | Fixed bug introduced in #24519. Makes build green again | Bogdan Gusiev | 2016-04-13 | 1 | -1/+1 |
| | |||||
* | Use keyword arguments to cleanup without droping performance | Bogdan Gusiev | 2016-04-13 | 1 | -8/+8 |
| | |||||
* | prevent 'attribute_changed?' from returning nil | Sen-Zhang | 2016-04-11 | 1 | -1/+1 |
| | |||||
* | Merge pull request #24511 from lihanli/activemodel-dirty-attribute-changed | Jeremy Daer | 2016-04-11 | 1 | -3/+5 |
|\ | | | | | speed up ActiveModel::Dirty#attribute_changed? |