Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Clarify ActiveModel::Validator initialization in docs. | Henrik Nyh | 2013-02-09 | 1 | -0/+3 |
| | | | As discussed with @josevalim on Ruby Rogues Parley. | ||||
* | Missing require extract_options | Akira Matsuda | 2013-01-31 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #8989 from robertomiranda/use-rails-4-find-by" | Guillermo Iguaran | 2013-01-18 | 2 | -3/+3 |
| | | | | | This reverts commit 637a7d9d357a0f3f725b0548282ca8c5e7d4af4a, reversing changes made to 5937bd02dee112646469848d7fe8a8bfcef5b4c1. | ||||
* | User Rails 4 find_by | robertomiranda | 2013-01-18 | 2 | -3/+3 |
| | |||||
* | Set default value to ActiveModel::Validator initializer attribute | Irio Irineu Musskopf Junior | 2013-01-09 | 1 | -1/+1 |
| | | | | Makes it easier to test its objects. | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-01-09 | 1 | -1/+1 |
|\ | | | | | | | | | Conflicts: guides/source/getting_started.md | ||||
| * | prefer american spelling of 'behavior' | Gosha Arinich | 2013-01-07 | 1 | -1/+1 |
| | | |||||
* | | Reduce number of Strings a bit | Akira Matsuda | 2013-01-07 | 2 | -3/+3 |
| | | |||||
* | | Namespace HashWithIndifferentAccess | Akira Matsuda | 2013-01-07 | 1 | -1/+1 |
|/ | |||||
* | Updated copyright notices for 2013 | Andrew Nesbitt | 2012-12-31 | 1 | -1/+1 |
| | |||||
* | Revert the change at ActiveModel::Errors#add_on_blank and fix in the | Rafael Mendonça França | 2012-12-26 | 2 | -9/+3 |
| | | | | | | | | | | | right place. The EachValidator#validate already handle :allow_blank and :allow_nil, correctly. Closes #8622. Fix #8621. | ||||
* | Tests and fix for validates_presence of :allow_nil, :allow_blank | Colin Kelley | 2012-12-26 | 1 | -1/+7 |
| | | | | | Conflicts: activemodel/lib/active_model/errors.rb | ||||
* | chmod -x from non-script files | Akira Matsuda | 2012-12-24 | 1 | -0/+0 |
| | |||||
* | Use :present as key for the absence validatior message | Rafael Mendonça França | 2012-12-21 | 2 | -2/+2 |
| | |||||
* | Remove ActiveModel::Errors#add_on_present method. | Rafael Mendonça França | 2012-12-21 | 3 | -16/+3 |
| | | | | | | | | We don't need to define a new method in ActiveMode::Errors for each validatior. See https://github.com/rails/rails/commit/d72a07f1d1478db9daed847eadb35bfd840674f6#commitcomment-2325333 | ||||
* | Add `ActiveModel::Validations::AbsenceValidator`, a validator to check the ↵ | Roberto Vasquez Angel | 2012-12-15 | 3 | -0/+45 |
| | | | | | | absence of attributes. Add `ActiveModel::Errors#add_on_present` method. Adds error messages to present attributes. | ||||
* | Merge pull request #8510 from thedarkone/thread_safety_improvements | Aaron Patterson | 2012-12-14 | 1 | -4/+5 |
|\ | | | | | Thread safety improvements | ||||
| * | Replace some global Hash usages with the new thread safe cache. | thedarkone | 2012-12-14 | 1 | -4/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary of the changes: * Add thread_safe gem. * Use thread safe cache for digestor caching. * Replace manual synchronization with ThreadSafe::Cache in Relation::Delegation. * Replace @attribute_method_matchers_cache Hash with ThreadSafe::Cache. * Use TS::Cache to avoid the synchronisation overhead on listener retrieval. * Replace synchronisation with TS::Cache usage. * Use a preallocated array for performance/memory reasons. * Update the controllers cache to the new AS::Dependencies::ClassCache API. The original @controllers cache no longer makes much sense after @tenderlove's changes in 7b6bfe84f3 and f345e2380c. * Use TS::Cache in the connection pool to avoid locking overhead. * Use TS::Cache in ConnectionHandler. | ||||
* | | Only call `in_time_zone` on Time or DateTime instances | Andrew White | 2012-12-11 | 1 | -1/+6 |
|/ | | | | | Both String and Date now respond to in_time_zone so we need to check if the value is a Time or a DateTime. | ||||
* | Replace comments' non-breaking spaces with spaces | claudiob | 2012-12-04 | 3 | -6/+6 |
| | | | | | | | | | | Sometimes, on Mac OS X, programmers accidentally press Option+Space rather than just Space and don’t see the difference. The problem is that Option+Space writes a non-breaking space (0XA0) rather than a normal space (0x20). This commit removes all the non-breaking spaces inadvertently introduced in the comments of the code. | ||||
* | Reset attributes should not report changes. | Renato Mascarenhas | 2012-12-01 | 1 | -1/+4 |
| | | | | | | | | | | | When resetting an attribute, you expect it to return to the state it was before any changes. Namely, this fixes this unexpected behavior: ~~~ruby model.name = "Bob" model.reset_name! model.name_changed? #=> true ~~~ | ||||
* | Remove observers and sweepers | Rafael Mendonça França | 2012-11-28 | 3 | -527/+0 |
| | | | | | | | | They was extracted from a plugin. See https://github.com/rails/rails-observers [Rafael Mendonça França + Steve Klabnik] | ||||
* | Specify type of singular association during serialization | Steve Klabnik | 2012-11-28 | 1 | -1/+6 |
| | | | | | | | | | | | | When serialising a class, specify the type of any singular associations, if necessary. Rails already correctly specifies the :type of any enumerable association (e.g. a has_many association), but made no attempt to do so for non-enumerables (e.g. a has_one association). We must specify the :type of any STI association. A has_one association to a class which uses single-table inheritance is an example of this type of association. Fixes #7471 | ||||
* | Merge pull request #7282 from xHire/validates_length_of_fix | Rafael Mendonça França | 2012-11-26 | 1 | -2/+14 |
|\ | | | | | | | | | | | | | Length validation handles correctly nil. Fix #7180 Conflicts: activemodel/CHANGELOG.md | ||||
| * | Length validation handles correctly nil. Fix #7180 | Michal Zima | 2012-11-26 | 1 | -2/+14 |
| | | | | | | | | When nil or empty string are not allowed, they are not valid. | ||||
* | | cleanup, removed dispensable `require` statements from `ActiveModel` | Yves Senn | 2012-11-25 | 7 | -12/+0 |
| | | |||||
* | | cleanup, remove broken whitespace | Yves Senn | 2012-11-25 | 4 | -9/+9 |
|/ | |||||
* | Point user to strong_parameters as the new protection model [ci skip] | Saulius Grigaliunas | 2012-11-18 | 1 | -4/+6 |
| | |||||
* | Initialize #min_cost to avoid warning in Ruby 2.0 | Carlos Antonio da Silva | 2012-11-17 | 1 | -2/+3 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-11-17 | 1 | -0/+4 |
|\ | | | | | | | | | Conflicts: actionpack/lib/action_dispatch/routing/redirection.rb | ||||
| * | add details on password confirmation used with has_secure_password | Daniel Lopes | 2012-11-13 | 1 | -0/+4 |
| | | |||||
* | | Use BCrypt's MIN_COST in the test environment for speedier tests | Trevor Turk | 2012-11-14 | 2 | -1/+8 |
| | | |||||
* | | Trivial documentation fix for ActiveModel::Naming comment. | Dennis Taylor | 2012-11-09 | 1 | -2/+2 |
| | | |||||
* | | rm dead code | Aaron Patterson | 2012-11-09 | 1 | -1/+1 |
| | | |||||
* | | use Array() instead flatten | Vasiliy Ermolovich | 2012-11-05 | 1 | -2/+2 |
| | | | | | | | | | | * move ActiveModel::Errors tests to errors_test.rb * add spec coverage for add_on_empty and add_on_blank | ||||
* | | Raise ArgumentError when no attribute is given to AMo::EachValidator | Carlos Antonio da Silva | 2012-11-04 | 1 | -1/+1 |
| | | | | | | | | ArgumentError is better suited than RuntimeError for this. | ||||
* | | Set hash value instead of using merge! | Carlos Antonio da Silva | 2012-11-04 | 1 | -1/+1 |
|/ | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-11-03 | 12 | -43/+35 |
|\ | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/mime_responds.rb activerecord/lib/active_record/attribute_methods.rb guides/source/working_with_javascript_in_rails.md | ||||
| * | minor edits and remove mixed titles in AM::Validations docs [ci skip] | Francesco Rodriguez | 2012-10-25 | 9 | -21/+13 |
| | | |||||
| * | fix output messages - docs [ci skip] | Francesco Rodriguez | 2012-10-22 | 1 | -16/+16 |
| | | |||||
| * | convert comments to 1.9 hash syntax | AvnerCohen | 2012-10-22 | 3 | -17/+17 |
| | | |||||
* | | Make caller attribute in deprecation methods optional | Alexey Gaziev | 2012-10-30 | 2 | -2/+2 |
| | | |||||
* | | Provide a call stack for deprecation warnings where needed. | Nikita Afanasenko | 2012-10-29 | 2 | -7/+6 |
| | | | | | | | | It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly. | ||||
* | | fix AM::Serializers titles [ci skip] | Francesco Rodriguez | 2012-10-26 | 2 | -2/+2 |
| | | |||||
* | | AM::Serializers::Xml depends on AM::Naming | Francesco Rodriguez | 2012-10-26 | 1 | -0/+4 |
|/ | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-10-21 | 23 | -35/+35 |
|\ | | | | | | | | | | | Conflicts: activesupport/lib/active_support/core_ext/hash/slice.rb guides/source/active_support_core_extensions.md | ||||
| * | minor edits in AM documentation [ci skip] | Francesco Rodriguez | 2012-10-21 | 22 | -32/+32 |
| | | |||||
| * | remove non-breaking spaces [ci skip] | Francesco Rodriguez | 2012-10-18 | 1 | -3/+3 |
| | | |||||
* | | active_model/validations requires necessary files to run | Yves Senn | 2012-10-18 | 1 | -0/+1 |
| | | |||||
* | | cleanup, replace non-breaking spaces with spaces | Yves Senn | 2012-10-18 | 1 | -5/+5 |
|/ |