| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
| | | | |
| | | | |
| | | | | |
[ci skip]
|
| |_|_|/
|/| | |
| | | |
| | | | |
Make AM::Dirty less dirty to plugin into AR or other library
|
| |_|/
|/| |
| | |
| | | |
[ci skip]
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | | |
change docs for xml serializer to talk about xml
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
follow the same refactor at a63a964a5d1ed02cf0df1b1a33a96ed2a9fa987b
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
ActiveModel::Validations::Clusivity#include? method
the original name `exclusion` is a bit confusing when using with the method `inclusion_method`
rename it to a more logic neutral name.
|
| | | |
|
| | |
| | |
| | |
| | | |
Rails 4.0 has removed attr_protected and attr_accessible feature in favor of Strong Parameters.
|
|\ \ \
| | | |
| | | | |
make default value for `:message` on `AM::Errors` explicit.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
chuckbergeron/validates-inclusion-of-accuracy-for-non-numeric-ranges
Greater accuracy for validates_inclusion_of on non-numeric ranges
Closes #10774, fixes #10593
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Range#include? for non-numeric ranges
added changelog message
|
| | | | |
| | | | |
| | | | |
| | | | | |
Removing other occurrences of `the` appearing twice
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Those two files are required by active_support/rails.rb
loaded in active_model.rb
It is common to require common dependencies on the root
files to avoid boilerplate in each file.
This reverts commit 763635e30f17800ebc0a8ae98d780edc8ebfb4e5, reversing
changes made to 4f46ef36aaef217834f3f96d3689d32f6a6761ea.
|
|\ \ \ \
| | | | |
| | | | | |
Add explicit dependencies of ActiveSupport to enable independent usage of ActiveModel::Name
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
There are two missing ActiveSupport dependencies to use ActiveModel::Name class or ActiveModel::Naming module independently.
Missing dependencies for Module#delegate defined in `active_support/core_ext/module/delegation`, used at [L148](https://github.com/rails/rails/blob/master/activemodel/lib/active_model/naming.rb#L148)
Missing dependencies for Object#blank? defined in `active_support/core_ext/object/blank`, used at [L131](https://github.com/rails/rails/blob/master/activemodel/lib/active_model/naming.rb#L131)
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
|
|/ / / / |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | | |
Dynamically setting instance variables based on user input probably isn't a great idea. Better to go through the setter methods provided by attr_accessor.
|
|/ / /
| | |
| | |
| | | |
If the confirmation was blank, but the password wasn't, it would still save.
|
| | |
| | |
| | |
| | | |
their setup in their constructor now.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The error message uses English to say that the object should respond
to a certain method. You check that with respond_to, but that's not
English.
This makes this error message also consistent with the rest.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Based on my benchmark results, this change improves performance
substantially when defining callbacks.
This benchmark (https://gist.github.com/wangjohn/5542610) was run using
the current master and also using my experimental branch which replaced
class_eval with define_single_method.
Using class_eval (current master):
user system total real
10 trials 0.000000 0.000000 0.000000 ( 0.001568)
50 trials 0.020000 0.000000 0.020000 ( 0.021715)
500 trials 0.110000 0.000000 0.110000 ( 0.115357)
1000 trials 0.250000 0.000000 0.250000 ( 0.260025)
10000 trials 2.560000 0.000000 2.560000 ( 2.568408)
50000 trials 12.800000 0.010000 12.810000 ( 12.886871)
Using define_single_method (experimental branch):
user system total real
10 trials 0.000000 0.000000 0.000000 ( 0.000790)
50 trials 0.000000 0.000000 0.000000 ( 0.002960)
500 trials 0.050000 0.010000 0.060000 ( 0.055690)
1000 trials 0.100000 0.000000 0.100000 ( 0.094073)
10000 trials 0.890000 0.000000 0.890000 ( 0.900364)
50000 trials 4.650000 0.000000 4.650000 ( 4.686127)
|
| | |
| | |
| | |
| | |
| | | |
I also attempted to fix other styleguide violations such as
{ a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ).
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
* Highlights the requirement of an attributes method.
* Removes some details that depend on the implementation of the class including the module.
* Applies guidelines here and there.
|
| | | |
|
| | |
| | |
| | |
| | | |
Add a working example of how to use this new method.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Add #to_s method to VERSION modules
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Just raising from the rescue block will re-raise the exception, so the
variable is not necessary.
|
| | | | |
|
|/ / /
| | |
| | |
| | | |
rest of the code the wat the includes are done
|
| | |
| | |
| | |
| | |
| | |
| | | |
it only cleared the validations that created :validate callbacks. This
didn't include the validates created by validates_with, so I've added a
method to clear all validations.
|
|\ \ \
| | | |
| | | | |
`has_secure_password` is not invalid when assigning empty Strings
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Closes #9535.
With 692b3b6 the `password=` setter does no longer set blank passwords.
This triggered validation errors when assigning empty Strings to `password`
and `password_confirmation`.
This patch only sets the confirmation if it is not `blank?`.
|