Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | after_validation should be called irrespective of the result of validation. | Neeraj Singh | 2010-08-20 | 1 | -1/+1 |
| | | | | | | | | I confirmed that this is the behavior on 2.3.x . [5419 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'docrails/master' | Xavier Noria | 2010-08-18 | 1 | -2/+2 |
|\ | |||||
| * | you rarely want ^ or $ in validations, use \A when you mean \A | Xavier Noria | 2010-08-18 | 1 | -2/+2 |
| | | |||||
| * | Missing object for comparison in ActiveModel::EachValidator example code. | Trey Bean | 2010-08-17 | 1 | -1/+1 |
| | | |||||
| * | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 17 | -222/+222 |
| | | | | | | | | 's/[ \t]*$//' -i {} \;) | ||||
| * | no callbacks should be created for empty array [#5289 state:resolved] | Subba Rao Pasupuleti | 2010-08-14 | 1 | -3/+6 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | tidy up validations length code [#5297 state:resolved] | Subba Rao Pasupuleti | 2010-08-14 | 1 | -6/+2 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Add missing ActiveModel::Validations require | Greg Campbell | 2010-08-14 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | | | [#5311 state: resolved] ActiveModel::Validations uses Hash#except, but does not require it from ActiveSupport. (This wasn't showing up in the tests, because it was required in the helper, and was also required in ActiveModel::Serialization). Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | to_key should return all exists keys (if any exists), regardless if the ↵ | José Valim | 2010-08-15 | 2 | -3/+7 |
| | | | | | | | | object is persisted or not. If you need it to reflect persistance, you should use to_param. | ||||
* | | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 17 | -222/+222 |
| | | | | | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | | no callbacks should be created for empty array [#5289 state:resolved] | Subba Rao Pasupuleti | 2010-08-12 | 1 | -3/+6 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | tidy up validations length code [#5297 state:resolved] | Subba Rao Pasupuleti | 2010-08-12 | 1 | -6/+2 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Add missing ActiveModel::Validations require | Greg Campbell | 2010-08-12 | 1 | -0/+1 |
|/ | | | | | | | | | | | [#5311 state: resolved] ActiveModel::Validations uses Hash#except, but does not require it from ActiveSupport. (This wasn't showing up in the tests, because it was required in the helper, and was also required in ActiveModel::Serialization). Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'docrails/master' | Xavier Noria | 2010-08-12 | 1 | -3/+3 |
|\ | |||||
| * | ActiveModel::Base doesn't exist, include_root_in_json is a class_attribute ↵ | Santiago Pastorino | 2010-08-10 | 1 | -3/+3 |
| | | | | | | | | for the classes which includes this module | ||||
* | | fixes a typo reported by rymai | Xavier Noria | 2010-08-10 | 1 | -1/+1 |
|/ | |||||
* | typo in AM | Adam Meehan | 2010-08-09 | 1 | -1/+1 |
| | |||||
* | edit pass to AMo::Serializers::JSON | Xavier Noria | 2010-08-06 | 1 | -9/+9 |
| | |||||
* | Merge remote branch 'docrails/master' | Xavier Noria | 2010-08-05 | 2 | -2/+4 |
|\ | |||||
| * | adding documentation to ActiveSupport::Concern ht:strictly typed for an ↵ | Neeraj Singh | 2010-08-04 | 1 | -0/+2 |
| | | | | | | | | | | | | awesome example some minor documentation changes | ||||
| * | fixing documentation | Neeraj Singh | 2010-08-03 | 1 | -2/+2 |
| | | |||||
* | | Tidy up error.rb code | Subba Rao Pasupuleti | 2010-08-03 | 1 | -5/+1 |
| | | | | | | | | | | | | [#5288 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | | Freeze options so we raise an error when people modify it in place. | José Valim | 2010-08-03 | 2 | -3/+5 |
| | | |||||
* | | validates_length_of should not change the options hash in place. [#5283 ↵ | José Valim | 2010-08-03 | 1 | -4/+7 |
| | | | | | | | | state:resolved] | ||||
* | | Remove or fix non-working examples and add a few tests to Dirty [#5185 ↵ | Tore Darell | 2010-08-03 | 1 | -7/+2 |
|/ | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | ActiveModel::Errors json serialization to work as Rails 3b4 [#5254 ↵ | Alex Le | 2010-08-02 | 1 | -2/+2 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-07-30 | 7 | -31/+30 |
|\ | |||||
| * | edit pass to apply API guideline wrt the use of "# =>" in example code | Xavier Noria | 2010-07-30 | 6 | -30/+29 |
| | | |||||
| * | Prep for RC | David Heinemeier Hansson | 2010-07-26 | 1 | -1/+1 |
| | | |||||
* | | expanding on the will_change! method in documentation | Neeraj Singh | 2010-07-29 | 1 | -1/+4 |
|/ | |||||
* | replacing around with for in the comments for callbacks | Neeraj Singh | 2010-07-22 | 1 | -1/+1 |
| | |||||
* | Moved a few methods from RecordIdentifier to ActiveModel::Naming | Piotr Sarnacki | 2010-07-21 | 1 | -0/+29 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | adding proper markup to comment | Neeraj Singh | 2010-07-16 | 1 | -2/+2 |
| | |||||
* | Add missing require to use Set | Santiago Pastorino | 2010-07-11 | 1 | -1/+2 |
| | |||||
* | Improve a bit the code in latest commits. | José Valim | 2010-07-08 | 1 | -1/+2 |
| | |||||
* | Removing method before redefining it. It was causing warnings. [#5072 ↵ | Łukasz Strzałkowski | 2010-07-08 | 1 | -0/+1 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Change documentation for ActiveModel::MassAssignmentSecurity a bit and make ↵ | José Valim | 2010-07-08 | 3 | -47/+54 |
| | | | | debug always be called since some people may overwrite warn! to add extra behavior even if logger is not available. | ||||
* | mass_assignment_security moved from AR to AMo, and minor test cleanup | Josh Kalderimis | 2010-07-08 | 4 | -0/+216 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Add a missing require to allow the usage of Array#to_xml | Santiago Pastorino | 2010-07-03 | 1 | -0/+1 |
| | |||||
* | Move constantize from conversions to inflections. | Santiago Pastorino | 2010-06-26 | 1 | -1/+0 |
| | | | | | | | | This removes ActiveModel dependency on TZInfo. [#4979 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Work around the fact the JSON gem was overwriting to_json implementation for ↵ | José Valim | 2010-06-26 | 1 | -10/+7 |
| | | | | | | | all Ruby core classes. This is required because the JSON gem is incompatible with Rails behavior and was not allowing ActiveModel::Errors to be serialized. So we need to ensure Rails implementation is the one triggered. [#4890 state:resolved] | ||||
* | Regression with how base errors messages are added to a model. Works ↵ | Josh Kalderimis | 2010-06-23 | 2 | -2/+2 |
| | | | | | | correctly for both string error messages and symbol translated messages. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Refactor previous commit a bit [#4057 state:resolved] | José Valim | 2010-06-21 | 7 | -16/+16 |
| | |||||
* | Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵ | Jeroen van Dijk | 2010-06-21 | 9 | -32/+69 |
| | | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now. The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-20 | 2 | -2/+66 |
|\ | | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb | ||||
| * | ActiveModel::Validations::Callbacks should not be required by default. | José Valim | 2010-06-19 | 2 | -13/+23 |
| | | |||||
| * | moving before_validation and after_validation functionality from ↵ | Neeraj Singh | 2010-06-19 | 2 | -12/+66 |
| | | | | | | | | | | | | | | | | ActiveRecord to ActiveModel [#4653 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Changes call backs to callbacks. | Rizwan Reza | 2010-06-15 | 2 | -9/+9 |
| | | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Rizwan Reza | 2010-06-15 | 1 | -2/+2 |
|\ \ | |||||
| * | | Active Model lint - fix minor typos | Bryan Woods | 2010-06-15 | 1 | -2/+2 |
| | | |