Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Silence warning emitted in tests | Sean Griffin | 2014-07-01 | 1 | -0/+1 |
| | | | | | The instance method `model_name` was being defined multiple times, causing a redefinition warning. | ||||
* | Rename rollback_changes to undo_changes | Rafael Mendonça França | 2014-06-30 | 1 | -3/+3 |
| | | | | To avoid overload with database rollback | ||||
* | Add CHANGELOG entry for #14861 and document private methods on the API | Rafael Mendonça França | 2014-06-30 | 1 | -5/+5 |
| | |||||
* | Merge pull request #14861 from igor04/dirty-rollback | Rafael Mendonça França | 2014-06-30 | 1 | -0/+17 |
|\ | | | | | | | Added rollback method to ActiveModel::Dirty | ||||
| * | Added rollback method to ActiveModel::Dirty | igor04 | 2014-06-23 | 1 | -0/+17 |
| | | |||||
* | | We are talking about the libraries, not the constants | Sean Griffin | 2014-06-27 | 1 | -3/+3 |
| | | |||||
* | | Note that `_will_change!` is no longer needed for AR instances | Sean Griffin | 2014-06-27 | 1 | -3/+5 |
| | | | | | | | | | | | | | | Leave the note for `ActiveModel`, since it can't yet detect mutations (hopefully we can change this in time for 4.2). However, we now detect mutations on all supported types in `ActiveRecord`, so we can note that `_will_change!` is no longer needed there. | ||||
* | | Merge pull request #15834 from rmehner/allow_proc_and_symbol_for_only_integer | Rafael Mendonça França | 2014-06-26 | 1 | -1/+13 |
|\ \ | | | | | | | Allow proc and symbol as values for `only_integer` of `NumericalityValidator` | ||||
| * | | `only_integer` of `NumericalityValidator` now allows procs and symbols | Robin Mehner | 2014-06-22 | 1 | -1/+13 |
| | | | |||||
* | | | Delegate #model_name method to self.class | Yuki Nishijima | 2014-06-22 | 1 | -0/+6 |
|/ / | |||||
* | | :scissors: and :nail_care: from d60c405 [ci skip] | Zachary Scott | 2014-06-16 | 1 | -3/+3 |
| | | |||||
* | | [ci skip] correct doc for serialization in accordance with API Doc Guide | Aditya Kapoor | 2014-06-16 | 1 | -11/+11 |
| | | |||||
* | | Edit pass on `has_secure_password` documentation [ci skip] | Godfrey Chan | 2014-06-14 | 1 | -5/+6 |
| | | |||||
* | | [ci skip] Update #has_secure_password docs | Akshay Vishnoi | 2014-06-14 | 1 | -6/+9 |
| | | |||||
* | | SecurePassword - Validate password must be less than or equal to 72 | Akshay Vishnoi | 2014-06-14 | 1 | -0/+6 |
| | | | | | | | | See #14591, Reason - BCrypt hash function can handle maximum 72 characters. | ||||
* | | Merge pull request #15690 from deeeki/activemodel_model_doc | Arthur Nogueira Neves | 2014-06-13 | 1 | -3/+3 |
|\ \ | | | | | | | [ci skip] Clarify ActiveModel::Model docs | ||||
| * | | [ci skip] Clarify ActiveModel::Model docs | deeeki | 2014-06-14 | 1 | -3/+3 |
| | | | | | | | | | | | | ActiveModel attributes initialized with String return String values | ||||
* | | | [ci skip] correct docs for conversion | Aditya Kapoor | 2014-06-11 | 1 | -5/+12 |
|/ / | |||||
* | | remove depricated Validatior#setup | Kuldeep Aggarwal | 2014-06-10 | 1 | -16/+0 |
| | | |||||
* | | [ci skip] Include ActiveModel::Model in a class instead of inheriting | Akshay Vishnoi | 2014-05-30 | 1 | -2/+3 |
| | | |||||
* | | Name#model_name doesn't return a String object | ShunsukeAida | 2014-05-30 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #15154 from msgehard/move_password_field | Rafael Mendonça França | 2014-05-20 | 1 | -2/+2 |
|\ \ | | | | | | | Put attr_reader in with all of the other instance methods | ||||
| * | | Put attr_reader in with all of the other instance methods | Mike Gehard | 2014-05-17 | 1 | -2/+2 |
| | | | | | | | | | | | | This makes the grouping make a little more sense | ||||
* | | | Let others know why this code is here | Mike Gehard | 2014-05-18 | 1 | -0/+1 |
|/ / | | | | | | | [ci skip] | ||||
* / | Add singular and plural form for some validation messages | Abd ar-Rahman Hamidi | 2014-05-02 | 1 | -3/+9 |
|/ | |||||
* | add missing parentheses to validates_with documentation [skip ci] | Steve Agalloco | 2014-04-04 | 1 | -1/+1 |
| | |||||
* | Adds explanation of :base attribute to errors.add | David Underwood | 2014-03-27 | 1 | -0/+7 |
| | | | [ci skip] | ||||
* | ActiveRecord/ActiveModel '#validate' alias for 'valid?' | Henrik Nyh | 2014-03-27 | 1 | -0/+4 |
| | | | | | | | | It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies. | ||||
* | Introduce `Rails.gem_version` | Prem Sichanugrist | 2014-03-05 | 2 | -7/+19 |
| | | | | | | | | | | | | | | | | | | | This method return `Gem::Version.new(Rails.version)`, suggesting a more reliable way to perform version comparison. Example: Rails.version #=> "4.1.2" Rails.gem_version #=> #<Gem::Version "4.1.2"> Rails.version > "4.1.10" #=> false Rails.gem_version > Gem::Version.new("4.1.10") #=> true Gem::Requirement.new("~> 4.1.2") =~ Rails.gem_version #=> true This was originally introduced as `.version` by @charliesome in #8501 but got reverted in #10002 since it was not backward compatible. Also, updating template for `rake update_versions`. | ||||
* | Fix some validators when used on model instance | Eric Hutzelman | 2014-02-26 | 1 | -0/+2 |
| | | | | | | | | Now that Validator #setup is called from the initializer, we need a reference to the model's class to be passed in to allow the validators to continue functioning when used at the instance level. Closes #14134. | ||||
* | Pass strings to demodulize method | Carlos Antonio da Silva | 2014-02-26 | 1 | -1/+1 |
| | | | | | Goes along with fea1cdcff4d50d302d8e8532432c3ab107ff816d and 59ec4562a2e70df455b2e44a67c340fa5254e26e. | ||||
* | pass the class name to `tableize` | Aaron Patterson | 2014-02-26 | 1 | -1/+1 |
| | | | | We should not rely on to_s to return the name of the class | ||||
* | Bump version of bcrypt gem | T.J. Schuck | 2014-02-25 | 1 | -4/+4 |
| | |||||
* | update version to 4.2.0.alpha | Yves Senn | 2014-02-23 | 1 | -1/+1 |
| | |||||
* | Merge branch '4-1-0-beta2' | Rafael Mendonça França | 2014-02-18 | 1 | -1/+1 |
|\ | | | | | | | | | | | Conflicts: actionview/CHANGELOG.md activerecord/CHANGELOG.md | ||||
| * | Preparing for 4.1.0.beta2 release | Rafael Mendonça França | 2014-02-18 | 1 | -1/+1 |
| | | |||||
* | | `#to_param` returns `nil` if `to_key` returns `nil`. Closes #11399. | Yves Senn | 2014-02-04 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The documentation of `#to_key` (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key) states that it returns `nil` if there are no key attributes. `to_param` needs to be aware of that fact and return `nil` as well. Previously it raised the following exception: ``` 1) Error: ConversionTest#test_to_param_returns_nil_if_to_key_is_nil: NoMethodError: undefined method `join' for nil:NilClass /Users/senny/Projects/rails/activemodel/lib/active_model/conversion.rb:65:in `to_param' /Users/senny/Projects/rails/activemodel/test/cases/conversion_test.rb:34:in `block in <class:ConversionTest>' ``` | ||||
* | | Fix doc markup of clear_validators! | Carlos Antonio da Silva | 2014-01-27 | 1 | -2/+2 |
| | | |||||
* | | Ability to specify multiple contexts when defining a validation. | Vince Puzzella | 2014-01-27 | 1 | -5/+9 |
| | | | | | | | | | | | | Example: validates_presence_of :name, on: [:update, :custom_validation_context] | ||||
* | | revises references to :allow_(nil|blank) in some docs [ci skip] [Steven Yang ↵ | Xavier Noria | 2014-01-26 | 10 | -26/+12 |
| | | | | | | | | | | | | & Xavier Noria] Closes #11247. | ||||
* | | Some minor fixes | Godfrey Chan | 2014-01-24 | 1 | -2/+2 |
| | | |||||
* | | Got all the new tests passing | Godfrey Chan | 2014-01-24 | 1 | -10/+8 |
| | | |||||
* | | Restored the ability to clear the password with user.password= nil (see the ↵ | Godfrey Chan | 2014-01-24 | 1 | -1/+3 |
| | | | | | | | | docs) | ||||
* | | Fix ActiveModel::Errors#has_key? return value | Adrien Coquio | 2014-01-22 | 1 | -1/+1 |
| | | |||||
* | | Forgot to push this change in the parent commit | Rafael Mendonça França | 2014-01-20 | 1 | -1/+1 |
| | | |||||
* | | When applying changes or reseting changes create the right class | Rafael Mendonça França | 2014-01-20 | 1 | -3/+3 |
| | | | | | | | | | | | | | | Before this patch after the changes are applied the changes can be only accessed using string keys, but before symbols are also accepted. After this change every state of the model will be consistent. | ||||
* | | doc proc/lambda arg on inclusion validation. Closes #13689. [ci skip] | Yves Senn | 2014-01-13 | 1 | -1/+2 |
| | | |||||
* | | Use a better method name to check the requirement of password confirmation | Carlos Antonio da Silva | 2014-01-07 | 1 | -5/+5 |
| | | | | | | | | | | Also improve changelog entries related to secure password to proper highlight. | ||||
* | | Fix typo in AMo docs [ci skip] | Carlos Antonio da Silva | 2014-01-06 | 1 | -1/+1 |
| | | |||||
* | | Change all "can not"s to the correct "cannot". | T.J. Schuck | 2014-01-03 | 1 | -20/+20 |
| | |