aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel/lib/active_model
Commit message (Collapse)AuthorAgeFilesLines
* %i doesn't work on 1.9Aaron Patterson2014-07-171-1/+1
|
* check for valid options in validate methodsonnym2014-07-171-0/+6
| | | | | | | | | | | This change prevents a certain class of user error which results when mistakenly using the `validate` class method instead of the `validates` class method. Only apply when all arguments are symbols, because some validations use the `validate` method and pass in additional options, namely the `LenghValidator` via the `ActiveMode::Validations::validates_with` method.
* Make restore_attributes publicRafael Mendonça França2014-07-171-5/+5
| | | | | | | Also make it accept a list of attributes to be changed. This will make possible to restore only a subset of the changed attributes. Closes #16203
* Deprecate `reset_#{attribute}` in favor of `restore_#{attribute}`.Rafael Mendonça França2014-07-151-4/+12
| | | | | | | | | These methods may cause confusion with the `reset_changes` that behaves differently of them. Also rename undo_changes to restore_changes to match this new set of methods.
* Deprecate ActiveModel::Dirty#reset_changes in favor of ↵Rafael Mendonça França2014-07-151-4/+12
| | | | | | | | | #clear_changes_information This method name is causing confusion with the `reset_#{attribute}` methods. While `reset_name` set the value of the name attribute for the previous value the `reset_changes` only discard the changes and previous changes.
* [ci skip] Little bit doc code improvement.Santosh Wadghule2014-07-141-1/+1
|
* Only automatically include validations when enabledGodfrey Chan2014-07-021-1/+2
| | | | This is a follow up to #16024.
* automatically include ActiveModel::Validations when include ↵Aditya Kapoor2014-07-031-0/+1
| | | | ActiveModel::SecurePassword
* Silence warning emitted in testsSean Griffin2014-07-011-0/+1
| | | | | The instance method `model_name` was being defined multiple times, causing a redefinition warning.
* Rename rollback_changes to undo_changesRafael Mendonça França2014-06-301-3/+3
| | | | To avoid overload with database rollback
* Add CHANGELOG entry for #14861 and document private methods on the APIRafael Mendonça França2014-06-301-5/+5
|
* Merge pull request #14861 from igor04/dirty-rollbackRafael Mendonça França2014-06-301-0/+17
|\ | | | | | | Added rollback method to ActiveModel::Dirty
| * Added rollback method to ActiveModel::Dirtyigor042014-06-231-0/+17
| |
* | We are talking about the libraries, not the constantsSean Griffin2014-06-271-3/+3
| |
* | Note that `_will_change!` is no longer needed for AR instancesSean Griffin2014-06-271-3/+5
| | | | | | | | | | | | | | Leave the note for `ActiveModel`, since it can't yet detect mutations (hopefully we can change this in time for 4.2). However, we now detect mutations on all supported types in `ActiveRecord`, so we can note that `_will_change!` is no longer needed there.
* | Merge pull request #15834 from rmehner/allow_proc_and_symbol_for_only_integerRafael Mendonça França2014-06-261-1/+13
|\ \ | | | | | | Allow proc and symbol as values for `only_integer` of `NumericalityValidator`
| * | `only_integer` of `NumericalityValidator` now allows procs and symbolsRobin Mehner2014-06-221-1/+13
| | |
* | | Delegate #model_name method to self.classYuki Nishijima2014-06-221-0/+6
|/ /
* | :scissors: and :nail_care: from d60c405 [ci skip]Zachary Scott2014-06-161-3/+3
| |
* | [ci skip] correct doc for serialization in accordance with API Doc GuideAditya Kapoor2014-06-161-11/+11
| |
* | Edit pass on `has_secure_password` documentation [ci skip]Godfrey Chan2014-06-141-5/+6
| |
* | [ci skip] Update #has_secure_password docsAkshay Vishnoi2014-06-141-6/+9
| |
* | SecurePassword - Validate password must be less than or equal to 72Akshay Vishnoi2014-06-141-0/+6
| | | | | | | | See #14591, Reason - BCrypt hash function can handle maximum 72 characters.
* | Merge pull request #15690 from deeeki/activemodel_model_docArthur Nogueira Neves2014-06-131-3/+3
|\ \ | | | | | | [ci skip] Clarify ActiveModel::Model docs
| * | [ci skip] Clarify ActiveModel::Model docsdeeeki2014-06-141-3/+3
| | | | | | | | | | | | ActiveModel attributes initialized with String return String values
* | | [ci skip] correct docs for conversionAditya Kapoor2014-06-111-5/+12
|/ /
* | remove depricated Validatior#setupKuldeep Aggarwal2014-06-101-16/+0
| |
* | [ci skip] Include ActiveModel::Model in a class instead of inheritingAkshay Vishnoi2014-05-301-2/+3
| |
* | Name#model_name doesn't return a String objectShunsukeAida2014-05-301-1/+1
| |
* | Merge pull request #15154 from msgehard/move_password_fieldRafael Mendonça França2014-05-201-2/+2
|\ \ | | | | | | Put attr_reader in with all of the other instance methods
| * | Put attr_reader in with all of the other instance methodsMike Gehard2014-05-171-2/+2
| | | | | | | | | | | | This makes the grouping make a little more sense
* | | Let others know why this code is hereMike Gehard2014-05-181-0/+1
|/ / | | | | | | [ci skip]
* / Add singular and plural form for some validation messagesAbd ar-Rahman Hamidi2014-05-021-3/+9
|/
* add missing parentheses to validates_with documentation [skip ci]Steve Agalloco2014-04-041-1/+1
|
* Adds explanation of :base attribute to errors.addDavid Underwood2014-03-271-0/+7
| | | [ci skip]
* ActiveRecord/ActiveModel '#validate' alias for 'valid?'Henrik Nyh2014-03-271-0/+4
| | | | | | | | It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies.
* Introduce `Rails.gem_version`Prem Sichanugrist2014-03-052-7/+19
| | | | | | | | | | | | | | | | | | | This method return `Gem::Version.new(Rails.version)`, suggesting a more reliable way to perform version comparison. Example: Rails.version #=> "4.1.2" Rails.gem_version #=> #<Gem::Version "4.1.2"> Rails.version > "4.1.10" #=> false Rails.gem_version > Gem::Version.new("4.1.10") #=> true Gem::Requirement.new("~> 4.1.2") =~ Rails.gem_version #=> true This was originally introduced as `.version` by @charliesome in #8501 but got reverted in #10002 since it was not backward compatible. Also, updating template for `rake update_versions`.
* Fix some validators when used on model instanceEric Hutzelman2014-02-261-0/+2
| | | | | | | | Now that Validator #setup is called from the initializer, we need a reference to the model's class to be passed in to allow the validators to continue functioning when used at the instance level. Closes #14134.
* Pass strings to demodulize methodCarlos Antonio da Silva2014-02-261-1/+1
| | | | | Goes along with fea1cdcff4d50d302d8e8532432c3ab107ff816d and 59ec4562a2e70df455b2e44a67c340fa5254e26e.
* pass the class name to `tableize`Aaron Patterson2014-02-261-1/+1
| | | | We should not rely on to_s to return the name of the class
* Bump version of bcrypt gemT.J. Schuck2014-02-251-4/+4
|
* update version to 4.2.0.alphaYves Senn2014-02-231-1/+1
|
* Merge branch '4-1-0-beta2'Rafael Mendonça França2014-02-181-1/+1
|\ | | | | | | | | | | Conflicts: actionview/CHANGELOG.md activerecord/CHANGELOG.md
| * Preparing for 4.1.0.beta2 releaseRafael Mendonça França2014-02-181-1/+1
| |
* | `#to_param` returns `nil` if `to_key` returns `nil`. Closes #11399.Yves Senn2014-02-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The documentation of `#to_key` (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key) states that it returns `nil` if there are no key attributes. `to_param` needs to be aware of that fact and return `nil` as well. Previously it raised the following exception: ``` 1) Error: ConversionTest#test_to_param_returns_nil_if_to_key_is_nil: NoMethodError: undefined method `join' for nil:NilClass /Users/senny/Projects/rails/activemodel/lib/active_model/conversion.rb:65:in `to_param' /Users/senny/Projects/rails/activemodel/test/cases/conversion_test.rb:34:in `block in <class:ConversionTest>' ```
* | Fix doc markup of clear_validators!Carlos Antonio da Silva2014-01-271-2/+2
| |
* | Ability to specify multiple contexts when defining a validation.Vince Puzzella2014-01-271-5/+9
| | | | | | | | | | | | Example: validates_presence_of :name, on: [:update, :custom_validation_context]
* | revises references to :allow_(nil|blank) in some docs [ci skip] [Steven Yang ↵Xavier Noria2014-01-2610-26/+12
| | | | | | | | | | | | & Xavier Noria] Closes #11247.
* | Some minor fixesGodfrey Chan2014-01-241-2/+2
| |
* | Got all the new tests passingGodfrey Chan2014-01-241-10/+8
| |