| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | | renamed mass-assignment scopes to roles, updated code, tests, docs and ↵ | Josh Kalderimis | 2011-05-08 | 1 | -23/+23 | |
| | | | | | | | | | security guide | |||||
| * | | Add documentation for new observer enable/disable feature. | Myron Marston | 2011-05-06 | 2 | -3/+51 | |
| | | | ||||||
| * | | Prepare for beta1 | David Heinemeier Hansson | 2011-05-04 | 1 | -1/+1 | |
| |/ | ||||||
| * | Improved ActiveModel Observing docs. | Sebastian Martinez | 2011-04-30 | 1 | -2/+4 | |
| | | ||||||
| * | Merge branch 'master' of github.com:lifo/docrails | Dan Pickett | 2011-04-29 | 3 | -4/+4 | |
| |\ | ||||||
| | * | Rephrased Dirty#changed? docs | Sebastian Martinez | 2011-04-26 | 1 | -1/+1 | |
| | | | ||||||
| | * | Removed extra whitespace | Sebastian Martinez | 2011-04-26 | 1 | -1/+1 | |
| | | | ||||||
| | * | Better formatting on ActiveModel::Translation | Sebastian Martinez | 2011-04-26 | 1 | -2/+2 | |
| | | | ||||||
| * | | fix typo | Aditya Sanghi | 2011-04-29 | 1 | -1/+1 | |
| | | | ||||||
| * | | :if should not fire on validations when not in context with :on | Aditya Sanghi | 2011-04-29 | 2 | -3/+3 | |
| | | | ||||||
| * | | Fix bug with AM::Observer disablement. | Myron Marston | 2011-04-28 | 2 | -25/+17 | |
| | | | | | | | | | | | Now that we propagate the enabling/disabling to descendants, we no longer have to check the disabled_observer Set on each superclass of the model class. This was causing a bug when disabling all observers at a superclass level and then enabling an individual observer at a subclass level. Plus the logic is simpler now :). | |||||
| * | | Fix dev env memory leaks by using AS::DescendantsTracker rather than keeping ↵ | Myron Marston | 2011-04-28 | 2 | -36/+12 | |
| | | | | | | | | | | | track of subclasses manually. There's also no need to keep track of all ObserverArray instances in a hash, as this is likely to leak memory, too. | |||||
| * | | Revert "Revert "Handle enabling/disabling observers at different levels of ↵ | Myron Marston | 2011-04-28 | 2 | -3/+36 | |
| | | | | | | | | | | | | | | | | | | | the class hierarchy."" This reverts commit 2a25c5818b03d7d6cd63aad180bff23479dbd861. I'm going to add another commit that keeps the same behavior of fixes the problems of leaking memory in development. | |||||
| * | | Revert "Handle enabling/disabling observers at different levels of the class ↵ | José Valim | 2011-04-28 | 2 | -36/+3 | |
| | | | | | | | | | | | | | | | | | | | | | hierarchy." This reverts commit ad62f1928768bd2676958a4a08512bad342fe469 because the current subclasses implementation leaks memory in development. Instead of keeping an array of subclasses, the better solution is to ask the parent if an observer is being disabled or not. | |||||
| * | | Handle enabling/disabling observers at different levels of the class hierarchy. | Myron Marston | 2011-04-28 | 2 | -3/+36 | |
| | | | | | | | | | Last call wins. | |||||
| * | | Allow observers to be enabled and disabled. | Myron Marston | 2011-04-28 | 2 | -3/+122 | |
| | | | | | | | | | This is useful in situations like model unit tests and the occasional rake task to backfill old data. | |||||
| * | | Wrap line that is over 200 characters long. Now it's much easier to read. | Myron Marston | 2011-04-28 | 1 | -1/+5 | |
| | | | ||||||
| * | | minor correction to the AMo mass-assignment security docs | Josh Kalderimis | 2011-04-24 | 1 | -1/+1 | |
| | | | ||||||
| * | | AM mass assignment security attr_accessible and attr_protected now allow for ↵ | Josh Kalderimis | 2011-04-24 | 1 | -34/+85 | |
| |/ | | | | | | | | scopes using :as => scope eg. attr_accessible :name attr_accessible :name, :admin, :as => :admin | |||||
| * | minor correction to the Active Model instantiate_observers doc | Josh Kalderimis | 2011-04-22 | 1 | -1/+1 | |
| | | ||||||
| * | let this regexp be stricter | Xavier Noria | 2011-04-19 | 1 | -1/+1 | |
| | | | | | | | | | | The purpose of this regexp is to detect strings that are valid identifiers to be used as method names. The anchor $ allows a trailing newline, and both ^ and $ may be bypassed because Ruby regexps are multiline always. The anchors \A and \z are the proper ones to ensure string boundaries. | |||||
| * | Let's not dup because value may not always be duplicable. | José Valim | 2011-04-19 | 1 | -1/+1 | |
| | | ||||||
| * | Avoid define_method if possible. | José Valim | 2011-04-19 | 1 | -12/+39 | |
| | | ||||||
| * | bcrypt will encrypt anything, so validate_presence_of would not catch nil / ↵ | Aaron Patterson | 2011-04-14 | 1 | -1/+3 | |
| | | | | | blank passwords. Thank you to Aleksander Kamil Modzelewski for reporting this | |||||
| * | Declaring the attr_accessor for password_confirmation is not necessary | Brian Cardarella | 2011-04-14 | 1 | -2/+1 | |
| | | | | | as the confirmation validation already adds that attr_accessor | |||||
| * | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -1/+1 | |
| | | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | |||||
| * | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-04-12 | 1 | -1/+1 | |
| |\ | ||||||
| | * | Rewording | Oge Nnadi | 2011-04-11 | 1 | -1/+1 | |
| | | | ||||||
| * | | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -1/+1 | |
| | | | | | | | | | suggestion! | |||||
| * | | Remove code duplication. | José Valim | 2011-04-11 | 3 | -20/+27 | |
| | | | ||||||
| * | | No need to rescue here. Invoking the wrong method in an object can happen ↵ | José Valim | 2011-04-11 | 3 | -6/+0 | |
| | | | | | | | | | anywhere if you are not careful. In other words, test your shit. | |||||
| * | | Revert "Add :use_include option to allow user to explicitly use ↵ | José Valim | 2011-04-11 | 2 | -18/+14 | |
| | | | | | | | | | | | | | | | | | `Range#include?` method in Ruby 1.9" Use :with => range.to_a instead. This reverts commit f6540211b5b9133c9f93c11655a04d613c237e67. | |||||
| * | | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -1/+2 | |
| | | | | | | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | |||||
| * | | Add :use_include option to allow user to explicitly use `Range#include?` ↵ | Prem Sichanugrist | 2011-04-10 | 2 | -14/+18 | |
| | | | | | | | | | | | | | method in Ruby 1.9 In Ruby 1.9 we're currently use `Range#cover?` to fix the performance problem. However, there might be the case that you want to use `Range#include?` instead. This patch will give you that option. | |||||
| * | | Add support for proc or lambda as an option for InclusionValidator, ↵ | Prem Sichanugrist | 2011-04-10 | 3 | -20/+76 | |
| |/ | | | | | | ExclusionValidator, and FormatValidator You can now use a proc or lambda in :in option for InclusionValidator and ExclusionValidator, and :with, :without option for FormatValidator | |||||
| * | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-04-03 | 1 | -11/+10 | |
| |\ | ||||||
| | * | Fix formatting and broken markup | John Firebaugh | 2011-03-28 | 1 | -11/+10 | |
| | | | ||||||
| * | | Bring back AMo#i18n_key method | Santiago Pastorino | 2011-03-30 | 3 | -8/+13 | |
| |/ | ||||||
| * | use class_eval with a string when it's possible | Santiago Pastorino | 2011-03-22 | 1 | -2/+8 | |
| | | ||||||
| * | Do not in place modify what table_name returns | Santiago Pastorino | 2011-03-22 | 1 | -1/+1 | |
| | | ||||||
| * | define_attr_method should be able to define methods that returns nil | Santiago Pastorino | 2011-03-17 | 1 | -2/+2 | |
| | | ||||||
| * | remove misleading comment | Aaron Patterson | 2011-03-17 | 1 | -2/+0 | |
| | | ||||||
| * | dup strings on return so that in place modifications do not break anything. ↵ | Aaron Patterson | 2011-03-17 | 1 | -1/+1 | |
| | | | | | I am looking at you "compute_table_name" | |||||
| * | define_attr_method correctly defines methods with invalid identifiers | Santiago Pastorino | 2011-03-16 | 1 | -3/+2 | |
| | | ||||||
| * | Fix typo in assertion message | Andrew White | 2011-03-16 | 1 | -1/+1 | |
| | | ||||||
| * | Add messages to plain assertions. | Norman Clarke | 2011-03-15 | 1 | -2/+2 | |
| | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
| * | Refactor length validation | Santiago Pastorino | 2011-03-12 | 1 | -3/+3 | |
| | | ||||||
| * | length validation for fixnums | Andriy Tyurnikov | 2011-03-12 | 1 | -1/+2 | |
| | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
| * | Add additional text to NotImplementedErrors [#6328 state:resolved] | Mike Gehard | 2011-03-12 | 1 | -2/+2 | |
| | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
| * | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-03-07 | 5 | -25/+18 | |
| |\ | ||||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |