Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Change the deprecation messages to show the preferred way to work with | Rafael Mendonça França | 2015-02-20 | 1 | -1/+1 |
| | | | | ActiveModel::Errors | ||||
* | use `messages` instead of deprecated `ActiveModel::Errors#[]=` method [ci skip] | yuuji.yaginuma | 2015-02-20 | 1 | -1/+1 |
| | |||||
* | Fix validations on child record when record parent has validate: false | eileencodes | 2015-02-01 | 1 | -0/+4 |
| | | | | | | | | | | | | | | Fixes #17621. This 5 year old (or older) issue causes validations to fire when a parent record has `validate: false` option and a child record is saved. It's not the responsibility of the model to validate an associated object unless the object was created or modified by the parent. Clean up tests related to validations `assert_nothing_raised` is not benefiting us in these tests Corrected spelling of "respects" It's better to use `assert_not_operator` over `assert !r.valid` | ||||
* | Use Active Model, not ActiveModel in plain English | claudiob | 2015-01-02 | 1 | -1/+1 |
| | | | | | | | Also prevents the word "Model" from linking to the documentation of ActiveModel::Model because that's not intended. [ci skip] | ||||
* | Fix example code of `EachValidator` [ci skip] | Chun-wei Kuo | 2014-07-28 | 1 | -1/+1 |
| | | | | | We have to specify the `:title` option to really use the `TitleValidator` defined above. | ||||
* | remove depricated Validatior#setup | Kuldeep Aggarwal | 2014-06-10 | 1 | -16/+0 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-12-20 | 1 | -1/+1 |
|\ | |||||
| * | Typos. return -> returns. [ci skip] | Lauro Caetano | 2013-12-03 | 1 | -1/+1 |
| | | |||||
* | | Fix typo [ci skip] | Rafael Mendonça França | 2013-12-13 | 1 | -1/+1 |
| | | |||||
* | | typos rectified lifecycle => life cycle | Aayush khandelwal | 2013-12-12 | 1 | -1/+1 |
|/ | |||||
* | deprecate Validator#setup (to get rid of a respond_to call). validators do ↵ | Nick Sutterer | 2013-05-23 | 1 | -9/+23 |
| | | | | their setup in their constructor now. | ||||
* | Clarify ActiveModel::Validator initialization in docs. | Henrik Nyh | 2013-02-09 | 1 | -0/+3 |
| | | | As discussed with @josevalim on Ruby Rogues Parley. | ||||
* | Set default value to ActiveModel::Validator initializer attribute | Irio Irineu Musskopf Junior | 2013-01-09 | 1 | -1/+1 |
| | | | | Makes it easier to test its objects. | ||||
* | Remove ActiveModel::Errors#add_on_present method. | Rafael Mendonça França | 2012-12-21 | 1 | -1/+1 |
| | | | | | | | | We don't need to define a new method in ActiveMode::Errors for each validatior. See https://github.com/rails/rails/commit/d72a07f1d1478db9daed847eadb35bfd840674f6#commitcomment-2325333 | ||||
* | Replace comments' non-breaking spaces with spaces | claudiob | 2012-12-04 | 1 | -2/+2 |
| | | | | | | | | | | Sometimes, on Mac OS X, programmers accidentally press Option+Space rather than just Space and don’t see the difference. The problem is that Option+Space writes a non-breaking space (0XA0) rather than a normal space (0x20). This commit removes all the non-breaking spaces inadvertently introduced in the comments of the code. | ||||
* | Raise ArgumentError when no attribute is given to AMo::EachValidator | Carlos Antonio da Silva | 2012-11-04 | 1 | -1/+1 |
| | | | | ArgumentError is better suited than RuntimeError for this. | ||||
* | convert comments to 1.9 hash syntax | AvnerCohen | 2012-10-22 | 1 | -1/+1 |
| | |||||
* | minor edits in AM documentation [ci skip] | Francesco Rodriguez | 2012-10-21 | 1 | -1/+1 |
| | |||||
* | removes usage of Object#in? from the code base (the method remains defined ↵ | Xavier Noria | 2012-08-06 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case. | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-08-04 | 1 | -11/+11 |
|\ | | | | | | | | | | | Conflicts: activemodel/lib/active_model/secure_password.rb activerecord/lib/active_record/associations/collection_proxy.rb | ||||
| * | update ActiveModel::Validations docs [ci skip] | Francesco Rodriguez | 2012-07-29 | 1 | -1/+1 |
| | | |||||
| * | update ActiveModel::Validator docs [ci skip] | Francesco Rodriguez | 2012-07-29 | 1 | -10/+10 |
| | | |||||
* | | load active_support/core_ext/object/inclusion in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| | | |||||
* | | load active_support/core_ext/object/blank in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
|/ | |||||
* | add :nodoc: to internal implementations of AM::Validator [ci skip] | Francesco Rodriguez | 2012-07-06 | 1 | -2/+2 |
| | |||||
* | Remove Array.wrap call in ActiveModel | Rafael Mendonça França | 2012-01-06 | 1 | -2/+1 |
| | |||||
* | correct documentation on initialize method to accept a single parameter | bradrobertson | 2011-10-26 | 1 | -1/+1 |
| | |||||
* | Use .add instead of << to add errors | Evgeniy Dolzhenko | 2011-10-11 | 1 | -3/+3 |
| | |||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -1/+1 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -1/+1 |
| | | | | suggestion! | ||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -1/+2 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | Add additional text to NotImplementedErrors [#6328 state:resolved] | Mike Gehard | 2011-03-12 | 1 | -2/+2 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | formatting changes | Vijay Dev | 2011-03-07 | 1 | -12/+11 |
| | |||||
* | Remove Example headers. Code just flows with the text. 6ce844a3 | Paco Guzman | 2011-03-06 | 1 | -3/+1 |
| | |||||
* | Tiny fixes to rdoc | Alexey Mahotkin | 2010-09-16 | 1 | -2/+2 |
| | |||||
* | Revert "Setup explicit requires for files with exceptions. Removed them from ↵ | José Valim | 2010-09-02 | 1 | -1/+0 |
| | | | | | | | | autoloading." Booting a new Rails application does not work after this commit [#5359 state:open] This reverts commit 38a421b34d0b414564e919f67d339fac067a56e6. | ||||
* | Setup explicit requires for files with exceptions. Removed them from ↵ | Łukasz Strzałkowski | 2010-09-02 | 1 | -0/+1 |
| | | | | | | autoloading. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -11/+11 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Freeze options so we raise an error when people modify it in place. | José Valim | 2010-08-03 | 1 | -1/+1 |
| | |||||
* | edit pass to apply API guideline wrt the use of "# =>" in example code | Xavier Noria | 2010-07-30 | 1 | -2/+2 |
| | |||||
* | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-15 | 1 | -2/+2 |
|\ | |||||
| * | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-11 | 1 | -2/+2 |
| | | |||||
* | | edit pass: the names of Rails components have a space, ie, "Active Record", ↵ | Xavier Noria | 2010-06-14 | 1 | -1/+1 |
| | | | | | | | | not "ActiveRecord" | ||||
* | | Revised the rest of the files from ActiveModel. | Rizwan Reza | 2010-06-14 | 1 | -0/+3 |
|/ | |||||
* | minor changes to instance level validations implementation based on feedback ↵ | Josh Kalderimis | 2010-05-13 | 1 | -0/+3 |
| | | | | from José Valim | ||||
* | adds missing requires for Object#blank? and Object#present? | Xavier Noria | 2010-03-28 | 1 | -0/+1 |
| | |||||
* | Use Array.wrap uniformly | Jeremy Kemper | 2010-03-27 | 1 | -1/+2 |
| | |||||
* | Add validators reflection so you can do 'Person.validators' and ↵ | Prem Sichanugrist | 2010-02-21 | 1 | -0/+18 |
| | | | | | | 'Person.validators_on(:name)'. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Full update on ActiveModel documentation | Mikel Lindsaar | 2010-02-01 | 1 | -2/+3 |
| | |||||
* | Add validates method as shortcut to setup validators for a given set of ↵ | jamie | 2010-01-07 | 1 | -9/+58 |
| | | | | | | | | | | | | | | | attributes: class Person < ActiveRecord::Base include MyValidators validates :name, :presence => true, :uniqueness => true, :length => { :maximum => 100 } validates :email, :presence => true, :email => true end [#3058 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> |