Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove code duplication. | José Valim | 2011-04-11 | 3 | -20/+27 |
| | |||||
* | No need to rescue here. Invoking the wrong method in an object can happen ↵ | José Valim | 2011-04-11 | 3 | -6/+0 |
| | | | | anywhere if you are not careful. In other words, test your shit. | ||||
* | Revert "Add :use_include option to allow user to explicitly use ↵ | José Valim | 2011-04-11 | 2 | -18/+14 |
| | | | | | | | | `Range#include?` method in Ruby 1.9" Use :with => range.to_a instead. This reverts commit f6540211b5b9133c9f93c11655a04d613c237e67. | ||||
* | Add :use_include option to allow user to explicitly use `Range#include?` ↵ | Prem Sichanugrist | 2011-04-10 | 2 | -14/+18 |
| | | | | | | method in Ruby 1.9 In Ruby 1.9 we're currently use `Range#cover?` to fix the performance problem. However, there might be the case that you want to use `Range#include?` instead. This patch will give you that option. | ||||
* | Add support for proc or lambda as an option for InclusionValidator, ↵ | Prem Sichanugrist | 2011-04-10 | 3 | -20/+76 |
| | | | | | | ExclusionValidator, and FormatValidator You can now use a proc or lambda in :in option for InclusionValidator and ExclusionValidator, and :with, :without option for FormatValidator | ||||
* | Refactor length validation | Santiago Pastorino | 2011-03-12 | 1 | -3/+3 |
| | |||||
* | length validation for fixnums | Andriy Tyurnikov | 2011-03-12 | 1 | -1/+2 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Configuration options are symbols | Paco Guzman | 2011-03-06 | 1 | -2/+2 |
| | |||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-02-21 | 8 | -10/+24 |
|\ | |||||
| * | copy-edits 8d96b89 | Xavier Noria | 2011-02-21 | 8 | -9/+24 |
| | | |||||
| * | Clarification of ActiveRecord ActiveModel validation documentation | Peer Allan | 2011-02-18 | 6 | -7/+6 |
| | | |||||
* | | documents the backported Range#cover?, and related stuff | Xavier Noria | 2011-02-20 | 1 | -3/+5 |
| | | |||||
* | | refactored ActiveModel::Validations::InclusionValidator#validate_each | Diego Carrion | 2011-02-19 | 1 | -18/+8 |
|/ | | | | | | [#6455 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Change validates inclusion to use cover? for Ranges in ruby 1.9 [#6453 ↵ | Frederick Cheung | 2011-02-18 | 1 | -3/+20 |
| | | | | | | state:committed] Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | Optionally pass in the attribute being validated to an instance method validator | Carl Lerche | 2011-02-05 | 1 | -1/+7 |
| | |||||
* | Be able to pass a validator method to #validates | Carl Lerche | 2011-02-05 | 1 | -0/+6 |
| | |||||
* | Provide a way to specify alternate option keys for validates | Carl Lerche | 2011-02-05 | 1 | -1/+7 |
| | |||||
* | Do not require that validation attributes be specified as symbols | Carl Lerche | 2011-02-05 | 1 | -2/+1 |
| | |||||
* | Use run_callbacks; the generated _run_<name>_callbacks method is not a ↵ | John Firebaugh | 2011-01-31 | 1 | -1/+1 |
| | | | | | | public interface. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Add support for namespaced validators | Samuel Kadolph | 2010-12-16 | 1 | -1/+7 |
| | | | | | | Includes test and documentation for new feature Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Don't compute this string again | Santiago Pastorino | 2010-12-02 | 1 | -1/+1 |
| | |||||
* | Don't redefine existing attributes accessors. | Emilio Tagua | 2010-09-27 | 1 | -1/+3 |
| | |||||
* | Better shortcut options for custom validators [#5672 state:resolved] | Obie Fernandez | 2010-09-24 | 1 | -5/+10 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | remove irrelevant comments | Neeraj Singh | 2010-09-18 | 1 | -2/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Refactoring conditional logic | Subba Rao Pasupuleti | 2010-09-01 | 1 | -3/+3 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | type fixed | Santiago Pastorino | 2010-08-22 | 1 | -1/+1 |
| | |||||
* | after_validation should be called irrespective of the result of validation. | Neeraj Singh | 2010-08-20 | 1 | -1/+1 |
| | | | | | | | | I confirmed that this is the behavior on 2.3.x . [5419 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | you rarely want ^ or $ in validations, use \A when you mean \A | Xavier Noria | 2010-08-18 | 1 | -2/+2 |
| | |||||
* | Missing object for comparison in ActiveModel::EachValidator example code. | Trey Bean | 2010-08-17 | 1 | -1/+1 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 4 | -27/+27 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | tidy up validations length code [#5297 state:resolved] | Subba Rao Pasupuleti | 2010-08-14 | 1 | -6/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | fixes a typo reported by rymai | Xavier Noria | 2010-08-10 | 1 | -1/+1 |
| | |||||
* | validates_length_of should not change the options hash in place. [#5283 ↵ | José Valim | 2010-08-03 | 1 | -4/+7 |
| | | | | state:resolved] | ||||
* | Refactor previous commit a bit [#4057 state:resolved] | José Valim | 2010-06-21 | 6 | -12/+9 |
| | |||||
* | Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵ | Jeroen van Dijk | 2010-06-21 | 8 | -19/+30 |
| | | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now. The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-20 | 1 | -0/+57 |
|\ | | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb | ||||
| * | ActiveModel::Validations::Callbacks should not be required by default. | José Valim | 2010-06-19 | 1 | -12/+5 |
| | | |||||
| * | moving before_validation and after_validation functionality from ↵ | Neeraj Singh | 2010-06-19 | 1 | -0/+64 |
| | | | | | | | | | | | | | | | | ActiveRecord to ActiveModel [#4653 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Add titles to the rest of the files in active_model/validations/* | Rizwan Reza | 2010-06-15 | 8 | -0/+16 |
| | | |||||
* | | Minor doc changes to active_model/validations/confirmation.rb | Rizwan Reza | 2010-06-15 | 1 | -13/+27 |
| | | |||||
* | | Minor doc changes to active_model/validations/acceptance.rb | Rizwan Reza | 2010-06-15 | 1 | -15/+30 |
| | | |||||
* | | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-11 | 1 | -1/+1 |
|/ | |||||
* | Fixed numericality validator in ActiveModel to reject hex numbers for floats ↵ | rohit | 2010-05-18 | 1 | -1/+1 |
| | | | | | | completely [#4622 state:commited] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Valid hex strings aren't valid float column values, to match the integer ↵ | Jeremy Kemper | 2010-05-17 | 1 | -3/+8 |
| | | | | restriction. [#4622 state:resolved] | ||||
* | Revert "Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an ↵ | José Valim | 2010-05-15 | 8 | -13/+13 |
| | | | | | | | | options hash and make various Validators pass their (filtered) options." Having a huge array to whitelist options is not the proper way to handle this case. This means that the ActiveModel::Errors object should know about the options given in *all* validators and break the extensibility added by the validators itself. If the intent is to whitelist options before sending them to I18n, each validator should clean its respective options instead of throwing the responsibility to the Errors object. This reverts commit bc1c8d58ec45593acba614d1d0fecb49adef08ff. | ||||
* | Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵ | Jeroen van Dijk | 2010-05-15 | 8 | -13/+13 |
| | | | | | | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Original patch by Sven Fuchs, some minor changes and has been changed to be applicable to master again [#4057 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | minor changes to instance level validations implementation based on feedback ↵ | Josh Kalderimis | 2010-05-13 | 2 | -37/+12 |
| | | | | from José Valim | ||||
* | validation macros can now be used within an instance | Josh Kalderimis | 2010-05-13 | 10 | -8/+86 |
| | |||||
* | Favor %{} in all code instead of (deprecated) {{}} as interpolation syntax ↵ | Lawrence Pit | 2010-05-03 | 3 | -5/+5 |
| | | | | | | for I18n Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Makes validates_acceptance_of to not override database fields [#4460 ↵ | Santiago Pastorino | 2010-04-28 | 1 | -2/+4 |
| | | | | | | state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> |