aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel/lib/active_model/lint.rb
Commit message (Collapse)AuthorAgeFilesLines
* Use respond_to test helpersDaniel Colson2018-01-251-12/+12
|
* Use frozen string literal in activemodel/Kir Shatrov2017-07-161-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* applies remaining conventions across the projectXavier Noria2016-08-061-1/+0
|
* Better docs for AM::Lint::Testsclaudiob2015-01-071-28/+32
| | | | | | | | | | | | | | | This commit changes the original documentation of ActiveModel::Lint::Tests introduced in dbf20c2d to focus less on *why* the tests exist and more on *what* the tests do. For instance, `test_to_key` was documented as: > Returns an Enumerable of all (primary) key attributes... whereas `test_to_key` is simply a test meant to *fail* or *pass*, and the documentation above refers to `to_key`. [ci skip]
* Use #model_name on instances instead of classesAmiel Martin2014-06-241-4/+7
| | | | | | This allows rails code to be more confdent when asking for a model name, instead of having to ask for the class. Rails core discussion here: https://groups.google.com/forum/#!topic/rubyonrails-core/ThSaXw9y1F8
* Fix few typos and improve markup at some levelsRobin Dupret2013-12-241-1/+1
|
* respond_to -> respond to in a message from AM::LintXavier Noria2013-05-121-1/+1
| | | | | | | | The error message uses English to say that the object should respond to a certain method. You check that with respond_to, but that's not English. This makes this error message also consistent with the rest.
* minor edits in AM documentation [ci skip]Francesco Rodriguez2012-10-211-4/+4
|
* update ActiveModel::Lint documentation [ci skip]Francesco Rodriguez2012-06-221-22/+23
|
* Allow ActiveModel::Name to duck typePiotr Sarnacki2012-03-281-4/+4
|
* ActiveModel::Name does not inherit from stringLukasz Sarnacki2012-03-261-1/+1
|
* Add config.default_method_for_update to support PATCHDavid Lee2012-02-221-3/+3
| | | | | | | | | | | | | | | | PATCH is the correct HTML verb to map to the #update action. The semantics for PATCH allows for partial updates, whereas PUT requires a complete replacement. Changes: * adds config.default_method_for_update you can set to :patch * optionally use PATCH instead of PUT in resource routes and forms * adds the #patch verb to routes to detect PATCH requests * adds #patch? to Request * changes documentation and comments to indicate support for PATCH This change maintains complete backwards compatibility by keeping :put as the default for config.default_method_for_update.
* Trim down Active Model API by removing valid? and errors.full_messagesJosé Valim2012-02-071-27/+13
|
* Rename new method to_path to to_partial_path to avoid conflicts with ↵José Valim2011-08-011-4/+4
| | | | File#to_path and similar.
* Let ActiveModel instances define partial paths.Grant Hutchins & Peter Jaros2011-07-251-3/+12
| | | | | | Deprecate ActiveModel::Name#partial_path. Now you should call #to_path directly on ActiveModel instances.
* Fix typo in assertion messageAndrew White2011-03-161-1/+1
|
* Add messages to plain assertions.Norman Clarke2011-03-151-2/+2
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Move ActiveModel::Lint::Tests documentation to be above module declaration ↵Ryan Bigg2010-12-091-14/+14
| | | | so it appears in the API docs for this module.
* to_key should return all exists keys (if any exists), regardless if the ↵José Valim2010-08-151-0/+1
| | | | object is persisted or not. If you need it to reflect persistance, you should use to_param.
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-141-1/+1
| | | | 's/[ \t]*$//' -i {} \;)
* Active Model lint - fix minor typosBryan Woods2010-06-151-2/+2
|
* edit pass: the names of Rails components have a space, ie, "Active Record", ↵Xavier Noria2010-06-141-1/+1
| | | | not "ActiveRecord"
* Revised naming.rb and lint.rbRizwan Reza2010-06-141-1/+1
|
* Added headings and revised active_model.rb/lint.rb grammaticallyRizwan Reza2010-06-141-1/+3
|
* ActiveModel::Lint should not require our models to respond to id.José Valim2010-02-281-2/+0
|
* Require persisted? in ActiveModel::Lint and remove new_record? and ↵José Valim2010-02-211-15/+10
| | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not.
* AMo #key is now #to_key and CI is probably happysnusnu2010-02-201-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Obviously #key is a too common name to be included in the AMo interface, #to_key fits better and also relates nicely to #to_param. Thx wycats, koz and josevalim for the suggestion. AR's #to_key implementation now takes customized primary keys into account and there's a testcase for that too. The #to_param AMo lint makes no assumptions on how the method behaves in the presence of composite primary keys. It leaves the decision wether to provide a default, or to raise and thus signal to the user that implementing this method will need his special attention, up to the implementers. All AMo cares about is that #to_param is implemented and returns nil in case of a new_record?. The default CompliantObject used in lint_test provides a naive default implementation that just joins all key attributes with '-'. The #to_key default implementation in lint_test's CompliantObject now returns [id] instead of [1]. This was previously causing the (wrong) tests I added for AR's #to_key implementation to pass. The #to_key tests added with this patch should be better. The CI failure was caused by my lack of knowledge about the test:isolated task. The tests for the record_identifier code in action_controller are using fake non AR models and I forgot to stub the #to_key method over there. This issue didn't come up when running the test task, only test:isolated revealed it. This patch fixes that. All tests pass isolated or not, well, apart from one previously unpended test in action_controller that is unrelated to my patch.
* Adds #key and #to_param to the AMo interfacesnusnu2010-02-191-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit introduces two new methods that every AMo compliant object must implement. Below are the default implementations along with the implied interface contract. # Returns an Enumerable of all (primary) key # attributes or nil if new_record? is true def key new_record? ? nil : [1] end # Returns a string representing the object's key # suitable for use in URLs, or nil if new_record? # is true def to_param key ? key.first.to_s : nil end 1) The #key method Previously rails' record_identifier code, which is used in the #dom_id helper, relied on calling #id on the record to provide a reasonable DOM id. Now with rails3 being all ORM agnostic, it's not safe anymore to assume that every record ever will have an #id as its primary key attribute. Having a #key method available on every AMo object means that #dom_id can be implemented using record.to_model.key # instead of record.id Using this we're able to take composite primary keys into account (e.g. available in datamapper) by implementing #dom_id using a newly added record_key_for_dom_id(record) method. The user can overwrite this method to provide customized versions of the object's key used in #dom_id. Also, dealing with more complex keys that can contain arbitrary strings, means that we need to make sure that we only provide DOM ids that are valid according to the spec. For this reason, this patch sends the key provided through a newly added sanitize_dom_id(candidate_id) method, that makes sure we only produce valid HTML The reason to not just add #dom_id to the AMo interface was that it feels like providing a DOM id should not be a model concern. Adding #dom_id to the AMo interface would force these concern on the model, while it's better left to be implemented in a helper. Now one could say the same is true for #to_param, and actually I think that it doesn't really fit into the model either, but it's used in AR and it's a main part of integrating into the rails router. This is different from #dom_id which is only used in view helpers and can be implemented on top of a semantically more meaningful method like #key. 2) The #to_param method Since the rails router relies on #to_param to be present, AR::Base implements it and returns the id by default, allowing the user to overwrite the method if desired. Now with different ORMs integrating into rails, every ORM railtie needs to implement it's own #to_param implementation while already providing code to be AMo compliant. Since the whole point of AMo compliance seems to be to integrate any ORM seamlessly into rails, it seems fair that all we really need to do as another ORM, is to be AMo compliant. By including #to_param into the official interface, we can make sure that this code can be centralized in the various AMo compliance layers, and not be added separately by every ORM railtie. 3) All specs pass
* Full update on ActiveModel documentationMikel Lindsaar2010-02-011-10/+6
|
* Stop overriding LoadError.new to return a MissingSourceError (and sometimes ↵Yehuda Katz2010-01-191-0/+2
| | | | nil!)
* Add naming to AMo::LintJosé Valim2010-01-021-0/+14
|
* Rewrite ActiveModel::Lint as a simple TU mixinJoshua Peek2009-10-071-48/+30
|
* Use ActiveModel::TestCase base classJeremy Kemper2009-09-241-3/+3
|
* fixed ActiveModel::Lint typos [#3236 state:resolved]lakshan2009-09-211-4/+3
| | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Initial AMo Lint implementationYehuda Katz2009-08-291-0/+96
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-29 23:02:53 +0000