Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | add brackets around attribute_name | _tiii | 2014-12-08 | 1 | -1/+1 |
| | | | | | | since 'attr_name_will_change!' is not an actual method it should be clearer that you have to insert the attribute name as in line 104 [ci skip] | ||||
* | [Enh] Changed the visibility of the ↵ | Daniele Di Bernardo | 2014-11-06 | 1 | -1/+1 |
| | | | | | | | | | ActiveModel::Dirty#clear_attribute_changes method In Rails 4.2 it is impossible to define a custom default value for a model's attribute without making it appear as _changed?, especially when the model is first initialized. Making this method publicly visible will allow such a behaviour, without the need to use private APIs. | ||||
* | edit pass over all warnings | Xavier Noria | 2014-10-28 | 1 | -2/+10 |
| | | | | | | | | | | | | | | | This patch uniformizes warning messages. I used the most common style already present in the code base: * Capitalize the first word. * End the message with a full stop. * "Rails 5" instead of "Rails 5.0". * Backticks for method names and inline code. Also, converted a few long strings into the new heredoc convention. | ||||
* | Don't expose these new APIs yet (added in 877ea78 / #16189) | Godfrey Chan | 2014-08-16 | 1 | -14/+15 |
| | | | | | | | WARNING: don't use them! They might change or go away between future beta/RC/ patch releases! Also added a CHANGELOG entry for this. | ||||
* | Implement `_was` and `changes` for in-place mutations of AR attributes | Sean Griffin | 2014-08-16 | 1 | -3/+16 |
| | |||||
* | Make restore_attributes public | Rafael Mendonça França | 2014-07-17 | 1 | -5/+5 |
| | | | | | | | Also make it accept a list of attributes to be changed. This will make possible to restore only a subset of the changed attributes. Closes #16203 | ||||
* | Deprecate `reset_#{attribute}` in favor of `restore_#{attribute}`. | Rafael Mendonça França | 2014-07-15 | 1 | -4/+12 |
| | | | | | | | | | These methods may cause confusion with the `reset_changes` that behaves differently of them. Also rename undo_changes to restore_changes to match this new set of methods. | ||||
* | Deprecate ActiveModel::Dirty#reset_changes in favor of ↵ | Rafael Mendonça França | 2014-07-15 | 1 | -4/+12 |
| | | | | | | | | | #clear_changes_information This method name is causing confusion with the `reset_#{attribute}` methods. While `reset_name` set the value of the name attribute for the previous value the `reset_changes` only discard the changes and previous changes. | ||||
* | Rename rollback_changes to undo_changes | Rafael Mendonça França | 2014-06-30 | 1 | -3/+3 |
| | | | | To avoid overload with database rollback | ||||
* | Add CHANGELOG entry for #14861 and document private methods on the API | Rafael Mendonça França | 2014-06-30 | 1 | -5/+5 |
| | |||||
* | Merge pull request #14861 from igor04/dirty-rollback | Rafael Mendonça França | 2014-06-30 | 1 | -0/+17 |
|\ | | | | | | | Added rollback method to ActiveModel::Dirty | ||||
| * | Added rollback method to ActiveModel::Dirty | igor04 | 2014-06-23 | 1 | -0/+17 |
| | | |||||
* | | We are talking about the libraries, not the constants | Sean Griffin | 2014-06-27 | 1 | -3/+3 |
| | | |||||
* | | Note that `_will_change!` is no longer needed for AR instances | Sean Griffin | 2014-06-27 | 1 | -3/+5 |
|/ | | | | | | | Leave the note for `ActiveModel`, since it can't yet detect mutations (hopefully we can change this in time for 4.2). However, we now detect mutations on all supported types in `ActiveRecord`, so we can note that `_will_change!` is no longer needed there. | ||||
* | Forgot to push this change in the parent commit | Rafael Mendonça França | 2014-01-20 | 1 | -1/+1 |
| | |||||
* | When applying changes or reseting changes create the right class | Rafael Mendonça França | 2014-01-20 | 1 | -3/+3 |
| | | | | | | | Before this patch after the changes are applied the changes can be only accessed using string keys, but before symbols are also accepted. After this change every state of the model will be consistent. | ||||
* | Allows you to check if an attribute has changed to a particular value | Tejas Dinkar | 2013-12-15 | 1 | -2/+6 |
| | | | | model.name_changed?(from: "Pete", to: "Ringo") | ||||
* | Added :nodoc: for `attribute_changed?` and `attribute_was` [ci skip] | Godfrey Chan | 2013-12-12 | 1 | -2/+2 |
| | | | | | | These methods were made "public" in 47617ecd so that `method_missing` can invoke them without going through `send`, but they aren't meant for consumption from outside of Rails. | ||||
* | Merge pull request #8791 from griffinmyers/master | Rafael Mendonça França | 2013-10-03 | 1 | -1/+1 |
|\ | | | | | | | | | | | | | Updated DirtyModel's @changed_attributes hash to be symbol/string agnostic Conflicts: activemodel/CHANGELOG.md | ||||
| * | DirtyModel uses a hash to keep track of any changes made to attributes | William Myers | 2013-05-27 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | of an instance. When using the attribute_will_change! method, you must supply a string and not a symbol or the *_changed? method will break (because it is looking for the attribute name as a string in the keys of the underlying hash). To remedy this, I simply made the underlying hash a HashWithIndifferentAccess so it won't matter if you supply the attribute name as a symbol or string to attribute_will_change!. | ||||
* | | Fix the documentation method. | Rafael Mendonça França | 2013-09-23 | 1 | -1/+1 |
| | | | | | | | | | | | | It is reload! in the class definition. [ci skip] | ||||
* | | Document reset_changes since it is part of public API | Rafael Mendonça França | 2013-09-23 | 1 | -0/+12 |
| | | | | | | | | [ci skip] | ||||
* | | Merge pull request #10816 from bogdan/less-dirty-dirty | Rafael Mendonça França | 2013-09-23 | 1 | -10/+16 |
| | | | | | | | | Make AM::Dirty less dirty to plugin into AR or other library | ||||
* | | expose a few attribute changed methods | Aaron Patterson | 2013-06-11 | 1 | -10/+10 |
| | | |||||
* | | Convert ActiveModel to 1.9 hash syntax. | Patrick Robertson | 2013-05-01 | 1 | -1/+1 |
| | | | | | | | | | | I also attempted to fix other styleguide violations such as { a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ). | ||||
* | | Prefer find_by over dynamic finders in rdoc | Sam Ruby | 2013-04-02 | 1 | -1/+1 |
| | | |||||
* | | Revert "Merge pull request #8989 from robertomiranda/use-rails-4-find-by" | Guillermo Iguaran | 2013-01-18 | 1 | -1/+1 |
| | | | | | | | | | | This reverts commit 637a7d9d357a0f3f725b0548282ca8c5e7d4af4a, reversing changes made to 5937bd02dee112646469848d7fe8a8bfcef5b4c1. | ||||
* | | User Rails 4 find_by | robertomiranda | 2013-01-18 | 1 | -1/+1 |
|/ | |||||
* | Namespace HashWithIndifferentAccess | Akira Matsuda | 2013-01-07 | 1 | -1/+1 |
| | |||||
* | Reset attributes should not report changes. | Renato Mascarenhas | 2012-12-01 | 1 | -1/+4 |
| | | | | | | | | | | | When resetting an attribute, you expect it to return to the state it was before any changes. Namely, this fixes this unexpected behavior: ~~~ruby model.name = "Bob" model.reset_name! model.name_changed? #=> true ~~~ | ||||
* | cleanup, removed dispensable `require` statements from `ActiveModel` | Yves Senn | 2012-11-25 | 1 | -1/+0 |
| | |||||
* | minor edits in AM documentation [ci skip] | Francesco Rodriguez | 2012-10-21 | 1 | -1/+1 |
| | |||||
* | load active_support/core_ext/object/blank in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| | |||||
* | update ActiveModel::Errors documentation and minor fixes [ci skip] | Francesco Rodriguez | 2012-06-22 | 1 | -3/+3 |
| | |||||
* | update ActiveModel::Dirty documentation | Francesco Rodriguez | 2012-05-31 | 1 | -24/+35 |
| | |||||
* | updating define_attribute_methods documentation | Francesco Rodriguez | 2012-05-14 | 1 | -1/+1 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-01 | 1 | -0/+1 |
|\ | |||||
| * | Add line which gives a little bit more information how *_will_change! works. | Edward Tsech | 2012-05-01 | 1 | -0/+1 |
| | | |||||
* | | Return earlier if attribute already changed in *_will_change! methods | Carlos Antonio da Silva | 2012-04-27 | 1 | -1/+3 |
|/ | | | | Avoid obtaining the value and duplicating it when possible. | ||||
* | Changing active model dirty module helper method to more appropriate method ↵ | Prasath Venkatraman | 2012-02-06 | 1 | -1/+2 |
| | | | | | | | | with helper #4903 Changing active model dirty module helper method to more appropriate method with helper with Active Support Helper #4903 Changing active model dirty module helper method to more appropriate method with helper with Active Support Helper typo fixed #4903 | ||||
* | use any? instead of !empty? | Oscar Del Ben | 2011-11-14 | 1 | -1/+1 |
| | |||||
* | Fix typo in ActiveModel::Dirty comment. define_attribute_methods is a class ↵ | Josh Nesbitt | 2011-09-02 | 1 | -1/+1 |
| | | | | method, not attribute. | ||||
* | Documentation fix: adding missing equal sign in code sample for ↵ | Sebastian Gassner | 2011-07-20 | 1 | -1/+1 |
| | | | | ActiveModel::Dirty. | ||||
* | changing an attribute multiple times retains the correct original value | Ian Stewart | 2011-06-28 | 1 | -1/+1 |
| | |||||
* | Rephrased Dirty#changed? docs | Sebastian Martinez | 2011-04-26 | 1 | -1/+1 |
| | |||||
* | Rewording | Oge Nnadi | 2011-04-11 | 1 | -1/+1 |
| | |||||
* | Remove require AS::Concern from places where is already in | Santiago Pastorino | 2010-12-19 | 1 | -1/+0 |
| | |||||
* | Perf: refactor methods using inject when not need in activemodel. | Emilio Tagua | 2010-09-22 | 1 | -1/+1 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -18/+18 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Remove or fix non-working examples and add a few tests to Dirty [#5185 ↵ | Tore Darell | 2010-08-03 | 1 | -7/+2 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> |