Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix typo [ci skip] | Carlos Antonio da Silva | 2014-08-07 | 1 | -1/+1 |
| | |||||
* | Allow password to contain spaces only. | Yevhene Shemet | 2014-08-06 | 1 | -0/+6 |
| | |||||
* | Merge pull request #16210 from sonnym/assert_valid_keys_in_validate | Matthew Draper | 2014-07-18 | 1 | -0/+6 |
|\ | | | | | | | Check for valid options in validate method | ||||
| * | check for valid options in validate method | sonnym | 2014-07-17 | 1 | -0/+6 |
|/ | | | | | | | | | | | This change prevents a certain class of user error which results when mistakenly using the `validate` class method instead of the `validates` class method. Only apply when all arguments are symbols, because some validations use the `validate` method and pass in additional options, namely the `LenghValidator` via the `ActiveMode::Validations::validates_with` method. | ||||
* | Deprecate `reset_#{attribute}` in favor of `restore_#{attribute}`. | Rafael Mendonça França | 2014-07-15 | 1 | -2/+7 |
| | | | | | | | | | These methods may cause confusion with the `reset_changes` that behaves differently of them. Also rename undo_changes to restore_changes to match this new set of methods. | ||||
* | Deprecate ActiveModel::Dirty#reset_changes in favor of ↵ | Rafael Mendonça França | 2014-07-15 | 1 | -0/+7 |
| | | | | | | | | | #clear_changes_information This method name is causing confusion with the `reset_#{attribute}` methods. While `reset_name` set the value of the name attribute for the previous value the `reset_changes` only discard the changes and previous changes. | ||||
* | Rename rollback_changes to undo_changes | Rafael Mendonça França | 2014-06-30 | 1 | -1/+1 |
| | | | | To avoid overload with database rollback | ||||
* | Add CHANGELOG entry for #14861 and document private methods on the API | Rafael Mendonça França | 2014-06-30 | 1 | -0/+5 |
| | |||||
* | `only_integer` of `NumericalityValidator` now allows procs and symbols | Robin Mehner | 2014-06-22 | 1 | -0/+4 |
| | |||||
* | Added changelog for #15708 [ci skip] | Godfrey Chan | 2014-06-14 | 1 | -0/+7 |
| | |||||
* | fix typo in changelog [ci skip] | Vijay Dev | 2014-06-11 | 1 | -1/+1 |
| | |||||
* | Merge pull request #15635 from kuldeepaggarwal/add-missing-changelog | Yves Senn | 2014-06-11 | 1 | -0/+6 |
|\ | | | | | | | add missing changelog entry. refer [#16db90d] [ci skip] | ||||
| * | add missing changelog entry. refer [#16db90d] [ci skip] | Kuldeep Aggarwal | 2014-06-11 | 1 | -0/+4 |
|/ | |||||
* | formatting pass through CHANGELOGS. [ci skip] | Yves Senn | 2014-05-16 | 1 | -1/+1 |
| | |||||
* | Add singular and plural form for some validation messages | Abd ar-Rahman Hamidi | 2014-05-02 | 1 | -0/+4 |
| | |||||
* | Enhance a bit a few changelog entries [ci skip] | Robin Dupret | 2014-05-02 | 1 | -1/+2 |
| | |||||
* | Add CHANGELOG to Active Model too [ci skip] | Rafael Mendonça França | 2014-03-27 | 1 | -0/+6 |
| | |||||
* | Point master changelogs to 4-1-stable branch | Carlos Antonio da Silva | 2014-02-25 | 1 | -72/+1 |
| | | | | Remove 4-1 related entries from master [ci skip] | ||||
* | `#to_param` returns `nil` if `to_key` returns `nil`. Closes #11399. | Yves Senn | 2014-02-04 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | The documentation of `#to_key` (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key) states that it returns `nil` if there are no key attributes. `to_param` needs to be aware of that fact and return `nil` as well. Previously it raised the following exception: ``` 1) Error: ConversionTest#test_to_param_returns_nil_if_to_key_is_nil: NoMethodError: undefined method `join' for nil:NilClass /Users/senny/Projects/rails/activemodel/lib/active_model/conversion.rb:65:in `to_param' /Users/senny/Projects/rails/activemodel/test/cases/conversion_test.rb:34:in `block in <class:ConversionTest>' ``` | ||||
* | tidy CHANGELOGs [ci skip] | Yves Senn | 2014-01-30 | 1 | -2/+5 |
| | |||||
* | Ability to specify multiple contexts when defining a validation. | Vince Puzzella | 2014-01-27 | 1 | -0/+20 |
| | | | | | | Example: validates_presence_of :name, on: [:update, :custom_validation_context] | ||||
* | Use a better method name to check the requirement of password confirmation | Carlos Antonio da Silva | 2014-01-07 | 1 | -3/+3 |
| | | | | | Also improve changelog entries related to secure password to proper highlight. | ||||
* | Allows you to check if an attribute has changed to a particular value | Tejas Dinkar | 2013-12-15 | 1 | -0/+6 |
| | | | | model.name_changed?(from: "Pete", to: "Ringo") | ||||
* | first pass through CHANGELOGS to extract 4_1_release_notes. [ci skip] | Yves Senn | 2013-11-28 | 1 | -2/+2 |
| | | | | | | | | | | | | Extract **notable changes**, **deprecations** and **removals** from each CHANGELOG. I tried to reference the commits and pull requests for new features and deprecations. In the process I also made some minor changes to the CHANGELOGS. The 4_1_release_notes guide is declared WIP. | ||||
* | Use bcrypt's public cost attr, not internal constant | T.J. Schuck | 2013-10-10 | 1 | -0/+4 |
| | | | | | | | | See: - https://github.com/codahale/bcrypt-ruby/pull/63 - https://github.com/codahale/bcrypt-ruby/pull/64 - https://github.com/codahale/bcrypt-ruby/pull/65 | ||||
* | Merge pull request #8791 from griffinmyers/master | Rafael Mendonça França | 2013-10-03 | 1 | -0/+5 |
|\ | | | | | | | | | | | | | Updated DirtyModel's @changed_attributes hash to be symbol/string agnostic Conflicts: activemodel/CHANGELOG.md | ||||
| * | DirtyModel uses a hash to keep track of any changes made to attributes | William Myers | 2013-05-27 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | | | | of an instance. When using the attribute_will_change! method, you must supply a string and not a symbol or the *_changed? method will break (because it is looking for the attribute name as a string in the keys of the underlying hash). To remedy this, I simply made the underlying hash a HashWithIndifferentAccess so it won't matter if you supply the attribute name as a symbol or string to attribute_will_change!. | ||||
* | | No need to abbreviate ActiveModel | Rafael Mendonça França | 2013-09-23 | 1 | -1/+1 |
| | | | | | | | | [ci skip] | ||||
* | | Merge pull request #10816 from bogdan/less-dirty-dirty | Rafael Mendonça França | 2013-09-23 | 1 | -0/+6 |
| | | | | | | | | Make AM::Dirty less dirty to plugin into AR or other library | ||||
* | | Fix secure_password password_confirmation validations | Vladimir Kiselev | 2013-07-24 | 1 | -0/+5 |
| | | |||||
* | | Merge pull request #10774 from ↵ | Carlos Antonio da Silva | 2013-06-25 | 1 | -0/+9 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | chuckbergeron/validates-inclusion-of-accuracy-for-non-numeric-ranges Greater accuracy for validates_inclusion_of on non-numeric ranges Closes #10774, fixes #10593 | ||||
| * | | Use Range#cover? for Numeric ranges (tests via endpoints) and use ↵ | Charles Bergeron | 2013-05-27 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | | | Range#include? for non-numeric ranges added changelog message | ||||
* | | | Fix regression in has_secure_password. | Phil Calvin | 2013-05-30 | 1 | -0/+5 |
|/ / | | | | | | | If the confirmation was blank, but the password wasn't, it would still save. | ||||
* | | deprecate Validator#setup (to get rid of a respond_to call). validators do ↵ | Nick Sutterer | 2013-05-23 | 1 | -1/+3 |
| | | | | | | | | their setup in their constructor now. | ||||
* | | rails/master is now 4.1.0.beta | Rafael Mendonça França | 2013-04-29 | 1 | -212/+2 |
| | | |||||
* | | use unified and clean formatting in CHANGELOGS. [ci skip] | Yves Senn | 2013-04-12 | 1 | -9/+12 |
| | | |||||
* | | Improve changelog entry for ActiveModel::Errors#full_messages_for [ci skip] | Carlos Antonio da Silva | 2013-03-30 | 1 | -2/+13 |
| | | | | | | | | Add a working example of how to use this new method. | ||||
* | | Add a method full_messages_for to the Errors class | shock_one | 2013-03-24 | 1 | -0/+5 |
| | | |||||
* | | Fixed typo in activemodel/CHANGELOG | Prathamesh Sonpatki | 2013-03-24 | 1 | -1/+1 |
| | | |||||
* | | The repair_validations helper was not working correctly before because | wangjohn | 2013-03-19 | 1 | -0/+21 |
| | | | | | | | | | | | | it only cleared the validations that created :validate callbacks. This didn't include the validates created by validates_with, so I've added a method to clear all validations. | ||||
* | | Small typos here and there. | Vipul A M | 2013-03-15 | 1 | -1/+1 |
| | | |||||
* | | Fix AMo code example indent, add missing author to entry [ci skip] | Carlos Antonio da Silva | 2013-03-09 | 1 | -6/+8 |
| | | |||||
* | | `has_secure_password` is not invalid when assigning empty Strings. | Yves Senn | 2013-03-04 | 1 | -0/+10 |
| | | | | | | | | | | | | | | | | | | | | Closes #9535. With 692b3b6 the `password=` setter does no longer set blank passwords. This triggered validation errors when assigning empty Strings to `password` and `password_confirmation`. This patch only sets the confirmation if it is not `blank?`. | ||||
* | | `validates_confirmation_of` does not override writer methods. | Yves Senn | 2013-03-04 | 1 | -0/+15 |
| | | |||||
* | | Update CHANGELOGS | Rafael Mendonça França | 2013-02-26 | 1 | -0/+3 |
| | | |||||
* | | Preparing for 4.0.0.beta1 release | David Heinemeier Hansson | 2013-02-25 | 1 | -1/+1 |
| | | |||||
* | | did a pass over the AM changelog [ci skip] | Xavier Noria | 2013-02-24 | 1 | -15/+35 |
|/ | |||||
* | This change doesn't need a CHANGELOG entry. | Rafael Mendonça França | 2012-12-26 | 1 | -5/+0 |
| | | | | [ci skip] | ||||
* | Add CHANGELOG entry for #8622 | Rafael Mendonça França | 2012-12-26 | 1 | -0/+5 |
| | |||||
* | Remove CHANGELOG entry for ActiveModel::Errors#add_on_present | Rafael Mendonça França | 2012-12-21 | 1 | -5/+0 |
| |