aboutsummaryrefslogtreecommitdiffstats
path: root/activejob
Commit message (Collapse)AuthorAgeFilesLines
* Silence callback deprecation warning if testing AJclaudiob2015-08-311-0/+1
| | | | | | | | | | | | | | | Currently the log returned by running ActiveJob tests is filled with: > DEPRECATION WARNING: Returning `false` in a callback will not implicitly halt a callback chain in the next release of Rails. To explicitly halt a callback chain, please use `throw :abort` instead. For instance, see https://travis-ci.org/rails/rails/builds/77978273 This happens because some setup and teardown methods [like these one](https://github.com/rails/rails/blob/master/activejob/test/cases/async_job_test.rb#L10-L17) invoke other methods like `perform_asynchronously!` that can return `false`, but not with the intention of halting the process if they do. In my opinion, these deprecation warnings can be silenced to have the log result cleaner (especially when browsing for errors).
* Initial implementation of ActiveJob AsyncAdapter.Jerry D'Antonio2015-08-2511-2/+181
|
* Fix typo on method nameRafael Mendonça França2015-08-161-3/+3
| | | | [Robin Dupret]
* use `average_scheduled_poll_interval` option instead of deprecated ↵yuuji.yaginuma2015-08-151-1/+1
| | | | | | | | | | `poll_interval` this removes the following warning: ``` DEPRECATION: `config.poll_interval = 0.5` will be removed in Sidekiq 4. Please update to `config.average_scheduled_poll_interval = 0.5`. ```
* implement `provider_job_id` for `queue_classic`.Yves Senn2015-08-133-5/+14
| | | | | | The latest, currently unreleased, version of queue_classic is required for this to work. See https://github.com/QueueClassic/queue_classic/pull/262 for more details.
* use `assert_not` instead of `refute` as mentioned in our guides.Yves Senn2015-08-131-3/+2
| | | | | | | | | | | As described in the "Follow Coding Conventions" section in our contribution guide (http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) we favor `assert_not` over `refute`. While we don't usually make stylistic changes on it's own I opted to do it in this case. The reason being that test cases are usually copied as a starting point for new tests. This results in a spread of `refute` in files that have been using it already.
* Make assert_enqueued_with and assert_performed_with returns the matched jobJean Boussier2015-08-103-2/+38
|
* Merge pull request #21145 from toydestroyer/masterYves Senn2015-08-061-15/+14
|\ | | | | | | | | | | [ci skip] Documentation: update queue_classic info in Active Job adapters list
| * Documentation: update queue_classic info in Active Job adapters listSergey Toy2015-08-061-4/+3
|/
* Add missing HelloJob require.Kasper Timm Hansen2015-08-051-0/+1
| | | | This way JobSerializationTest runs in isolation without errors.
* Merge pull request #20800 from xijo/make_active_job_locale_awareKasper Timm Hansen2015-08-0410-2/+98
|\ | | | | Make ActiveJob locale aware
| * Fixes #20799Johannes Opper2015-08-0410-2/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When `#perform_later` is called the locale isn't stored on the queue, which results in a locale reset when the job is performed. An example of the problem: I18n.locale = 'de' HelloJob.perform_now # german message, correct but I18n.locale = 'de' HelloJob.perform_later # english message, incorrect This PR attaches the current I18n.locale to every job during the serialization process. It is then restored during deserialization and used to perform the job with the correct locale. It falls back to the default locale if no serialized locale is found in order to provide backward compatibility with previously stored jobs. It is not necessary to clear the queue for the update.
* | Add `:nodoc:` for internal testing methods [ci skip]Robin Dupret2015-07-281-2/+2
|/
* Improve error message when serializing unsaved records for jobsFaraz Yashar2015-06-282-7/+21
|
* [ci skip] Add `.`yui-knk2015-06-101-1/+1
|
* [skip ci] Add documentation for QueueAdapter::queue_adapterAnton Davydov2015-06-021-0/+2
|
* Merge pull request #20371 from davydovanton/doc-adapter-lookupYves Senn2015-06-011-0/+4
|\ | | | | Update documentation for QueueAdapters::lookup [ci skip]
| * [skip ci] Update documentation for QueueAdapters::lookupAnton Davydov2015-06-011-0/+4
| |
* | minor formatting changes in changelogs. [ci skip]Yves Senn2015-05-311-1/+1
| |
* | Remove unused package tasksArun Agrawal2015-05-281-8/+0
|/ | | | We are using `all:build` now.
* Merge pull request #20262 from arunagw/aa-remove-broken-unused-release-taskYves Senn2015-05-271-7/+0
|\ | | | | Remove broken and unused release task
| * Remove broken and unused release taskArun Agrawal2015-05-221-7/+0
| | | | | | | | | | - We do release with release.rb - There is no `rake/gemcutter`
* | Fix spelling mistakesYoong Kang Lim2015-05-251-4/+4
|/
* doc changes for readability [ci skip]Gourav Tiwari2015-05-191-2/+2
|
* Pass over CHANGELOGS [ci skip]Prathamesh Sonpatki2015-05-161-1/+1
|
* [ci skip] Don’t encourage `sudo gem install`claudiob2015-05-121-1/+1
| | | | | | | | | | | | | I think we are better off leaving `sudo` outside of the documented way of installing gems (`activerecord`, `actionpack`, …). We don’t want newbies to think that `sudo` is required or, even worse, than they actually have to type `[sudo] gem install`. In most scenarios, `sudo` is not needed to install gems, and people who do need it, probably already know about it. What do you think? :grin:
* Merge pull request #20064 from kddeisz/qu_provider_job_idRafael Mendonça França2015-05-084-9/+16
|\ | | | | Provide provider_job_id to qu adapter.
| * Provide provider_job_id to qu adapter.Kevin Deisz2015-05-074-9/+16
| | | | | | | | Further work to provide provider_job_id for queue adapters.
* | Merge pull request #20072 from vngrs/refactor_active_job_sidekiq_adapterYves Senn2015-05-081-6/+2
|\ \ | | | | | | Refactor sidekiq adapter enqueue and enqueue_at methods
| * | Refactor sidekiq adapter enqueue and enqueue_at methodsMehmet Emin İNAÇ2015-05-081-6/+2
| |/
* / Don't need to explicitly set test_order it's :random defaultMehmet Emin İNAÇ2015-05-081-2/+0
|/
* Make que report back its job_id to provider_job_idJeroen van Baarsen2015-05-073-20/+13
| | | | Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
* Let Sidekiq set provider_job_idJeroen van Baarsen2015-05-073-2/+21
| | | | | | | | | | When a job is added to Sidekiq by ActiveJob, make sure we still can get the original job_id provider by Sidekiq. We do this by adding the sidekiq jid to provider_job_id field on the job object. Partly fixes #18821 Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
* Get provider_job_id from DelayedJobKevin Deisz2015-05-054-2/+22
| | | | | When queueing with DelayedJob, get the id of the job instance and report it back to ActiveJob as provider_job_id.
* Do not use named queues for que adapterRafael Mendonça França2015-05-032-2/+2
| | | | See #19498
* Disable warnings on activejob testsRafael Mendonça França2015-05-031-2/+2
| | | | | The implementations seems to not be interested to remove the warnings so enabling them we are just making harder to read the outputs
* Merge pull request #19498 from chanks/activejob-que-remove-named-queuesRafael Mendonça França2015-05-032-3/+7
|\ | | | | ActiveJob: Stop using Que's named queues.
| * Stop using Que's named queues in its ActiveJob adapter.Chris Hanks2015-03-242-3/+7
| |
* | Merge pull request #19969 from y-yagi/fix_job_helper_methodYves Senn2015-05-013-2/+30
|\ \ | | | | | | | | | match a expected value with message of `assert_equal` in AJ helper methods
| * | match a expected value with message of `assert_equal` in AJ helper methodsyuuji.yaginuma2015-05-011-2/+2
|/ /
* | Add doc for original_exception in ActiveJob::DeserializationError [ci skip]Zachary Scott2015-04-291-0/+2
| |
* | Add initial doc for Core in AJ [ci skip]Zachary Scott2015-04-291-0/+2
| |
* | Add initial doc for Enqueuing module [ci skip]Zachary Scott2015-04-291-0/+1
| |
* | Rails should be nodoc'd here [ci skip]Zachary Scott2015-04-291-1/+1
| |
* | Add missing error messages for sucker_punch, sneakers and qu activejob ↵Mehmet Emin İNAÇ2015-04-294-4/+4
| | | | | | | | | | | | | | | | | | | | adapters [ci skip] fix error message change raise to use rails conventions fix misspells
* | nodoc private internal constants from ActiveJob::ArgumentsZachary Scott2015-04-261-0/+5
| |
* | Remove nonexistent adapterRafael Mendonça França2015-04-231-1/+0
| | | | | | | | | | | | Closes #19866 [ci skip]
* | Queue Classic runs a second earlier than scheduledMatthew Draper2015-04-231-1/+1
| | | | | | | | | | | | | | That seems to be a bug, but as we don't actually care about the precision for our test, we'll just give it a bit longer. [Matthew Draper & Cristian Bica]
* | Only *configure* the queue in setup; DB creation must come laterMatthew Draper2015-04-202-21/+25
| | | | | | | | | | | | | | | | | | setup gets called from the initializer, so it happens more than once in a test run. Trying to drop the database again after the first process is connected is.. ineffective. And entirely pointless. Instead, defer creating the database to start_workers -- which only happens once, right before we start doing anything real.
* | Shuffle a few things in aid of easier debuggingMatthew Draper2015-04-201-20/+36
| | | | | | | | | | | | | | * Don't swallow output -- if there is any, it's probably useful * Wait for the process to finish * Use IPC instead of a sleep * No need for a pidfile