aboutsummaryrefslogtreecommitdiffstats
path: root/activejob
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #19034 from jvanbaarsen/explicit-job-base-classMatthew Draper2015-03-303-2/+5
|\ | | | | | | Add explicit base class for ActiveJob jobs
| * Add explicit base class for ActiveJob jobsJeroen van Baarsen2015-03-233-2/+5
| | | | | | | | | | | | | | | | * Jobs generated now inherent from ApplicationJob * ApplicationJob inherents from ActiveJob::Base * Added entry to changelog Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
* | Pass wrapped class name to Sidekiq for logging purposesMike Perham2015-03-232-7/+22
| | | | | | | | | | | | | | Sidekiq logs the name of the job class being performed. Because ActiveJob wraps the class, this means every job logs as an AJ::JobWrapper instead of the actual class name. Will help fix mperham/sidekiq#2248
* | Closes rails/rails#18864: Renaming transactional fixtures to transactional testsBrandon Weiss2015-03-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I’m renaming all instances of `use_transcational_fixtures` to `use_transactional_tests` and “transactional fixtures” to “transactional tests”. I’m deprecating `use_transactional_fixtures=`. So anyone who is explicitly setting this will get a warning telling them to use `use_transactional_tests=` instead. I’m maintaining backwards compatibility—both forms will work. `use_transactional_tests` will check to see if `use_transactional_fixtures` is set and use that, otherwise it will use itself. But because `use_transactional_tests` is a class attribute (created with `class_attribute`) this requires a little bit of hoop jumping. The writer method that `class_attribute` generates defines a new reader method that return the value being set. Which means we can’t set the default of `true` using `use_transactional_tests=` as was done previously because that won’t take into account anyone using `use_transactional_fixtures`. Instead I defined the reader method manually and it checks `use_transactional_fixtures`. If it was set then it should be used, otherwise it should return the default, which is `true`. If someone uses `use_transactional_tests=` then it will overwrite the backwards-compatible method with whatever they set.
* | Move Adapter to private constantSemyon Pupkov2015-03-161-0/+1
|/
* `QueueAdapters` does the lookupTamir Duberstein2015-03-122-5/+9
|
* Use a more conservative `const_get` over `constantize`Tamir Duberstein2015-03-121-1/+1
|
* `ActiveJob::Base#queue_adapter` is now a `class_attribute`Tamir Duberstein2015-03-114-17/+82
| | | | | | This allows different `queue_adapters` to be used in each `ActiveJob` class heirarchy. Previously, all subclasses used a single global queue adapter.
* `ActiveJob::QueueAdapters::*` are no longer singletonsTamir Duberstein2015-03-1118-152/+173
|
* Fix naming collisionTamir Duberstein2015-03-111-1/+1
|
* Target Ruby 2.2.1 in gemspecsPeter Suschlik2015-03-091-1/+1
| | | | This is a follow-up to #19257
* Fix leaky `only: …` option for Active Job assertionsJeremy Kemper2015-03-062-9/+23
| | | | | | | The filter was set on the pseudo-global TestAdapter but not restored to its original value. See e818f65770fe115ab1cc7fbacc0e7e94d92af6a4
* Fixed ActiveJob integration testsCristian Bica2015-03-052-2/+4
|
* Minor fixes (proposal)Darío Hereñú2015-02-281-2/+2
|
* Avoid creating an extra hash on the job test adapterCarlos Antonio da Silva2015-02-241-1/+1
|
* `ActiveJob::QueueAdapters::TestAdapter` is now a singletonTamir Duberstein2015-02-234-31/+31
| | | | | | | | | Since `ActiveJob::TestHelper` globally sets `ActiveJob::Base.queue_adapter` on setup, there is no benefit in instantiating a new `TestAdapter` per tests. The original rationale was to allow parallel tests to run without interference, but since they'd all mutate the global `ActiveJob::Base.queue_adapter`, that was never realized.
* Changed the AJADAPTER to AJ_ADAPTERJeroen van Baarsen2015-02-226-7/+7
| | | | | | | * This allows for easier reading, since those are two words, so they should be split by _ Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
* Move #18833 changelog to the top [ci skip]Carlos Antonio da Silva2015-02-081-35/+33
|
* Add an `:only` option to `perform_enqueued_jobs` to filter jobs based onMichael Ryan2015-02-064-18/+186
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | type. This allows specific jobs to be tested, while preventing others from being performed unnecessarily. Example: def test_hello_job assert_performed_jobs 1, only: HelloJob do HelloJob.perform_later('jeremy') LoggingJob.perform_later end end An array may also be specified, to support testing multiple jobs. Example: def test_hello_and_logging_jobs assert_nothing_raised do assert_performed_jobs 2, only: [HelloJob, LoggingJob] do HelloJob.perform_later('jeremy') LoggingJob.perform_later('stewie') RescueJob.perform_later('david') end end end Fixes #18802. Trim space and document :only option.
* Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846robertomiranda2015-01-311-1/+1
| | | | ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769
* Allow keyword arguments to work with ActiveJobSean Griffin2015-01-304-19/+82
| | | | | | | | | | | | | | | | | Unfortunately, the HashWithIndifferent access approach is insufficient for our needs. It's perfectly reasonable to want to use keyword arguments with Active Job, which we will see as a symbol keyed hash. For Ruby to convert this back to keyword arguments, it must deserialize to a symbol keyed hash. There are two primary changes to the serialization behavior. We first treat a HWIA separately, and mark it as such so we can convert it back into a HWIA during deserialization. For normal hashes, we keep a list of all symbol keys, and convert them back to symbol keys after deserialization. Fixes #18741.
* Fix ActiveJob assertions with a GlobalID object argumentRichard Manyanza2015-01-232-2/+51
|
* formatting pass over CHANGELOGs. [ci skip]Yves Senn2015-01-101-2/+6
|
* Add :only option to assert_no_enqueued_jobsGeorge Claghorn2015-01-082-2/+29
|
* Fix Active Job changelog formatting and reword a bit [ci skip]Carlos Antonio da Silva2015-01-081-24/+22
|
* Add :only option to assert_enqueued_jobsGeorge Claghorn2015-01-073-7/+76
| | | | With the option, assert_enqueued_jobs will check the number of times a specific kind of job is enqueued.
* No need to disable sidikiq tests with 1.9.3 anymoreRafael Mendonça França2015-01-041-11/+0
|
* Do not run integration tests for the test adapterRafael Mendonça França2015-01-021-1/+1
|
* Merge pull request #18271 from arunagw/change-copyright-yearRobin Dupret2015-01-012-2/+2
|\ | | | | Update copyright notices to 2015 [ci skip]
| * Update copyright notices to 2015 [ci skip]Arun Agrawal2014-12-312-2/+2
| |
* | Tiny follow-up to #18260 [ci skip]Robin Dupret2014-12-312-11/+12
| | | | | | | | | | | | | | Indent the list content by 4 spaces instead of 2 to match the other changelog files. Also wrap the lines around 80 chars. Finally update the documentation example with nit-picky things.
* | Merge pull request #18277 from prathamesh-sonpatki/typo-aj-changelogArun Agrawal2014-12-311-1/+1
|\ \ | | | | | | Fixed typo in ActiveJob CHANGELOG [ci skip]
| * | Fixed typo in ActiveJob CHANGELOG [ci skip]Prathamesh Sonpatki2014-12-311-1/+1
| |/
* | Merge pull request #18274 from rajcybage/spell_fixRobin Dupret2014-12-311-2/+2
|\ \ | |/ |/| Fix spell life cycle on activejob docs [ci skip]
| * Fix spell life cycle on activejob docs [ ci skip]Rajarshi Das2014-12-311-2/+2
| |
* | ActiveJob is not ActionJob [ci skip] :smile:Prathamesh Sonpatki2014-12-311-1/+1
| |
* | Merge pull request #18266 from cristianbica/ajfixesRafael Mendonça França2014-12-306-12/+21
|\ \ | | | | | | ActiveJob testing improvements
| * | ActiveJob testing improvementsCristian Bica2014-12-306-12/+21
| | | | | | | | | | | | | | | | | | | | | | | | 1. The :test adapter wasn't going through a full cycle of serialize/deserialize when performing jobs. Now it does 2. Regular AJ tests were not run for the :test adapter. Now they are 3. ActiveJob::TestHelper uses assert_valid_keys but doesn’t requires the file that implements that method. Now it does
* | | ActiveJob: delegate full deserialization to classIsaac Seymour2014-12-302-4/+53
|/ /
* | Expectation comes firstYukio Mizuta2014-12-281-1/+1
| |
* | Require Ruby 2.2 for Rails 5.0claudiob2014-12-261-1/+1
| | | | | | | | | | Stems from [this comment](https://github.com/rails/rails/pull/18203#issuecomment-68138096) by @robin850 and by the blog post http://weblog.rubyonrails.org/2014/12/19/Rails-4-2-final
* | Add 'require' for Hash#with_indifferent_accessjoker10072014-12-211-0/+2
| | | | | | | | | | | | | | | | | | ActiveJob::Arguments uses Hash#with_indifferent_access. But, activejob gem does not require Hash extension library. When we use activejob as standalone, we need extra require statement. This is unhandy. This commit fixes it.
* | Replace guides.ror.org/v4.2.0 with guides.ror.orgclaudiob2014-12-201-1/+1
| | | | | | | | | | No need to point links to http://guides.rubyonrails.org/v4.2.0/... now that the Ruby on Rails guides point to 4.2.0.
* | redis 3.2.0 doesn't allow tcp protocol anymoreRafael Mendonça França2014-12-131-1/+1
| | | | | | | | Use redis protocol
* | Include missing requireDavid Heinemeier Hansson2014-12-051-0/+1
| |
* | Merge pull request #17817 from aripollak/hide-activejob-argsDavid Heinemeier Hansson2014-12-052-1/+14
|\ \ | | | | | | GlobalID objects are logged by their URI, not #inspect on the object, to prevent logging private data
| * | Inline to_global_id conversionAri Pollak2014-12-041-5/+1
| | |
| * | Use try instead of checking for GlobalID::IdentificationAri Pollak2014-12-041-5/+1
| | |
| * | Only filter GIDable objects; remove cosmetic changesAri Pollak2014-12-012-16/+14
| | |
| * | Hide potentially sensitive ActiveJob params from logsAri Pollak2014-11-282-11/+34
| | | | | | | | | | | | * Show GlobalID instead of full object .inspect output