aboutsummaryrefslogtreecommitdiffstats
path: root/activejob
Commit message (Collapse)AuthorAgeFilesLines
* [ci skip] Add a dollar sign to each command in the READMEsElektron1c972015-12-061-1/+1
| | | | | | According to pr #22443 in the guides there's always a dollar sign before every command, so why is in the main README a `$` and in every submodule a `%`? Just eye candy..
* Fix race condition testing for job execution orderWill Jessop2015-11-233-7/+18
| | | | | | | | | | | | | | | On most filesystems file ctime is limited to 1 second granularity, which means that on faster computers multiple simple jobs (for instance dummy TestJob) can finish within the same second. The execution order test in ActiveJob integration tests relies on multiple TestJobs writing files then comparing the ctime. As a result integration tests would sometimes fail as the ctime of the files written by these TestJobs could have coincidental ctimes making the comparison for job order fail. This commit adds a far more precise execution time (to the extent that the Ruby Time class allows) to the file created by TestJob, and updates the execution order assertion to use it, removing the race condition.
* Fixed wording.Mike Boone2015-11-082-2/+2
|
* Require only necessary concurrent-ruby classes.Jerry D'Antonio2015-11-042-2/+4
|
* Deprecate exception#original_exception in favor of exception#causeYuki Nishijima2015-11-032-10/+17
|
* Merge pull request #21878 from Gaurav2728/require_monitorMatthew Draper2015-10-101-1/+1
|\ | | | | monitor is require for SneakersAdapter
| * monitor is require for SneakersAdapterGaurav Sharma2015-10-061-1/+1
| | | | | | we are using `@monitor = Monitor.new` that inherit from Monitor class, we leave behind this commit https://github.com/rails/rails/commit/cbfc8b36
* | Added missing specs for not modifying queues when using AJ test helpersWojciech Wnętrzak2015-10-072-14/+31
|/
* Merge pull request #21854 from morgoth/fix-serializing-at-option-in-aj-matchersYves Senn2015-10-053-8/+38
|\ | | | | | | Fixed serializing `:at` option for `assert_eqnueued_with` and `assert_performed_with`
| * Fixed serializing `:at` option for `assert_enqueued_with` and ↵Wojciech Wnętrzak2015-10-033-8/+32
| | | | | | | | `assert_performed_with`
* | Merge pull request #20116 from cristianbica/activejob-enqueue-loggingArthur Nogueira Neves2015-10-041-1/+1
|\ \ | |/ |/| ActiveJob - log enqueued message only after the job was successfully enqueued
| * ActiveJob - log enqueued message only after the job was successfully enqueuedCristian Bica2015-05-111-1/+1
| |
* | Support passing array to `assert_enqueued_jobs` in `:only` optionWojciech Wnętrzak2015-10-033-1/+23
| |
* | Do not document private methods in AJ::TestHelperWojciech Wnętrzak2015-10-021-5/+5
| | | | | | | | [CI skip]
* | Merge pull request #19425 from wvengen/feature/activejob-priority-masterRafael Mendonça França2015-09-2511-6/+132
|\ \ | | | | | | Add job priorities to ActiveJob
| * | Add job priorities to ActiveJobwvengen2015-09-1711-6/+132
| | |
* | | Use Sidekiq.options to set initial waitAndrew White2015-09-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The INITIAL_WAIT constant has moved to the Sidekiq::Poller class but rather than setting the constant directly we can override it via the `:poll_interval_average` option. This was causing random build failures because the test was waiting for 10 seconds for the job to execute but the initial wait was a random value between 10 and 15 seconds.
* | | Run `rake db:migrate` for all Active Job integration testsAndrew White2015-09-211-1/+2
| | | | | | | | | | | | | | | | | | If db/schema.rb doesn't exist then we get warnings from the dummy Rails application so run it for all adapters even if they're not using the database to store jobs.
* | | Silence logging in Active Job unit testsAndrew White2015-09-211-0/+1
| | |
* | | :hocho: TyposAkira Matsuda2015-09-211-1/+1
| | |
* | | Added new lines to run title for easy log readinghiren mistry2015-09-191-1/+1
| | |
* | | Replaced `ThreadSafe::Map` with successor `Concurrent::Map`.Jerry D'Antonio2015-09-191-2/+1
|/ / | | | | | | | | | | | | The thread_safe gem is being deprecated and all its code has been merged into the concurrent-ruby gem. The new class, Concurrent::Map, is exactly the same as its predecessor except for fixes to two bugs discovered during the merge.
* | Properly log nested parameters to Active JobMarek Pieczyk2015-09-082-1/+23
| | | | | | | | Refactor arguments logging method for Active Job
* | Silence callback deprecation warning if testing AJclaudiob2015-08-311-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently the log returned by running ActiveJob tests is filled with: > DEPRECATION WARNING: Returning `false` in a callback will not implicitly halt a callback chain in the next release of Rails. To explicitly halt a callback chain, please use `throw :abort` instead. For instance, see https://travis-ci.org/rails/rails/builds/77978273 This happens because some setup and teardown methods [like these one](https://github.com/rails/rails/blob/master/activejob/test/cases/async_job_test.rb#L10-L17) invoke other methods like `perform_asynchronously!` that can return `false`, but not with the intention of halting the process if they do. In my opinion, these deprecation warnings can be silenced to have the log result cleaner (especially when browsing for errors).
* | Initial implementation of ActiveJob AsyncAdapter.Jerry D'Antonio2015-08-2511-2/+181
| |
* | Fix typo on method nameRafael Mendonça França2015-08-161-3/+3
| | | | | | | | [Robin Dupret]
* | use `average_scheduled_poll_interval` option instead of deprecated ↵yuuji.yaginuma2015-08-151-1/+1
| | | | | | | | | | | | | | | | | | | | `poll_interval` this removes the following warning: ``` DEPRECATION: `config.poll_interval = 0.5` will be removed in Sidekiq 4. Please update to `config.average_scheduled_poll_interval = 0.5`. ```
* | implement `provider_job_id` for `queue_classic`.Yves Senn2015-08-133-5/+14
| | | | | | | | | | | | The latest, currently unreleased, version of queue_classic is required for this to work. See https://github.com/QueueClassic/queue_classic/pull/262 for more details.
* | use `assert_not` instead of `refute` as mentioned in our guides.Yves Senn2015-08-131-3/+2
| | | | | | | | | | | | | | | | | | | | | | As described in the "Follow Coding Conventions" section in our contribution guide (http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) we favor `assert_not` over `refute`. While we don't usually make stylistic changes on it's own I opted to do it in this case. The reason being that test cases are usually copied as a starting point for new tests. This results in a spread of `refute` in files that have been using it already.
* | Make assert_enqueued_with and assert_performed_with returns the matched jobJean Boussier2015-08-103-2/+38
| |
* | Merge pull request #21145 from toydestroyer/masterYves Senn2015-08-061-15/+14
|\ \ | | | | | | | | | | | | | | | [ci skip] Documentation: update queue_classic info in Active Job adapters list
| * | Documentation: update queue_classic info in Active Job adapters listSergey Toy2015-08-061-4/+3
|/ /
* | Add missing HelloJob require.Kasper Timm Hansen2015-08-051-0/+1
| | | | | | | | This way JobSerializationTest runs in isolation without errors.
* | Merge pull request #20800 from xijo/make_active_job_locale_awareKasper Timm Hansen2015-08-0410-2/+98
|\ \ | | | | | | Make ActiveJob locale aware
| * | Fixes #20799Johannes Opper2015-08-0410-2/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When `#perform_later` is called the locale isn't stored on the queue, which results in a locale reset when the job is performed. An example of the problem: I18n.locale = 'de' HelloJob.perform_now # german message, correct but I18n.locale = 'de' HelloJob.perform_later # english message, incorrect This PR attaches the current I18n.locale to every job during the serialization process. It is then restored during deserialization and used to perform the job with the correct locale. It falls back to the default locale if no serialized locale is found in order to provide backward compatibility with previously stored jobs. It is not necessary to clear the queue for the update.
* | | Add `:nodoc:` for internal testing methods [ci skip]Robin Dupret2015-07-281-2/+2
|/ /
* | Improve error message when serializing unsaved records for jobsFaraz Yashar2015-06-282-7/+21
| |
* | [ci skip] Add `.`yui-knk2015-06-101-1/+1
| |
* | [skip ci] Add documentation for QueueAdapter::queue_adapterAnton Davydov2015-06-021-0/+2
| |
* | Merge pull request #20371 from davydovanton/doc-adapter-lookupYves Senn2015-06-011-0/+4
|\ \ | | | | | | Update documentation for QueueAdapters::lookup [ci skip]
| * | [skip ci] Update documentation for QueueAdapters::lookupAnton Davydov2015-06-011-0/+4
| | |
* | | minor formatting changes in changelogs. [ci skip]Yves Senn2015-05-311-1/+1
| | |
* | | Remove unused package tasksArun Agrawal2015-05-281-8/+0
|/ / | | | | | | We are using `all:build` now.
* | Merge pull request #20262 from arunagw/aa-remove-broken-unused-release-taskYves Senn2015-05-271-7/+0
|\ \ | | | | | | Remove broken and unused release task
| * | Remove broken and unused release taskArun Agrawal2015-05-221-7/+0
| | | | | | | | | | | | | | | - We do release with release.rb - There is no `rake/gemcutter`
* | | Fix spelling mistakesYoong Kang Lim2015-05-251-4/+4
|/ /
* | doc changes for readability [ci skip]Gourav Tiwari2015-05-191-2/+2
| |
* | Pass over CHANGELOGS [ci skip]Prathamesh Sonpatki2015-05-161-1/+1
| |
* | [ci skip] Don’t encourage `sudo gem install`claudiob2015-05-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | I think we are better off leaving `sudo` outside of the documented way of installing gems (`activerecord`, `actionpack`, …). We don’t want newbies to think that `sudo` is required or, even worse, than they actually have to type `[sudo] gem install`. In most scenarios, `sudo` is not needed to install gems, and people who do need it, probably already know about it. What do you think? :grin:
* | Merge pull request #20064 from kddeisz/qu_provider_job_idRafael Mendonça França2015-05-084-9/+16
|\ \ | | | | | | Provide provider_job_id to qu adapter.