Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | make backburner integration test to work | yuuji.yaginuma | 2017-01-28 | 1 | -2/+2 |
| | | | | | | | | | | | | | Currently, backburner integration test is not running on CI. https://travis-ci.org/rails/rails/jobs/196005322#L610 Using `Backburner::Worker.connection` to check whether beanstalkd is running. But `Backburner::Worker.connection` was removed in backburner 1.2.0. https://github.com/nesquena/backburner/commit/81fde499c2263abe8dedee59a3d0e03e92d72627 Therefore, this check process always becomes false, so the test is no longer done. I fixed it so that check processing is done correctly. | ||||
* | assert_enqueued_jobs with queue option | Michael Elfassy | 2017-01-18 | 1 | -0/+21 |
| | |||||
* | `self.` is not needed when calling its own instance method | Akira Matsuda | 2017-01-05 | 3 | -3/+3 |
| | | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby | ||||
* | remove useless import | Snowmanzzz(Zhengzhong Zhao) | 2016-12-30 | 1 | -2/+0 |
| | |||||
* | "Use assert_nil if expecting nil. This will fail in minitest 6." | Akira Matsuda | 2016-12-25 | 2 | -3/+3 |
| | |||||
* | Privatize unneededly protected methods in Active Job tests | Akira Matsuda | 2016-12-24 | 2 | -2/+2 |
| | |||||
* | Output adapter being tested. | utilum | 2016-12-12 | 1 | -0/+1 |
| | |||||
* | Avoid race condition in AJ integration tests | Matthew Draper | 2016-11-30 | 2 | -1/+3 |
| | | | | Make sure the file doesn't exist until we've finished writing it. | ||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 10 | -15/+15 |
| | |||||
* | removes requires already present in active_support/rails | Xavier Noria | 2016-10-27 | 1 | -1/+0 |
| | |||||
* | Uses queue adapter_method instead of ActiveJob::Base.queue_adapter | Gabi Stefanini | 2016-10-24 | 1 | -2/+2 |
| | | | | Change ActiveJob::Base.queue_adapter to use queue_adapter method to make test code consistent. | ||||
* | Removed deprecated support to passing the adapter class to .queue_adapter | Rafael Mendonça França | 2016-10-10 | 1 | -13/+0 |
| | |||||
* | use `descendants` to get class that inherited `ActiveJob::Base` | yuuji.yaginuma | 2016-09-05 | 3 | -0/+16 |
| | | | | | | `subclasses` get only child classes. Therefore, if create a job common parent class as `ApplicationJob`, inherited class does not get properly. | ||||
* | fixes remaining RuboCop issues [Vipul A M, Xavier Noria] | Xavier Noria | 2016-09-01 | 1 | -1/+1 |
| | |||||
* | Added instance variable `@queue` to JobWrapper. | InJung Chung | 2016-08-19 | 1 | -0/+7 |
| | | | | | This will fix issues in [resque-scheduler](https://github.com/resque/resque-scheduler) `#job_to_hash` method, so we can use `#enqueue_delayed_selection`, `#remove_delayed` method in resque-scheduler smoothly. | ||||
* | Yield the job instance so you have access to things like `job.arguments` on ↵ | David Heinemeier Hansson | 2016-08-16 | 2 | -3/+3 |
| | | | | the custom logic after retries fail | ||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -7/+7 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | code gardening: removes redundant selfs | Xavier Noria | 2016-08-08 | 2 | -2/+2 |
| | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required. | ||||
* | Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty lines | Ryuta Kamizono | 2016-08-07 | 3 | -4/+0 |
| | |||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 3 | -3/+0 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 10 | -24/+18 |
| | |||||
* | remove redundant curlies from hash arguments | Xavier Noria | 2016-08-06 | 1 | -3/+2 |
| | |||||
* | modernizes hash syntax in activejob | Xavier Noria | 2016-08-06 | 3 | -12/+12 |
| | |||||
* | applies new string literal convention in activejob/test | Xavier Noria | 2016-08-06 | 47 | -279/+279 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Fix tests against ActiveSupport::Durations | David Heinemeier Hansson | 2016-08-02 | 2 | -28/+47 |
| | |||||
* | Please Rubocup | David Heinemeier Hansson | 2016-08-02 | 1 | -2/+2 |
| | |||||
* | Not needed | David Heinemeier Hansson | 2016-08-01 | 1 | -1/+0 |
| | |||||
* | Allow for custom handling of exceptions that persist beyond the retry attempts | David Heinemeier Hansson | 2016-08-01 | 2 | -0/+7 |
| | |||||
* | Add exponentially_longer and custom wait algorithms | David Heinemeier Hansson | 2016-08-01 | 2 | -0/+43 |
| | |||||
* | Use descriptive exception names | David Heinemeier Hansson | 2016-08-01 | 2 | -20/+20 |
| | |||||
* | Reraise instead of swallow exceptions that occur beyond the retry attempts | David Heinemeier Hansson | 2016-07-29 | 1 | -1/+1 |
| | |||||
* | Satisfy pedantic rubocop whitespace detection | David Heinemeier Hansson | 2016-07-29 | 1 | -4/+4 |
| | |||||
* | Add retry_on/discard_on for better exception handling | David Heinemeier Hansson | 2016-07-29 | 2 | -0/+68 |
| | |||||
* | Fix accessing provider_job_id inside active jobs for sidekiq adapter | Azzurrio | 2016-07-28 | 2 | -0/+16 |
| | |||||
* | Fix AJ tests on ruby 2.4 being causes since classes are unified for Integer, ↵ | Vipul A M | 2016-07-09 | 1 | -1/+1 |
| | | | | and we create test name nased on arg class. Append ar as well to the test name | ||||
* | Fix jobs overriding AJ::Base#logger | Jean Boussier | 2016-06-17 | 2 | -1/+15 |
| | |||||
* | Provide the ability to override the queue adapter used by jobs under | Steve Lounsbury | 2016-06-11 | 1 | -0/+12 |
| | | | | | | | | | | | | | test. This PR adds a method called `queue_adapter_for_test` to `ActiveJob::TestHelper`. This method is expected to provide the queue adapter to be used for jobs under test. It maintains the current behaviour by defaulting to an instance of `ActiveJob::QueueAdapter::TestAdapter`. Tests that include `ActiveJob::TestHelper` or extend from `ActiveJob::TestCase` can provide a custom queue adapter by overriding `queue_adapter_for_test` in their class. | ||||
* | Chomp: prefer String#chomp where we can for a clarity boost | lvl0nax | 2016-04-29 | 1 | -1/+3 |
| | | | | | | Closes #24766, #24767 Signed-off-by: Jeremy Daer <jeremydaer@gmail.com> | ||||
* | Added more tests for reserved hash keys of ActiveJob::Arguments. | Santosh Wadghule | 2016-03-17 | 1 | -6/+7 |
| | | | | | | - Added tests for checking all reserved hash keys of ActiveJob::Arguments. - Moved unrelated code from the test to the correct place, i.e. newly created test. | ||||
* | Add JSON round trip verification testcase | Mike Perham | 2016-03-09 | 1 | -1/+16 |
| | |||||
* | Job payload should be symmetric across JSON dump/load | Mike Perham | 2016-03-09 | 1 | -3/+3 |
| | | | Placing non-native JSON data types, like symbols, in the hash to serialize means that the deserialize method will return something different from what was serialized, a common bug and source of frustration for devs. | ||||
* | Merge pull request #23932 from arthurnn/arthurnn/remove_load_paths | Arthur Nogueira Neves | 2016-03-01 | 1 | -2/+0 |
|\ | | | | | Remove load_paths file | ||||
| * | Remove load_paths file | Arthur Neves | 2016-02-27 | 1 | -2/+0 |
| | | |||||
* | | Merge pull request #23966 from ↵ | Jeremy Daer | 2016-03-01 | 4 | -48/+5 |
|\ \ | | | | | | | | | | | | | jeremy/activejob/pare-down-async-adapter-for-low-footprint-dev Active Job: pare down async adapter for low footprint dev | ||||
| * | | Active Job: smaller footprint for the dev/test async adapter | Jeremy Daer | 2016-02-29 | 4 | -48/+5 |
| |/ | | | | | | | | | Use one shared worker pool for all queues with 0-#CPU workers rather than separate pools per queue with 2-10*#CPU workers each. | ||||
* / | - Updating the dummy app template to have rails_command instead of rake | Mohit Natoo | 2016-03-01 | 1 | -1/+1 |
|/ | |||||
* | Remove celluloid from the Gemfile | Rafael Mendonça França | 2016-01-27 | 1 | -3/+1 |
| | |||||
* | Added support for bigdecimals in perform later | Siva Gollapalli | 2015-12-03 | 1 | -1/+1 |
| | |||||
* | Fix race condition testing for job execution order | Will Jessop | 2015-11-23 | 3 | -7/+18 |
| | | | | | | | | | | | | | | | On most filesystems file ctime is limited to 1 second granularity, which means that on faster computers multiple simple jobs (for instance dummy TestJob) can finish within the same second. The execution order test in ActiveJob integration tests relies on multiple TestJobs writing files then comparing the ctime. As a result integration tests would sometimes fail as the ctime of the files written by these TestJobs could have coincidental ctimes making the comparison for job order fail. This commit adds a far more precise execution time (to the extent that the Ruby Time class allows) to the file created by TestJob, and updates the execution order assertion to use it, removing the race condition. | ||||
* | Require only necessary concurrent-ruby classes. | Jerry D'Antonio | 2015-11-04 | 1 | -1/+0 |
| |