| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Keep executions for each specific exception (#34352) | Alberto Almagro | 2018-11-23 | 1 | -0/+22 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Keep executions for each specific declaration Fixes #34337 ActiveJob used the global executions counter to control the number of times a job should be retried. The problem with this approach was that in case a job raised different exceptions during its executions they weren't retried the number of times defined by their `attemps` number. **Example:** Having the following job: ```ruby class BuggyJob < ActiveJob::Base retry_on CustomException, attemps: 3 retry_on OtherException, attempts: 3 end ``` If the job raised `CustomException` in the first two executions and then it raised `OtherException`, the job wasn't retried anymore because the global executions counter was already indicating 3 attempts. With this patch each `retry_on` declaration has its specific counter so that the first two executions that raise `CustomException` don't affect the retries count that future exceptions may have. * Revert "clarifies documentation around the attempts arugment to retry_on" This reverts commit 86aa8f8c5631f77ed9a208e5107003c01512133e. | ||||
| * | Increment execution count before deserialize arguments | yuuji.yaginuma | 2018-08-18 | 1 | -0/+8 |
| | | | | | | | | | Currently, the execution count increments after deserializes arguments. Therefore, if an error occurs with deserialize, it retries indefinitely. In order to prevent this, the count is moved before deserialize. Fixes #33344. | ||||
| * | Allow passing multiple exceptions to retry_on/discard_on | George Claghorn | 2018-06-25 | 1 | -0/+18 |
| | | |||||
| * | Pass the error instance as the second parameter of block executed by ↵ | yuuji.yaginuma | 2018-05-12 | 1 | -1/+1 |
| | | | | | | | | | | | | `discard_on` I'm not sure what originally wanted to pass to the argument. However, as long as see the document added along with the commit, it seems just to be mistaken that trying to pass the error instance. https://github.com/rails/rails/pull/30622/files#diff-59beb0189c8c6bc862edf7fdb84ff5a7R64 Fixes #32853 | ||||
| * | Merge branch 'master' into custom-discarded-job-handling | Aidan Haran | 2017-12-09 | 1 | -1/+1 |
| |\ | |||||
| | * | Test exception message to ensure an exception instance is yielded | Kazunori Kajihiro | 2017-10-13 | 1 | -1/+1 |
| | | | |||||
| * | | Allow for custom handling of exceptions that are discarded | Aidan Haran | 2017-09-16 | 1 | -0/+7 |
| |/ | |||||
| * | [Active Job] `rubocop -a --only Layout/EmptyLineAfterMagicComment` | Koichi ITO | 2017-07-11 | 1 | -0/+1 |
| | | |||||
| * | Use frozen-string-literal in ActiveJob | Kir Shatrov | 2017-07-09 | 1 | -0/+1 |
| | | |||||
| * | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
| * | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | | |||||
| * | fixes remaining RuboCop issues [Vipul A M, Xavier Noria] | Xavier Noria | 2016-09-01 | 1 | -1/+1 |
| | | |||||
| * | Yield the job instance so you have access to things like `job.arguments` on ↵ | David Heinemeier Hansson | 2016-08-16 | 1 | -2/+2 |
| | | | | | the custom logic after retries fail | ||||
| * | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -15/+15 |
| | | |||||
| * | applies new string literal convention in activejob/test | Xavier Noria | 2016-08-06 | 1 | -11/+11 |
| | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
| * | Fix tests against ActiveSupport::Durations | David Heinemeier Hansson | 2016-08-02 | 1 | -28/+45 |
| | | |||||
| * | Please Rubocup | David Heinemeier Hansson | 2016-08-02 | 1 | -2/+2 |
| | | |||||
| * | Not needed | David Heinemeier Hansson | 2016-08-01 | 1 | -1/+0 |
| | | |||||
| * | Allow for custom handling of exceptions that persist beyond the retry attempts | David Heinemeier Hansson | 2016-08-01 | 1 | -0/+5 |
| | | |||||
| * | Add exponentially_longer and custom wait algorithms | David Heinemeier Hansson | 2016-08-01 | 1 | -0/+39 |
| | | |||||
| * | Use descriptive exception names | David Heinemeier Hansson | 2016-08-01 | 1 | -14/+14 |
| | | |||||
| * | Reraise instead of swallow exceptions that occur beyond the retry attempts | David Heinemeier Hansson | 2016-07-29 | 1 | -1/+1 |
| | | |||||
| * | Satisfy pedantic rubocop whitespace detection | David Heinemeier Hansson | 2016-07-29 | 1 | -4/+4 |
| | | |||||
| * | Add retry_on/discard_on for better exception handling | David Heinemeier Hansson | 2016-07-29 | 1 | -0/+47 |
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |