Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Append skipped jobs to enqueued_jobs | Alexander Pauly | 2017-01-31 | 1 | -7/+3 | |
| | | | | | | | | | | Refactored ActiveJob TestAdapter Updated ActiveJob changelog Fixed typo in changelog Fixed formatting issue in changelog | |||||
* | Merge pull request #27624 from elfassy/assert_enqueued_jobs_with_queue_level | Guillermo Iguaran | 2017-01-19 | 1 | -10/+24 | |
|\ | | | | | Specify the queue to be used with assert_enqueued_jobs | |||||
| * | assert_enqueued_jobs with queue option | Michael Elfassy | 2017-01-18 | 1 | -10/+24 | |
| | | ||||||
* | | s/perfomed/performed/ | Akira Matsuda | 2017-01-17 | 1 | -1/+1 | |
| | | | | | | | | [ci skip] | |||||
* | | remove unused require | yuuji.yaginuma | 2017-01-15 | 1 | -1/+0 | |
|/ | | | | `InlineAdapter` is not used from 1f8558f. | |||||
* | `self.` is not needed when calling its own instance method | Akira Matsuda | 2017-01-05 | 1 | -1/+1 | |
| | | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby | |||||
* | Revert "Merge pull request #27550 from ↵ | Rafael Mendonça França | 2017-01-03 | 1 | -1/+1 | |
| | | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine" This reverts commit 1e969bfb98b88799e2c759fce25a1d8cf00d7ce7, reversing changes made to a5041f267ded119c2d00b8786c2f2c1e3f93c8a1. Reason: It breaks the public API | |||||
* | Fix generator command for nested (namespaced) rails engine | Fumiaki MATSUSHIMA | 2017-01-03 | 1 | -1/+1 | |
| | | | | | | | | | | | | | If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In #6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not. | |||||
* | Bump license years for 2017 | Jon Moss | 2016-12-31 | 1 | -1/+1 | |
| | | | | | | | | Per https://www.timeanddate.com/counters/firstnewyear.html, it's already 2017 in a lot of places, so we should bump the Rails license years to 2017. [ci skip] | |||||
* | Privatize unneededly protected method in Active Job | Akira Matsuda | 2016-12-24 | 1 | -2/+2 | |
| | ||||||
* | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 1 | -5/+5 | |
| | ||||||
* | remove Ruby warning from Active Job test helper methods | yuuji.yaginuma | 2016-11-18 | 1 | -4/+4 | |
| | | | | | | | | | This removes the following warnings. ``` /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:241: warning: shadowing outer local variable - job /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:265: warning: shadowing outer local variable - job ``` | |||||
* | Use named parameters instead of `assert_valid_keys` | Maxime Boisvert | 2016-11-16 | 1 | -8/+8 | |
| | ||||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 8 | -8/+8 | |
| | ||||||
* | removes requires already present in active_support/rails | Xavier Noria | 2016-10-27 | 1 | -1/+0 | |
| | ||||||
* | Add examples of queue_adapter and perform_enqueued jobs to API Docs. | Gabi Stefanini | 2016-10-21 | 1 | -0/+24 | |
| | ||||||
* | add missing closing tag [ci skip] | yuuji.yaginuma | 2016-10-14 | 1 | -1/+1 | |
| | ||||||
* | Removed deprecated support to passing the adapter class to .queue_adapter | Rafael Mendonça França | 2016-10-10 | 1 | -10/+0 | |
| | ||||||
* | Removed deprecated #original_exception in ActiveJob::DeserializationError | Rafael Mendonça França | 2016-10-10 | 1 | -13/+1 | |
| | ||||||
* | Fixnum and Bignum are deprecated in Ruby trunk | Matthew Draper | 2016-10-08 | 1 | -2/+2 | |
| | | | | https://bugs.ruby-lang.org/issues/12739 | |||||
* | fix link to `resque` [ci skip] | yuuji.yaginuma | 2016-09-20 | 1 | -1/+1 | |
| | | | | | `1-x-stable` branch does not exist, `master` is 1.x branch. Ref: http://words.steveklabnik.com/rescuing-resque-again | |||||
* | use `descendants` to get class that inherited `ActiveJob::Base` | yuuji.yaginuma | 2016-09-05 | 1 | -1/+1 | |
| | | | | | | `subclasses` get only child classes. Therefore, if create a job common parent class as `ApplicationJob`, inherited class does not get properly. | |||||
* | fixes remaining RuboCop issues [Vipul A M, Xavier Noria] | Xavier Noria | 2016-09-01 | 1 | -1/+1 | |
| | ||||||
* | Add load hooks to all tests classes | Rafael Mendonça França | 2016-08-25 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | Usually users extends tests classes doing something like: ActionView::TestCase.include MyCustomTestHelpers This is bad because it will load the ActionView::TestCase right aways and this will load ActionController::Base making its on_load hooks to execute early than it should. One way to fix this is using the on_load hooks of the components like: ActiveSupport.on_load(:action_view) do ActionView::TestCase.include MyCustomTestHelpers end The problem with this approach is that the test extension will be only load when ActionView::Base is loaded and this may happen too late in the test. To fix this we are adding hooks to people extend the test classes that will be loaded exactly when the test classes are needed. | |||||
* | Merge pull request #26205 from pedaling-corp/fix/active-job-resque | Rafael Mendonça França | 2016-08-23 | 1 | -0/+1 | |
|\ | | | | | | | Add @queue variable to JobWrapper | |||||
| * | Added instance variable `@queue` to JobWrapper. | InJung Chung | 2016-08-19 | 1 | -0/+1 | |
| | | | | | | | | | | This will fix issues in [resque-scheduler](https://github.com/resque/resque-scheduler) `#job_to_hash` method, so we can use `#enqueue_delayed_selection`, `#remove_delayed` method in resque-scheduler smoothly. | |||||
* | | correct exception class in `retry_on` example [ci skip] | yuuji.yaginuma | 2016-08-20 | 1 | -2/+2 | |
|/ | | | | | If the deadlock has occurred `ActiveRecord::Deadlocked` will raise. Ref: #25107, #26059 | |||||
* | Yield the job instance so you have access to things like `job.arguments` on ↵ | David Heinemeier Hansson | 2016-08-16 | 1 | -3/+3 | |
| | | | | the custom logic after retries fail | |||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -2/+2 | |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | |||||
* | code gardening: removes redundant selfs | Xavier Noria | 2016-08-08 | 1 | -2/+2 | |
| | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required. | |||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 2 | -2/+0 | |
| | ||||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 5 | -91/+91 | |
| | ||||||
* | applies new string literal convention in activejob/lib | Xavier Noria | 2016-08-06 | 28 | -99/+99 | |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | |||||
* | Offer invitations to use retry_on/discard_on for common cases | David Heinemeier Hansson | 2016-08-04 | 1 | -0/+5 | |
| | ||||||
* | Guard against jobs that were persisted before we started counting executions ↵ | David Heinemeier Hansson | 2016-08-03 | 1 | -1/+3 | |
| | | | | by zeroing out nil counters | |||||
* | Fix tests against ActiveSupport::Durations | David Heinemeier Hansson | 2016-08-02 | 1 | -4/+9 | |
| | ||||||
* | Please Rubocup | David Heinemeier Hansson | 2016-08-02 | 1 | -3/+3 | |
| | ||||||
* | Allow for custom handling of exceptions that persist beyond the retry attempts | David Heinemeier Hansson | 2016-08-01 | 1 | -4/+14 | |
| | ||||||
* | Add exponentially_longer and custom wait algorithms | David Heinemeier Hansson | 2016-08-01 | 1 | -3/+25 | |
| | ||||||
* | Executions counting is not a serialization concern | David Heinemeier Hansson | 2016-08-01 | 2 | -1/+2 | |
| | | | | | Let’s do it when we actually execute instead. Then the tests dealing with comparable serializations won’t fail either! | |||||
* | Reraise instead of swallow exceptions that occur beyond the retry attempts | David Heinemeier Hansson | 2016-07-29 | 1 | -1/+2 | |
| | ||||||
* | Proper logging when we bail on retrying after X attempts | David Heinemeier Hansson | 2016-07-29 | 1 | -2/+6 | |
| | ||||||
* | Allow retries to happen with different priority and queue | David Heinemeier Hansson | 2016-07-29 | 1 | -2/+4 | |
| | ||||||
* | Require time extension for 3.seconds default | David Heinemeier Hansson | 2016-07-29 | 1 | -0/+2 | |
| | ||||||
* | Mention defaults | David Heinemeier Hansson | 2016-07-29 | 1 | -2/+2 | |
| | ||||||
* | Satisfy pedantic rubocop whitespace detection | David Heinemeier Hansson | 2016-07-29 | 1 | -2/+2 | |
| | ||||||
* | Remove needless require | David Heinemeier Hansson | 2016-07-29 | 1 | -2/+0 | |
| | ||||||
* | Add retry_on/discard_on for better exception handling | David Heinemeier Hansson | 2016-07-29 | 4 | -26/+87 | |
| | ||||||
* | Fix accessing provider_job_id inside active jobs for sidekiq adapter | Azzurrio | 2016-07-28 | 2 | -1/+2 | |
| | ||||||
* | Fix jobs overriding AJ::Base#logger | Jean Boussier | 2016-06-17 | 1 | -1/+1 | |
| |