Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Keep executions for each specific exception (#34352) | Alberto Almagro | 2018-11-23 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Keep executions for each specific declaration Fixes #34337 ActiveJob used the global executions counter to control the number of times a job should be retried. The problem with this approach was that in case a job raised different exceptions during its executions they weren't retried the number of times defined by their `attemps` number. **Example:** Having the following job: ```ruby class BuggyJob < ActiveJob::Base retry_on CustomException, attemps: 3 retry_on OtherException, attempts: 3 end ``` If the job raised `CustomException` in the first two executions and then it raised `OtherException`, the job wasn't retried anymore because the global executions counter was already indicating 3 attempts. With this patch each `retry_on` declaration has its specific counter so that the first two executions that raise `CustomException` don't affect the retries count that future exceptions may have. * Revert "clarifies documentation around the attempts arugment to retry_on" This reverts commit 86aa8f8c5631f77ed9a208e5107003c01512133e. | ||||
* | Extract `instrument` method. | Kasper Timm Hansen | 2018-09-23 | 1 | -26/+11 |
| | | | | Similar to Action View's and Action Controller's instrument helpers. | ||||
* | `retry_job` should publish `enqueue_retry.active_job` notification | bogdanvlviv | 2018-09-16 | 1 | -11/+17 |
| | | | | | | | | | | Also this commit removes `:wait` from payload of `retry_stopped.active_job`. Related to https://github.com/rails/rails/pull/33751#discussion_r214140008 Follow up #33751 /cc @kaspth, @rafaelfranca | ||||
* | clarifies documentation around the attempts arugment to retry_on | Graham Turner | 2018-09-09 | 1 | -1/+3 |
| | |||||
* | Move ActiveJob retry and discard logging into log subscriber | Steve S | 2018-08-30 | 1 | -5/+3 |
| | |||||
* | Add hooks to ActiveJob around retries and discards | Steve S | 2018-08-29 | 1 | -7/+25 |
| | |||||
* | Allow passing multiple exceptions to retry_on/discard_on | George Claghorn | 2018-06-25 | 1 | -7/+7 |
| | |||||
* | Fix name of the second parameter of block executed by `discard_on` and ↵ | bogdanvlviv | 2018-05-29 | 1 | -4/+4 |
| | | | | | | | | `retry_on` [ci skip] Follow up #32854 and ba07b5fc12a740d41d288bea6347f15f4948483c. | ||||
* | Pass the error instance as the second parameter of block executed by ↵ | yuuji.yaginuma | 2018-05-12 | 1 | -1/+1 |
| | | | | | | | | | | | `discard_on` I'm not sure what originally wanted to pass to the argument. However, as long as see the document added along with the commit, it seems just to be mistaken that trying to pass the error instance. https://github.com/rails/rails/pull/30622/files#diff-59beb0189c8c6bc862edf7fdb84ff5a7R64 Fixes #32853 | ||||
* | Merge branch 'master' into custom-discarded-job-handling | Aidan Haran | 2017-12-09 | 1 | -1/+1 |
|\ | |||||
| * | Yield with an error instance instead of error class | Kazunori Kajihiro | 2017-09-29 | 1 | -1/+1 |
| | | |||||
* | | Allow for custom handling of exceptions that are discarded | Aidan Haran | 2017-09-16 | 1 | -1/+11 |
|/ | |||||
* | [Active Job] `rubocop -a --only Layout/EmptyLineAfterMagicComment` | Koichi ITO | 2017-07-11 | 1 | -0/+1 |
| | |||||
* | Use frozen-string-literal in ActiveJob | Kir Shatrov | 2017-07-09 | 1 | -0/+1 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -1/+1 |
| | |||||
* | add missing closing tag [ci skip] | yuuji.yaginuma | 2016-10-14 | 1 | -1/+1 |
| | |||||
* | correct exception class in `retry_on` example [ci skip] | yuuji.yaginuma | 2016-08-20 | 1 | -2/+2 |
| | | | | | If the deadlock has occurred `ActiveRecord::Deadlocked` will raise. Ref: #25107, #26059 | ||||
* | Yield the job instance so you have access to things like `job.arguments` on ↵ | David Heinemeier Hansson | 2016-08-16 | 1 | -3/+3 |
| | | | | the custom logic after retries fail | ||||
* | applies new string literal convention in activejob/lib | Xavier Noria | 2016-08-06 | 1 | -1/+1 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Fix tests against ActiveSupport::Durations | David Heinemeier Hansson | 2016-08-02 | 1 | -4/+9 |
| | |||||
* | Please Rubocup | David Heinemeier Hansson | 2016-08-02 | 1 | -3/+3 |
| | |||||
* | Allow for custom handling of exceptions that persist beyond the retry attempts | David Heinemeier Hansson | 2016-08-01 | 1 | -4/+14 |
| | |||||
* | Add exponentially_longer and custom wait algorithms | David Heinemeier Hansson | 2016-08-01 | 1 | -3/+25 |
| | |||||
* | Reraise instead of swallow exceptions that occur beyond the retry attempts | David Heinemeier Hansson | 2016-07-29 | 1 | -1/+2 |
| | |||||
* | Proper logging when we bail on retrying after X attempts | David Heinemeier Hansson | 2016-07-29 | 1 | -2/+6 |
| | |||||
* | Allow retries to happen with different priority and queue | David Heinemeier Hansson | 2016-07-29 | 1 | -2/+4 |
| | |||||
* | Require time extension for 3.seconds default | David Heinemeier Hansson | 2016-07-29 | 1 | -0/+2 |
| | |||||
* | Mention defaults | David Heinemeier Hansson | 2016-07-29 | 1 | -2/+2 |
| | |||||
* | Satisfy pedantic rubocop whitespace detection | David Heinemeier Hansson | 2016-07-29 | 1 | -2/+2 |
| | |||||
* | Remove needless require | David Heinemeier Hansson | 2016-07-29 | 1 | -2/+0 |
| | |||||
* | Add retry_on/discard_on for better exception handling | David Heinemeier Hansson | 2016-07-29 | 1 | -0/+78 |