aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge pull request #27692 from y-yagi/make_render_work_with_ac_paramsEileen M. Uchitelle2017-01-161-1/+5
|\ \ \ \ | | | | | | | | | | make `render` work with AC::Params
| * | | | make `render` work with AC::Paramsyuuji.yaginuma2017-01-151-1/+5
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 4.2, since AC::Params inherited `Hash`, processing in the case of `Hash` was done. But in 5.x, since AC::Params does not inherit `Hash`, need to add care for AC::Params. Related to 00285e7cf75c96553719072a27c27e4ab7d25b40
* | | | Update comment for Scrubber usage [ci skip]kenta-s2017-01-161-6/+4
| | | |
* | | | Allow render locals to be assigned to instance variablesAndrew White2017-01-154-1/+12
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | In #26672 we blocked use of Ruby keywords as identifiers for view locals but inadvertently broke the use of instance variable names as identifiers. Whilst not explicitly documented this behavior has been around for a long time and there's no need to break it now. Fixes #27480.
* | | Fix broken sample code in action_view/helpers/output_safety_helper.rb [ci skip]kenta-s2017-01-151-1/+1
|/ /
* | Fix grammar in asset_url_helper.rb [ci skip]kenta-s2017-01-131-3/+3
| |
* | class Foo < Struct.new(:x) creates an extra unneeded anonymous classAkira Matsuda2017-01-136-12/+10
| | | | | | | | because Struct.new returns a Class, we just can give it a name and use it directly without inheriting from it
* | Fix typo extention -> extension [ci skip]kenta-s2017-01-131-1/+1
|/
* Reduce string objects by using \ instead of + or << for concatenating stringsAkira Matsuda2017-01-129-528/+528
| | | | (I personally prefer writing one string in one line no matter how long it is, though)
* Use Encoding::UTF_8 constant for default_{internal,external} in the testsAkira Matsuda2017-01-111-2/+2
|
* Remove unneeded Deprecation silenceRafael Mendonça França2017-01-061-5/+3
|
* `self.` is not needed when calling its own instance methodAkira Matsuda2017-01-056-7/+7
| | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
* Merge pull request #27549 from mpugach/consider_params_in_current_pageRafael França2017-01-043-2/+20
|\ | | | | Add "check_parameters" option to "current_page?"
| * Add `check_parameters` option to `current_page?`Maksym Pugach2017-01-043-2/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: For "http://www.example.com/shop/checkout?order=desc&page=1" current_page?('http://www.example.com/shop/checkout') => true current_page?( 'http://www.example.com/shop/checkout', check_parameters: true ) => false
* | Fix typo s/permited/permitted/Ryuta Kamizono2017-01-041-2/+2
| | | | | | | | | | | | | | | | | | ``` % git grep -n permited actionview/test/template/url_helper_test.rb:238: def test_button_to_with_permited_strong_params actionview/test/template/url_helper_test.rb:245: def test_button_to_with_unpermited_strong_params activerecord/test/cases/relations_test.rb:1620: def test_update_on_relation_passing_active_record_object_is_not_permited ```
* | Generate indexed names in input even when objects are not persistedRafael Mendonça França2017-01-032-6/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When you ask to generate multiple nested inputs using: field_for('comments[]', Comment.new) do |c| c.text_field :body Rails should generated the names like `post[comments][][body]`. To make sure we don't have regression the fake models now use the same implementation of `#to_param` as `ActiveRecord::Base` Fixes #26942
* | Prevent duplicate data-disable-with attributesTyler Hunt2017-01-032-14/+25
|/ | | | | | When using the hash form of the data option, prevent duplicate data-disable-with attributes from appearing in the submit tag due to both string and symbol forms of the hash key being present.
* Bump license years for 2017Jon Moss2016-12-312-2/+2
| | | | | | | | Per https://www.timeanddate.com/counters/firstnewyear.html, it's already 2017 in a lot of places, so we should bump the Rails license years to 2017. [ci skip]
* Merge pull request #27463 from y-yagi/fix_26931Rafael França2016-12-283-2/+11
|\ | | | | do not mutate `object_name` of class in `fields_for`
| * do not mutate `object_name` of class in `fields_for`yuuji.yaginuma2016-12-273-2/+11
| | | | | | | | | | | | Since it affects the entire form, should not mutate `object_name` of class. Fixes #26931
* | Fix Rubocop violations and fix documentation visibilityRafael Mendonça França2016-12-287-33/+32
| | | | | | | | | | | | Some methods were added to public API in 5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of the public API.
* | Fix typo in action_view/template.rb [ci skip]kenta-s2016-12-281-1/+1
|/
* assert_equal takes expectation firstAkira Matsuda2016-12-261-5/+5
|
* "Use assert_nil if expecting nil. This will fail in minitest 6."Akira Matsuda2016-12-254-16/+16
|
* self. is not needed when calling its own instance methodAkira Matsuda2016-12-241-2/+1
|
* Privatize unneededly protected methods in Action ViewAkira Matsuda2016-12-247-39/+32
|
* No need to nodoc private methodsAkira Matsuda2016-12-249-20/+20
|
* Wrong rake task name in the documentAkira Matsuda2016-12-241-1/+1
| | | | [ci skip]
* Privatize unneededly protected methods in Action View testsAkira Matsuda2016-12-235-5/+5
|
* Describe what we are protectingAkira Matsuda2016-12-231-0/+2
|
* Unneeded attr_accessor with side effectsAkira Matsuda2016-12-232-8/+0
|
* Fix grammar in asset tag documentationeileencodes2016-12-201-1/+1
| | | | | Updated the docmentation because "options supports" is not grammatically correct.
* Improve `javascript_include_tag` documentation (#27403)Pablo Ifrán2016-12-201-5/+24
| | | | Add all the available options, and correct the samples of the `javascript_include_tag`.
* fields: support attributes not on model.Kasper Timm Hansen2016-12-182-0/+37
| | | | Ensure the support works like form_with.
* [ci skip] fields don't output ids by default anymore.Kasper Timm Hansen2016-12-181-2/+2
|
* form_with: allow methods outside the model.Kasper Timm Hansen2016-12-183-16/+96
| | | | | | | | Has the handy effect of making the initial examples in the form_with docs work too. Had to do some finagling such that form_with's without a scope didn't wrap their names in braces ala `[title]`.
* [ci skip] Replace remote with local in form_with doc.Kasper Timm Hansen2016-12-181-1/+1
| | | | Remote is gone, long live local.
* Make attributes output in html opt-in.Kasper Timm Hansen2016-12-181-1/+1
| | | | | | | | | | By using `except` any option provided to `form_with` would become an html attribute unless explicitly opted out. This proved annoying when adding new internal keys in the options hash and seeing them pop up in the html output. Prevent this by inverting the `except` to `slice` out the keys we want to allow becoming html attributes, like id and class.
* Add missing option on numbers helperPablo Ifran2016-12-171-0/+6
| | | | | The `delimiter_pattern` option was not present on the documentaion of the helper.
* Merge pull request #27367 from georgeclaghorn/local-form-withKasper Timm Hansen2016-12-152-4/+10
|\ | | | | Avoid invalid attribute on local forms generated by `form_with`
| * Avoid invalid attribute on local forms generated by `form_with`George Claghorn2016-12-152-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | Fixes that the following ERB template would result in invalid HTML output: <%= form_with model: Post.new, local: true do |form| %> <% end %> Specifically, the resulting form tag would have a spurious `remote` attribute: <form remote="false" ...>
* | Add missing spaces to button_tag api doc [ci skip] (#27369)Andreas Maierhofer2016-12-151-1/+1
|/
* form_with/fields: Don't output ids by defaultKasper Timm Hansen2016-12-134-206/+243
| | | | | | | | | | | Continuing 67f81cc where we decided not to output ids by default in the new form helpers. Went with @dhh's suggestion of just requiring ids on fields being labelled: https://github.com/rails/rails/issues/25197#issuecomment-231797117 Seems okay enough.
* split DELEGATION_RESERVED_METHOD_NAMES in halfToshimaru2016-12-094-6/+12
|
* Enable `block` variable in viewToshimaru2016-12-093-1/+6
| | | | Remove `block` keyword from reserved method names
* Merge pull request #27271 from printercu/permantent_digest_in_testsMatthew Draper2016-12-082-1/+9
|\ | | | | Don't clear digest cache in test environment
| * Fixed usage of cache_template_loadingMax Melentiev2016-12-062-1/+9
| | | | | | | | It disables recompilation of templates on every request in test env.
* | Update url_helper.rb, adjust link_to api docAndreas Maierhofer2016-12-051-4/+3
|/ | | | | Removed references to `button` in the `link_to` `disable_with` api description.
* Merge pull request #27258 from y-yagi/stop_using_removed_render_textKasper Timm Hansen2016-12-031-1/+1
|\ | | | | stop using removed `render :text`
| * stop using removed `render :text`yuuji.yaginuma2016-12-031-1/+1
| | | | | | | | Follow up to 79a5ea9eadb4d43b62afacedc0706cbe88c54496
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 08:53:49 +0000