Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Expand select documentation to tell about the block | Rafael Mendonça França | 2013-09-23 | 1 | -0/+9 |
| | | | | [ci skip] | ||||
* | Use ERB in the CHANGELOG [ci skip] | Rafael Mendonça França | 2013-09-23 | 1 | -3/+5 |
| | |||||
* | Ability to pass block to AV#select helper | Bogdan Gusiev | 2013-09-23 | 4 | -5/+29 |
| | | | | | | | | Example: = select(report, "campaign_ids") do - available_campaigns.each do |c| %option{:data => {:tags => c.tags.to_json}, :value => c.id}= c.name | ||||
* | handle `:namespace` form option in collection labels | Vasiliy Ermolovich | 2013-09-22 | 4 | -1/+43 |
| | |||||
* | Merge pull request #12232 from claudiob/delete-unused-helper-fixtures | Santiago Pastorino | 2013-09-20 | 4 | -16/+0 |
|\ | | | | | Remove unused AV helper fixtures from e10a2531 | ||||
| * | Remove unused AV helper fixtures from e10a2531 | claudiob | 2013-09-14 | 4 | -16/+0 |
| | | | | | | | | | | Several fixtures for helpers are removed. They were introduced in ActionView by @strzalek but never referenced in any test. | ||||
* | | Bust the template digest cache key when details are changed | Daniel Schierbeck | 2013-09-19 | 3 | -2/+39 |
| | | | | | | | | | | | | Since the lookup details will influence which template is resolved, they need to be included in the cache key -- otherwise two different templates may erroneously share the same digest value. | ||||
* | | There's no need to do this | Santiago Pastorino | 2013-09-17 | 1 | -4/+1 |
|/ | | | | | | | AS does the following inside Time.find_zone! ... `ActiveSupport::TimeZone[time_zone] || TZInfo::Timezone.get(time_zone)` and given that the test is stubbing AS::TZ[] we don't need the removed code. | ||||
* | "generates" applies to "collection radio" so it should be singular | Waynn Lue | 2013-09-12 | 1 | -2/+2 |
| | | | I accidentally pushed this change to docrails before realizing that it's technically a code change, so I'm opening this pull request (and rolling back my change to docrails). | ||||
* | Merge pull request #12112 from adamniedzielski/fix-form-for-namespace-and-as | Rafael Mendonça França | 2013-09-12 | 3 | -1/+21 |
|\ | | | | | | | | | | | | | form_for - fix :namespace and :as options clash Conflicts: actionview/CHANGELOG.md | ||||
| * | form_for - fix :namespace and :as options clash | Adam Niedzielski | 2013-09-09 | 3 | -1/+21 |
| | | | | | | | | | | | | | | | | :as option should not overwrite :namespace option when generating html id attribute of the form element. id should be prefixed by specified namespace even if :as option is present Add test case showing the issue and code fixing it | ||||
* | | Write the right CHANGELOG entry for #11603 | Rafael Mendonça França | 2013-09-12 | 1 | -1/+1 |
| | | | | | | | | [ci skip] | ||||
* | | Merge pull request #11603 from ↵ | Rafael Mendonça França | 2013-09-12 | 3 | -2/+10 |
|\ \ | | | | | | | | | | | | | | | | jetthoughts/join_strings_instead_of_contactination Cleanup: replace String concatenation by joining for excerpt helper | ||||
| * | | Cleanup of excerpt helper | Paul Nikitochkin | 2013-09-06 | 3 | -2/+10 |
| |/ | | | | | | | | | * replaced String concatenation by joining * separator has default value to '', even it is nil | ||||
* | | Merge pull request #12173 from arunagw/fixes_reverted_by_revert_commit | Guillermo Iguaran | 2013-09-10 | 1 | -1/+1 |
|\ \ | | | | | | | Revert fixes | ||||
| * | | Back AV description in gemspec | Arun Agrawal | 2013-09-09 | 1 | -1/+1 |
| |/ | |||||
* | | Remove helper fixtures not used in any test | claudiob | 2013-09-09 | 1 | -2/+0 |
| | | | | | | | | | | | | The fixture for module AbcHelper defines three functions bare_a, bare_b and bare_c, but only bare_a is used in the code that tests helper functions. | ||||
* | | Remove remaining coupling with AV in MimeResponds | José Valim | 2013-09-09 | 1 | -0/+7 |
| | | |||||
* | | Remove BasicRendering and remove template functionality from AbsC::Rendering | José Valim | 2013-09-09 | 1 | -7/+5 |
|/ | |||||
* | Fix failure with minitest 5.0.7 | Carlos Antonio da Silva | 2013-09-06 | 1 | -0/+1 |
| | | | | | | | | | | | | | Require minitest/mock in test where stub method is needed. Apparently this was being "imported" by minitest pride plugin, which previously required "minitest/autorun", that required "minitest/mock", making the method available by chance. It has been changed in minitest: https://github.com/seattlerb/minitest/commit/595ce955c0d89575726d10fc18d2afd8f334bcbe So we need to make sure we require what we really need where necessary. | ||||
* | Merge pull request #12143 from rajcybage/fixing_typos | Carlos Antonio da Silva | 2013-09-05 | 1 | -1/+1 |
|\ | | | | | fix actionview and activemodel test cases typos | ||||
| * | fix actionview and activemodel test cases typos | Rajarshi Das | 2013-09-05 | 1 | -1/+1 |
| | | |||||
* | | Fix method name typos | Vipul A M | 2013-09-05 | 2 | -2/+2 |
| | | |||||
* | | Fix a few typos. [ci skip] | namusyaka | 2013-09-04 | 1 | -2/+2 |
| | | |||||
* | | Move skeleton methods from AV to AbsC | Łukasz Strzałkowski | 2013-09-03 | 1 | -22/+0 |
| | | | | | | | | | | | | | | | | | | | | The methods: * #render_to_body * #render_to_string * #_normalize_render Haven't had anything specyfic to ActionView. This was common code which should belong to AbstractController | ||||
* | | Return to using protected_instance_variables in AV | Łukasz Strzałkowski | 2013-09-02 | 1 | -4/+0 |
| | | |||||
* | | fix the typo [ci skip] | Rajarshi Das | 2013-09-02 | 1 | -1/+1 |
|/ | | | fix the typo newstopics => new topics in action view cache helper | ||||
* | Improve CHANGELOG entry [ci skip] | Rafael Mendonça França | 2013-08-27 | 1 | -4/+2 |
| | |||||
* | Merge pull request #11768 from cloudspace/cache_template_loading | Rafael Mendonça França | 2013-08-27 | 3 | -5/+24 |
|\ | | | | | Only cache template digests if !config.cache_template_loading | ||||
| * | Only cache template digests if config.cache_template_loading | Josh Lauer | 2013-08-06 | 3 | -5/+24 |
| | | | | | | | | | | | | since ActionView::Resolver.caching is set to the same value as config.cache_template_loading only cache template digests if config.cache_template_loading is not falsy fixes issues #10752 and #10791 | ||||
* | | Move abstract's controller tests to AV | Łukasz Strzałkowski | 2013-08-25 | 21 | -0/+917 |
| | | | | | | | | The ones that were actually testing AV functionality and should belong in there | ||||
* | | Move actionpack's controller tests | Łukasz Strzałkowski | 2013-08-25 | 4 | -12/+12 |
| | | |||||
* | | Load HTML in ActionView not ActionPack | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+1 |
| | | | | | | | | HTML Scanner is part of ActionView and it should be loaded along with it | ||||
* | | Move AP's capture tests to AV | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+81 |
| | | |||||
* | | Move remaining layouts tests to AV | Łukasz Strzałkowski | 2013-08-25 | 17 | -0/+288 |
| | | |||||
* | | Add AP tests to runner | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+9 |
| | | |||||
* | | Cleanup & reorganise rake tasks in AV | Łukasz Strzałkowski | 2013-08-25 | 1 | -16/+13 |
| | | |||||
* | | Split rendering tests between AP & AV | Łukasz Strzałkowski | 2013-08-25 | 1 | -248/+13 |
| | | | | | | | | All rendering test remain in AV. Head, ETag etc. test stay in AP | ||||
* | | Move render_test to AV | Łukasz Strzałkowski | 2013-08-25 | 92 | -0/+1722 |
| | | |||||
* | | Fist stab on basic rendering | Łukasz Strzałkowski | 2013-08-25 | 1 | -2/+0 |
| | | |||||
* | | Add #rendered_format method to controllers | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+4 |
| | | |||||
* | | Add missing requires inside AV | Łukasz Strzałkowski | 2013-08-25 | 4 | -1/+8 |
| | | |||||
* | | Do not load AV inside AP | Łukasz Strzałkowski | 2013-08-25 | 2 | -0/+2 |
| | | | | | | | | Move that part to AV railtie | ||||
* | | Add missing require | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+2 |
| | | |||||
* | | Revert "Move setting content_type to AV" | Łukasz Strzałkowski | 2013-08-25 | 2 | -3/+1 |
| | | | | | | | | This reverts commit f4d602aff6cec80304b131ecfcc2676d0304f0cc. | ||||
* | | Move setting content_type to AV | Łukasz Strzałkowski | 2013-08-25 | 2 | -1/+3 |
| | | |||||
* | | Use concat to avoid allocating additional array | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+1 |
| | | |||||
* | | Pass args to render's super method | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+2 |
| | | |||||
* | | Improve AV::Rendering docs | Łukasz Strzałkowski | 2013-08-25 | 1 | -2/+8 |
| | | |||||
* | | Include AV::Layouts before setting view_paths | Łukasz Strzałkowski | 2013-08-25 | 1 | -2/+2 |
| | |