Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | Allow non-English values for collection_radio_buttons/check_boxes | colorfulfool | 2017-08-02 | 2 | -1/+15 | |
| |/ / / | ||||||
* / / / | Use File::NULL instead of "/dev/null" | Kazuhiro NISHIYAMA | 2017-07-31 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | Merge pull request #30001 from y-yagi/fix_test_directory | Kasper Timm Hansen | 2017-07-30 | 3 | -3/+3 | |
|\ \ \ | | | | | | | | | Fix test directory to correct path | |||||
| * | | | Fix test directory to correct path | yuuji.yaginuma | 2017-07-30 | 3 | -3/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Together, fix to the following lint violation. ``` rails/actionview/test/ujs/public/test/data-confirm.js 303:11 error Strings must use singlequote quotes rails/actionview/test/ujs/public/test/data-remote.js 414:32 error Extra semicolon semi ✖ 2 problems (2 errors, 0 warnings) ``` | |||||
* | | | | Fix testing helpers that use Action View's capturing helpers (e.g. content_for) | George Claghorn | 2017-07-25 | 2 | -0/+10 | |
|/ / / | ||||||
* | | | Suppress warning from actionview controller helper. | Christina Thompson | 2017-07-24 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | Explicitly pass a destructed array to the delegate method. Signed-off-by: Yuki Nishijima <yk.nishijima@gmail.com> | |||||
* | | | Merge pull request #29897 from kirs/frozen-actionview | Rafael França | 2017-07-24 | 177 | -1/+350 | |
|\ \ \ | | | | | | | | | Use frozen string literal in actionview/ | |||||
| * | | | Use frozen string literal in actionview/ | Kir Shatrov | 2017-07-24 | 177 | -1/+350 | |
| | | | | ||||||
* | | | | Merge pull request #29792 from lugray/delegate_respond_to | Rafael França | 2017-07-24 | 2 | -2/+21 | |
|\ \ \ \ | |/ / / |/| | | | Delegate respond_to? in ActionView::Helpers::ControllerHelper | |||||
| * | | | Delegate respond_to? in ActionView::Helpers::ControllerHelper | Lisa Ugray | 2017-07-19 | 2 | -2/+21 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Since methods defined in the controller helper are mostly delegated to the controller, delegate respond_to? as well, so that for example `respond_to?(:params)` behaves as expected. | |||||
* | | | | Make actionview ready for frozen strings | Kir Shatrov | 2017-07-23 | 1 | -1/+2 | |
| | | | | ||||||
* | | | | Merge pull request #29884 from padi/update_rails_5_upgrade_guide | Rafael França | 2017-07-21 | 1 | -2/+2 | |
|\ \ \ \ | | | | | | | | | | | Updates Rails upgrade guide on `ActionView::Helpers::RecordTagHelper` | |||||
| * | | | | Suppress documentation for content_tag_for and div_for since they were ↵ | Marc Rendl Ignacio | 2017-07-21 | 1 | -2/+2 | |
| | |/ / | |/| | | | | | | | | | | removed already | |||||
* | | | | Remove log directory in test postprocessing | yuuji.yaginuma | 2017-07-21 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | The "log" is directory. So it is necessary to use `FileUtils.rm_rf`. | |||||
* | | | | Add jQuery to test vendor files | Marc Rendl Ignacio | 2017-07-20 | 2 | -1/+9832 | |
| |/ / |/| | | | | | | | | | | | ... so that we can run most, if not all, of rails-ujs tests without necessarily requiring an internet connection. | |||||
* | | | [ci skip]Replace jquery-ujs with rails-ujs | willnet | 2017-07-19 | 1 | -1/+1 | |
| | | | ||||||
* | | | Enable `Layout/FirstParameterIndentation` cop | Ryuta Kamizono | 2017-07-17 | 2 | -24/+24 | |
|/ / | | | | | | | | | | | | | We have some indentation cops. But now there is a little inconsistent params indentations. Enable `Layout/FirstParameterIndentation` cop to prevent newly inconsistent indentation added and auto-correct to existing violations. | |||||
* | | [Action View] `rubocop -a --only Layout/EmptyLineAfterMagicComment` | Koichi ITO | 2017-07-11 | 3 | -0/+3 | |
| | | ||||||
* | | Prepare AP and AR to be frozen string friendly | Kir Shatrov | 2017-07-06 | 2 | -1/+3 | |
| | | ||||||
* | | Merge branch 'master' into require_relative_2017 | Xavier Noria | 2017-07-02 | 24 | -236/+257 | |
|\ \ | ||||||
| * | | Expectation first | Akira Matsuda | 2017-07-02 | 2 | -8/+8 | |
| | | | ||||||
| * | | Avoid shadowed variable | Matthew Draper | 2017-07-02 | 1 | -2/+2 | |
| | | | ||||||
| * | | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 191 | -191/+1 | |
| | | | | | | | | | | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | |||||
| * | | Merge pull request #29540 from kirs/rubocop-frozen-string | Matthew Draper | 2017-07-02 | 191 | -1/+191 | |
| |\ \ | | | | | | | | | | | | | Enforce frozen string in Rubocop | |||||
| | * | | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 191 | -1/+191 | |
| | | | | ||||||
| * | | | Merge pull request #29506 from pat/frozen-string-literals | Matthew Draper | 2017-07-02 | 21 | -225/+225 | |
| |\ \ \ | | | | | | | | | | | | | | | | Make ActiveSupport frozen-string-literal friendly. | |||||
| | * | | | Make ActionView frozen string literal friendly. | Pat Allan | 2017-06-20 | 19 | -220/+220 | |
| | | | | | | | | | | | | | | | | | | | | Plus a couple of related ActionPack patches. | |||||
| | * | | | Make ActionMailer frozen string literal friendly. | Pat Allan | 2017-06-20 | 2 | -3/+3 | |
| | | | | | ||||||
| | * | | | Make ActiveModel frozen string literal friendly. | Pat Allan | 2017-06-20 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | Includes two external changes because they're referenced within the ActiveModel test suite. | |||||
| * | | | | Merge pull request #29349 from robertomiranda/responsive-images | Matthew Draper | 2017-07-02 | 3 | -3/+24 | |
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | Add srcset option to image_tag helper | |||||
| | * | | | | Add `srcset` option to `image_tag` helper | Roberto Miranda | 2017-06-29 | 3 | -2/+23 | |
| | | |/ / | | |/| | | ||||||
* | / | | | [Action View] require => require_relative | Akira Matsuda | 2017-07-01 | 25 | -35/+35 | |
|/ / / / | ||||||
* / / / | Fallback Parameters#to_s to Hash#to_s | Kir Shatrov | 2017-06-30 | 1 | -0/+6 | |
|/ / / | | | | | | | Fixes https://github.com/rails/rails/issues/29617 | |||||
* | | | Merge pull request #29588 from greysteil/add-gemspec-links | Rafael França | 2017-06-28 | 1 | -0/+5 | |
|\ \ \ | | | | | | | | | Add source code and changelog links to gemspecs | |||||
| * | | | Add source code and changelog links to gemspecs | Grey Baker | 2017-06-28 | 1 | -0/+5 | |
| | | | | ||||||
* | | | | :scissors: | Ryuta Kamizono | 2017-06-28 | 1 | -4/+4 | |
|/ / / | | | | | | | | | | [ci skip] | |||||
* | | | Add changes to CHANGELOG | savroff | 2017-06-19 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | | | fix fix | |||||
* | | | Fix current_page? helper issue with engine root path | savroff | 2017-06-19 | 2 | -4/+17 | |
|/ / | ||||||
* | | Use `require_relative` instead of `require` with full path | bogdanvlviv | 2017-06-14 | 1 | -1/+1 | |
| | | ||||||
* | | Generate field ids in `collection_check_boxes` and `collection_radio_buttons` | yuuji.yaginuma | 2017-06-11 | 4 | -18/+28 | |
| | | | | | | | | | | This makes sure that the labels are linked up with the fields. Fixes #29014 | |||||
* | | Don't rely on the @view_renderer being defined. | Kasper Timm Hansen | 2017-06-08 | 1 | -2/+2 | |
| | | | | | | | | That won't be true for Action Pack and Action Mailer. | |||||
* | | Merge pull request https://github.com/rails/rails/pull/28637 from ↵ | Kasper Timm Hansen | 2017-06-08 | 6 | -33/+42 | |
| | | | | | | | | st0012/fix-partial-cache-logging | |||||
* | | Use a hash to record every partial's cache hit status instead of sharing a ↵ | Stan Lo | 2017-06-08 | 7 | -3/+51 | |
| | | | | | | | | boolean. | |||||
* | | Don't support namespace in form_with. | Kasper Timm Hansen | 2017-06-07 | 1 | -18/+0 | |
| | | | | | | | | | | form_with requires people to pass an id manually, so users can just prefix their namespace right there. | |||||
* | | Move slicing to initializer. | Kasper Timm Hansen | 2017-06-07 | 2 | -2/+2 | |
| | | | | | | | | | | | | Forgot all about https://github.com/rails/rails/pull/28844/files#r113780934 cc @rafaelfranca | |||||
* | | Use mattr_accessor default: option throughout the project | Genadi Samokovarov | 2017-06-03 | 7 | -25/+13 | |
|/ | ||||||
* | Merge pull request #29187 from robin850/remove-mathn | Rafael França | 2017-05-30 | 1 | -3/+11 | |
|\ | | | | | Remove requirement on mathn | |||||
| * | Remove requirement on mathn | Robin Dupret | 2017-05-30 | 1 | -3/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | The test using mathn was first introduced in f1d9179 to check that the `distance_of_time_in_words` properly doesn't use the `Fixnum#/` method by explicitly requiring this library as it redefines this method. Given that `mathn` has been gemified in Ruby 2.5 and is deprecated since version 2.2, we can certainly safely assume that people will most-likely not require this library in their application. However, to make sure that we don't regress, let's add a test similar to the one before f1d9179. | |||||
* | | Grammar fixes | Jon Moss | 2017-05-29 | 1 | -2/+3 | |
| | | | | | | | | [ci skip] | |||||
* | | Merge pull request #29191 from ↵ | Kasper Timm Hansen | 2017-05-29 | 1 | -1/+1 | |
|\ \ | | | | | | | | | | | | | bogdanvlviv/pass_params_filename_lineno_to_class_eval Pass params __FILE__ and __LINE__ + 1 if class_eval with << |