| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| | |
[ci skip] remove duplicate doc for current_page?
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
JackDanger/danger/use-default-view-pattern-in-docs
[docs] Using the real resolver pattern in docs
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If someone copies the docs into their app they'll find it simply doesn't
work because the locale pattern doesn't have the same logic. This makes
the doc examples work exactly as written.
[ci skip]
|
| |\ \ \
| | | |
| | | | |
fix for actionview parent layout bug
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This commit fixes issue #19626
Don't need to check layout conditions if there is no condition
test for parent layout bug fix
|
| |\ \ \ \
| |/ / /
|/| | | |
Accept lambda as child_index option in #fields_for method
|
| | | | | |
|
| |/ / / |
|
| |\ \ \
| | | |
| | | | |
correct output of auto_discovery_link_tag [ci skip]
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
Allow an array to be a default translation value.
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
4.2.1 introduced a change to the way `translate`/`t` works with an
option of `default: [[]]`. In 4.2.0, this would give a default value of
`[]`, but in 4.2.1, it leads to a missing translation.
`default: [[]]` is again allowed for cases where a default of `[]` is
needed.
This addresses GitHub issue 19640.
|
| |/ / / |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
https://github.com/ruby/ruby/pull/579 - there is a new optimization
since ruby 2.2
Previously regexp patterns were faster (since a string was converted to
regexp underneath anyway). But now string patterns are faster and
better reflect the purpose.
Benchmark.ips do |bm|
bm.report('regexp') { 'this is ::a random string'.gsub(/::/, '/') }
bm.report('string') { 'this is ::a random string'.gsub('::', '/') }
bm.compare!
end
# string: 753724.4 i/s
# regexp: 501443.1 i/s - 1.50x slower
|
| | |/
|/| |
|
| |\ \
| | |
| | | |
[ci skip] Unify the code comment in ActionView::Renderer#render_template...
|
| | | | |
|
| |/ / |
|
| |\ \
| | |
| | |
| | |
| | | |
Conflicts:
guides/source/4_0_release_notes.md
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
No need to merge hashes when simply setting options does the job.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The previous change 92a3c8dcdf174dab5e8759031b6bbe6cd891fe3c improved
this example, but calling .create + #valid? ends up running validations
twice, and we don't want to showcase that.
Lets use the normal use case of building a new object and calling #save
on it, which is what a basic scaffold with Active Record does.
[ci skip]
|
| | | | |
|
| | | |
| | |
| | |
| | | |
Strip nils out of default translations. Fixes #19419
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Preserving RACK_ENV behavior.
This reverts commit 7bdc7635b885e473f6a577264fd8efad1c02174f, reversing
changes made to 45786be516e13d55a1fca9a4abaddd5781209103.
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This logic was just doing duplicated work, since the button_to helper
relies on tag/content_tag to generate the button html, which already
handles all boolean attributes it knows about.
The code dates back to 2005: 43c470fae468ef63e0d5c3dc1e202925685fd47b.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I’m renaming all instances of `use_transcational_fixtures` to
`use_transactional_tests` and “transactional fixtures” to
“transactional tests”.
I’m deprecating `use_transactional_fixtures=`. So anyone who is
explicitly setting this will get a warning telling them to use
`use_transactional_tests=` instead.
I’m maintaining backwards compatibility—both forms will work.
`use_transactional_tests` will check to see if
`use_transactional_fixtures` is set and use that, otherwise it will use
itself. But because `use_transactional_tests` is a class attribute
(created with `class_attribute`) this requires a little bit of hoop
jumping. The writer method that `class_attribute` generates defines a
new reader method that return the value being set. Which means we can’t
set the default of `true` using `use_transactional_tests=` as was done
previously because that won’t take into account anyone using
`use_transactional_fixtures`. Instead I defined the reader method
manually and it checks `use_transactional_fixtures`. If it was set then
it should be used, otherwise it should return the default, which is
`true`. If someone uses `use_transactional_tests=` then it will
overwrite the backwards-compatible method with whatever they set.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Let strip_tags leave HTML escaping to Rails.
|
| | | | |
| | | |
| | | |
| | | | |
Prevents double escaping errors, such as "&" becoming "&".
|
| |/ / /
| | |
| | |
| | | |
This is a follow-up to #19257
|
| |\ \ \
| | | |
| | | | |
Run all our tests in random order
|
| | | | |
| | | |
| | | |
| | | | |
This reverts commit 7025d7769dc53f0a3ffab8b537727ef3fee367fc.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 2f52f969885b2834198de0045748436a4651a94e.
Conflicts:
actionmailer/test/abstract_unit.rb
actionview/test/abstract_unit.rb
activemodel/test/cases/helper.rb
activerecord/test/cases/helper.rb
activesupport/test/abstract_unit.rb
railties/test/abstract_unit.rb
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
Closes #19227.
|
| | | | | |
|
| | | | | |
|
