rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
...
* \| \|	Fix cache_helper comment ERB	Anthony Dmitriyev	2015-02-20	1	-2/+2
\| \| \|
* \| \|	Merge pull request #17143 from kuldeepaggarwal/fix-mailTo	Rafael Mendonça França	2015-02-20	2	-1/+6
\|\ \ \ \| \| \| \| \| \| \| \| \| \| \| \|	mail_to helper method fix
\| * \| \|	do not generate blank options in mailTo	Kuldeep Aggarwal	2014-10-02	2	-2/+8
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	when mail_to generate blank options for any passed options(cc, bcc, body, subject) then MICROSOFT OUTLOOK treats it differently and set wrong values in different options.
* \| \| \|	Use a name that better reflect the return value	Rafael Mendonça França	2015-02-20	1	-2/+2
\| \| \| \|
* \| \| \|	Merge pull request #17138 from jpcody/rename_default_form_builder	Rafael Mendonça França	2015-02-20	1	-2/+2
\|\ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Rename default_form_builder to avoid collision
\| * \| \| \|	Rename default_form_builder to avoid collision	Joshua Cody	2014-10-01	1	-2/+2
\| \| \| \| \|
* \| \| \| \|	Corrects the API to method select_tag	Leandro Nunes	2015-02-20	1	-2/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The 'selected' option is not doing what it should do. The expected behavior is to pass the value selected by default for the options_from_collection_for_select method
* \| \| \| \|	Make the helpers a required argument	Evan Phoenix	2015-02-19	1	-1/+1
\| \| \| \| \|
* \| \| \| \|	Merge pull request #18411 from todd/extract_record_tag_helper	Rafael Mendonça França	2015-02-18	4	-186/+22
\|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \|	Remove RecordTagHelper
\| * \| \| \| \|	Remove RecordTagHelper, add extraction notices	Todd Bealmear	2015-02-16	4	-186/+22
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Per DHH in #18337, ActionView::Helpers::RecordTagHelper has been extracted to an external gem (source currently lives at todd/record_tag_helper). Removal notices have also been added for anyone upgrading that use the extracted methods.
* \| \| \| \| \|	Add nodoc to private constant [ci skip]	Rafael Mendonça França	2015-02-18	1	-1/+1
\| \| \| \| \| \|
* \| \| \| \| \|	Merge pull request #18970 from nithinbekal/local-assigns-doc	Rafael Mendonça França	2015-02-18	1	-0/+8
\|\ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Add documentation for local_assigns [ci skip]
\| * \| \| \| \| \|	Add documentation for local_assigns [ci skip]	Nithin Bekal	2015-02-17	1	-0/+8
\| \|/ / / / /
* \| \| \| \| \|	Improve documentation of local_assigns	Rafael Mendonça França	2015-02-18	1	-7/+13
\| \| \| \| \| \|
* \| \| \| \| \|	Merge pull request #15700 from maurogeorge/guides-local_assigns	Rafael Mendonça França	2015-02-18	1	-0/+7
\|\ \ \ \ \ \ \| \|/ / / / / \|/\| \| \| \| \| \| \| \| \| \| \|	Add docs about local_assigns on guides
\| * \| \| \| \|	Add RDoc about local_assigns	Mauro George	2014-06-13	1	-0/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	[ci skip]
* \| \| \| \| \|	Merge pull request #18949 from craftsmen/image_tag_size	Yves Senn	2015-02-16	3	-0/+9
\|\ \ \ \ \ \ \| \|_\|_\|_\|_\|/ \|/\| \| \| \| \| \| \| \| \| \| \|	Allow to pass a string value to size option in `image_tag` and `video_tag`
\| * \| \| \| \|	Allow to pass a string value to size option in `image_tag` and `video_tag`	Mehdi Lahmam	2015-02-16	3	-0/+9
\|/ / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This makes the behavior more consistent with `width` or `height` options
* \| \| \| \|	Merge pull request #18845 from bogdan/remove-code-dups-in-action-view	Rafael Mendonça França	2015-02-11	2	-33/+25
\|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \|	Remove some code duplication in ActionView tags code
\| * \| \| \| \|	Remove code duplication in ActionView::Helpers::Tags::Base	Bogdan Gusiev	2015-02-11	2	-33/+25
\| \| \| \| \| \|
* \| \| \| \| \|	Remove warning from ActionView::Helpers::Tags::Translator	Yuki Nishijima	2015-02-08	1	-1/+3
\|/ / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This removes the following warning: /GitHub/rails/actionview/lib/action_view/helpers/tags/translator.rb:19: warning: private attribute?
* \| \| \| \|	use kwargs instead of xhr method. refs #18771.	yuuji.yaginuma	2015-02-07	1	-2/+2
\| \| \| \| \|
* \| \| \| \|	Fixed undefined method `i18n_key' for nil:NilClass for labels in non AR form_for	Miklos Fazekas	2015-02-06	2	-1/+13
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Refactoring at #18647 broke using non active record objects in form_for. This patch restores the original behaviour where we only compute i18 key when object.respond_to?(:to_model)
* \| \| \| \|	Indicate link_to creates an anchor element	Colin Rymer	2015-02-06	1	-2/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The `link_to` helper generates an HTML anchor element (consisting of opening and closing anchor tags and an element body). The docs currently state the a link tag is generated (which would indicate a tag like `<link>`, which is another valid HTML tag), so this change clarifies that an anchor element is actually generated. [ci skip]
* \| \| \| \|	Rename method to make explicit its intention	Rafael Mendonça França	2015-02-05	3	-3/+3
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	call is too generic
* \| \| \| \|	Use kwags to make the argument meaning explicit	Rafael Mendonça França	2015-02-05	3	-6/+6
\| \| \| \| \|
* \| \| \| \|	Use new hash syntax	Rafael Mendonça França	2015-02-05	1	-1/+1
\| \| \| \| \|
* \| \| \| \|	Change the method visibility	Rafael Mendonça França	2015-02-05	1	-2/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Thse methods are used only inside this class
* \| \| \| \|	Add tests to make sure label and placeholder respect to_model	Rafael Mendonça França	2015-02-05	2	-0/+58
\| \| \| \| \|
* \| \| \| \|	Only check if object respond_to to_model once	Rafael Mendonça França	2015-02-05	1	-6/+2
\| \| \| \| \|
* \| \| \| \|	placeholder doesn't exist inside this context	Rafael Mendonça França	2015-02-05	1	-2/+2
\| \| \| \| \|
* \| \| \| \|	Merge pull request #18647 from mcls/placeholderable-to-model	Rafael Mendonça França	2015-02-05	4	-28/+47
\|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The `model_name` method should be called on `to_model`
\| * \| \| \| \|	Reduce duplication when generating translations	Maarten Claes	2015-01-22	4	-34/+47
\| \| \| \| \| \|
\| * \| \| \| \|	Convert with `to_model` before calling ActiveModel methods on `object`	Maarten Claes	2015-01-22	2	-8/+14
\| \| \| \| \| \|
* \| \| \| \| \|	Partial template name does no more have to be a valid Ruby identifier	Akira Matsuda	2015-02-06	5	-16/+21
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	because the partial renderer would not create an lvar per each template since c67005f221f102fe2caca231027d9b11cf630484
* \| \| \| \| \|	Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵	Vipul A M	2015-02-03	6	-6/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	onwards.
* \| \| \| \| \|	Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846	robertomiranda	2015-01-31	4	-4/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769
* \| \| \| \| \|	Fixed test for deprecation warning in actionview, renaming from ↵	Vipul A M	2015-01-31	3	-29/+29
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	https://github.com/rails/rails/commit/baf14ae513337cb185acf865e93dfc48f3aabf6a
* \| \| \| \| \|	Add missing options to `datetime_select` [ci skip]	yachibit	2015-01-25	1	-0/+2
\|/ / / / /
* \| \| \| \|	Merge pull request #18546 from brainopia/action_view_render	Rafael Mendonça França	2015-01-22	2	-2/+14
\|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \|	A shortcut to setup controller environment
\| * \| \| \| \|	Support `:assigns` option when rendering with controllers/mailers.	brainopia	2015-01-22	2	-2/+14
\| \| \| \| \| \|
* \| \| \| \| \|	Single instead of double quotes	T.J. Schuck	2015-01-20	1	-2/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	[ci skip]
* \| \| \| \| \|	Rewrite SanitizeHelper docs	T.J. Schuck	2015-01-20	1	-77/+50
\| \| \| \| \| \|
* \| \| \| \| \|	Fix code formatting in sanitize docs	T.J. Schuck	2015-01-20	1	-9/+11
\| \| \| \| \| \|
* \| \| \| \| \|	fix typo in number_field_tag documentation [ci skip]	yuuji.yaginuma	2015-01-19	1	-2/+2
\| \| \| \| \| \|
* \| \| \| \| \|	Use existing constant for joining instead of '_'	Prathamesh Sonpatki	2015-01-18	1	-1/+1
\| \| \| \| \| \|
* \| \| \| \| \|	nodoc ActionView::ModelNaming module	Prathamesh Sonpatki	2015-01-18	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	- Its only used by ActionView internals and not supposed to be used through public API.
* \| \| \| \| \|	Eliminate a ruby warning in a test in Action View	Yuki Nishijima	2015-01-17	1	-1/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This eliminates the warning below: actionview/test/template/form_helper_test.rb:913: warning: method redefined; discarding old id_came_from_user? actionview/test/template/form_helper_test.rb:104: warning: previous definition of id_came_from_user? was here
* \| \| \| \| \|	Use option url: false to allow entries without a link tag	Daniel Gomez de Souza	2015-01-16	3	-2/+30
\|/ / / / /
* \| \| \| \|	Only use the `_before_type_cast` in the form when from user input	Sean Griffin	2015-01-14	2	-2/+26
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	While we don't want to change the form input when validations fail, blindly using `_before_type_cast` will cause the input to display the wrong data for any type which does additional work on database values.