aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Avoid accurate assertions on error messagesRobin Dupret2015-03-021-1/+1
| | | | | | | | | | | | | | | Since there are disparities between the raised error messages on the different implementations, let's avoid being too accurate.
* | | move _generate_paths_by_default to where it is usedAaron Patterson2015-03-011-0/+6
|/ / | | | | | | | | _generate_paths_by_default wasn't used in AD::Routing::UrlFor, so we should be able to move it where it is used in AV::Routing
* | Fix regression when passing a value different of String.Ulisses Almeida2015-02-263-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous version of rails(4.2.0) you can pass objects to the default option of translation helper. For example: ```ruby t('foo', default: 1) ``` But on rails 4.2.1 version this kind of use stopped to work, because started only to accept String types. Now with this fix we can use orther value types on this helper again.
* | [ci skip] Add changelog entry for #18948.Kasper Timm Hansen2015-02-261-0/+20
| |
* | Fix typos in ActionView::Helpers::FormBuilder comment [ci skip]Yu Haidong2015-02-261-1/+2
| |
* | Merge pull request #19074 from ↵Rafael Mendonça França2015-02-253-5/+20
|\ \ | | | | | | | | | | | | Mession/fix_test_dependency_of_erb_template_partial_with_layout Fix dependency tracker bug
| * | Fix dependency tracker bugJuho Leinonen2015-02-253-5/+20
| | |
* | | Merge pull request #18948 from kaspth/automatic-collection-cachingRafael Mendonça França2015-02-2510-2/+193
|\ \ \ | |/ / |/| | Merge multi_fetch_fragments.
| * | Collections automatically cache and fetch partials.Kasper Timm Hansen2015-02-217-3/+101
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Collections can take advantage of `multi_read` if they render one template and their partials begin with a cache call. The cache call must correspond to either what the collections elements are rendered as, or match the inferred name of the partial. So with a notifications/_notification.html.erb template like: ```ruby <% cache notification %> <%# ... %> <% end %> ``` A collection would be able to use `multi_read` if rendered like: ```ruby <%= render @notifications %> <%= render partial: 'notifications/notification', collection: @notifications, as: :notification %> ```
| * | Merge multi_fetch_fragments.Kasper Timm Hansen2015-02-206-2/+95
| | | | | | | | | | | | | | | | | | | | | | | | Makes caching a collection of template partials faster using `read_multi` on the Rails cache store. Some caching implementations have optimized `read_multi` so we don't have to check in the cache store for every template.
* | | Error message testing fixFranky W2015-02-204-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | The testing of error messages have been implemented wrongly a few times. This is an attempt to fix it. For example, some of these test should have failed with the new code. The reason they are not failling with the new string is the fact they were not being tested beforehand.
* | | Merge pull request #17069 from modosc/masterRafael Mendonça França2015-02-201-7/+9
|\ \ \ | | | | | | | | move cache_digests rake methods into their own namespace
| * | | move cache_digests rake methods into their own namespacejonathan schatz2014-09-261-7/+9
| | | |
* | | | Fix cache_helper comment ERBAnthony Dmitriyev2015-02-201-2/+2
| | | |
* | | | Merge pull request #17143 from kuldeepaggarwal/fix-mailToRafael Mendonça França2015-02-202-1/+6
|\ \ \ \ | | | | | | | | | | | | | | | mail_to helper method fix
| * | | | do not generate blank options in mailToKuldeep Aggarwal2014-10-022-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | when mail_to generate blank options for any passed options(cc, bcc, body, subject) then MICROSOFT OUTLOOK treats it differently and set wrong values in different options.
* | | | | Use a name that better reflect the return valueRafael Mendonça França2015-02-201-2/+2
| | | | |
* | | | | Merge pull request #17138 from jpcody/rename_default_form_builderRafael Mendonça França2015-02-201-2/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Rename default_form_builder to avoid collision
| * | | | | Rename default_form_builder to avoid collisionJoshua Cody2014-10-011-2/+2
| | | | | |
* | | | | | Corrects the API to method select_tagLeandro Nunes2015-02-201-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | The 'selected' option is not doing what it should do. The expected behavior is to pass the value selected by default for the options_from_collection_for_select method
* | | | | | Make the helpers a required argumentEvan Phoenix2015-02-191-1/+1
| | | | | |
* | | | | | Merge pull request #18411 from todd/extract_record_tag_helperRafael Mendonça França2015-02-184-186/+22
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove RecordTagHelper
| * | | | | | Remove RecordTagHelper, add extraction noticesTodd Bealmear2015-02-164-186/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Per DHH in #18337, ActionView::Helpers::RecordTagHelper has been extracted to an external gem (source currently lives at todd/record_tag_helper). Removal notices have also been added for anyone upgrading that use the extracted methods.
* | | | | | | Add nodoc to private constant [ci skip]Rafael Mendonça França2015-02-181-1/+1
| | | | | | |
* | | | | | | Merge pull request #18970 from nithinbekal/local-assigns-docRafael Mendonça França2015-02-181-0/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Add documentation for local_assigns [ci skip]
| * | | | | | | Add documentation for local_assigns [ci skip]Nithin Bekal2015-02-171-0/+8
| |/ / / / / /
* | | | | | | Improve documentation of local_assignsRafael Mendonça França2015-02-181-7/+13
| | | | | | |
* | | | | | | Merge pull request #15700 from maurogeorge/guides-local_assignsRafael Mendonça França2015-02-181-0/+7
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | Add docs about local_assigns on guides
| * | | | | | Add RDoc about local_assignsMauro George2014-06-131-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | Merge pull request #18949 from craftsmen/image_tag_sizeYves Senn2015-02-163-0/+9
|\ \ \ \ \ \ \ | |_|_|_|_|/ / |/| | | | | | | | | | | | | Allow to pass a string value to size option in `image_tag` and `video_tag`
| * | | | | | Allow to pass a string value to size option in `image_tag` and `video_tag`Mehdi Lahmam2015-02-163-0/+9
|/ / / / / / | | | | | | | | | | | | | | | | | | This makes the behavior more consistent with `width` or `height` options
* | | | | | Merge pull request #18845 from bogdan/remove-code-dups-in-action-viewRafael Mendonça França2015-02-112-33/+25
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove some code duplication in ActionView tags code
| * | | | | | Remove code duplication in ActionView::Helpers::Tags::BaseBogdan Gusiev2015-02-112-33/+25
| | | | | | |
* | | | | | | Remove warning from ActionView::Helpers::Tags::TranslatorYuki Nishijima2015-02-081-1/+3
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the following warning: /GitHub/rails/actionview/lib/action_view/helpers/tags/translator.rb:19: warning: private attribute?
* | | | | | use kwargs instead of xhr method. refs #18771.yuuji.yaginuma2015-02-071-2/+2
| | | | | |
* | | | | | Fixed undefined method `i18n_key' for nil:NilClass for labels in non AR form_forMiklos Fazekas2015-02-062-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactoring at #18647 broke using non active record objects in form_for. This patch restores the original behaviour where we only compute i18 key when object.respond_to?(:to_model)
* | | | | | Indicate link_to creates an anchor elementColin Rymer2015-02-061-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `link_to` helper generates an HTML anchor element (consisting of opening and closing anchor tags and an element body). The docs currently state the a link tag is generated (which would indicate a tag like `<link>`, which is another valid HTML tag), so this change clarifies that an anchor element is actually generated. [ci skip]
* | | | | | Rename method to make explicit its intentionRafael Mendonça França2015-02-053-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | call is too generic
* | | | | | Use kwags to make the argument meaning explicitRafael Mendonça França2015-02-053-6/+6
| | | | | |
* | | | | | Use new hash syntaxRafael Mendonça França2015-02-051-1/+1
| | | | | |
* | | | | | Change the method visibilityRafael Mendonça França2015-02-051-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | Thse methods are used only inside this class
* | | | | | Add tests to make sure label and placeholder respect to_modelRafael Mendonça França2015-02-052-0/+58
| | | | | |
* | | | | | Only check if object respond_to to_model onceRafael Mendonça França2015-02-051-6/+2
| | | | | |
* | | | | | placeholder doesn't exist inside this contextRafael Mendonça França2015-02-051-2/+2
| | | | | |
* | | | | | Merge pull request #18647 from mcls/placeholderable-to-modelRafael Mendonça França2015-02-054-28/+47
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | The `model_name` method should be called on `to_model`
| * | | | | | Reduce duplication when generating translationsMaarten Claes2015-01-224-34/+47
| | | | | | |
| * | | | | | Convert with `to_model` before calling ActiveModel methods on `object`Maarten Claes2015-01-222-8/+14
| | | | | | |
* | | | | | | Partial template name does no more have to be a valid Ruby identifierAkira Matsuda2015-02-065-16/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | because the partial renderer would not create an lvar per each template since c67005f221f102fe2caca231027d9b11cf630484
* | | | | | | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵Vipul A M2015-02-036-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | onwards.
* | | | | | | Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846robertomiranda2015-01-314-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 13:18:00 +0000