Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix `_write_layout_method` | Ryuta Kamizono | 2019-08-02 | 1 | -1/+1 |
| | |||||
* | No private def | Rafael Mendonça França | 2019-08-01 | 2 | -3/+6 |
| | |||||
* | These methods doesn't have to be `protected` | Akira Matsuda | 2019-08-01 | 2 | -6/+3 |
| | |||||
* | Use `try` only when we're unsure if the receiver would respond_to the method | Akira Matsuda | 2019-08-01 | 8 | -11/+8 |
| | |||||
* | Merge pull request #36818 from hc0208/fix_typo_in_data_remote_js | Ryuta Kamizono | 2019-07-31 | 1 | -1/+1 |
|\ | | | | | Fix typo submited → submitted | ||||
| * | Fix typo submited → submitted [ci skip] | hc0208 | 2019-07-31 | 1 | -1/+1 |
| | | |||||
* | | Avoid creating new Array when looking up already registered detail | Akira Matsuda | 2019-07-31 | 1 | -1/+1 |
|/ | |||||
* | Merge pull request #36813 from haruyuki97/haruyuki97/fix-comment-in-url-helper | Prem Sichanugrist | 2019-07-30 | 1 | -1/+1 |
|\ | | | | | | | | | Fix a/an usage on `phone_to` documentation. [ci skip] | ||||
| * | fix a typo [ci skip] | haruyuki97 | 2019-07-30 | 1 | -1/+1 |
| | | |||||
* | | Use match? where we don't need MatchData | Akira Matsuda | 2019-07-29 | 1 | -1/+1 |
| | | |||||
* | | Add AS::TimeZone#match? | Akira Matsuda | 2019-07-29 | 2 | -2/+4 |
| | | |||||
* | | Suppress Ruby warning: :warning: non-nil $, will be deprecated | Akira Matsuda | 2019-07-29 | 1 | -2/+6 |
| | | |||||
* | | Assert query counts in cache relation test | st0012 | 2019-07-28 | 1 | -1/+16 |
|/ | | | | This is to guard the change in #35982 | ||||
* | Use match? where we don't need MatchData | Akira Matsuda | 2019-07-27 | 2 | -2/+2 |
| | | | | We're already running Performance/RegexpMatch cop, but it seems like the cop is not always =~ justice | ||||
* | Change test description with the correct URL name | Pietro Moro | 2019-07-26 | 1 | -8/+8 |
| | |||||
* | Merge pull request #36178 from sshaw/fix_time_zone_options_priority | Rafael França | 2019-07-26 | 1 | -3/+4 |
|\ | | | | | Update time_zone_options_for_select docs | ||||
| * | Update time_zone_options_for_select docs | sshaw | 2019-05-04 | 1 | -3/+4 |
| | | |||||
* | | Change the test description to say the URL helper name in test. | Abhay Nikam | 2019-07-27 | 1 | -7/+7 |
| | | |||||
* | | Added a phone_to helper method, on the style of mail_to and sms_to. (#36775) | Pietro Moro | 2019-07-26 | 3 | -0/+115 |
| | | | | | | | | | | | | | | | | | | | | | | * Added a phone_to helper method, on the style of mail_to and sms_to. It creates an anchor tag with the href set to tel: *here your number* which, when clicked on a mobile phone, or on a desktop with a supported application, lets the phone app kick in, and it prepopulates it with the phone number specified. [Pietro Moro + Rafael Mendonça França] | ||||
* | | Merge pull request #36764 from ↵ | Rafael França | 2019-07-26 | 2 | -0/+19 |
|\ \ | | | | | | | | | | | | | willianveiga/feature/inputs-inside-disabled-fieldset-are-not-submited-on-remote-true-forms Inputs inside disabled fieldset are not submited on remote: true forms | ||||
| * | | Add test for submitted fields within disabled fieldsets | Willian Gustavo Veiga | 2019-07-26 | 1 | -0/+18 |
| | | | |||||
| * | | Issue #36728 - Inputs inside disabled fieldset are not submited on remote: ↵ | Willian Gustavo Veiga | 2019-07-25 | 1 | -0/+1 |
| | | | | | | | | | | | | true forms | ||||
* | | | Add a default value for arg `format` in `ActionView::Digestor.digest()` | Sharang Dashputre | 2019-07-26 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #35334 from sharang-d/digest-doc-update | Rafael França | 2019-07-26 | 1 | -3/+4 |
|\ \ \ | | | | | | | | | Update comment for ActionView::Digestor.digest [ci skip] | ||||
| * | | | Update comment for ActionView::Digestor.digest [ci skip] | Sharang Dashputre | 2019-04-16 | 1 | -3/+4 |
| | | | | |||||
* | | | | Merge pull request #36576 from mtsmfm/mtsmfm/fix-fixture-resolver | Rafael Mendonça França | 2019-07-25 | 2 | -13/+47 |
|\ \ \ \ | | | | | | | | | | | | | | | | Support :any variants for ActionView::FixtureResolver | ||||
| * | | | | Support :any variants for FixtureResolver | Fumiaki MATSUSHIMA | 2019-06-30 | 2 | -13/+47 |
| | | | | | |||||
* | | | | | Merge pull request #36412 from robotdana/compact_blank | Rafael Mendonça França | 2019-07-25 | 1 | -1/+1 |
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | Add compact_blank shortcut for reject(&:blank?) | ||||
| * | | | | Use compact_blank throughout rails | Dana Sherson | 2019-06-05 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Merge pull request #36467 from spk/add-doc-host-protocol-asset_path | Rafael França | 2019-07-24 | 1 | -0/+2 |
|\ \ \ \ \ | | | | | | | | | | | | | Add documentation on actionview asset_path with host and protocol | ||||
| * | | | | | Add documentation on actionview asset_path with host and protocol | Laurent Arnoud | 2019-06-12 | 1 | -0/+2 |
| | | | | | | |||||
* | | | | | | Fix broken rdoc for UrlHelper [ci skip] | Ryuta Kamizono | 2019-07-24 | 1 | -6/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix unintentionally linked String, Symbol, Hash, and ERB. * Fix unintentionally code block. | ||||
* | | | | | | Fix argument in doc sample of new `sms_to` helper [ci skip] | Carlos Antonio da Silva | 2019-07-19 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | Merge pull request #36511 from aantix/sms_link_helper | Guillermo Iguaran | 2019-07-19 | 2 | -0/+110 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Helper method to create an sms link | ||||
| * | | | | | | Doc changes. | Jim Jones | 2019-06-18 | 1 | -4/+4 |
| | | | | | | | |||||
| * | | | | | | Helper method to create an sms link - when clicked it opens the ↵ | Jim Jones | 2019-06-18 | 2 | -0/+110 |
| |/ / / / / | | | | | | | | | | | | | | | | | | | phone/desktop's messaging client with the phone number and optional body value prepopulated. | ||||
* | | | | | | Fix a minor typo in ActionView::UnboundTemplate | Jean Boussier | 2019-07-19 | 1 | -3/+3 |
| | | | | | | |||||
* | | | | | | Empty array instead of nil for source_extract | Guilherme Mansur | 2019-07-14 | 3 | -12/+29 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The source_extract method will return nil when it can't find the file name in the backtrace, methods that consume this method expect an array and the nil ends up causing type errors down the road like it happened here: #36341. This patch refactors the source_extract method so that it returns an empty array instead of nil when it can't find the source code. Co-authored-by: Kasper Timm Hansen <kaspth@gmail.com> | ||||
* | | | | | | active_support/deprecation has to be already required via ↵ | Akira Matsuda | 2019-07-12 | 5 | -7/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | active_support/rails.rb | ||||
* | | | | | | A type class or nil has to respond_to :to_s | Akira Matsuda | 2019-07-12 | 1 | -2/+1 |
| | | | | | | |||||
* | | | | | | No Woman, No try | Akira Matsuda | 2019-07-12 | 1 | -1/+0 |
| |_|/ / / |/| | | | | |||||
* | | | | | Autoload SyntaxErrorInTemplate | Guilherme Mansur | 2019-06-19 | 2 | -0/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a SyntaxError is detected in a template we raise this exception. On a first request to the server the exception we get a NameError since the exception is not required from `active_view/template/error.rb` yet. However later on it gets required and a second request will succeed. On the first request we see the rails "Something Wen Wrong" page and not the expected syntax error in template error page with the webconsole and stacktrace. By autoloading the constant we fix this issue. Co-authored-by: Gannon McGibbon <gannon.mcgibbon@gmail.com> | ||||
* | | | | | Merge pull request #36482 from Shopify/fix-translation-helper-default-hash | Rafael França | 2019-06-17 | 2 | -1/+6 |
|\ \ \ \ \ | | | | | | | | | | | | | Fix TranslationHelper#translate handling of Hash defaults | ||||
| * | | | | | Fix TranslationHelper#translate handling of Hash defaults | Jean Boussier | 2019-06-14 | 2 | -1/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is sometimes expected of the `translate` methods to return a Hash, for instance it's the case of the `number.format` key. As such users might need to specify a Hash default, e.g. `translate(:'some.format', default: { separator: '.', delimiter: ',' })`. This works as expected with the `I18n.translate` methods, however `TranslationHelper#translate` apply `Array()` on the default value. As a result the default value end up as `[:separator, '.', :delimiter, ',']`. | ||||
* | | | | | | :golf: | Akira Matsuda | 2019-06-15 | 1 | -6/+2 |
| | | | | | | |||||
* | | | | | | Fix rubocop violations | Ryuta Kamizono | 2019-06-14 | 1 | -1/+0 |
|/ / / / / | |||||
* | | | | | Merge pull request #36477 from albertoalmagro/alberto/button-to-default-path | Rafael França | 2019-06-13 | 1 | -1/+1 |
|\ \ \ \ \ | | | | | | | | | | | | | [ci skip] Use default path in button_to documentation | ||||
| * | | | | | [ci skip] Use default path in button_to documentation | Alberto Almagro | 2019-06-13 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is really a nit pick, but as this is the framework's documentation I think it should follow standards as many times as possible to avoid confusion in new users. If we were using `resources :articles` in routes. which is what scaffold adds, the generated helper would be `new_article_path` instead of `new_articles_path`. | ||||
* | | | | | | Merge pull request #36437 from sudara/fix_programmatic_clicks_with_data_remote | Gannon McGibbon | 2019-06-13 | 2 | -2/+16 |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | Fix programmatic clicks with data-remote | ||||
| * | | | | | Ensure non-mouse/programmatic clicks work with data-remote | Sudara | 2019-06-13 | 2 | -2/+16 |
| | | | | | |