Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | documentation fix | Gaurav Sharma | 2014-05-24 | 1 | -2/+2 | |
| | | ||||||
* | | update docs to include html id for select_tag | Omar Ismail | 2014-05-23 | 1 | -2/+2 | |
| | | ||||||
* | | Feature detect based on Ruby version. | Aaron Patterson | 2014-05-18 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | I didn't want to do this, FNM_EXTGLOB is defined on 2.1.x, but Dir.glob returns the wrong value on Ruby less than 2.2.0. Checking for a case-insensitive FS seems too hard, so just check Ruby version Checking for a case-insensitive FS seems too hard, so just check Ruby version. | |||||
* | | Merge pull request #15021 from hubertlepicki/allow_custom_host_in_asset_url | Rafael Mendonça França | 2014-05-16 | 3 | -3/+30 | |
|\ \ | | | | | | | | | | Allow custom asset host to be passed in asset_url | |||||
| * | | Improve documentation for asset_url | Hubert Łępicki | 2014-05-08 | 2 | -1/+12 | |
| | | | | | | | | | | | | Updated CHANGELOG.md with entry about :host in asset_url | |||||
| * | | Allow custom asset host to be passed in asset_url | Hubert Łępicki | 2014-05-08 | 2 | -1/+17 | |
| | | | ||||||
* | | | formatting pass through CHANGELOGS. [ci skip] | Yves Senn | 2014-05-16 | 1 | -1/+3 | |
| | | | ||||||
* | | | We need an explicit return | Rafael Mendonça França | 2014-05-14 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we don't return early Ruby will memoize the value of the prefix of the parent class what will make the subsequent searchs to not work as expected. If the early return we are avoiding the memoization. But when using the deprecated path we need to memoize the value, so we are not using early return for the deprecated path. | |||||
* | | | Following documentation guideline | Rafael Mendonça França | 2014-05-14 | 1 | -4/+3 | |
| | | | ||||||
* | | | Refactoring the code to make consitional return explicit | Rafael Mendonça França | 2014-05-14 | 1 | -4/+9 | |
| | | | ||||||
* | | | Follow the documentation guideline | Rafael Mendonça França | 2014-05-14 | 1 | -1/+1 | |
| | | | ||||||
* | | | Mark _prefix as nodoc | Rafael Mendonça França | 2014-05-14 | 1 | -3/+2 | |
| | | | | | | | | | | | | These methods are private API. | |||||
* | | | ._prefix is private API so we should not recommend to override it | Rafael Mendonça França | 2014-05-14 | 1 | -2/+2 | |
| | | | ||||||
* | | | Improve CHANGELOG entry | Rafael Mendonça França | 2014-05-14 | 1 | -2/+4 | |
| | | | ||||||
* | | | Merge remote-tracking branch 'apotonick/simplify-prefixes' | Rafael Mendonça França | 2014-05-14 | 3 | -15/+75 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | This is the rebased version of #15026 Closes #15026 | |||||
| * | | | deprecate AbC:Base::parent_prefixes. | Nick Sutterer | 2014-05-13 | 3 | -4/+69 | |
| | | | | | | | | | | | | | | | | | | | | | | | | rename ::_local_prefixes to ::local_prefixes to state the public attribute. document the latter. make ::local_prefixes private, test overriding it and remove documentation for overriding ::_parent_prefixes. | |||||
| * | | | simplify AC:ViewPaths::_prefixes. by making it recursively traversing up the ↵ | Nick Sutterer | 2014-05-13 | 1 | -15/+10 | |
| | |/ | |/| | | | | | | | inheritance chain, classes can override local prefixes. | |||||
* | | | minor: point to the right test suite location | azul | 2014-05-14 | 1 | -1/+1 | |
| | | | ||||||
* | | | Fix assertion order and :scissors: extra spaces | Carlos Antonio da Silva | 2014-05-13 | 2 | -4/+3 | |
| | | | ||||||
* | | | Merge pull request #15068 from josepjaume/patch-1 | Aaron Patterson | 2014-05-13 | 2 | -0/+8 | |
|\ \ \ | | | | | | | | | Dup options hash to prevent modifications | |||||
| * | | | Dup options hash to prevent modifications | Josep Jaume Rey | 2014-05-13 | 2 | -0/+8 | |
| |/ / | | | | | | | | | | `options[:default]` and `options[:raise]` can be mistakenly added to the `options` hash. This can be a problem if you're reusing the same object. | |||||
* | | | fix bad merge | Aaron Patterson | 2014-05-12 | 1 | -15/+0 | |
| | | | ||||||
* | | | :cry::gun: use an empty hash for magical speed. | Aaron Patterson | 2014-05-12 | 1 | -1/+5 | |
| | | | | | | | | | | | | | | | | | | For some reason, if the hash is empty, we choose "optimized" routes. I am not sure how or why optimized routes differ from regular routes. But, if we make sure the hash is empty, we get a nice speed improvement. | |||||
* | | | use the helper method builder to construct helper methods | Aaron Patterson | 2014-05-12 | 1 | -2/+6 | |
| | | | ||||||
* | | | probably should not check in a raise | Aaron Patterson | 2014-05-12 | 1 | -1/+0 | |
| | | | ||||||
* | | | undo optimized calls until the builder object is finished | Aaron Patterson | 2014-05-12 | 1 | -4/+3 | |
| | | | ||||||
* | | | fix url_for with classes | Aaron Patterson | 2014-05-12 | 1 | -1/+1 | |
| | | | ||||||
* | | | break each polymorphic type to it's own method | Aaron Patterson | 2014-05-12 | 1 | -1/+5 | |
| | | | ||||||
* | | | add a test for the parameters sent to the url helper for new records | Aaron Patterson | 2014-05-12 | 1 | -0/+15 | |
| | | | ||||||
* | | | simplified route method name generation | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 1 | -0/+2 | |
| | | | ||||||
* | | | add a test with three objects | Aaron Patterson | 2014-05-12 | 1 | -2/+13 | |
| | | | ||||||
* | | | add a test for passing two models to the polymorphic_url method | Aaron Patterson | 2014-05-12 | 1 | -0/+8 | |
|/ / | ||||||
* | | feature detect for FNM_EXTGLOB for older Ruby. Fixes #15053 | Aaron Patterson | 2014-05-10 | 1 | -5/+21 | |
| | | ||||||
* | | use fnmatch to test for case insensitive file systems | Aaron Patterson | 2014-05-09 | 1 | -4/+2 | |
| | | | | | | | | | | | | this is due to: https://bugs.ruby-lang.org/issues/5994 | |||||
* | | add tests for path based url_for calls | Aaron Patterson | 2014-05-08 | 1 | -2/+19 | |
| | | ||||||
* | | don't manipulate the testclass, just add helpers to the instance | Aaron Patterson | 2014-05-08 | 1 | -10/+11 | |
| | | ||||||
* | | add a test for classes with options | Aaron Patterson | 2014-05-08 | 1 | -0/+7 | |
| | | ||||||
* | | add tests for the polymorphic_path method | Aaron Patterson | 2014-05-08 | 1 | -0/+3 | |
| | | ||||||
* | | add more tests around the polymorphic url api | Aaron Patterson | 2014-05-08 | 1 | -0/+12 | |
|/ | ||||||
* | test for inconsistency between String and Symbol url_for handling | Aaron Patterson | 2014-05-07 | 1 | -0/+4 | |
| | ||||||
* | add tests for symbols passed to polymorphic_url | Aaron Patterson | 2014-05-07 | 1 | -0/+12 | |
| | ||||||
* | apparently passing a string to polymorphic_url is something we support | Aaron Patterson | 2014-05-06 | 1 | -0/+12 | |
| | | | | o_O | |||||
* | make sure url_for works similar to polymorphic_url | Aaron Patterson | 2014-05-06 | 1 | -38/+43 | |
| | ||||||
* | add a test for the parameters sent to the url helper for new records | Aaron Patterson | 2014-05-06 | 1 | -0/+15 | |
| | ||||||
* | Merge pull request #14997 from jpcody/nested_value_i18n | Rafael Mendonça França | 2014-05-06 | 3 | -2/+31 | |
|\ | | | | | Include label value in i18n attribute lookup | |||||
| * | Include label value in i18n attribute lookup | Joshua Cody | 2014-05-06 | 3 | -2/+31 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, only the object and method name from the label tag were used when looking up the translation for a label. If a value is given for the label, this ought to be additionally used. The following: # form.html.erb <%= form_for @post do |f| %> <%= f.label :type, value: "long" %> <% end %> # en.yml en: activerecord: attributes: post/long: "Long-form Post" Used to simply return "long", but now it will return "Long-form Post". | |||||
* | | Ensure that .process return the method return | Arthur Neves | 2014-05-06 | 2 | -9/+13 | |
|/ | ||||||
* | Typo, grammar and textual changes [ci skip] | Akshay Vishnoi | 2014-05-03 | 1 | -4/+5 | |
| | ||||||
* | passing a nil in the polymorphic array is not supported. remove nils before ↵ | Aaron Patterson | 2014-05-02 | 1 | -4/+4 | |
| | | | | you call the method | |||||
* | passing a nil should always raise an ArgumentError | Aaron Patterson | 2014-05-02 | 1 | -0/+25 | |
| |