aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #18949 from craftsmen/image_tag_sizeYves Senn2015-02-163-0/+9
|\ | | | | | | Allow to pass a string value to size option in `image_tag` and `video_tag`
| * Allow to pass a string value to size option in `image_tag` and `video_tag`Mehdi Lahmam2015-02-163-0/+9
|/ | | | This makes the behavior more consistent with `width` or `height` options
* Merge pull request #18845 from bogdan/remove-code-dups-in-action-viewRafael Mendonça França2015-02-112-33/+25
|\ | | | | Remove some code duplication in ActionView tags code
| * Remove code duplication in ActionView::Helpers::Tags::BaseBogdan Gusiev2015-02-112-33/+25
| |
* | Remove warning from ActionView::Helpers::Tags::TranslatorYuki Nishijima2015-02-081-1/+3
|/ | | | | | This removes the following warning: /GitHub/rails/actionview/lib/action_view/helpers/tags/translator.rb:19: warning: private attribute?
* use kwargs instead of xhr method. refs #18771.yuuji.yaginuma2015-02-071-2/+2
|
* Fixed undefined method `i18n_key' for nil:NilClass for labels in non AR form_forMiklos Fazekas2015-02-062-1/+13
| | | | | Refactoring at #18647 broke using non active record objects in form_for. This patch restores the original behaviour where we only compute i18 key when object.respond_to?(:to_model)
* Indicate link_to creates an anchor elementColin Rymer2015-02-061-2/+2
| | | | | | The `link_to` helper generates an HTML anchor element (consisting of opening and closing anchor tags and an element body). The docs currently state the a link tag is generated (which would indicate a tag like `<link>`, which is another valid HTML tag), so this change clarifies that an anchor element is actually generated. [ci skip]
* Rename method to make explicit its intentionRafael Mendonça França2015-02-053-3/+3
| | | | call is too generic
* Use kwags to make the argument meaning explicitRafael Mendonça França2015-02-053-6/+6
|
* Use new hash syntaxRafael Mendonça França2015-02-051-1/+1
|
* Change the method visibilityRafael Mendonça França2015-02-051-2/+4
| | | | Thse methods are used only inside this class
* Add tests to make sure label and placeholder respect to_modelRafael Mendonça França2015-02-052-0/+58
|
* Only check if object respond_to to_model onceRafael Mendonça França2015-02-051-6/+2
|
* placeholder doesn't exist inside this contextRafael Mendonça França2015-02-051-2/+2
|
* Merge pull request #18647 from mcls/placeholderable-to-modelRafael Mendonça França2015-02-054-28/+47
|\ | | | | | | The `model_name` method should be called on `to_model`
| * Reduce duplication when generating translationsMaarten Claes2015-01-224-34/+47
| |
| * Convert with `to_model` before calling ActiveModel methods on `object`Maarten Claes2015-01-222-8/+14
| |
* | Partial template name does no more have to be a valid Ruby identifierAkira Matsuda2015-02-065-16/+21
| | | | | | | | because the partial renderer would not create an lvar per each template since c67005f221f102fe2caca231027d9b11cf630484
* | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵Vipul A M2015-02-036-6/+0
| | | | | | | | onwards.
* | Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846robertomiranda2015-01-314-4/+4
| | | | | | | | ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769
* | Fixed test for deprecation warning in actionview, renaming from ↵Vipul A M2015-01-313-29/+29
| | | | | | | | https://github.com/rails/rails/commit/baf14ae513337cb185acf865e93dfc48f3aabf6a
* | Add missing options to `datetime_select` [ci skip]yachibit2015-01-251-0/+2
|/
* Merge pull request #18546 from brainopia/action_view_renderRafael Mendonça França2015-01-222-2/+14
|\ | | | | A shortcut to setup controller environment
| * Support `:assigns` option when rendering with controllers/mailers.brainopia2015-01-222-2/+14
| |
* | Single instead of double quotes T.J. Schuck2015-01-201-2/+2
| | | | | | [ci skip]
* | Rewrite SanitizeHelper docsT.J. Schuck2015-01-201-77/+50
| |
* | Fix code formatting in sanitize docsT.J. Schuck2015-01-201-9/+11
| |
* | fix typo in number_field_tag documentation [ci skip]yuuji.yaginuma2015-01-191-2/+2
| |
* | Use existing constant for joining instead of '_'Prathamesh Sonpatki2015-01-181-1/+1
| |
* | nodoc ActionView::ModelNaming modulePrathamesh Sonpatki2015-01-181-1/+1
| | | | | | | | | | - Its only used by ActionView internals and not supposed to be used through public API.
* | Eliminate a ruby warning in a test in Action ViewYuki Nishijima2015-01-171-1/+5
| | | | | | | | | | | | | | This eliminates the warning below: actionview/test/template/form_helper_test.rb:913: warning: method redefined; discarding old id_came_from_user? actionview/test/template/form_helper_test.rb:104: warning: previous definition of id_came_from_user? was here
* | Use option url: false to allow entries without a link tagDaniel Gomez de Souza2015-01-163-2/+30
|/
* Only use the `_before_type_cast` in the form when from user inputSean Griffin2015-01-142-2/+26
| | | | | | While we don't want to change the form input when validations fail, blindly using `_before_type_cast` will cause the input to display the wrong data for any type which does additional work on database values.
* Add tests with an explanation of why we're using `_before_type_cast`Sean Griffin2015-01-141-3/+4
| | | | | | | If you entered incorrect input into a form (particularly with a numericality validation), we should not replace what you typed in with `0`, since clicking submit a second time would essentially be the same as erroneously accepting the junk input as 0.
* Revert "Don't use the `_before_type_cast` version of attributes in the form"Sean Griffin2015-01-144-3/+13
| | | | This reverts commit 787e22bb491bd8c36db1e9734261c4ce02c5c5fd.
* Don't use the `_before_type_cast` version of attributes in the formSean Griffin2015-01-144-13/+3
| | | | | | | | | | | We should never be ignoring valuable information that the types may need to give us. The reason that it originally used `_before_type_cast` is unclear, but appears to date back long enough that the reasons may not be relevant today. There is only one test that asserts that it uses the before type cast version, but it gives no context as to why and uses a mock which does not simulate the real world. Fixes #18523.
* Fix typo in ActionView CHANGELOG [ci skip]Prathamesh Sonpatki2015-01-141-1/+1
|
* No need of requiring `rbconfig`, it is by-default loadedKuldeep Aggarwal2015-01-101-1/+0
|
* Avoid changing the global state on the testsRafael Mendonça França2015-01-051-1/+6
|
* Merge pull request #17676 from ↵Rafael Mendonça França2015-01-052-6/+27
|\ | | | | | | | | | | tigrish/fix_custom_i18n_exception_handler_regression Fix I18n regression introduced by #13832
| * Fix I18n regression introduced by #13832Christopher Dell2014-11-192-6/+27
| | | | | | | | Previously, when the `:raise` options was set to `false`, it would get overwritten to `true`, preventing custom exception handlers to be used.
* | Merge pull request #18328 from brainopia/remove_tz_proxyRafael Mendonça França2015-01-041-1/+1
|\ \ | | | | | | Use directly TZInfo::Timezone without proxy
| * | Use directly TZInfo::Timezone without proxybrainopia2015-01-041-1/+1
| | | | | | | | | | | | | | | Since real timezone is loaded anyway in `#utc_offset` which is called during `#create`
* | | Remove wrong TODO commentRafael Mendonça França2015-01-041-1/+1
| | |
* | | Remove version conditional for find_template_pathsRafael Mendonça França2015-01-041-18/+6
|/ / | | | | | | | | Now that we only support Ruby 2.2+ we don't need this conditional anymore
* | Remove unneeded `require 'as/deprecation'`claudiob2015-01-041-1/+0
| | | | | | | | | | Tests should still pass after removing `require 'active_support/deprecation'` from these files since the related deprecations have been removed.
* | Remove unneeded requiresRafael Mendonça França2015-01-041-1/+0
| | | | | | | | These requires were added only to change deprecation message
* | Change the default template handler from `ERB` to `Raw`.Rafael Mendonça França2015-01-043-8/+9
| | | | | | | | | | Files without a template handler in their extension will be rended using the raw handler instead of ERB.
* | Remove deprecated `AbstractController::Base::parent_prefixes`Rafael Mendonça França2015-01-043-35/+7
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 06:25:03 +0000