aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Use &= instead of select with include?Rafael Mendonça França2014-07-161-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The performance is almost the same with both implementations but this is clear. Before this patch: Calculating ------------------------------------- small erb template 1452 i/100ms ------------------------------------------------- small erb template 17462.1 (±13.3%) i/s - 85668 in 5.031395s .Calculating ------------------------------------- small erb template with 1 partial 887 i/100ms ------------------------------------------------- small erb template with 1 partial 8899.6 (±18.8%) i/s - 42576 in 5.009453s .Calculating ------------------------------------- small erb template with 2 partials 666 i/100ms ------------------------------------------------- small erb template with 2 partials 6821.5 (±8.8%) i/s - 33966 in 5.020791s After the patch: Calculating ------------------------------------- small erb template 1479 i/100ms ------------------------------------------------- small erb template 15956.6 (±7.6%) i/s - 79866 in 5.036001s .Calculating ------------------------------------- small erb template with 1 partial 841 i/100ms ------------------------------------------------- small erb template with 1 partial 9242.2 (±6.9%) i/s - 46255 in 5.029497s .Calculating ------------------------------------- small erb template with 2 partials 615 i/100ms ------------------------------------------------- small erb template with 2 partials 6524.7 (±6.8%) i/s - 32595 in 5.020456s You can find the benchmark code at https://gist.github.com/rafaelfranca/dee31120cfdb1ddc3b56
| * | | Merge pull request #15917 from luke-gru/actionview_perfRafael Mendonça França2014-07-161-1/+1
| |\ \ \ | | | | | | | | | | | | | | | remove Set.new from DetailsKey::get, impacts rendering overhead
| | * | | remove Set.new from DetailsKey::get, impacts rendering overhead performanceLuke Gruber2014-06-251-1/+1
| | | |/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using ruby-prof, I noticed that Set#add had the largest 'self time' percentage (5% of the overall time spent rendering) when benchmarking the rendering of a small cached ERB template that was 3 lines long. It turns out it was from this line. I don't believe the Set is necessary, either. Removing this line increases the rendering ips using Benchmark::ips accordingly.
| * | | Fix typo on the variable nameRafael Mendonça França2014-07-161-8/+8
| | | |
| * | | Add CHANGELOG entry for PartialIteration.Rafael Mendonça França2014-07-161-0/+10
| | | | | | | | | | | | | | | | Closes #7698.
| * | | Document the PartialIteration objectRafael Mendonça França2014-07-161-3/+9
| | | |
| * | | Build only one PartialIteration object for loopRafael Mendonça França2014-07-162-16/+26
| | | |
| * | | No need to have a file to PartialIteration classRafael Mendonça França2014-07-162-4/+19
| | | | | | | | | | | | | | | | This class is only used on the PartialRenderer.
| * | | Added PartialIteration class used when rendering collectionsJoel Junström2014-07-166-14/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The iteration object is available as the local variable "template_name_iteration" when rendering partials with collections. It gives access to the +size+ of the collection beeing iterated over, the current +index+ and two convinicence methods +first?+ and +last?+ "template_name_counter" variable is kept but is deprecated. [Joel Junström + Lucas Uyezu]
| * | | Merge pull request #16175 from skorks/log_digestor_as_debugRafael Mendonça França2014-07-151-1/+1
| |\ \ \ | | | | | | | | | | Log digest as :debug instead of :info
| | * | | Log digest as :debug instead of :infoAlan Skorkin2014-07-151-1/+1
| | | | |
| * | | | Merge pull request #16161 from jpawlyn/masterAndrew White2014-07-153-1/+14
| |\ \ \ \ | | |/ / / | |/| | | Fix empty host for an asset url when asset_host proc returns nil
| | * | | Return an absolute instead of relative path from an asset url in the case of ↵Jolyon Pawlyn2014-07-153-1/+14
| | | | | | | | | | | | | | | | | | | | the `asset_host` proc returning nil
| * | | | Fix typos like `a html` to `an html` and 'an mail' to 'an email'. [ci skip]Santosh Wadghule2014-07-141-1/+1
| |/ / /
| * | | Assert the nature of the original exceptionMatthew Draper2014-07-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Just so it's clearer what's going on in the following assertion. /cc #11993 @robin850
| * | | Merge pull request #11993 from razielgn/actionview-use-name-to-inspect-errorGuillermo Iguaran2014-07-111-1/+1
| |\ \ \ | | | | | | | | | | Use NameError#name to assert raised error.
| | * | | Use NameError#name to assert raised error.Federico Ravasio2013-11-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | This makes the test compatible with other Ruby implementations, which may implement error messages differently.
| * | | | Synced 4.2 release notes with the latest commits.Godfrey Chan2014-07-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Also reordered some of the items to put newer ones on top (same order as CHANGELOGs), which makes it easier to diff while we are still working on it.
| * | | | Fixed borken tests in AV caused by 013c74dGodfrey Chan2014-07-101-2/+2
| | | | |
* | | | | Use the plugin API to the getter and settersRafael Mendonça França2014-07-151-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | To avoid having to redefine these methods on the deprecated plugin we should be using the sanitizer_vendor API.
* | | | | Use regexp instead exact match for atom testRafael Mendonça França2014-07-151-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are two xml namespaces in the response body and the xhtml namespace is not registered in the root node. This create an invalid XML and nokogiri can't navigate using xpath on that node.
* | | | | All these tests are passing nowRafael Mendonça França2014-07-153-7/+0
| | | | |
* | | | | Defining the right dependenciesRafael Mendonça França2014-07-151-1/+2
| | | | |
* | | | | We don't need loofah for the assertionsRafael Mendonça França2014-07-152-3/+2
| | | | | | | | | | | | | | | | | | | | We can just use nokogiri
* | | | | Include the selector assertions on the test caseRafael Mendonça França2014-07-151-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | We don't need to require users to include this module on ActionMailer::TestCase
* | | | | Merge pull request #11218 from kaspth/loofah-integrationRafael Mendonça França2014-07-1027-2957/+180
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Loofah-integration Conflicts: actionpack/CHANGELOG.md actionview/CHANGELOG.md
| * | | | Make output_buffers used in tests be utf-8 encoded. Fixing unknown encoding ↵Timm2014-06-161-1/+3
| | | | | | | | | | | | | | | | | | | | ASCII-8BIT test errors.
| * | | | Change date helper tests to expect attributes with double quoted strings.Timm2014-06-161-14/+15
| | | | |
| * | | | Fix invalid css selectors in form_collections_helper_test.rb.Timm2014-06-161-11/+11
| | | | |
| * | | | Don't splat arguments to allowed tags or attributes.Timm2014-06-161-2/+2
| | | | |
| * | | | Change sanitizer_vendor to just be a method and reword documentation.Timm2014-06-161-4/+5
| | | | |
| * | | | Revert some stuff to use the new sanitizers.Timm2014-06-161-6/+6
| | | | |
| * | | | Remove html-scanner and its tests.Timm2014-06-1613-2454/+0
| | | | |
| * | | | Remove deprecation notice.Timm2014-06-161-2/+0
| | | | |
| * | | | Add a layer of indirection making sanitizers pluggable.Timm2014-06-163-3/+23
| | | | |
| * | | | Delegate allowed tags and attributes setting to HTML::WhiteListSanitizer.Timm2014-06-161-4/+4
| | | | |
| * | | | Changed configuration documentation to no longer state it replaces a Set.Timm2014-06-161-2/+2
| | | | |
| * | | | Deprecate configurations and use allowed_tags and allowed_attributes on ↵Timm2014-06-161-99/+22
| | | | | | | | | | | | | | | | | | | | WhiteListSanitizer.
| * | | | Migrated test away from escaped quotes.Timm2014-06-161-1/+1
| | | | |
| * | | | Made deprecation messages in sanitize_helper more clear.Timm2014-06-161-3/+3
| | | | |
| * | | | Updated CHANGELOG message to include info about rails-html-sanitizer.Timm2014-06-161-2/+3
| | | | |
| * | | | Updated CHANGELOG message about rails-dom-testing.Timm2014-06-161-12/+3
| | | | |
| * | | | Completed integration of rails-html-sanitizer in SanitizeHelper. Deprecated ↵Timm2014-06-163-294/+19
| | | | | | | | | | | | | | | | | | | | protocol_separator accessors and bad_tags=.
| * | | | Updated html-scanner deprecation message.Timm2014-06-161-1/+1
| | | | |
| * | | | Support for changes in SelectorAssertions.Timm2014-06-161-5/+6
| | | | |
| * | | | Fixed deprecated selector in form_collections_helper_test.rb with from ↵Timm2014-06-161-1/+1
| | | | | | | | | | | | | | | | | | | | catch_invalid_selector. Sweet.
| * | | | Removed sanitizers- and scrubbers_test.rb. They are in rails-html-sanitizer.Timm2014-06-162-645/+0
| | | | |
| * | | | Included DomAssertions in url_helper- and atom_feed_helper_test.rb.Timm2014-06-162-1/+3
| | | | |
| * | | | Removed assert_select test file, since it has been moved to rails-dom-testing.Timm2014-06-161-365/+0
| | | | |
| * | | | Required rails-dom-testing in test_case.rbTimm2014-06-161-1/+3
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-19 15:06:44 +0000