| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
|
|/ / /
| | |
| | |
| | | |
[ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | | |
fix
fix
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| | |
This makes sure that the labels are linked up with the fields.
Fixes #29014
|
| |
| |
| |
| | |
That won't be true for Action Pack and Action Mailer.
|
| |
| |
| |
| | |
st0012/fix-partial-cache-logging
|
| |
| |
| |
| | |
boolean.
|
| |
| |
| |
| |
| | |
form_with requires people to pass an id manually, so users can just
prefix their namespace right there.
|
| |
| |
| |
| |
| |
| | |
Forgot all about https://github.com/rails/rails/pull/28844/files#r113780934
cc @rafaelfranca
|
|/ |
|
|\
| |
| | |
Remove requirement on mathn
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The test using mathn was first introduced in f1d9179 to check that the
`distance_of_time_in_words` properly doesn't use the `Fixnum#/` method
by explicitly requiring this library as it redefines this method.
Given that `mathn` has been gemified in Ruby 2.5 and is deprecated since
version 2.2, we can certainly safely assume that people will most-likely
not require this library in their application.
However, to make sure that we don't regress, let's add a test similar to
the one before f1d9179.
|
| |
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | |
| | |
| | | |
bogdanvlviv/pass_params_filename_lineno_to_class_eval
Pass params __FILE__ and __LINE__ + 1 if class_eval with <<
|
| |/ |
|
|\ \
| | |
| | | |
Check for jQuery ajax
|
| | |
| | |
| | | |
jQuery slim version doesn't have ajax, so if a person include this version ajaxFilter raises error.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Allow a default value to be declared for class_attribute
* Convert to using class_attribute default rather than explicit setter
* Removed instance_accessor option by mistake
* False is a valid default value
* Documentation
|
|\ \ \
| | | |
| | | | |
Fix server-generated JS response processing on IE9
|
| | | |
| | | |
| | | |
| | | | |
remote: true
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Define path with __dir__
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
".. with __dir__ we can restore order in the Universe." - by @fxn
Related to 5b8738c2df003a96f0e490c43559747618d10f5f
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
Fix select tag helper used with Enumerable choices
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | | |
Allows a custom object implementing Enumerable to be used as the choices
parameter for a select tag, which previously wasn't possible due to the
call to `empty?` on the choices (which isn't implemented on Enumerable).
|
| |/ /
|/| |
| | | |
[ci skip]
|
| |/
|/|
| |
| |
| | |
This allows auto_discovery_link_tag to support the JSON Feed standard.
See https://jsonfeed.org/version/1 for more information.
|
|\ \
| | |
| | |
| | |
| | | |
koic/suppress_warning_assigned_but_unused_variable
Suppress `warning: assigned but unused variable - stdout`
|
| |/ |
|
| |
| |
| |
| | |
see: https://bugs.ruby-lang.org/issues/6696
|
|/ |
|
| |
|
|\
| |
| | |
Add tests for rendering with variants
|
| | |
|
| |
| |
| |
| |
| |
| | |
* Remove trailing spaces.
* Add backticks around method and command.
* Fix indentation.
|
|\ \
| | |
| | | |
Ensure input to distance_of_time_in_words is not nil
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Internally all input is converted to time so that it can be treated
uniformly.
Remove now-unneeded condition
* Now that all input is treated is converted to time, we no longer need
to type check it.
Rename variables to clarify their purpose
Extract private method to normalize distance_of_time args to time
Update actionview changelog
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
kyuden/remove_unnecessary_attributes_of_select_in_form_with
Remove unnecessary `skip_default_ids` and `allow_method_names_outside_object` attributes of select tag in `form_with`
|
| |/ /
| | |
| | |
| | | |
`allow_method_names_outside_object` attributes of select tag in `form_with`
|
|\ \ \
| | | |
| | | | |
`sort_query_string_params` method is no more used
|
| |/ /
| | |
| | |
| | |
| | | |
- This method was added in this commit https://github.com/rails/rails/commit/33258d713a4bc20b71e92fd656c923a7b189cd33
- The last caller got removed there https://github.com/rails/rails/commit/0b6ce3422370647cad3e91263a291f69b313d65b
|
|/ /
| |
| |
| |
| |
| | |
- `check_parameters` kwargs was added to the `current_page?` method, the implementation was assuming only hashes responds to `delete`. This was causing issues when `current_page?` was called with a Active Model object
- ref https://github.com/rails/rails/pull/27549
- Fixes #28846
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
specified
Without this check, even if config is not specified, `ActionView::Helpers::FormHelper.form_with_generates_remote_forms`
always be set to nil and remote form not be generated.
Follow up to 128b804c6ce40fcbde744f294f8cb98654f6efec
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This configuration is not present in ActionView::Base so we can't let
the action_view.set_configs initializer set it.
Also add tests to make sure this config works.
Fixes #28824
|
| |
| |
| |
| |
| | |
Closes #28382
Closes #28651
|
| |
| |
| |
| |
| | |
Since this protection is now in Parameters we can use it instead of
reimplementing again.
|
| |
| |
| |
| |
| |
| |
| | |
Allows users to not have remote forms by default, since there's
more JS harness, e.g. bundling rails-ujs, otherwise.
Also don't skip creating defaults file anymore. Sprockets isn't the only new config.
|
| |
| |
| |
| |
| |
| |
| | |
Effectively treat nil values as "auto", e.g. whatever a form helper
chooses to interpret it as.
But treat an explicitly assigned false value as disabling.
|