| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
Now we keep only the common code and move the specific code to the gems
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppose you have two resources routed in the following manner:
```ruby
resources :blogs do
resources :posts
end
resources :posts
```
When using polymorphic resource routing like `url_for([@blog, @post])`, and `@blog` is `nil` Rails should still try to match the route to the top-level posts resource.
Fixes #16754
|
| |
|
|
|
|
|
|
|
| |
When we are loading a component and we want to know its version, we are
actually not speaking about the constant but the library itself.
[ci skip]
[Godfrey Chan & Xavier Noria]
|
| |\ |
|
| | |
| |
| |
| | |
Dir.glob result must be already sorted anyway
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
the ERB has already been compiled to Ruby code by the time we're calling
module_eval. Nothing that module eval raises will be caught by a blank
`rescue`, so I think we can remove this
|
| | | |
|
| | |\
| | |
| | | |
Provide a builder for form labels to customize wrapping around I18n content
|
| | | | |
|
| | |\ \
| | | |
| | | | |
Add I18n support for `:placeholder` HTML option is passed to form fields
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is true of the first param (url_for_options),
not of the second options param which is being
documented here.
[ci skip]
|
| | |/ /
| | |
| | |
| | |
| | |
| | | |
Docs for all the other form tag helpers in this
file already clarify this.
[ci skip]
|
| | |/
| |
| |
| | |
fields"
|
| |/ |
|
| | |
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Conflicts:
actionpack/lib/action_controller/metal/mime_responds.rb
actionview/lib/action_view/vendor/html-scanner/html/sanitizer.rb
activerecord/lib/active_record/type/value.rb
|
| | |
| |
| |
| | |
[skip ci]
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | | |
Use #model_name on instances instead of classes
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This allows rails code to be more confdent when asking for a model name, instead of having to ask for the class.
Rails core discussion here: https://groups.google.com/forum/#!topic/rubyonrails-core/ThSaXw9y1F8
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Conflicts:
actionpack/CHANGELOG.md
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Benchmarking the existing code:
```ruby
{ :only_path => options[:host].nil? }.merge!(options.symbolize_keys))
```
Against optimized code, that does not require a new hash or a merge:
```ruby
options = options.symbolize_keys
options[:only_path] = options[:host].nil? unless options.key?(:only_path)
options
```
We see a statistically significant performance gain:
Updated to not mutate incoming parameters
|
| | |\ \ \
| | | | |
| | | | | |
Add I18n support for `:placeholder` HTML option is passed to form fields
|
| | | | | | |
|
| | | | | | |
|
| | |/ / / |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Default to Rails::DeprecatedSanitizer in ActionView::Helpers::SanitizeHelper.
- Add upgrade notes.
- Add sanitizer to new applications Gemfiles.
- Remove 'rails-dom-testing' as a dependency.
|
| |\| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Conflicts:
actionpack/CHANGELOG.md
actionpack/test/controller/integration_test.rb
actionview/CHANGELOG.md
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes
everyone's tests order dependent, which should never be done by the framework.
|
| | | | |
| | | |
| | | |
| | | | |
So this trick is not needed to be documented anymore.
|
| | | |/
| |/| |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The message passed to Minitest's assert_raise is used as output in case
the assertion fails, but we can test against the exact message by using
the actual exception object that is returned from the assert_raise call.
|
| | | |
| | |
| | |
| | | |
just ask whether or not the route is defined
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead.
Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR.
Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead.
The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`.
Paired @sgrif & @schneems
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
[ci skip]
This fixes the broken code block rendering and indents the examples
within the parameter list.
|
| | | |
| | |
| | |
| | | |
tracker, but only half-ways. You can add that layout option on the same render call, and both templates should be added to the dependency tree. But thats going to require a more serious rework of the tracker. Please do help fix this part of it too. For now, render layout needs to be on its own line.
|
| | |\ \
| | | |
| | | |
| | | |
| | | | |
Conflicts:
actionpack/test/abstract_unit.rb
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We are planning to remove mocha from our test suite because of
performance problems. To make this possible we should stop require mocha
on ActionSupport::TestCase.
This should not affect applications since users still need to add mocha
to Gemfile and this already load mocha.
Added FIXME notes to place that still need mocha removal
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
