aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
* sub! can return nilArun Agrawal2013-11-071-1/+1
| | | | | | Revert "drop one more string allocation" This reverts commit 4d15661d6c46c86a62ee1fc358f4b3ef9dd9f2ea.
* drop one more string allocationAaron Patterson2013-11-061-1/+1
|
* drop string allocations in the log subscriberAaron Patterson2013-11-061-2/+12
|
* Merge pull request #12788 from kylefritz/patch-1Rafael Mendonça França2013-11-061-2/+2
| | | | | | rdoc: favicon source shouldn't begin with a slash to reference asset pipeline resource [ci skip] Conflicts: actionview/lib/action_view/helpers/asset_tag_helper.rb
* Refactor File.expand_path usage to remove additional File.joinAlex Johnson2013-11-051-1/+1
|
* Line up the comments for aestheticsDavid Heinemeier Hansson2013-11-031-5/+5
|
* Warnings removed for ruby trunkArun Agrawal2013-11-011-1/+1
| | | Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb
* Fix typo in the CHANGELOGJérémy Lecour2013-10-311-1/+1
|
* Convert CDATA input to string before gsub'ingCarsten Zimmermann2013-10-292-1/+5
| | | | | Rails 3.2 API allowed arbitrary input for cdata_section; this change re-introduces the old behaviour.
* Remove warning of shadowing outer local variableRafael Mendonça França2013-10-271-2/+2
|
* Merge pull request #12636 from kongregate/dont_rescue_ExceptionsRafael Mendonça França2013-10-241-2/+2
|\ | | | | Avoid unnecessary catching of Exception instead of StandardError (conver...
| * Avoid unnecessary catching of Exception instead of StandardError (converting ↵stopdropandrew2013-10-241-2/+2
| | | | | | | | Exceptions into StandardErrors)
* | Merge pull request #10471 from andyw8/button_to_paramsRafael Mendonça França2013-10-242-0/+14
|\ \ | |/ |/| | | | | | | | | Add params option for button_to Conflicts: actionpack/CHANGELOG.md
| * Add params option for button_toAndy Waite2013-09-182-0/+14
| | | | | | | | | | | | The parameters are rendered as hidden form fields within the generated form. This is useful for when a record has multiple buttons associated with it, each of which target the same controller method, but which need to submit different attributes.
* | Ensure the state is clean after one failureRafael Mendonça França2013-10-161-5/+4
| |
* | Merge pull request #12540 from wyaeld/bug/fix-recursive-digestRafael Mendonça França2013-10-163-6/+37
|\ \ | | | | | | | | | Ensure ActionView::Digestor.cache is correctly cleaned up
| * | add a new local variable to track if digests are being stored, to ensure the ↵Brad Murray2013-10-171-2/+2
| | | | | | | | | | | | cleanup works correctly
| * | update digestor code based on reviewBrad Murray2013-10-151-2/+2
| | |
| * | update changelogBrad Murray2013-10-151-0/+5
| | |
| * | Ensure ActionView::Digest.cache is correctly cleaned up whenBrad Murray2013-10-151-6/+6
| | | | | | | | | | | | ActionView::Resolver.caching = false.
| * | Add 2 tests, 1 of which fails, to isolate the digest_caching behaviour ↵Brad Murray2013-10-151-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | causing #12521 If config.action_view.cache_template_loading = false, most likely in a development configuration if config.cache_classes = false & config.action_controller.perform_caching = true. config.action_view.cache_template_loading defaults to the value of config.cache_classes
* | | Fix typo in form_helper.rbAdam Jahnke2013-10-161-1/+1
|/ /
* | Merge pull request #12491 from shamanime/patch-1Rafael Mendonça França2013-10-131-2/+2
|\ \ | | | | | | Fix wrong variable name used in the select_day method documentation
| * | Fix wrong variable name used in the select_day method documentationJefferson Queiroz Venerando2013-10-101-2/+2
| | | | | | | | | The variable name created in the example is `my_date`, the methods were using `my_time` instead.
* | | Change `map` to `map!` to save extra array creation on new arrayVipul A M2013-10-131-1/+1
|/ /
* | Moved viewpathstest into actionview/test/actionpack/controllerArun Agrawal2013-10-091-0/+0
| | | | | | | | These test were not running at all, Now it will run as a tests part.
* | FakeController is not required in AVArun Agrawal2013-10-091-35/+0
| |
* | Merge pull request #12437 from websiteswithclass/masterRafael Mendonça França2013-10-041-6/+6
|\ \ | | | | | | Fixed typo in documentation
| * | Fixed return strings in documentationJoseph Zidell2013-10-031-3/+3
| | |
| * | Fixed typo in documentationJoseph Zidell2013-10-031-3/+3
| | |
* | | Directory name in RUNNING_UNIT_TESTS.rdoc [ci skip]Arun Agrawal2013-10-041-1/+1
|/ /
* | Running all isolated test for actionviewArun Agrawal2013-10-031-1/+1
| | | | | | | | | | 1. fix name for activerecord directory 2. Added actionpack directory to run tests
* | Adds template dependencies rake task from cache_digests gem.Thomas von Deyen2013-09-262-0/+21
| | | | | | | | This adds the rake tasks `cache_digests:dependencies` and `cache_digests:nested_dependencies` from `cache_digests` gem.
* | Add CHANGELOG entry for #12344Rafael Mendonça França2013-09-241-0/+5
| | | | | | | | [ci skip]
* | Use the given name in html_options for the hidden field in ↵Angel N. Sciortino2013-09-242-1/+9
| | | | | | | | collection_check_boxes
* | Merge pull request #10773 from wangjohn/link_and_routing_optionsRafael Mendonça França2013-09-231-2/+3
| | | | | | | | Adding documentation and tests to ``polymorphic_url`` and ``link_to``
* | Fix some edge cases for AV `select` helper with `:selected` optionBogdan Gusiev2013-09-233-1/+22
| |
* | Expand select documentation to tell about the blockRafael Mendonça França2013-09-231-0/+9
| | | | | | | | [ci skip]
* | Use ERB in the CHANGELOG [ci skip]Rafael Mendonça França2013-09-231-3/+5
| |
* | Ability to pass block to AV#select helperBogdan Gusiev2013-09-234-5/+29
| | | | | | | | | | | | | | | | Example: = select(report, "campaign_ids") do - available_campaigns.each do |c| %option{:data => {:tags => c.tags.to_json}, :value => c.id}= c.name
* | handle `:namespace` form option in collection labelsVasiliy Ermolovich2013-09-224-1/+43
| |
* | Merge pull request #12232 from claudiob/delete-unused-helper-fixturesSantiago Pastorino2013-09-204-16/+0
|\ \ | | | | | | Remove unused AV helper fixtures from e10a2531
| * | Remove unused AV helper fixtures from e10a2531claudiob2013-09-144-16/+0
| | | | | | | | | | | | | | | Several fixtures for helpers are removed. They were introduced in ActionView by @strzalek but never referenced in any test.
* | | Bust the template digest cache key when details are changedDaniel Schierbeck2013-09-193-2/+39
| | | | | | | | | | | | | | | | | | Since the lookup details will influence which template is resolved, they need to be included in the cache key -- otherwise two different templates may erroneously share the same digest value.
* | | There's no need to do thisSantiago Pastorino2013-09-171-4/+1
|/ / | | | | | | | | | | | | AS does the following inside Time.find_zone! ... `ActiveSupport::TimeZone[time_zone] || TZInfo::Timezone.get(time_zone)` and given that the test is stubbing AS::TZ[] we don't need the removed code.
* | "generates" applies to "collection radio" so it should be singularWaynn Lue2013-09-121-2/+2
| | | | | | I accidentally pushed this change to docrails before realizing that it's technically a code change, so I'm opening this pull request (and rolling back my change to docrails).
* | Merge pull request #12112 from adamniedzielski/fix-form-for-namespace-and-asRafael Mendonça França2013-09-123-1/+21
|\ \ | | | | | | | | | | | | | | | | | | form_for - fix :namespace and :as options clash Conflicts: actionview/CHANGELOG.md
| * | form_for - fix :namespace and :as options clashAdam Niedzielski2013-09-093-1/+21
| | | | | | | | | | | | | | | | | | | | | | | | :as option should not overwrite :namespace option when generating html id attribute of the form element. id should be prefixed by specified namespace even if :as option is present Add test case showing the issue and code fixing it
* | | Write the right CHANGELOG entry for #11603Rafael Mendonça França2013-09-121-1/+1
| | | | | | | | | | | | [ci skip]
* | | Merge pull request #11603 from ↵Rafael Mendonça França2013-09-123-2/+10
|\ \ \ | | | | | | | | | | | | | | | | | | | | jetthoughts/join_strings_instead_of_contactination Cleanup: replace String concatenation by joining for excerpt helper