Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | sub! can return nil | Arun Agrawal | 2013-11-07 | 1 | -1/+1 |
| | | | | | | Revert "drop one more string allocation" This reverts commit 4d15661d6c46c86a62ee1fc358f4b3ef9dd9f2ea. | ||||
* | drop one more string allocation | Aaron Patterson | 2013-11-06 | 1 | -1/+1 |
| | |||||
* | drop string allocations in the log subscriber | Aaron Patterson | 2013-11-06 | 1 | -2/+12 |
| | |||||
* | Merge pull request #12788 from kylefritz/patch-1 | Rafael Mendonça França | 2013-11-06 | 1 | -2/+2 |
| | | | | | | rdoc: favicon source shouldn't begin with a slash to reference asset pipeline resource [ci skip] Conflicts: actionview/lib/action_view/helpers/asset_tag_helper.rb | ||||
* | Refactor File.expand_path usage to remove additional File.join | Alex Johnson | 2013-11-05 | 1 | -1/+1 |
| | |||||
* | Line up the comments for aesthetics | David Heinemeier Hansson | 2013-11-03 | 1 | -5/+5 |
| | |||||
* | Warnings removed for ruby trunk | Arun Agrawal | 2013-11-01 | 1 | -1/+1 |
| | | | Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb | ||||
* | Fix typo in the CHANGELOG | Jérémy Lecour | 2013-10-31 | 1 | -1/+1 |
| | |||||
* | Convert CDATA input to string before gsub'ing | Carsten Zimmermann | 2013-10-29 | 2 | -1/+5 |
| | | | | | Rails 3.2 API allowed arbitrary input for cdata_section; this change re-introduces the old behaviour. | ||||
* | Remove warning of shadowing outer local variable | Rafael Mendonça França | 2013-10-27 | 1 | -2/+2 |
| | |||||
* | Merge pull request #12636 from kongregate/dont_rescue_Exceptions | Rafael Mendonça França | 2013-10-24 | 1 | -2/+2 |
|\ | | | | | Avoid unnecessary catching of Exception instead of StandardError (conver... | ||||
| * | Avoid unnecessary catching of Exception instead of StandardError (converting ↵ | stopdropandrew | 2013-10-24 | 1 | -2/+2 |
| | | | | | | | | Exceptions into StandardErrors) | ||||
* | | Merge pull request #10471 from andyw8/button_to_params | Rafael Mendonça França | 2013-10-24 | 2 | -0/+14 |
|\ \ | |/ |/| | | | | | | | | | Add params option for button_to Conflicts: actionpack/CHANGELOG.md | ||||
| * | Add params option for button_to | Andy Waite | 2013-09-18 | 2 | -0/+14 |
| | | | | | | | | | | | | The parameters are rendered as hidden form fields within the generated form. This is useful for when a record has multiple buttons associated with it, each of which target the same controller method, but which need to submit different attributes. | ||||
* | | Ensure the state is clean after one failure | Rafael Mendonça França | 2013-10-16 | 1 | -5/+4 |
| | | |||||
* | | Merge pull request #12540 from wyaeld/bug/fix-recursive-digest | Rafael Mendonça França | 2013-10-16 | 3 | -6/+37 |
|\ \ | | | | | | | | | | Ensure ActionView::Digestor.cache is correctly cleaned up | ||||
| * | | add a new local variable to track if digests are being stored, to ensure the ↵ | Brad Murray | 2013-10-17 | 1 | -2/+2 |
| | | | | | | | | | | | | cleanup works correctly | ||||
| * | | update digestor code based on review | Brad Murray | 2013-10-15 | 1 | -2/+2 |
| | | | |||||
| * | | update changelog | Brad Murray | 2013-10-15 | 1 | -0/+5 |
| | | | |||||
| * | | Ensure ActionView::Digest.cache is correctly cleaned up when | Brad Murray | 2013-10-15 | 1 | -6/+6 |
| | | | | | | | | | | | | ActionView::Resolver.caching = false. | ||||
| * | | Add 2 tests, 1 of which fails, to isolate the digest_caching behaviour ↵ | Brad Murray | 2013-10-15 | 1 | -0/+26 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | causing #12521 If config.action_view.cache_template_loading = false, most likely in a development configuration if config.cache_classes = false & config.action_controller.perform_caching = true. config.action_view.cache_template_loading defaults to the value of config.cache_classes | ||||
* | | | Fix typo in form_helper.rb | Adam Jahnke | 2013-10-16 | 1 | -1/+1 |
|/ / | |||||
* | | Merge pull request #12491 from shamanime/patch-1 | Rafael Mendonça França | 2013-10-13 | 1 | -2/+2 |
|\ \ | | | | | | | Fix wrong variable name used in the select_day method documentation | ||||
| * | | Fix wrong variable name used in the select_day method documentation | Jefferson Queiroz Venerando | 2013-10-10 | 1 | -2/+2 |
| | | | | | | | | | The variable name created in the example is `my_date`, the methods were using `my_time` instead. | ||||
* | | | Change `map` to `map!` to save extra array creation on new array | Vipul A M | 2013-10-13 | 1 | -1/+1 |
|/ / | |||||
* | | Moved viewpathstest into actionview/test/actionpack/controller | Arun Agrawal | 2013-10-09 | 1 | -0/+0 |
| | | | | | | | | These test were not running at all, Now it will run as a tests part. | ||||
* | | FakeController is not required in AV | Arun Agrawal | 2013-10-09 | 1 | -35/+0 |
| | | |||||
* | | Merge pull request #12437 from websiteswithclass/master | Rafael Mendonça França | 2013-10-04 | 1 | -6/+6 |
|\ \ | | | | | | | Fixed typo in documentation | ||||
| * | | Fixed return strings in documentation | Joseph Zidell | 2013-10-03 | 1 | -3/+3 |
| | | | |||||
| * | | Fixed typo in documentation | Joseph Zidell | 2013-10-03 | 1 | -3/+3 |
| | | | |||||
* | | | Directory name in RUNNING_UNIT_TESTS.rdoc [ci skip] | Arun Agrawal | 2013-10-04 | 1 | -1/+1 |
|/ / | |||||
* | | Running all isolated test for actionview | Arun Agrawal | 2013-10-03 | 1 | -1/+1 |
| | | | | | | | | | | 1. fix name for activerecord directory 2. Added actionpack directory to run tests | ||||
* | | Adds template dependencies rake task from cache_digests gem. | Thomas von Deyen | 2013-09-26 | 2 | -0/+21 |
| | | | | | | | | This adds the rake tasks `cache_digests:dependencies` and `cache_digests:nested_dependencies` from `cache_digests` gem. | ||||
* | | Add CHANGELOG entry for #12344 | Rafael Mendonça França | 2013-09-24 | 1 | -0/+5 |
| | | | | | | | | [ci skip] | ||||
* | | Use the given name in html_options for the hidden field in ↵ | Angel N. Sciortino | 2013-09-24 | 2 | -1/+9 |
| | | | | | | | | collection_check_boxes | ||||
* | | Merge pull request #10773 from wangjohn/link_and_routing_options | Rafael Mendonça França | 2013-09-23 | 1 | -2/+3 |
| | | | | | | | | Adding documentation and tests to ``polymorphic_url`` and ``link_to`` | ||||
* | | Fix some edge cases for AV `select` helper with `:selected` option | Bogdan Gusiev | 2013-09-23 | 3 | -1/+22 |
| | | |||||
* | | Expand select documentation to tell about the block | Rafael Mendonça França | 2013-09-23 | 1 | -0/+9 |
| | | | | | | | | [ci skip] | ||||
* | | Use ERB in the CHANGELOG [ci skip] | Rafael Mendonça França | 2013-09-23 | 1 | -3/+5 |
| | | |||||
* | | Ability to pass block to AV#select helper | Bogdan Gusiev | 2013-09-23 | 4 | -5/+29 |
| | | | | | | | | | | | | | | | | Example: = select(report, "campaign_ids") do - available_campaigns.each do |c| %option{:data => {:tags => c.tags.to_json}, :value => c.id}= c.name | ||||
* | | handle `:namespace` form option in collection labels | Vasiliy Ermolovich | 2013-09-22 | 4 | -1/+43 |
| | | |||||
* | | Merge pull request #12232 from claudiob/delete-unused-helper-fixtures | Santiago Pastorino | 2013-09-20 | 4 | -16/+0 |
|\ \ | | | | | | | Remove unused AV helper fixtures from e10a2531 | ||||
| * | | Remove unused AV helper fixtures from e10a2531 | claudiob | 2013-09-14 | 4 | -16/+0 |
| | | | | | | | | | | | | | | | Several fixtures for helpers are removed. They were introduced in ActionView by @strzalek but never referenced in any test. | ||||
* | | | Bust the template digest cache key when details are changed | Daniel Schierbeck | 2013-09-19 | 3 | -2/+39 |
| | | | | | | | | | | | | | | | | | | Since the lookup details will influence which template is resolved, they need to be included in the cache key -- otherwise two different templates may erroneously share the same digest value. | ||||
* | | | There's no need to do this | Santiago Pastorino | 2013-09-17 | 1 | -4/+1 |
|/ / | | | | | | | | | | | | | AS does the following inside Time.find_zone! ... `ActiveSupport::TimeZone[time_zone] || TZInfo::Timezone.get(time_zone)` and given that the test is stubbing AS::TZ[] we don't need the removed code. | ||||
* | | "generates" applies to "collection radio" so it should be singular | Waynn Lue | 2013-09-12 | 1 | -2/+2 |
| | | | | | | I accidentally pushed this change to docrails before realizing that it's technically a code change, so I'm opening this pull request (and rolling back my change to docrails). | ||||
* | | Merge pull request #12112 from adamniedzielski/fix-form-for-namespace-and-as | Rafael Mendonça França | 2013-09-12 | 3 | -1/+21 |
|\ \ | | | | | | | | | | | | | | | | | | | form_for - fix :namespace and :as options clash Conflicts: actionview/CHANGELOG.md | ||||
| * | | form_for - fix :namespace and :as options clash | Adam Niedzielski | 2013-09-09 | 3 | -1/+21 |
| | | | | | | | | | | | | | | | | | | | | | | | | :as option should not overwrite :namespace option when generating html id attribute of the form element. id should be prefixed by specified namespace even if :as option is present Add test case showing the issue and code fixing it | ||||
* | | | Write the right CHANGELOG entry for #11603 | Rafael Mendonça França | 2013-09-12 | 1 | -1/+1 |
| | | | | | | | | | | | | [ci skip] | ||||
* | | | Merge pull request #11603 from ↵ | Rafael Mendonça França | 2013-09-12 | 3 | -2/+10 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | jetthoughts/join_strings_instead_of_contactination Cleanup: replace String concatenation by joining for excerpt helper |