aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
* don't fallback to RACK_ENV when RAILS_ENV is not presentDamien Mathieu2015-03-191-1/+1
|
* Remove additional handling of boolean attributes on button to helperCarlos Antonio da Silva2015-03-181-30/+0
| | | | | | | | This logic was just doing duplicated work, since the button_to helper relies on tag/content_tag to generate the button html, which already handles all boolean attributes it knows about. The code dates back to 2005: 43c470fae468ef63e0d5c3dc1e202925685fd47b.
* Closes rails/rails#18864: Renaming transactional fixtures to transactional testsBrandon Weiss2015-03-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | I’m renaming all instances of `use_transcational_fixtures` to `use_transactional_tests` and “transactional fixtures” to “transactional tests”. I’m deprecating `use_transactional_fixtures=`. So anyone who is explicitly setting this will get a warning telling them to use `use_transactional_tests=` instead. I’m maintaining backwards compatibility—both forms will work. `use_transactional_tests` will check to see if `use_transactional_fixtures` is set and use that, otherwise it will use itself. But because `use_transactional_tests` is a class attribute (created with `class_attribute`) this requires a little bit of hoop jumping. The writer method that `class_attribute` generates defines a new reader method that return the value being set. Which means we can’t set the default of `true` using `use_transactional_tests=` as was done previously because that won’t take into account anyone using `use_transactional_fixtures`. Instead I defined the reader method manually and it checks `use_transactional_fixtures`. If it was set then it should be used, otherwise it should return the default, which is `true`. If someone uses `use_transactional_tests=` then it will overwrite the backwards-compatible method with whatever they set.
* Cleaning JavaScriptHelperTestThiago Pradi2015-03-141-8/+1
|
* Cleaning unused views from actionpack tests inside actionviewThiago Pradi2015-03-141-1/+0
|
* Zlib isn't required for AssetTagHelperTest anymoreThiago Pradi2015-03-141-1/+0
|
* Cleaning unused methods from abstract_unitThiago Pradi2015-03-141-57/+0
|
* Deleting unused fixturesThiago Pradi2015-03-142-10/+0
|
* [ci skip] correct output of selectKuldeep Aggarwal2015-03-131-15/+15
|
* [CI SKIP] Correct output of options_for_selectAkshay Vishnoi2015-03-131-5/+5
|
* Merge pull request #19252 from kaspth/single-escaping-strip-tagsRafael Mendonça França2015-03-103-2/+6
|\ | | | | Let strip_tags leave HTML escaping to Rails.
| * Let strip_tags leave HTML escaping to Rails.Kasper Timm Hansen2015-03-103-2/+6
| | | | | | | | Prevents double escaping errors, such as "&" becoming "&".
* | Target Ruby 2.2.1 in gemspecsPeter Suschlik2015-03-091-1/+1
|/ | | | This is a follow-up to #19257
* Merge pull request #19221 from matthewd/random-testsMatthew Draper2015-03-062-6/+1
|\ | | | | Run all our tests in random order
| * Revert "For now, we will keep sorting the tests."Matthew Draper2015-03-061-1/+1
| | | | | | | | This reverts commit 7025d7769dc53f0a3ffab8b537727ef3fee367fc.
| * Revert "Leave all our tests as order_dependent! for now"Matthew Draper2015-03-061-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2f52f969885b2834198de0045748436a4651a94e. Conflicts: actionmailer/test/abstract_unit.rb actionview/test/abstract_unit.rb activemodel/test/cases/helper.rb activerecord/test/cases/helper.rb activesupport/test/abstract_unit.rb railties/test/abstract_unit.rb
* | put the changelog entry in the right file :sweat: [ci skip]Yves Senn2015-03-061-0/+7
| |
* | `number_to_percentage` and `precision: 0` work with `NAN` and `INFINITY`.Yves Senn2015-03-061-0/+4
| | | | | | | | Closes #19227.
* | don't need to rescue Exception in this caseAaron Patterson2015-03-052-1/+7
| |
* | [ci skip] Delete excess white in documentationAnton Davydov2015-03-051-1/+1
| |
* | [ci skip] Add information about sanitize option in TextHelper#highlightAnton Davydov2015-03-051-1/+6
|/
* Merge pull request #19144 from y-yagi/fix_streaming_bufferRafael Mendonça França2015-03-043-1/+13
|\ | | | | fix ActionView::Template::Error when using Streaming with capture.
| * fix ActionView::Template::Error when using Streaming with capture.yuuji.yaginuma2015-03-013-1/+13
| | | | | | | | can't acquire a encoding from StreamingBuffer. fixes #12001
* | Fix spelling [ci skip]Yu Haidong2015-03-041-8/+8
| |
* | Avoid accurate assertions on error messagesRobin Dupret2015-03-021-1/+1
| | | | | | | | | | Since there are disparities between the raised error messages on the different implementations, let's avoid being too accurate.
* | move _generate_paths_by_default to where it is usedAaron Patterson2015-03-011-0/+6
|/ | | | | _generate_paths_by_default wasn't used in AD::Routing::UrlFor, so we should be able to move it where it is used in AV::Routing
* Fix regression when passing a value different of String.Ulisses Almeida2015-02-263-1/+15
| | | | | | | | | | | | | | | | | The previous version of rails(4.2.0) you can pass objects to the default option of translation helper. For example: ```ruby t('foo', default: 1) ``` But on rails 4.2.1 version this kind of use stopped to work, because started only to accept String types. Now with this fix we can use orther value types on this helper again.
* [ci skip] Add changelog entry for #18948.Kasper Timm Hansen2015-02-261-0/+20
|
* Fix typos in ActionView::Helpers::FormBuilder comment [ci skip]Yu Haidong2015-02-261-1/+2
|
* Merge pull request #19074 from ↵Rafael Mendonça França2015-02-253-5/+20
|\ | | | | | | | | Mession/fix_test_dependency_of_erb_template_partial_with_layout Fix dependency tracker bug
| * Fix dependency tracker bugJuho Leinonen2015-02-253-5/+20
| |
* | Merge pull request #18948 from kaspth/automatic-collection-cachingRafael Mendonça França2015-02-2510-2/+193
|\ \ | |/ |/| Merge multi_fetch_fragments.
| * Collections automatically cache and fetch partials.Kasper Timm Hansen2015-02-217-3/+101
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Collections can take advantage of `multi_read` if they render one template and their partials begin with a cache call. The cache call must correspond to either what the collections elements are rendered as, or match the inferred name of the partial. So with a notifications/_notification.html.erb template like: ```ruby <% cache notification %> <%# ... %> <% end %> ``` A collection would be able to use `multi_read` if rendered like: ```ruby <%= render @notifications %> <%= render partial: 'notifications/notification', collection: @notifications, as: :notification %> ```
| * Merge multi_fetch_fragments.Kasper Timm Hansen2015-02-206-2/+95
| | | | | | | | | | | | | | | | Makes caching a collection of template partials faster using `read_multi` on the Rails cache store. Some caching implementations have optimized `read_multi` so we don't have to check in the cache store for every template.
* | Error message testing fixFranky W2015-02-204-5/+8
| | | | | | | | | | | | | | | | | | The testing of error messages have been implemented wrongly a few times. This is an attempt to fix it. For example, some of these test should have failed with the new code. The reason they are not failling with the new string is the fact they were not being tested beforehand.
* | Merge pull request #17069 from modosc/masterRafael Mendonça França2015-02-201-7/+9
|\ \ | | | | | | move cache_digests rake methods into their own namespace
| * | move cache_digests rake methods into their own namespacejonathan schatz2014-09-261-7/+9
| | |
* | | Fix cache_helper comment ERBAnthony Dmitriyev2015-02-201-2/+2
| | |
* | | Merge pull request #17143 from kuldeepaggarwal/fix-mailToRafael Mendonça França2015-02-202-1/+6
|\ \ \ | | | | | | | | | | | | mail_to helper method fix
| * | | do not generate blank options in mailToKuldeep Aggarwal2014-10-022-2/+8
| | | | | | | | | | | | | | | | | | | | when mail_to generate blank options for any passed options(cc, bcc, body, subject) then MICROSOFT OUTLOOK treats it differently and set wrong values in different options.
* | | | Use a name that better reflect the return valueRafael Mendonça França2015-02-201-2/+2
| | | |
* | | | Merge pull request #17138 from jpcody/rename_default_form_builderRafael Mendonça França2015-02-201-2/+2
|\ \ \ \ | | | | | | | | | | | | | | | Rename default_form_builder to avoid collision
| * | | | Rename default_form_builder to avoid collisionJoshua Cody2014-10-011-2/+2
| | | | |
* | | | | Corrects the API to method select_tagLeandro Nunes2015-02-201-2/+1
| | | | | | | | | | | | | | | | | | | | The 'selected' option is not doing what it should do. The expected behavior is to pass the value selected by default for the options_from_collection_for_select method
* | | | | Make the helpers a required argumentEvan Phoenix2015-02-191-1/+1
| | | | |
* | | | | Merge pull request #18411 from todd/extract_record_tag_helperRafael Mendonça França2015-02-184-186/+22
|\ \ \ \ \ | | | | | | | | | | | | Remove RecordTagHelper
| * | | | | Remove RecordTagHelper, add extraction noticesTodd Bealmear2015-02-164-186/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Per DHH in #18337, ActionView::Helpers::RecordTagHelper has been extracted to an external gem (source currently lives at todd/record_tag_helper). Removal notices have also been added for anyone upgrading that use the extracted methods.
* | | | | | Add nodoc to private constant [ci skip]Rafael Mendonça França2015-02-181-1/+1
| | | | | |
* | | | | | Merge pull request #18970 from nithinbekal/local-assigns-docRafael Mendonça França2015-02-181-0/+8
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Add documentation for local_assigns [ci skip]
| * | | | | | Add documentation for local_assigns [ci skip]Nithin Bekal2015-02-171-0/+8
| |/ / / / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 16:02:10 +0000