aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
* Revert "revises a test to account for case-insensitive file systems"Matthew Draper2015-06-141-18/+2
| | | | This reverts commit d345ce9630ce4c01bc81a09fb015e7bd935600ad.
* Merge pull request #20480 from senny/test_runnerYves Senn2015-06-121-0/+4
|\ | | | | use our own runner for Rails framework components `bin/test`
| * select the AR adapter through `bin/test`.Yves Senn2015-06-111-0/+1
| |
| * use our runner (`bin/test`) for framework components.Yves Senn2015-06-111-0/+3
| | | | | | | | | | | | | | | | | | | | This adds a script `bin/test` to most Rails framework components. The script uses the rails minitest plugin to augment the runner. See https://github.com/rails/rails/pull/19571 for details about the plugin. I did not yet add `bin/test` for activerecord, activejob and railties. These components rely on specific setup performed in the rake-tasks.
* | Merge pull request #20058 from farukaydin/cache-digests-dependency-rakeRafael Mendonça França2015-06-112-1/+22
|\ \ | | | | | | add error log that notify 'file not found' when using cache_digest dependency rake
| * | add error log that notify 'file not found' when using ↵Faruk AYDIN2015-05-072-1/+22
| | | | | | | | | | | | cache_digests:dependency and cache_digests:nested_dependency tasks
* | | Exclude cache_digests:dependencies rake task in api appJorge Bejar2015-06-111-2/+4
| |/ |/|
* | Tiny documentation edits [ci skip]Robin Dupret2015-06-091-7/+7
| |
* | Raise an ArgumentError when `include_blank` is false for a required field inGrey Baker2015-06-083-3/+21
| | | | | | | | | | | | | | | | | | | | `Tags::Base#select_content_tag`. Previously, passing a falsey value to `include_blank` would be ignored if the field was required, and a blank line would still be inserted. The following will now raise instead of quietly failing: `select("post", "category", %w(a required field), { include_blank: false }, required: 'required')`
* | [ci skip] Fix hours to minutes in `select_minute`yui-knk2015-06-071-1/+1
| |
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-06-051-1/+1
|\ \
| * | [ci skip] Fix typo you/yourclaudiob2015-05-231-1/+1
| | |
* | | Revert "Merge pull request #19685 from vngrs/actionview_parent_layout_bug"Rafael Mendonça França2015-06-022-31/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a9d58c77da800bb0052c9bfa432828b02526022c, reversing changes made to 041c2c879a3c4086ad3aa6d30fed1eede1d53c11. Reason: The old behavior is how it was working in previous version of Rails since 4.0.x so it is not safe to backport to a stable branch. See https://github.com/rails/rails/issues/19626#issuecomment-89862258 and https://github.com/rails/rails/pull/15050#issuecomment-45333449
* | | Remove `assigns` and `assert_template`.Guo Xiang Tan2015-05-306-135/+38
| | |
* | | Merge pull request #20331 from arunagw/arunagw-remove-unused-package-tasksRafael Mendonça França2015-05-281-7/+0
|\ \ \ | | | | | | | | Remove unused package tasks
| * | | Remove unused package tasksArun Agrawal2015-05-281-7/+0
| | | | | | | | | | | | | | | | We are using `all:build` now.
* | | | Deprecate `:nothing` option for render methodMehmet Emin İNAÇ2015-05-281-1/+1
|/ / / | | | | | | | | | `head` method works similar to `render` method with `:nothing` option
* | | Merge pull request #20263 from arunagw/aa-remove-custom-lines-actionviewRafael Mendonça França2015-05-281-21/+3
|\ \ \ | | | | | | | | Remove custom `lines` and use `/tools/line_statistics`
| * | | Remove custom `lines` and use `/tools/line_statistics`Arun Agrawal2015-05-221-21/+3
| | | |
* | | | Merge pull request #20262 from arunagw/aa-remove-broken-unused-release-taskYves Senn2015-05-271-7/+0
|\ \ \ \ | | | | | | | | | | Remove broken and unused release task
| * | | | Remove broken and unused release taskArun Agrawal2015-05-221-7/+0
| |/ / / | | | | | | | | | | | | | | | | - We do release with release.rb - There is no `rake/gemcutter`
* / / / Remove deprecation warning.Guo Xiang Tan2015-05-221-1/+1
|/ / / | | | | | | | | | https://travis-ci.org/rails/rails/jobs/63594316#L1982
* | | revises a test to account for case-insensitive file systemsXavier Noria2015-05-211-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The patched test assumed the file system is case-sensitive, but that is not necessarily the case. In particular, this test did not pass in the recommended setup for the dev box, because the /vagrant shared folder is case-insensitive. After looking at some gems that provide access to file system metadata I have chosen to go with the check you can see in the patch because, albeit it's a bit dirty creating a file, it is super easy to understand and clearly portable. References https://github.com/rails/rails-dev-box/issues/102.
* | | Fix docs markup for option_groups_from_collection_for_select [ci skip]Carlos Antonio da Silva2015-05-191-1/+1
| | |
* | | spelling fix [ci skip]karanarora2015-05-191-1/+1
| | |
* | | Pass over CHANGELOGS [ci skip]Prathamesh Sonpatki2015-05-161-2/+3
| | |
* | | Do not put partial name to local_assigns when rendering without an objectHenrik Nygren2015-05-144-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | When one rendered a partial template without specifying an object or a collection (e.g. <%= render partial: 'partial_name' %>), Rails would make an object called :partial_name available in local_assigns. I don't think this was the intended behavior, since no local variable called 'partial_name' gets defined in the view.
* | | Merge pull request #20149 from karanarora/Typo-fixRafael Mendonça França2015-05-131-11/+11
|\ \ \ | | | | | | | | remove redundant parenthesis.
| * | | remove redundant parenthesis. karanarora2015-05-141-11/+11
| | | |
* | | | [ci skip] Don’t encourage `sudo gem install`claudiob2015-05-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I think we are better off leaving `sudo` outside of the documented way of installing gems (`activerecord`, `actionpack`, …). We don’t want newbies to think that `sudo` is required or, even worse, than they actually have to type `[sudo] gem install`. In most scenarios, `sudo` is not needed to install gems, and people who do need it, probably already know about it. What do you think? :grin:
* | | | Better formatted documents [ci skip]Gourav Tiwari2015-05-081-8/+12
| |/ / |/| |
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-05-081-0/+1
|\ \ \
| * | | [ci skip] Add an example to ActionView::Helpers::FormBuilder#labelyui-knk2015-05-081-0/+1
| | | |
* | | | Updated dynamic value of id in comments [ci skip]Gourav Tiwari2015-05-071-1/+1
| | | | | | | | | | | | | | | | In help text for method, dynamic value makes it hard to understand, so replaced with static value matching with example above
* | | | Example updated [ci skip]Ankit Gupta2015-05-071-1/+1
| |_|/ |/| | | | | | | | Should be ApplicationController not ApplicationController::Base
* | | use the right assertions.Yves Senn2015-05-051-2/+2
| | | | | | | | | | | | | | | | | | | | | Prompted by: https://github.com/rails/rails/commit/e38dd7bfa4360e241eadf0cf44abdf86ea33a393#commitcomment-11011496 /cc @kuldeepaggarwal
* | | Remove :rescue_format option for translate helper since it's no longer ↵Bernard Potocki2015-05-043-16/+9
| | | | | | | | | | | | supported by I18n.
* | | Merge pull request #19998 from imanel/fix-missing-translationMatthew Draper2015-05-053-4/+24
|\ \ \ | | | | | | | | Handle raise flag in translate when both main and default translation is missing.
| * | | Handle raise flag in translate when both main and default translation is ↵Bernard Potocki2015-05-043-4/+24
| | | | | | | | | | | | | | | | missing. Fixes #19967
* | | | Merge pull request #18783 from mikestone14/actionview-image-tag-overrideRafael Mendonça França2015-05-032-0/+15
|\ \ \ \ | | | | | | | | | | Actionview image tag size option override
| * | | | image_tag raises an error if size is passed with height and/or widthMike Stone2015-04-242-0/+15
| | | | |
* | | | | Use ruby 1.9 lambda syntax in documentations [ci skip]Mehmet Emin İNAÇ2015-05-031-1/+1
| |/ / / |/| | |
* | | | [ci skip] Fix example codes of form_for methodyui-knk2015-05-021-26/+36
| | | |
* | | | add test-case for `link_to_if` behavior with a block.Yves Senn2015-05-011-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This illustrates the purpose of the block for `link_to_if` and `link_to_unless` helper methods. It should help to prevent further mistakes like #19844.
* | | | Revert "Merge pull request #19844 from ↵Yves Senn2015-05-013-10/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | stevenspiel/link_to_if_block_helper_addition" This reverts commit d459b001b43d25053e7982e96eb8383538a6e358, reversing changes made to 4d4950fae9e2a6970b5f1793aadc56a0b44e28a3. :sweat: The block is not supposed to be passed to `link_to`. It's used for a customized behavior of the `condtion = false` case. The docs illustrate that like so: ``` <%= link_to_if(@current_user.nil?, "Login", { controller: "sessions", action: "new" }) do link_to(@current_user.login, { controller: "accounts", action: "show", id: @current_user }) end %> ```
* | | | Merge pull request #19844 from stevenspiel/link_to_if_block_helper_additionYves Senn2015-05-013-1/+10
|\ \ \ \ | | | | | | | | | | | | | | | Update url_helper.rb
| * | | | Update url_helper.rbSteven Spiel2015-04-211-1/+1
| | | | | | | | | | | | | | | add block to link_to_if when condition is true
* | | | | Make ActionMailer #cache helper a no-op, not an exceptionJavan Makhmali2015-04-281-1/+1
| |_|_|/ |/| | |
* | | | Merge pull request #19892 from derekprior/dp-translate-helper-docsZachary Scott2015-04-251-23/+36
|\ \ \ \ | | | | | | | | | | Correct translate helper docs [ci skip]
| * | | | Correct translate helper docs [ci skip]Derek Prior2015-04-241-23/+36
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The documentation previously stated that calling `translate(".foo")` was equivalent to calling `I18n.translate("people.index.foo")` which is incorrect due to the various other functions of the `translate` view helper. This has been fixed. Additionally, a note about forcing the view helper to re-raise exceptions was added to the section detailing the handling of missing translations. Other cleanup includes: * Consistent formatting of code * Stop indenting bulleted list as a code sample * Tighten some of the language * Wrap at 80 characters.
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-30 06:02:46 +0000