aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
* You give jruby_skip & rubinius_skip a good nameAkira Matsuda2019-08-021-11/+0
| | | | | | | | This hack prevails everywhere in the codebase by being copy & pasted, and it's actually not a negative thing but a necessary thing for framework implementors, so it should better have a name and be a thing. And with this commit, activesupport/test/abstract_unit.rb now doesn't silently autoload AS::TestCase, so we're ready to establish clearner environment for running AS tests (probably in later commits)
* MethodCallAssertions is a regular player of the team ActiveSupport::TestCase nowAkira Matsuda2019-08-021-3/+0
| | | | It's used everywhere, clean and mature enough
* Fix `_write_layout_method`Ryuta Kamizono2019-08-021-1/+1
|
* No private defRafael Mendonça França2019-08-012-3/+6
|
* These methods doesn't have to be `protected`Akira Matsuda2019-08-012-6/+3
|
* Use `try` only when we're unsure if the receiver would respond_to the methodAkira Matsuda2019-08-018-11/+8
|
* Merge pull request #36818 from hc0208/fix_typo_in_data_remote_jsRyuta Kamizono2019-07-311-1/+1
|\ | | | | Fix typo submited → submitted
| * Fix typo submited → submitted [ci skip]hc02082019-07-311-1/+1
| |
* | Avoid creating new Array when looking up already registered detailAkira Matsuda2019-07-311-1/+1
|/
* Merge pull request #36813 from haruyuki97/haruyuki97/fix-comment-in-url-helperPrem Sichanugrist2019-07-301-1/+1
|\ | | | | | | | | Fix a/an usage on `phone_to` documentation. [ci skip]
| * fix a typo [ci skip]haruyuki972019-07-301-1/+1
| |
* | Use match? where we don't need MatchDataAkira Matsuda2019-07-291-1/+1
| |
* | Add AS::TimeZone#match?Akira Matsuda2019-07-292-2/+4
| |
* | Suppress Ruby warning: :warning: non-nil $, will be deprecatedAkira Matsuda2019-07-291-2/+6
| |
* | Assert query counts in cache relation testst00122019-07-281-1/+16
|/ | | | This is to guard the change in #35982
* Use match? where we don't need MatchDataAkira Matsuda2019-07-272-2/+2
| | | | We're already running Performance/RegexpMatch cop, but it seems like the cop is not always =~ justice
* Change test description with the correct URL namePietro Moro2019-07-261-8/+8
|
* Merge pull request #36178 from sshaw/fix_time_zone_options_priorityRafael França2019-07-261-3/+4
|\ | | | | Update time_zone_options_for_select docs
| * Update time_zone_options_for_select docssshaw2019-05-041-3/+4
| |
* | Change the test description to say the URL helper name in test.Abhay Nikam2019-07-271-7/+7
| |
* | Added a phone_to helper method, on the style of mail_to and sms_to. (#36775)Pietro Moro2019-07-263-0/+115
| | | | | | | | | | | | | | | | | | | | | | * Added a phone_to helper method, on the style of mail_to and sms_to. It creates an anchor tag with the href set to tel: *here your number* which, when clicked on a mobile phone, or on a desktop with a supported application, lets the phone app kick in, and it prepopulates it with the phone number specified. [Pietro Moro + Rafael Mendonça França]
* | Merge pull request #36764 from ↵Rafael França2019-07-262-0/+19
|\ \ | | | | | | | | | | | | willianveiga/feature/inputs-inside-disabled-fieldset-are-not-submited-on-remote-true-forms Inputs inside disabled fieldset are not submited on remote: true forms
| * | Add test for submitted fields within disabled fieldsetsWillian Gustavo Veiga2019-07-261-0/+18
| | |
| * | Issue #36728 - Inputs inside disabled fieldset are not submited on remote: ↵Willian Gustavo Veiga2019-07-251-0/+1
| | | | | | | | | | | | true forms
* | | Add a default value for arg `format` in `ActionView::Digestor.digest()`Sharang Dashputre2019-07-261-1/+1
| | |
* | | Merge pull request #35334 from sharang-d/digest-doc-updateRafael França2019-07-261-3/+4
|\ \ \ | | | | | | | | Update comment for ActionView::Digestor.digest [ci skip]
| * | | Update comment for ActionView::Digestor.digest [ci skip]Sharang Dashputre2019-04-161-3/+4
| | | |
* | | | Merge pull request #36576 from mtsmfm/mtsmfm/fix-fixture-resolverRafael Mendonça França2019-07-252-13/+47
|\ \ \ \ | | | | | | | | | | | | | | | Support :any variants for ActionView::FixtureResolver
| * | | | Support :any variants for FixtureResolverFumiaki MATSUSHIMA2019-06-302-13/+47
| | | | |
* | | | | Merge pull request #36412 from robotdana/compact_blankRafael Mendonça França2019-07-251-1/+1
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | Add compact_blank shortcut for reject(&:blank?)
| * | | | Use compact_blank throughout railsDana Sherson2019-06-051-1/+1
| | | | |
* | | | | Merge pull request #36467 from spk/add-doc-host-protocol-asset_pathRafael França2019-07-241-0/+2
|\ \ \ \ \ | | | | | | | | | | | | Add documentation on actionview asset_path with host and protocol
| * | | | | Add documentation on actionview asset_path with host and protocolLaurent Arnoud2019-06-121-0/+2
| | | | | |
* | | | | | Fix broken rdoc for UrlHelper [ci skip]Ryuta Kamizono2019-07-241-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix unintentionally linked String, Symbol, Hash, and ERB. * Fix unintentionally code block.
* | | | | | Fix argument in doc sample of new `sms_to` helper [ci skip]Carlos Antonio da Silva2019-07-191-1/+1
| | | | | |
* | | | | | Merge pull request #36511 from aantix/sms_link_helperGuillermo Iguaran2019-07-192-0/+110
|\ \ \ \ \ \ | | | | | | | | | | | | | | Helper method to create an sms link
| * | | | | | Doc changes.Jim Jones2019-06-181-4/+4
| | | | | | |
| * | | | | | Helper method to create an sms link - when clicked it opens the ↵Jim Jones2019-06-182-0/+110
| |/ / / / / | | | | | | | | | | | | | | | | | | phone/desktop's messaging client with the phone number and optional body value prepopulated.
* | | | | | Fix a minor typo in ActionView::UnboundTemplateJean Boussier2019-07-191-3/+3
| | | | | |
* | | | | | Empty array instead of nil for source_extractGuilherme Mansur2019-07-143-12/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The source_extract method will return nil when it can't find the file name in the backtrace, methods that consume this method expect an array and the nil ends up causing type errors down the road like it happened here: #36341. This patch refactors the source_extract method so that it returns an empty array instead of nil when it can't find the source code. Co-authored-by: Kasper Timm Hansen <kaspth@gmail.com>
* | | | | | active_support/deprecation has to be already required via ↵Akira Matsuda2019-07-125-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | active_support/rails.rb
* | | | | | A type class or nil has to respond_to :to_sAkira Matsuda2019-07-121-2/+1
| | | | | |
* | | | | | No Woman, No tryAkira Matsuda2019-07-121-1/+0
| |_|/ / / |/| | | |
* | | | | Autoload SyntaxErrorInTemplateGuilherme Mansur2019-06-192-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a SyntaxError is detected in a template we raise this exception. On a first request to the server the exception we get a NameError since the exception is not required from `active_view/template/error.rb` yet. However later on it gets required and a second request will succeed. On the first request we see the rails "Something Wen Wrong" page and not the expected syntax error in template error page with the webconsole and stacktrace. By autoloading the constant we fix this issue. Co-authored-by: Gannon McGibbon <gannon.mcgibbon@gmail.com>
* | | | | Merge pull request #36482 from Shopify/fix-translation-helper-default-hashRafael França2019-06-172-1/+6
|\ \ \ \ \ | | | | | | | | | | | | Fix TranslationHelper#translate handling of Hash defaults
| * | | | | Fix TranslationHelper#translate handling of Hash defaultsJean Boussier2019-06-142-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is sometimes expected of the `translate` methods to return a Hash, for instance it's the case of the `number.format` key. As such users might need to specify a Hash default, e.g. `translate(:'some.format', default: { separator: '.', delimiter: ',' })`. This works as expected with the `I18n.translate` methods, however `TranslationHelper#translate` apply `Array()` on the default value. As a result the default value end up as `[:separator, '.', :delimiter, ',']`.
* | | | | | :golf:Akira Matsuda2019-06-151-6/+2
| | | | | |
* | | | | | Fix rubocop violationsRyuta Kamizono2019-06-141-1/+0
|/ / / / /
* | | | | Merge pull request #36477 from albertoalmagro/alberto/button-to-default-pathRafael França2019-06-131-1/+1
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] Use default path in button_to documentation
| * | | | | [ci skip] Use default path in button_to documentationAlberto Almagro2019-06-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is really a nit pick, but as this is the framework's documentation I think it should follow standards as many times as possible to avoid confusion in new users. If we were using `resources :articles` in routes. which is what scaffold adds, the generated helper would be `new_article_path` instead of `new_articles_path`.
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-12 08:08:19 +0000