aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | Do not pass an instance variable to a private methodyui-knk2017-09-0513-19/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `ActionView::Helpers::Tags::Base` has `@object` and all passed arguments for * `#value` * `#value_before_type_cast` * `#value_came_from_user?` are `@object`, so we do not need to pass arguments in this case.
* | | | | Fix outdated comment [ci skip]yuuji.yaginuma2017-09-021-1/+1
| |_|_|/ |/| | | | | | | | | | | We do not use double assign since 61f92f8bc5fa0b486fc56f249fa23f1102e79759.
* | | | double assign is no longer an effective workaround for unused variable warningAkira Matsuda2017-09-011-1/+1
| | | | | | | | | | | | | | | | `def a() x = x = 1; end` warns since Ruby 2.5 (r59585)
* | | | Clarify intentions around method redefinitionsMatthew Draper2017-09-012-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't use remove_method or remove_possible_method just before a new definition: at best the purpose is unclear, and at worst it creates a race condition. Instead, prefer redefine_method when practical, and silence_redefinition_of_method otherwise.
* | | | Merge pull request #30392 from koic/unify_source_control_keep_file_nameMatthew Draper2017-08-311-0/+0
|\ \ \ \ | | | | | | | | | | Unify the internal source control .keep file name
| * | | | Unify the internal source control .keep file nameKoichi ITO2017-08-241-0/+0
| | | | |
* | | | | Use tt in doc for ActionView [ci skip]Yoshiyuki Hirano2017-08-275-24/+24
| | | | |
* | | | | Fix broken doc layout for action_view [ci skip]Yoshiyuki Hirano2017-08-2722-22/+22
| | | | |
* | | | | Remove `alt` text from `image_tag` example [ci skip]yuuji.yaginuma2017-08-242-7/+7
| | | | | | | | | | | | | | | | | | | | Follow up of #30213
* | | | | Make sure image_alt is deprecatedRafael Mendonça França2017-08-231-5/+15
| | | | |
* | | | | Remove alt generation from image_submit_tagRafael Mendonça França2017-08-232-7/+7
| | | | |
* | | | | Merge pull request #30213 from ckundo/ccundiff-alt-text-defaultRafael Mendonça França2017-08-233-29/+31
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | Do not generate default alt text for images
| * | | | Do not generate default alt text in image tagsCameron Cundiff2017-08-173-29/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096]
* | | | | Merge pull request #30352 from yhirano55/update_licenses_linkRyuta Kamizono2017-08-221-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Update MIT licenses link [ci skip]
| * | | | | Update MIT licenses link [ci skip]Yoshiyuki Hirano2017-08-221-1/+1
| | | | | |
* | | | | | Merge pull request #28912 from kaspth/getting-started-form-withKasper Timm Hansen2017-08-211-0/+30
|\ \ \ \ \ \ | |/ / / / / |/| | | | | [ci skip] form_with in the getting started guide.
| * | | | | [ci skip] form_with in the getting started guide.Kasper Timm Hansen2017-08-211-0/+30
| |/ / / / | | | | | | | | | | | | | | | Add back a bit about a resource oriented style of routing.
* / / / / Use ssl in guide and comment [ci skip]Yoshiyuki Hirano2017-08-191-1/+1
|/ / / /
* | | | Fix RuboCop offensesKoichi ITO2017-08-167-69/+69
| | | | | | | | | | | | | | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop.
* | | | Merge pull request #30165 from tjschuck/code_formatting_fixRafael França2017-08-111-10/+10
|\ \ \ \ | | | | | | | | | | Add code formatting and minor grammar clarifications
| * | | | Add code formatting and minor grammar clarificationsT.J. Schuck2017-08-091-10/+10
| | | | | | | | | | | | | | | [ci skip]
* | | | | Fix RDoc formatting: `+` doesn't work with `@`ohbarye2017-08-111-1/+1
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | refs: https://github.com/rails/rails/pull/30161 ``` $ echo "+@size+" | rdoc --pipe <p>+@size+</p> $ echo "<tt>@size</tt>" | rdoc --pipe <p><code>@size</code></p> ``` [ci skip]
* | | | Fix broken RDoc formattingT.J. Schuck2017-08-091-1/+1
| | | | | | | | | | | | | | | | | | | | The `@` ivar format doesn’t work with RDoc's `+` code formatting; needs `<tt>`. [ci skip]
* | | | Extend image_tag to accept ActiveStorage Attachments and Variants (#30084)Anton Khamets2017-08-072-5/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Extend image_tag to accept ActiveStorage's Attachments and Variants * Flip resolve_image_source around * Add tests for the new use-cases of image_tag * Remove the higher-level test * Update image_tag documentation * Add error states into the test suite * Re-raise polymorhic_url's NoMethodError as ArgumentError * delegate_missing_to will raise DelegationError instead of NoMethodError
* | | | Merge pull request #30020 from rails/active-storage-importDavid Heinemeier Hansson2017-08-045-2/+89
|\ \ \ \ | | | | | | | | | | Add Active Storage to Rails
| * | | | Remove duplicated convert_direct_upload_option_to_urlRafael Mendonça França2017-08-032-7/+4
| | | | | | | | | | | | | | | | | | | | FormHelper includes FormTagHelper so we don't need to define two methods
| * | | | Refactor convert_direct_upload_option_to_urlRafael Mendonça França2017-08-032-3/+35
| | | | | | | | | | | | | | | | | | | | Also make sure file_field doesn't mutate the original options passed in.
| * | | | Make sure Action View doesn't break with Active StorageRafael Mendonça França2017-08-033-1/+50
| | | | | | | | | | | | | | | | | | | | | | | | | When Active Storage is not loaded and direct_upload is used on file_field_tag we should not raise an exception.
| * | | | Merge branch 'master' into active-storage-importDavid Heinemeier Hansson2017-08-021-1/+1
| |\ \ \ \
| * | | | | Add requireDavid Heinemeier Hansson2017-08-011-0/+1
| | | | | |
| * | | | | Move the direct_upload: true convenience option from the activestorage ↵David Heinemeier Hansson2017-07-312-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | helper into actionview
* | | | | | Merge pull request #29984 from colorfulfool/form-helpers-unicode-sanitizationRafael França2017-08-022-1/+15
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Allow non-English values for collection_radio_buttons
| * | | | | Allow non-English values for collection_radio_buttons/check_boxescolorfulfool2017-08-022-1/+15
| |/ / / /
* / / / / Use File::NULL instead of "/dev/null"Kazuhiro NISHIYAMA2017-07-311-1/+1
|/ / / /
* | | | Merge pull request #30001 from y-yagi/fix_test_directoryKasper Timm Hansen2017-07-303-3/+3
|\ \ \ \ | | | | | | | | | | Fix test directory to correct path
| * | | | Fix test directory to correct pathyuuji.yaginuma2017-07-303-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Together, fix to the following lint violation. ``` rails/actionview/test/ujs/public/test/data-confirm.js 303:11 error Strings must use singlequote quotes rails/actionview/test/ujs/public/test/data-remote.js 414:32 error Extra semicolon semi ✖ 2 problems (2 errors, 0 warnings) ```
* | | | | Fix testing helpers that use Action View's capturing helpers (e.g. content_for)George Claghorn2017-07-252-0/+10
|/ / / /
* | | | Suppress warning from actionview controller helper.Christina Thompson2017-07-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Explicitly pass a destructed array to the delegate method. Signed-off-by: Yuki Nishijima <yk.nishijima@gmail.com>
* | | | Merge pull request #29897 from kirs/frozen-actionviewRafael França2017-07-24177-1/+350
|\ \ \ \ | | | | | | | | | | Use frozen string literal in actionview/
| * | | | Use frozen string literal in actionview/Kir Shatrov2017-07-24177-1/+350
| | | | |
* | | | | Merge pull request #29792 from lugray/delegate_respond_toRafael França2017-07-242-2/+21
|\ \ \ \ \ | |/ / / / |/| | | | Delegate respond_to? in ActionView::Helpers::ControllerHelper
| * | | | Delegate respond_to? in ActionView::Helpers::ControllerHelperLisa Ugray2017-07-192-2/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since methods defined in the controller helper are mostly delegated to the controller, delegate respond_to? as well, so that for example `respond_to?(:params)` behaves as expected.
* | | | | Make actionview ready for frozen stringsKir Shatrov2017-07-231-1/+2
| | | | |
* | | | | Merge pull request #29884 from padi/update_rails_5_upgrade_guideRafael França2017-07-211-2/+2
|\ \ \ \ \ | | | | | | | | | | | | Updates Rails upgrade guide on `ActionView::Helpers::RecordTagHelper`
| * | | | | Suppress documentation for content_tag_for and div_for since they were ↵Marc Rendl Ignacio2017-07-211-2/+2
| | |/ / / | |/| | | | | | | | | | | | | removed already
* | | | | Remove log directory in test postprocessingyuuji.yaginuma2017-07-211-1/+1
| | | | | | | | | | | | | | | | | | | | The "log" is directory. So it is necessary to use `FileUtils.rm_rf`.
* | | | | Add jQuery to test vendor filesMarc Rendl Ignacio2017-07-202-1/+9832
| |/ / / |/| | | | | | | | | | | | | | | ... so that we can run most, if not all, of rails-ujs tests without necessarily requiring an internet connection.
* | | | [ci skip]Replace jquery-ujs with rails-ujswillnet2017-07-191-1/+1
| | | |
* | | | Enable `Layout/FirstParameterIndentation` copRyuta Kamizono2017-07-172-24/+24
|/ / / | | | | | | | | | | | | | | | | | | We have some indentation cops. But now there is a little inconsistent params indentations. Enable `Layout/FirstParameterIndentation` cop to prevent newly inconsistent indentation added and auto-correct to existing violations.
* | | [Action View] `rubocop -a --only Layout/EmptyLineAfterMagicComment`Koichi ITO2017-07-113-0/+3
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 05:20:16 +0000