| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`Tags::Base#select_content_tag`.
Previously, passing a falsey value to `include_blank` would be ignored if the
field was required, and a blank line would still be inserted. The following will
now raise instead of quietly failing:
`select("post", "category", %w(a required field), { include_blank: false }, required: 'required')`
|
| |_|/
|/| | |
|
|\ \ \ |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit a9d58c77da800bb0052c9bfa432828b02526022c, reversing
changes made to 041c2c879a3c4086ad3aa6d30fed1eede1d53c11.
Reason: The old behavior is how it was working in previous version of
Rails since 4.0.x so it is not safe to backport to a stable branch.
See https://github.com/rails/rails/issues/19626#issuecomment-89862258
and https://github.com/rails/rails/pull/15050#issuecomment-45333449
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Remove unused package tasks
|
| | | | |
| | | | |
| | | | |
| | | | | |
We are using `all:build` now.
|
|/ / / /
| | | |
| | | |
| | | | |
`head` method works similar to `render` method with `:nothing` option
|
|\ \ \ \
| | | | |
| | | | | |
Remove custom `lines` and use `/tools/line_statistics`
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove broken and unused release task
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
- We do release with release.rb
- There is no `rake/gemcutter`
|
|/ / / /
| | | |
| | | |
| | | | |
https://travis-ci.org/rails/rails/jobs/63594316#L1982
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The patched test assumed the file system is case-sensitive, but that is not
necessarily the case. In particular, this test did not pass in the recommended
setup for the dev box, because the /vagrant shared folder is case-insensitive.
After looking at some gems that provide access to file system metadata I have
chosen to go with the check you can see in the patch because, albeit it's a bit
dirty creating a file, it is super easy to understand and clearly portable.
References https://github.com/rails/rails-dev-box/issues/102.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When one rendered a partial template without specifying an object
or a collection (e.g. <%= render partial: 'partial_name' %>), Rails
would make an object called :partial_name available in local_assigns.
I don't think this was the intended behavior, since no local variable
called 'partial_name' gets defined in the view.
|
|\ \ \ \
| | | | |
| | | | | |
remove redundant parenthesis.
|
| | | | | |
|
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I think we are better off leaving `sudo` outside of the documented
way of installing gems (`activerecord`, `actionpack`, …).
We don’t want newbies to think that `sudo` is required or, even worse, than
they actually have to type `[sudo] gem install`.
In most scenarios, `sudo` is not needed to install gems, and people who do
need it, probably already know about it.
What do you think? :grin:
|
| |/ /
|/| | |
|
|\ \ \ |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
In help text for method, dynamic value makes it hard to understand, so replaced with static value matching with example above
|
| |_|/
|/| |
| | |
| | | |
Should be ApplicationController not ApplicationController::Base
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Prompted by:
https://github.com/rails/rails/commit/e38dd7bfa4360e241eadf0cf44abdf86ea33a393#commitcomment-11011496
/cc @kuldeepaggarwal
|
| | |
| | |
| | |
| | | |
supported by I18n.
|
|\ \ \
| | | |
| | | | |
Handle raise flag in translate when both main and default translation is missing.
|
| | | |
| | | |
| | | |
| | | | |
missing. Fixes #19967
|
|\ \ \ \
| | | | |
| | | | | |
Actionview image tag size option override
|
| | | | | |
|
| |/ / /
|/| | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This illustrates the purpose of the block for `link_to_if` and
`link_to_unless` helper methods.
It should help to prevent further mistakes like #19844.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
stevenspiel/link_to_if_block_helper_addition"
This reverts commit d459b001b43d25053e7982e96eb8383538a6e358, reversing
changes made to 4d4950fae9e2a6970b5f1793aadc56a0b44e28a3.
:sweat:
The block is not supposed to be passed to `link_to`. It's used for a
customized behavior of the `condtion = false` case. The docs
illustrate that like so:
```
<%=
link_to_if(@current_user.nil?, "Login", { controller: "sessions", action: "new" }) do
link_to(@current_user.login, { controller: "accounts", action: "show", id: @current_user })
end
%>
```
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Update url_helper.rb
|
| | | | |
| | | | |
| | | | | |
add block to link_to_if when condition is true
|
| |_|_|/
|/| | | |
|
|\ \ \ \
| | | | |
| | | | | |
Correct translate helper docs [ci skip]
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The documentation previously stated that calling `translate(".foo")` was
equivalent to calling `I18n.translate("people.index.foo")` which is
incorrect due to the various other functions of the `translate` view
helper. This has been fixed.
Additionally, a note about forcing the view helper to re-raise
exceptions was added to the section detailing the handling of missing
translations.
Other cleanup includes:
* Consistent formatting of code
* Stop indenting bulleted list as a code sample
* Tighten some of the language
* Wrap at 80 characters.
|
| | | | |
|
|/ / /
| | |
| | |
| | | |
This method is not in use since 479c7cacd5db58ab7200bc1de58c829a1a643278
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Running Action View test case currently printing out this warning:
lib/mathn.rb is deprecated
This should silence the warning since we really want to require this
file in this test.
|
|/ / |
|
| | |
|
|\ \
| | |
| | | |
[Skip ci] Add information about :host options
|
| | |
| | |
| | |
| | |
| | |
| | | |
Added informations about :host options for each url helper
(#javascript_url, #video_url, #stylesheet_url, etc) based on #asser_url
method.
|