aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Merge pull request #18546 from brainopia/action_view_renderRafael Mendonça França2015-01-222-2/+14
|\ \ \ \ \ | | | | | | | | | | | | A shortcut to setup controller environment
| * | | | | Support `:assigns` option when rendering with controllers/mailers.brainopia2015-01-222-2/+14
| | | | | |
* | | | | | Single instead of double quotes T.J. Schuck2015-01-201-2/+2
| | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | Rewrite SanitizeHelper docsT.J. Schuck2015-01-201-77/+50
| | | | | |
* | | | | | Fix code formatting in sanitize docsT.J. Schuck2015-01-201-9/+11
| | | | | |
* | | | | | fix typo in number_field_tag documentation [ci skip]yuuji.yaginuma2015-01-191-2/+2
| | | | | |
* | | | | | Use existing constant for joining instead of '_'Prathamesh Sonpatki2015-01-181-1/+1
| | | | | |
* | | | | | nodoc ActionView::ModelNaming modulePrathamesh Sonpatki2015-01-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Its only used by ActionView internals and not supposed to be used through public API.
* | | | | | Eliminate a ruby warning in a test in Action ViewYuki Nishijima2015-01-171-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This eliminates the warning below: actionview/test/template/form_helper_test.rb:913: warning: method redefined; discarding old id_came_from_user? actionview/test/template/form_helper_test.rb:104: warning: previous definition of id_came_from_user? was here
* | | | | | Use option url: false to allow entries without a link tagDaniel Gomez de Souza2015-01-163-2/+30
|/ / / / /
* | | | | Only use the `_before_type_cast` in the form when from user inputSean Griffin2015-01-142-2/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While we don't want to change the form input when validations fail, blindly using `_before_type_cast` will cause the input to display the wrong data for any type which does additional work on database values.
* | | | | Add tests with an explanation of why we're using `_before_type_cast`Sean Griffin2015-01-141-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you entered incorrect input into a form (particularly with a numericality validation), we should not replace what you typed in with `0`, since clicking submit a second time would essentially be the same as erroneously accepting the junk input as 0.
* | | | | Revert "Don't use the `_before_type_cast` version of attributes in the form"Sean Griffin2015-01-144-3/+13
| | | | | | | | | | | | | | | | | | | | This reverts commit 787e22bb491bd8c36db1e9734261c4ce02c5c5fd.
* | | | | Don't use the `_before_type_cast` version of attributes in the formSean Griffin2015-01-144-13/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should never be ignoring valuable information that the types may need to give us. The reason that it originally used `_before_type_cast` is unclear, but appears to date back long enough that the reasons may not be relevant today. There is only one test that asserts that it uses the before type cast version, but it gives no context as to why and uses a mock which does not simulate the real world. Fixes #18523.
* | | | | Fix typo in ActionView CHANGELOG [ci skip]Prathamesh Sonpatki2015-01-141-1/+1
| | | | |
* | | | | No need of requiring `rbconfig`, it is by-default loadedKuldeep Aggarwal2015-01-101-1/+0
| | | | |
* | | | | Avoid changing the global state on the testsRafael Mendonça França2015-01-051-1/+6
| | | | |
* | | | | Merge pull request #17676 from ↵Rafael Mendonça França2015-01-052-6/+27
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tigrish/fix_custom_i18n_exception_handler_regression Fix I18n regression introduced by #13832
| * | | | | Fix I18n regression introduced by #13832Christopher Dell2014-11-192-6/+27
| | | | | | | | | | | | | | | | | | | | | | | | Previously, when the `:raise` options was set to `false`, it would get overwritten to `true`, preventing custom exception handlers to be used.
* | | | | | Merge pull request #18328 from brainopia/remove_tz_proxyRafael Mendonça França2015-01-041-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Use directly TZInfo::Timezone without proxy
| * | | | | | Use directly TZInfo::Timezone without proxybrainopia2015-01-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since real timezone is loaded anyway in `#utc_offset` which is called during `#create`
* | | | | | | Remove wrong TODO commentRafael Mendonça França2015-01-041-1/+1
| | | | | | |
* | | | | | | Remove version conditional for find_template_pathsRafael Mendonça França2015-01-041-18/+6
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | Now that we only support Ruby 2.2+ we don't need this conditional anymore
* | | | | | Remove unneeded `require 'as/deprecation'`claudiob2015-01-041-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tests should still pass after removing `require 'active_support/deprecation'` from these files since the related deprecations have been removed.
* | | | | | Remove unneeded requiresRafael Mendonça França2015-01-041-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | These requires were added only to change deprecation message
* | | | | | Change the default template handler from `ERB` to `Raw`.Rafael Mendonça França2015-01-043-8/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Files without a template handler in their extension will be rended using the raw handler instead of ERB.
* | | | | | Remove deprecated `AbstractController::Base::parent_prefixes`Rafael Mendonça França2015-01-043-35/+7
| | | | | |
* | | | | | Fix a few typos [ci skip]Robin Dupret2015-01-031-1/+1
| | | | | |
* | | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-01-031-5/+5
|\ \ \ \ \ \
| * | | | | | Fix "Rendering" not to link to AV::Renderingclaudiob2014-12-251-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "Rendering" word in the titles is not meant to be a link to the documentation for ActionView::Rendering. [ci skip]
* | | | | | | Unsafe default translations should not be marked html_safeJustin Coyne2015-01-023-19/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously default translation keys that didn't end in `_html`, but came after a missing key that ended in `_html` were being returned as html_safe. Now they are not. Fixes #18257
* | | | | | | Follow up to #17973 [ci skip]Robin Dupret2015-01-021-9/+10
| | | | | | |
* | | | | | | Merge pull request #17974 from killthekitten/fix-render-blockRafael Mendonça França2015-01-024-1/+13
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make possible to use blocks with short version of render partial Conflicts: actionview/CHANGELOG.md
| * | | | | | | Make possible to use blocks with short version of render partialNikolay Shebanov2014-12-194-1/+13
| |/ / / / / /
* | | | | | | Merge pull request #17973 from maurogeorge/file_field_hidden_fieldRafael Mendonça França2015-01-024-5/+58
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Generate a hidden_tag when using a file_field
| * | | | | | | Add a hidden_field on the file_fieldMauro George2015-01-024-5/+56
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will avoid a error be raised when the only input on the form is the `file_field`.
* | | | | | | Merge pull request #18271 from arunagw/change-copyright-yearRobin Dupret2015-01-012-2/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Update copyright notices to 2015 [ci skip]
| * | | | | | | Update copyright notices to 2015 [ci skip]Arun Agrawal2014-12-312-2/+2
| | | | | | | |
* | | | | | | | Changelog edits [ci skip]Robin Dupret2014-12-311-2/+2
|/ / / / / / /
* | | | | | | Fixes simple missprint in docs for #cyle in text_helperBen Woodall2014-12-301-1/+1
| | | | | | |
* | | | | | | Tiny documentation fixes [ci skip]Robin Dupret2014-12-301-3/+4
| | | | | | |
* | | | | | | Merge pull request #18130 from claudiob/better-record-identifier-docRobin Dupret2014-12-301-18/+42
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Better docs for AV::RecordIdentifier [ci skip]
| * | | | | | | Better docs for AV::RecordIdentifierclaudiob2014-12-231-18/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit intends to clarify the scope of ActionView::RecordIdentifier methods `dom_id` and `dom_class`. Most of the current documentation comes from da257eb8 (7 years ago) when the decoupling of ActionView, ActiveRecord and ActiveModel was not a concern. Since then, steps have been taken to reach such decoupling, especially 8ca17926 which duplicated ActionController::ModelNaming into ActionView::ModelNaming explaining that: > These are just a simple helpers for decoupling Active Model, so it does not > make sense to extract it to Active Support, but the point is to decouple also > Action View and Action Pack As of today, ActionView::RecordIdentifier only includes `dom_id` and `dom_class` so it makes sense to explicitly document those two methods, and leaving the details of helpers like `div_for` in the corresponding files. Moreover, I think it's important to mention in the documentation that ActionView::RecordIdentifier **does not strictly depend on the ActiveRecord API**: any class `Post` implementing `post.to_key` and `post.model_name.param_key` will work. [ci skip]
* | | | | | | | Merge pull request #18251 from tjgrathwell/fix-polymorphic-routes-to-modelRafael Mendonça França2014-12-301-5/+15
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix form_for to work with objects that implement to_model
| * | | | | | | | Fix form_for to work with objects that implement to_modelTravis Grathwell2014-12-291-5/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, if you tried to use form_for with a presenter object that implements to_model, it would crash in action_dispatch/routing/polymorphic_routes.rb when asking the presenter whether it is .persisted? Now, we always ask .persisted? of the to_model object instead. This seems to been an issue since 1606fc9d840da869a60213bc889da6fcf1fdc431 Signed-off-by: Eugenia Dellapenna <eugenia.dellapenna@gmail.com>
* | | | | | | | | Template lookup now respect default locale and I18n fallbacks.Rafael Mendonça França2014-12-291-8/+1
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Given the following templates: mailer/demo.html.erb mailer/demo.en.html.erb mailer/demo.pt.html.erb Before this change for a locale that doesn't have its related file the `mailer/demo.html.erb` will be rendered even if `en` is the default locale. Now `mailer/demo.en.html.erb` has precedence over the file without locale. Also, it is possible to give a fallback. mailer/demo.pt.html.erb mailer/demo.pt-BR.html.erb So if the locale is `pt-PT`, `mailer/demo.pt.html.erb` will be rendered given the right I18n fallback configuration. Fixes #11884.
* | | | | | | | fix error message of option as with invalid charters in partial renderingAngelo capilleri2014-12-293-5/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | before this PR IDENTIFIER_ERROR_MESSAGE could lead to misunderstand the convention of partial name. Added OPTION_AS_ERROR_MESSAGE for unvalid charter in as option.
* | | | | | | | Require Ruby 2.2 for Rails 5.0claudiob2014-12-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Stems from [this comment](https://github.com/rails/rails/pull/18203#issuecomment-68138096) by @robin850 and by the blog post http://weblog.rubyonrails.org/2014/12/19/Rails-4-2-final
* | | | | | | | Merge pull request #18107 from mkdynamic/add-reply-to-mail-toSean Griffin2014-12-242-4/+5
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Add support for Reply-To field in mail_to helper
| * | | | | | | | Add support for Reply-To field in mail_to helperMark Dodwell2014-12-202-4/+5
| | |/ / / / / / | |/| | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 03:24:20 +0000