aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | [ci skip] Don’t encourage `sudo gem install`claudiob2015-05-121-1/+1
| |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I think we are better off leaving `sudo` outside of the documented way of installing gems (`activerecord`, `actionpack`, …). We don’t want newbies to think that `sudo` is required or, even worse, than they actually have to type `[sudo] gem install`. In most scenarios, `sudo` is not needed to install gems, and people who do need it, probably already know about it. What do you think? :grin:
* | | | Better formatted documents [ci skip]Gourav Tiwari2015-05-081-8/+12
| |/ / |/| |
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-05-081-0/+1
|\ \ \
| * | | [ci skip] Add an example to ActionView::Helpers::FormBuilder#labelyui-knk2015-05-081-0/+1
| | | |
* | | | Updated dynamic value of id in comments [ci skip]Gourav Tiwari2015-05-071-1/+1
| | | | | | | | | | | | | | | | In help text for method, dynamic value makes it hard to understand, so replaced with static value matching with example above
* | | | Example updated [ci skip]Ankit Gupta2015-05-071-1/+1
| |_|/ |/| | | | | | | | Should be ApplicationController not ApplicationController::Base
* | | use the right assertions.Yves Senn2015-05-051-2/+2
| | | | | | | | | | | | | | | | | | | | | Prompted by: https://github.com/rails/rails/commit/e38dd7bfa4360e241eadf0cf44abdf86ea33a393#commitcomment-11011496 /cc @kuldeepaggarwal
* | | Remove :rescue_format option for translate helper since it's no longer ↵Bernard Potocki2015-05-043-16/+9
| | | | | | | | | | | | supported by I18n.
* | | Merge pull request #19998 from imanel/fix-missing-translationMatthew Draper2015-05-053-4/+24
|\ \ \ | | | | | | | | Handle raise flag in translate when both main and default translation is missing.
| * | | Handle raise flag in translate when both main and default translation is ↵Bernard Potocki2015-05-043-4/+24
| | | | | | | | | | | | | | | | missing. Fixes #19967
* | | | Merge pull request #18783 from mikestone14/actionview-image-tag-overrideRafael Mendonça França2015-05-032-0/+15
|\ \ \ \ | | | | | | | | | | Actionview image tag size option override
| * | | | image_tag raises an error if size is passed with height and/or widthMike Stone2015-04-242-0/+15
| | | | |
* | | | | Use ruby 1.9 lambda syntax in documentations [ci skip]Mehmet Emin İNAÇ2015-05-031-1/+1
| |/ / / |/| | |
* | | | [ci skip] Fix example codes of form_for methodyui-knk2015-05-021-26/+36
| | | |
* | | | add test-case for `link_to_if` behavior with a block.Yves Senn2015-05-011-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This illustrates the purpose of the block for `link_to_if` and `link_to_unless` helper methods. It should help to prevent further mistakes like #19844.
* | | | Revert "Merge pull request #19844 from ↵Yves Senn2015-05-013-10/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | stevenspiel/link_to_if_block_helper_addition" This reverts commit d459b001b43d25053e7982e96eb8383538a6e358, reversing changes made to 4d4950fae9e2a6970b5f1793aadc56a0b44e28a3. :sweat: The block is not supposed to be passed to `link_to`. It's used for a customized behavior of the `condtion = false` case. The docs illustrate that like so: ``` <%= link_to_if(@current_user.nil?, "Login", { controller: "sessions", action: "new" }) do link_to(@current_user.login, { controller: "accounts", action: "show", id: @current_user }) end %> ```
* | | | Merge pull request #19844 from stevenspiel/link_to_if_block_helper_additionYves Senn2015-05-013-1/+10
|\ \ \ \ | | | | | | | | | | | | | | | Update url_helper.rb
| * | | | Update url_helper.rbSteven Spiel2015-04-211-1/+1
| | | | | | | | | | | | | | | add block to link_to_if when condition is true
* | | | | Make ActionMailer #cache helper a no-op, not an exceptionJavan Makhmali2015-04-281-1/+1
| |_|_|/ |/| | |
* | | | Merge pull request #19892 from derekprior/dp-translate-helper-docsZachary Scott2015-04-251-23/+36
|\ \ \ \ | | | | | | | | | | Correct translate helper docs [ci skip]
| * | | | Correct translate helper docs [ci skip]Derek Prior2015-04-241-23/+36
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The documentation previously stated that calling `translate(".foo")` was equivalent to calling `I18n.translate("people.index.foo")` which is incorrect due to the various other functions of the `translate` view helper. This has been fixed. Additionally, a note about forcing the view helper to re-raise exceptions was added to the section detailing the handling of missing translations. Other cleanup includes: * Consistent formatting of code * Stop indenting bulleted list as a code sample * Tighten some of the language * Wrap at 80 characters.
* | | | :put_litter_in_its_place: Unused methodsAkira Matsuda2015-04-252-12/+0
| | | |
* | | | :put_litter_in_its_place: Unused methodAkira Matsuda2015-04-251-6/+0
|/ / / | | | | | | | | | This method is not in use since 479c7cacd5db58ab7200bc1de58c829a1a643278
* | | Silence warning from requiring mathnPrem Sichanugrist2015-04-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Running Action View test case currently printing out this warning: lib/mathn.rb is deprecated This should silence the warning since we really want to require this file in this test.
* | | pass over CHANGELOGs. [ci skip]Yves Senn2015-04-221-2/+1
|/ /
* | fix typo asser url [ci skip]Mehmet Emin İNAÇ2015-04-161-6/+6
| |
* | Merge pull request #19774 from davydovanton/doc-update-asser-urlAbdelkader Boudih2015-04-151-0/+30
|\ \ | | | | | | [Skip ci] Add information about :host options
| * | [Skip ci] Add information about :host optionsAnton Davydov2015-04-161-0/+30
| | | | | | | | | | | | | | | | | | Added informations about :host options for each url helper (#javascript_url, #video_url, #stylesheet_url, etc) based on #asser_url method.
* | | Merge pull request #19736 from kmcphillips/masterRafael Mendonça França2015-04-145-1/+54
|\ \ \ | | | | | | | | Set default form builder for a controller
| * | | Override default form builder for a controllerKevin McPhillips2015-04-135-1/+54
| | | |
* | | | Merge pull request #19753 from jonatack/use-ruby-2-2-2Guillermo Iguaran2015-04-131-1/+1
|\ \ \ \ | |_|_|/ |/| | | Upgrade to Ruby 2.2.2
| * | | Upgrade to Ruby 2.2.2Jon Atack2015-04-141-1/+1
| | | | | | | | | | | | | | | | and fix the grammar in the ruby_version_check.rb user message.
* | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-04-141-1/+1
|\ \ \ \ | |_|/ / |/| | |
| * | | [ci skip] Add `,`yui-knk2015-04-081-1/+1
| | | |
* | | | Merge pull request #19566 from aditya-kapoor/remove-dup-docRichard Schneeman2015-04-111-22/+10
|\ \ \ \ | | | | | | | | | | [ci skip] remove duplicate doc for current_page?
| * | | | [ci skip] remove duplicate doc for current_page?Aditya Kapoor2015-04-091-22/+10
| | |/ / | |/| |
* | | | Merge pull request #17512 from ↵Zachary Scott2015-04-101-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | JackDanger/danger/use-default-view-pattern-in-docs [docs] Using the real resolver pattern in docs
| * | | | Using the real resolver pattern in docsJack Danger Canty2014-11-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If someone copies the docs into their app they'll find it simply doesn't work because the locale pattern doesn't have the same logic. This makes the doc examples work exactly as written. [ci skip]
* | | | | Merge pull request #19685 from vngrs/actionview_parent_layout_bugRafael Mendonça França2015-04-082-8/+31
|\ \ \ \ \ | |_|_|_|/ |/| | | | fix for actionview parent layout bug
| * | | | fix for actionview parent layout bugMehmet Emin İNAÇ2015-04-082-8/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes issue #19626 Don't need to check layout conditions if there is no condition test for parent layout bug fix
* | | | | Merge pull request #19661 from Azdaroth/fields-for-child-index-lambdaRafael Mendonça França2015-04-063-1/+26
|\ \ \ \ \ | |/ / / / |/| | | | Accept lambda as child_index option in #fields_for method
| * | | | Accept lambda as child_index option in #fields_for methodKarol Galanciak2015-04-053-1/+26
| | | | |
* | | | | head no_content when there is no template or action performedStephen Bussey2015-04-051-1/+1
|/ / / /
* | | | Merge pull request #19644 from y-yagi/auto_discovery_link_tag_docYves Senn2015-04-051-1/+1
|\ \ \ \ | | | | | | | | | | correct output of auto_discovery_link_tag [ci skip]
| * | | | correct output of auto_discovery_link_tag [ci skip]yuuji.yaginuma2015-04-041-1/+1
| | | | |
* | | | | Merge pull request #19649 from aprescott/allow-array-defaultsMatthew Draper2015-04-053-1/+12
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Allow an array to be a default translation value.
| * | | | | Allow an array to be a default translation value.Adam Prescott2015-04-043-1/+14
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4.2.1 introduced a change to the way `translate`/`t` works with an option of `default: [[]]`. In 4.2.0, this would give a default value of `[]`, but in 4.2.1, it leads to a missing translation. `default: [[]]` is again allowed for cases where a default of `[]` is needed. This addresses GitHub issue 19640.
* / / / / [skip ci] Update information about #link_to attributesAnton Davydov2015-04-041-4/+3
|/ / / /
* | | | Freeze static arguments for gsubbrainopia2015-04-021-1/+1
| | | |
* | | | Prefer string patterns for gsubbrainopia2015-04-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/ruby/ruby/pull/579 - there is a new optimization since ruby 2.2 Previously regexp patterns were faster (since a string was converted to regexp underneath anyway). But now string patterns are faster and better reflect the purpose. Benchmark.ips do |bm| bm.report('regexp') { 'this is ::a random string'.gsub(/::/, '/') } bm.report('string') { 'this is ::a random string'.gsub('::', '/') } bm.compare! end # string: 753724.4 i/s # regexp: 501443.1 i/s - 1.50x slower