aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
...
* | Use a hash to record every partial's cache hit status instead of sharing a ↵Stan Lo2017-06-087-3/+51
| | | | | | | | boolean.
* | Don't support namespace in form_with.Kasper Timm Hansen2017-06-071-18/+0
| | | | | | | | | | form_with requires people to pass an id manually, so users can just prefix their namespace right there.
* | Move slicing to initializer.Kasper Timm Hansen2017-06-072-2/+2
| | | | | | | | | | | | Forgot all about https://github.com/rails/rails/pull/28844/files#r113780934 cc @rafaelfranca
* | Use mattr_accessor default: option throughout the projectGenadi Samokovarov2017-06-037-25/+13
|/
* Merge pull request #29187 from robin850/remove-mathnRafael França2017-05-301-3/+11
|\ | | | | Remove requirement on mathn
| * Remove requirement on mathnRobin Dupret2017-05-301-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | The test using mathn was first introduced in f1d9179 to check that the `distance_of_time_in_words` properly doesn't use the `Fixnum#/` method by explicitly requiring this library as it redefines this method. Given that `mathn` has been gemified in Ruby 2.5 and is deprecated since version 2.2, we can certainly safely assume that people will most-likely not require this library in their application. However, to make sure that we don't regress, let's add a test similar to the one before f1d9179.
* | Grammar fixesJon Moss2017-05-291-2/+3
| | | | | | | | [ci skip]
* | Merge pull request #29191 from ↵Kasper Timm Hansen2017-05-291-1/+1
|\ \ | | | | | | | | | | | | bogdanvlviv/pass_params_filename_lineno_to_class_eval Pass params __FILE__ and __LINE__ + 1 if class_eval with <<
| * | Pass params __FILE__ and __LINE__ + 1 if class_eval with <<bogdanvlviv2017-05-291-1/+1
| |/
* | Merge pull request #29151 from onemanstartup/jquery_slim_fixGuillermo Iguaran2017-05-291-1/+1
|\ \ | | | | | | Check for jQuery ajax
| * | Check for jQuery ajaxDmitriy Plekhanov2017-05-191-1/+1
| | | | | | | | | jQuery slim version doesn't have ajax, so if a person include this version ajaxFilter raises error.
* | | Add option for class_attribute default (#29270)David Heinemeier Hansson2017-05-295-24/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Allow a default value to be declared for class_attribute * Convert to using class_attribute default rather than explicit setter * Removed instance_accessor option by mistake * False is a valid default value * Documentation
* | | Merge pull request #29108 from inopinatus/ujs-sgjs-ie9-supportKasper Timm Hansen2017-05-281-1/+1
|\ \ \ | | | | | | | | Fix server-generated JS response processing on IE9
| * | | Fix server-generated JS response processing on IE9 when using rails-ujs and ↵Josh Goodall2017-05-171-1/+1
| | | | | | | | | | | | | | | | remote: true
* | | | Update to rails-ujs documentation for yarn installAdrian Stainforth2017-05-261-0/+10
| | | |
* | | | Merge pull request #29176 from bogdanvlviv/define-path-with__dir__Matthew Draper2017-05-2614-37/+35
|\ \ \ \ | | | | | | | | | | Define path with __dir__
| * | | | Define path with __dir__bogdanvlviv2017-05-2314-37/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f
* | | | | Merge pull request #29119 from spohlenz/fix-select-with-enumerableMatthew Draper2017-05-242-1/+18
|\ \ \ \ \ | |_|_|_|/ |/| | | | Fix select tag helper used with Enumerable choices
| * | | | Fix select tag helper used with Enumerable choicesSam Pohlenz2017-05-172-1/+18
| | |/ / | |/| | | | | | | | | | | | | | | | | | Allows a custom object implementing Enumerable to be used as the choices parameter for a select tag, which previously wasn't possible due to the call to `empty?` on the choices (which isn't implemented on Enumerable).
* | | | Update test link in ActionView javascripts README.md.Josef Šimánek2017-05-221-1/+1
| |/ / |/| | | | | [ci skip]
* | | Add :json type to auto_discovery_link_tagMike Gunderloy2017-05-203-5/+12
| |/ |/| | | | | | | This allows auto_discovery_link_tag to support the JSON Feed standard. See https://jsonfeed.org/version/1 for more information.
* | Merge pull request #29057 from ↵Akira Matsuda2017-05-191-1/+1
|\ \ | | | | | | | | | | | | koic/suppress_warning_assigned_but_unused_variable Suppress `warning: assigned but unused variable - stdout`
| * | Suppress `warning: assigned but unused variable - stdout`Koichi ITO2017-05-121-1/+1
| |/
* | ERB::Util.url_encode no longer escapes ~ since ruby 2.5Akira Matsuda2017-05-191-2/+2
| | | | | | | | see: https://bugs.ruby-lang.org/issues/6696
* | Use recyclable cache keys (#29092)David Heinemeier Hansson2017-05-185-15/+23
|/
* Should escape meta characters in regexpRyuta Kamizono2017-05-074-10/+10
|
* Merge pull request #28753 from st0012/add-render-with-variants-testKasper Timm Hansen2017-05-013-0/+10
|\ | | | | Add tests for rendering with variants
| * Add tests for render template/partial with variants option.Stan Lo2017-04-143-0/+10
| |
* | Cleanup CHANGELOGs [ci skip]Ryuta Kamizono2017-04-301-1/+2
| | | | | | | | | | | | * Remove trailing spaces. * Add backticks around method and command. * Fix indentation.
* | Merge pull request #20701 from iamvery/date-helper-argument-errorAndrew White2017-04-273-18/+41
|\ \ | | | | | | Ensure input to distance_of_time_in_words is not nil
| * | Ensure input to distance_of_time_in_words is not nilJay Hayes2017-04-273-18/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Internally all input is converted to time so that it can be treated uniformly. Remove now-unneeded condition * Now that all input is treated is converted to time, we no longer need to type check it. Rename variables to clarify their purpose Extract private method to normalize distance_of_time args to time Update actionview changelog
* | | Merge pull request #28844 from ↵Kasper Timm Hansen2017-04-272-1/+3
|\ \ \ | | | | | | | | | | | | | | | | kyuden/remove_unnecessary_attributes_of_select_in_form_with Remove unnecessary `skip_default_ids` and `allow_method_names_outside_object` attributes of select tag in `form_with`
| * | | Remove unnecessary `skip_default_ids` and ↵kyuden2017-04-242-1/+3
| |/ / | | | | | | | | | `allow_method_names_outside_object` attributes of select tag in `form_with`
* | | Merge pull request #28848 from Edouard-chin/ec-remove-unused-methodRafael França2017-04-261-7/+0
|\ \ \ | | | | | | | | `sort_query_string_params` method is no more used
| * | | `sort_query_string_params` method is no more usedEdouard CHIN2017-04-231-7/+0
| |/ / | | | | | | | | | | | | - This method was added in this commit https://github.com/rails/rails/commit/33258d713a4bc20b71e92fd656c923a7b189cd33 - The last caller got removed there https://github.com/rails/rails/commit/0b6ce3422370647cad3e91263a291f69b313d65b
* / / Fix `current_page?` regression:Edouard CHIN2017-04-262-1/+19
|/ / | | | | | | | | | | - `check_parameters` kwargs was added to the `current_page?` method, the implementation was assuming only hashes responds to `delete`. This was causing issues when `current_page?` was called with a Active Model object - ref https://github.com/rails/rails/pull/27549 - Fixes #28846
* | Set to `form_with_generates_remote_forms` only when config is explicitly ↵yuuji.yaginuma2017-04-221-2/+4
| | | | | | | | | | | | | | | | | | specified Without this check, even if config is not specified, `ActionView::Helpers::FormHelper.form_with_generates_remote_forms` always be set to nil and remote form not be generated. Follow up to 128b804c6ce40fcbde744f294f8cb98654f6efec
* | Configure form_with_generates_remote_forms in its own initializerRafael Mendonça França2017-04-212-0/+29
| | | | | | | | | | | | | | | | | | This configuration is not present in ActionView::Base so we can't let the action_view.set_configs initializer set it. Also add tests to make sure this config works. Fixes #28824
* | Fix all style guides violationsRafael Mendonça França2017-04-199-12/+12
| | | | | | | | | | Closes #28382 Closes #28651
* | Reuse the Parameters#to_h check in the routing helpersRafael Mendonça França2017-04-182-6/+5
| | | | | | | | | | Since this protection is now in Parameters we can use it instead of reimplementing again.
* | Add `form_with_generates_remote_forms` config.Kasper Timm Hansen2017-04-161-1/+3
| | | | | | | | | | | | | | Allows users to not have remote forms by default, since there's more JS harness, e.g. bundling rails-ujs, otherwise. Also don't skip creating defaults file anymore. Sprockets isn't the only new config.
* | Default embed_authenticity_token_in_remote_forms to nil.Kasper Timm Hansen2017-04-163-8/+10
| | | | | | | | | | | | | | Effectively treat nil values as "auto", e.g. whatever a form helper chooses to interpret it as. But treat an explicitly assigned false value as disabling.
* | Fix module name [ci skip]yuuji.yaginuma2017-04-151-10/+10
|/ | | | Replace `FormOptionHelper` to `FormOptionsHelper`.
* Merge pull request #28748 from DmytroVasin/rails-ujs-fix-ajax-response-parsingRafael França2017-04-132-3/+31
|\ | | | | Fix mistake in JS response parser
| * Fix mistake in JS response parser:Dmytro Vasin2017-04-132-3/+31
| | | | | | | | | | | | - Restore ability to accept ecmascript JS response should not modify DOM.
* | Close form_for tag in FormHelper API docsAlex Muller2017-04-131-2/+2
|/
* Fix rubocop violationsyuuji.yaginuma2017-04-121-1/+1
|
* Set current page as default for ajax requestsDmytro Vasin2017-04-112-22/+46
|
* Correct typo in component nameAndrew White2017-03-311-1/+1
|
* Reorganize rails-ujs filesJavan Makhmali2017-03-3013-104/+104
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 22:56:41 +0000