| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| | |
format other than the first default
|
| |
| |
| |
| |
| |
| | |
This method is used in `distance_of_time_in_words`
Fixes #25357
|
| |
| |
| |
| | |
The option was deprecated in #21191.
|
|\ \
| | |
| | |
| | | |
Use `#performed?` to terminate controller callbacks
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This test was broken by f650e0324207e46ed5240380e60bdf1e2a5023a6. It was
added by https://github.com/rails/rails/pull/17978, and is adequately
tested elsewhere. The reason that this breaks is that
`Controller#process` is not going to set a new response object, and we
now terminate in callbacks if the response has been sent. The only
reason that this test was calling `get` in the first place was because
the controller under test blows up if `request` was `nil`. The point
being that the failure is invalid, and I don't think we need to fix the
test in this location.
|
|/ |
|
| |
|
|
|
|
| |
Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
|
|
|
|
|
|
| |
Difference in rendering --> https://gist.github.com/maclover7/a50ff9231eb825c39c77cd5858af6d9a
[ci skip]
|
|
|
|
|
|
|
|
|
|
|
|
| |
`include_blank: true` option.
We now generate option with empty label, example:
`<select id="places" name="places"><option value="" label=" "></option></select>`
for include_blank: true. This is only done, if content is missing on the option, and we providing the value from this option.
Fixes #24816
|
|
|
|
|
|
| |
This reverts commit 0ce7eae7418f1b9bb06b351c1f26d50c3674c0d0.
Tests were broken https://travis-ci.org/rails/rails/jobs/131850726#L520
|
|
|
|
| |
[Rafael Mendonça França + Nick Sutterer + thedarkone]
|
|
|
|
| |
This way we don't have to make multiple calls on anonymous controllers
|
|\
| |
| | |
[Action View] Don't create middleman `DetailsKey` instance
|
| |
| |
| |
| |
| | |
All of this is `nodoc`'ed, so we shouldn't have to worry about breaking
changes, if there are any -- all internal API :).
|
| |
| |
| |
| |
| |
| |
| |
| | |
Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005
* Forward compat with new unified Integer class in Ruby 2.4+.
* Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3.
* Drops needless Fixnum distinction in docs, preferring Integer.
|
| |
| |
| |
| |
| | |
Sorry, I missed a few places in my last PR. This should be the last of
'em :grimacing:
|
| |
| |
| |
| |
| |
| | |
Using locals will cause layouts to be cached multiple times in the
template cache. This commit removes locals from consideration when
looking up the layout.
|
|/ |
|
|
|
|
|
| |
Leftover from an earlier commit, chose to fix because I was
just down in this file.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per request digest caches were added before we had hooks into
different units of work that Rails performs.
As such the most reliable way to prevent stale cache digests
was with a middleware. The middleware prevented staleness in
Action Controller requests.
However, the executor is superior because it should also prevent
staleness when running just Active Job jobs or broadcasting
through Action Cable's server.
|
| |
|
|
|
|
| |
Resolves #24924.
|
|\
| |
| | |
Improve AV changelog with regards to default RAW handler
|
| |
| |
| |
| | |
It highlights which kind of incompatibilities this could lead to when rendering plain JS or HTML partials.
|
| |
| |
| |
| | |
Will be using this in later code.
|
|/
|
|
|
| |
Each test executes in another tmp folder, so there's no chance
of polluting another test run.
|
| |
|
|
|
|
|
|
|
| |
depends on being called after action_controller.set_configs.
This causes, other AV initializers after it to be called after all of AC initializers, which get pulled in before since action_controller.set_configs gets called.
Hence, push initializer depending on after hook, to be called after all initializers for this railtie are done.
|
| |
|
|
|
|
|
|
| |
We don't need no stinking `on_load` where we're going! Because
people far wiser than me (@rafaelfranca and @jeremy) know that
passing `:after` means the lib is already loaded.
|
|
|
|
| |
configs are setup
|
| |
|
| |
|
|\
| |
| |
| | |
Add ActiveSupport::TimeZone.country_zones helper
|
|\ \
| | |
| | |
| | |
| | |
| | | |
neumayr/date_select_helper_with_css_classes_accept_hash
date_select helper with_css_classes option also accept a hash
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`date_select` helper `:with_css_classes` option now accepts a hash of strings
for `:year`, `:month`, `:day`, `:hour`, `:minute`, `:second` that will extend
the select type with the given css class value.
```erb
<%= f.date_select :birthday, with_css_classes: { month: "my-month", year: "my-year" } %>
```
```html
<select id="user_birthday_3i" name="user[birthday(3i)]">…</select>
<select id="user_birthday_2i" name="user[birthday(2i)]" class="my-month">…</select>
<select id="user_birthday_1i" name="user[birthday(1i)]" class="my-year">…</select>
```
Optional, add global `html_options` to modify every select tag in the set.
```erb
<%= f.date_select :birthday, with_css_classes: { month: "my-month", year: "my-year" }, { class: "my-date optional" } %>
```
Supported DateHelper methods: `select_day`, `select_month`, `select_year`,
`select_hour`, `select_minute`, `select_second`, `select_datetime`, `select_time`,
`time_select`, `date_select` and `datetime_select`.
`:with_css_classes` option was added to the `date_select` with #7975.
|
| | |
| | |
| | |
| | | |
[ci skip]
|
|\ \ \
| | | |
| | | | |
Add html_safe support to ActionView Array#OutputSafetyHelper
|
| | | | |
|
| |_|/
|/| |
| | |
| | |
| | |
| | |
| | | |
Object#inspect recursively inspects instance variables, exposing all
internal state, including sensitive internal cache objects. Override
Cache#inspect to give a high-level summary that never interferes with
concurrent cache writes.
|
| | | |
|
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
By default, this method formats US number. This commit extends its
functionality to format number for other countries with a custom regular
expression.
number_to_phone(18812345678, pattern: /(\d{3})(\d{4})(\d{4})/)
# => 188-1234-5678
The output phone number is divided into three groups, so the regexp
should also match three groups of numbers.
|
|\ \
| | |
| | | |
sanitiser helper may be remove in 5.1, update doc [ci skip]
|
| | |
| | |
| | | |
using `rails-html-sanitizer` gem still Rails providing strip_tags, strip_links features. May be remove in 5.1
|
|/ /
| |
| |
| |
| | |
Datetime input type was removed from HTML specification.
One can use `datetime_local_field` and `datetime_local_field_tag` instead.
|
| |
| |
| |
| |
| | |
initially set is used for template type https://github.com/rails/rails/commit/67f55e28
after this commit https://github.com/rails/rails/commit/91f2ad36 it’s not require
|
| |
| |
| |
| |
| |
| |
| |
| | |
[ci skip]
Sync AV, AR, AJ, AS, AM changelogs with our 5.0 release notes draft.
This is a follow up to c94045d and contains changes made since the
release of beta1.
|
| | |
|